2026-04-06 10:58:59 -05:00
|
|
|
// @vitest-environment jsdom
|
|
|
|
|
|
|
|
|
|
import { act } from "react";
|
|
|
|
|
import type { ComponentProps, ReactNode } from "react";
|
|
|
|
|
import { createRoot } from "react-dom/client";
|
|
|
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
|
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
|
import { NewIssueDialog } from "./NewIssueDialog";
|
|
|
|
|
|
|
|
|
|
const dialogState = vi.hoisted(() => ({
|
|
|
|
|
newIssueOpen: true,
|
|
|
|
|
newIssueDefaults: {} as Record<string, unknown>,
|
|
|
|
|
closeNewIssue: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const companyState = vi.hoisted(() => ({
|
|
|
|
|
companies: [
|
|
|
|
|
{
|
|
|
|
|
id: "company-1",
|
|
|
|
|
name: "Paperclip",
|
|
|
|
|
status: "active",
|
|
|
|
|
brandColor: "#123456",
|
|
|
|
|
issuePrefix: "PAP",
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
selectedCompanyId: "company-1",
|
|
|
|
|
selectedCompany: {
|
|
|
|
|
id: "company-1",
|
|
|
|
|
name: "Paperclip",
|
|
|
|
|
status: "active",
|
|
|
|
|
brandColor: "#123456",
|
|
|
|
|
issuePrefix: "PAP",
|
|
|
|
|
},
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const toastState = vi.hoisted(() => ({
|
|
|
|
|
pushToast: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockIssuesApi = vi.hoisted(() => ({
|
|
|
|
|
create: vi.fn(),
|
|
|
|
|
upsertDocument: vi.fn(),
|
|
|
|
|
uploadAttachment: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockExecutionWorkspacesApi = vi.hoisted(() => ({
|
|
|
|
|
list: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockProjectsApi = vi.hoisted(() => ({
|
|
|
|
|
list: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockAgentsApi = vi.hoisted(() => ({
|
|
|
|
|
list: vi.fn(),
|
|
|
|
|
adapterModels: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockAuthApi = vi.hoisted(() => ({
|
|
|
|
|
getSession: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockAssetsApi = vi.hoisted(() => ({
|
|
|
|
|
uploadImage: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockInstanceSettingsApi = vi.hoisted(() => ({
|
|
|
|
|
getExperimental: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../context/DialogContext", () => ({
|
|
|
|
|
useDialog: () => dialogState,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../context/CompanyContext", () => ({
|
|
|
|
|
useCompany: () => companyState,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../context/ToastContext", () => ({
|
[codex] Harden execution reliability and heartbeat tooling (#3679)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - Reliable execution depends on heartbeat routing, issue lifecycle
semantics, telemetry, and a fast enough local verification loop to keep
regressions visible
> - The remaining commits on this branch were mostly server/runtime
correctness fixes plus test and documentation follow-ups in that area
> - Those changes are logically separate from the UI-focused
issue-detail and workspace/navigation branches even when they touch
overlapping issue APIs
> - This pull request groups the execution reliability, heartbeat,
telemetry, and tooling changes into one standalone branch
> - The benefit is a focused review of the control-plane correctness
work, including the follow-up fix that restored the implicit
comment-reopen helpers after branch splitting
## What Changed
- Hardened issue/heartbeat execution behavior, including self-review
stage skipping, deferred mention wakes during active execution, stranded
execution recovery, active-run scoping, assignee resolution, and
blocked-to-todo wake resumption
- Reduced noisy polling/logging overhead by trimming issue run payloads,
compacting persisted run logs, silencing high-volume request logs, and
capping heartbeat-run queries in dashboard/inbox surfaces
- Expanded telemetry and status semantics with adapter/model fields on
task completion plus clearer status guidance in docs/onboarding material
- Updated test infrastructure and verification defaults with faster
route-test module isolation, cheaper default `pnpm test`, e2e isolation
from local state, and repo verification follow-ups
- Included docs/release housekeeping from the branch and added a small
follow-up commit restoring the implicit comment-reopen helpers that were
dropped during branch reconstruction
## Verification
- `pnpm vitest run
server/src/__tests__/issue-comment-reopen-routes.test.ts
server/src/__tests__/issue-telemetry-routes.test.ts`
- `pnpm vitest run server/src/__tests__/http-log-policy.test.ts
server/src/__tests__/heartbeat-run-log.test.ts
server/src/__tests__/health.test.ts`
- `server/src/__tests__/activity-service.test.ts`,
`server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and
`server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted
on this host but the embedded Postgres harness reported
init-script/data-dir problems and skipped or failed to start, so they
are noted as environment-limited
## Risks
- Medium: this branch changes core issue/heartbeat routing and
reopen/wakeup behavior, so regressions would affect agent execution flow
rather than isolated UI polish
- Because it also updates verification infrastructure, reviewers should
pay attention to whether the new tests are asserting the right failure
modes and not just reshaping harness behavior
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 13:34:52 -05:00
|
|
|
useToastActions: () => toastState,
|
2026-04-06 10:58:59 -05:00
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/issues", () => ({
|
|
|
|
|
issuesApi: mockIssuesApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/execution-workspaces", () => ({
|
|
|
|
|
executionWorkspacesApi: mockExecutionWorkspacesApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/projects", () => ({
|
|
|
|
|
projectsApi: mockProjectsApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/agents", () => ({
|
|
|
|
|
agentsApi: mockAgentsApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/auth", () => ({
|
|
|
|
|
authApi: mockAuthApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/assets", () => ({
|
|
|
|
|
assetsApi: mockAssetsApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/instanceSettings", () => ({
|
|
|
|
|
instanceSettingsApi: mockInstanceSettingsApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../hooks/useProjectOrder", () => ({
|
|
|
|
|
useProjectOrder: ({ projects }: { projects: unknown[] }) => ({
|
|
|
|
|
orderedProjects: projects,
|
|
|
|
|
}),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../lib/recent-assignees", () => ({
|
|
|
|
|
getRecentAssigneeIds: () => [],
|
|
|
|
|
sortAgentsByRecency: (agents: unknown[]) => agents,
|
|
|
|
|
trackRecentAssignee: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../lib/assignees", () => ({
|
|
|
|
|
assigneeValueFromSelection: ({
|
|
|
|
|
assigneeAgentId,
|
|
|
|
|
assigneeUserId,
|
|
|
|
|
}: {
|
|
|
|
|
assigneeAgentId?: string;
|
|
|
|
|
assigneeUserId?: string;
|
|
|
|
|
}) => assigneeAgentId ? `agent:${assigneeAgentId}` : assigneeUserId ? `user:${assigneeUserId}` : "",
|
|
|
|
|
currentUserAssigneeOption: () => [],
|
|
|
|
|
parseAssigneeValue: (value: string) => ({
|
|
|
|
|
assigneeAgentId: value.startsWith("agent:") ? value.slice("agent:".length) : null,
|
|
|
|
|
assigneeUserId: value.startsWith("user:") ? value.slice("user:".length) : null,
|
|
|
|
|
}),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./MarkdownEditor", async () => {
|
|
|
|
|
const React = await import("react");
|
|
|
|
|
return {
|
|
|
|
|
MarkdownEditor: React.forwardRef<
|
|
|
|
|
{ focus: () => void },
|
|
|
|
|
{ value: string; onChange?: (value: string) => void; placeholder?: string }
|
|
|
|
|
>(function MarkdownEditorMock({ value, onChange, placeholder }, ref) {
|
|
|
|
|
React.useImperativeHandle(ref, () => ({
|
|
|
|
|
focus: () => undefined,
|
|
|
|
|
}));
|
|
|
|
|
return (
|
|
|
|
|
<textarea
|
|
|
|
|
aria-label={placeholder ?? "Description"}
|
|
|
|
|
value={value}
|
|
|
|
|
onChange={(event) => onChange?.(event.target.value)}
|
|
|
|
|
/>
|
|
|
|
|
);
|
|
|
|
|
}),
|
|
|
|
|
};
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
vi.mock("./InlineEntitySelector", async () => {
|
|
|
|
|
const React = await import("react");
|
|
|
|
|
return {
|
|
|
|
|
InlineEntitySelector: React.forwardRef<
|
|
|
|
|
HTMLButtonElement,
|
|
|
|
|
{
|
|
|
|
|
value: string;
|
|
|
|
|
placeholder?: string;
|
|
|
|
|
renderTriggerValue?: (option: { id: string; label: string } | null) => ReactNode;
|
|
|
|
|
}
|
|
|
|
|
>(function InlineEntitySelectorMock({ value, placeholder, renderTriggerValue }, ref) {
|
|
|
|
|
return (
|
|
|
|
|
<button ref={ref} type="button">
|
|
|
|
|
{(renderTriggerValue?.(value ? { id: value, label: value } : null) ?? value) || placeholder}
|
|
|
|
|
</button>
|
|
|
|
|
);
|
|
|
|
|
}),
|
|
|
|
|
};
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
vi.mock("./AgentIconPicker", () => ({
|
|
|
|
|
AgentIcon: () => null,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("@/components/ui/dialog", () => ({
|
|
|
|
|
Dialog: ({ open, children }: { open: boolean; children: ReactNode }) => (open ? <div>{children}</div> : null),
|
|
|
|
|
DialogContent: ({
|
|
|
|
|
children,
|
|
|
|
|
showCloseButton: _showCloseButton,
|
|
|
|
|
onEscapeKeyDown: _onEscapeKeyDown,
|
|
|
|
|
onPointerDownOutside: _onPointerDownOutside,
|
|
|
|
|
...props
|
|
|
|
|
}: ComponentProps<"div"> & {
|
|
|
|
|
showCloseButton?: boolean;
|
|
|
|
|
onEscapeKeyDown?: (event: unknown) => void;
|
|
|
|
|
onPointerDownOutside?: (event: unknown) => void;
|
|
|
|
|
}) => <div {...props}>{children}</div>,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("@/components/ui/button", () => ({
|
|
|
|
|
Button: ({ children, onClick, type = "button", ...props }: ComponentProps<"button">) => (
|
|
|
|
|
<button type={type} onClick={onClick} {...props}>{children}</button>
|
|
|
|
|
),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("@/components/ui/toggle-switch", () => ({
|
|
|
|
|
ToggleSwitch: ({ checked, onCheckedChange }: { checked: boolean; onCheckedChange: () => void }) => (
|
|
|
|
|
<button type="button" aria-pressed={checked} onClick={onCheckedChange}>toggle</button>
|
|
|
|
|
),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("@/components/ui/popover", () => ({
|
|
|
|
|
Popover: ({ children }: { children: ReactNode }) => <div>{children}</div>,
|
|
|
|
|
PopoverTrigger: ({ children }: { children: ReactNode }) => <>{children}</>,
|
|
|
|
|
PopoverContent: ({ children }: { children: ReactNode }) => <div>{children}</div>,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
|
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
|
|
|
|
|
|
async function flush() {
|
|
|
|
|
await act(async () => {
|
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function renderDialog(container: HTMLDivElement) {
|
|
|
|
|
const queryClient = new QueryClient({
|
|
|
|
|
defaultOptions: {
|
|
|
|
|
queries: { retry: false },
|
|
|
|
|
mutations: { retry: false },
|
|
|
|
|
},
|
|
|
|
|
});
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<QueryClientProvider client={queryClient}>
|
|
|
|
|
<NewIssueDialog />
|
|
|
|
|
</QueryClientProvider>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
return { root, queryClient };
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
describe("NewIssueDialog", () => {
|
|
|
|
|
let container: HTMLDivElement;
|
|
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
|
container = document.createElement("div");
|
|
|
|
|
document.body.appendChild(container);
|
|
|
|
|
dialogState.newIssueOpen = true;
|
|
|
|
|
dialogState.newIssueDefaults = {};
|
|
|
|
|
dialogState.closeNewIssue.mockReset();
|
|
|
|
|
toastState.pushToast.mockReset();
|
|
|
|
|
mockIssuesApi.create.mockReset();
|
|
|
|
|
mockIssuesApi.upsertDocument.mockReset();
|
|
|
|
|
mockIssuesApi.uploadAttachment.mockReset();
|
|
|
|
|
mockExecutionWorkspacesApi.list.mockResolvedValue([]);
|
|
|
|
|
mockProjectsApi.list.mockResolvedValue([
|
|
|
|
|
{
|
|
|
|
|
id: "project-1",
|
|
|
|
|
name: "Alpha",
|
|
|
|
|
description: null,
|
|
|
|
|
archivedAt: null,
|
|
|
|
|
color: "#445566",
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
mockAgentsApi.list.mockResolvedValue([]);
|
|
|
|
|
mockAgentsApi.adapterModels.mockResolvedValue([]);
|
|
|
|
|
mockAuthApi.getSession.mockResolvedValue({ user: { id: "user-1" } });
|
|
|
|
|
mockAssetsApi.uploadImage.mockResolvedValue({ contentPath: "/uploads/asset.png" });
|
|
|
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
|
|
|
mockIssuesApi.create.mockResolvedValue({
|
|
|
|
|
id: "issue-2",
|
|
|
|
|
companyId: "company-1",
|
|
|
|
|
identifier: "PAP-2",
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
|
document.body.innerHTML = "";
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("shows sub-issue context only when opened from a sub-issue action", async () => {
|
|
|
|
|
dialogState.newIssueDefaults = {
|
|
|
|
|
parentId: "issue-1",
|
|
|
|
|
parentIdentifier: "PAP-1",
|
|
|
|
|
parentTitle: "Parent issue",
|
|
|
|
|
projectId: "project-1",
|
|
|
|
|
goalId: "goal-1",
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const { root } = renderDialog(container);
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).toContain("New sub-issue");
|
|
|
|
|
expect(container.textContent).toContain("Sub-issue of");
|
|
|
|
|
expect(container.textContent).toContain("PAP-1");
|
|
|
|
|
expect(container.textContent).toContain("Parent issue");
|
|
|
|
|
expect(container.textContent).toContain("Create Sub-Issue");
|
|
|
|
|
|
|
|
|
|
act(() => root.unmount());
|
|
|
|
|
|
|
|
|
|
dialogState.newIssueDefaults = {};
|
|
|
|
|
const rerendered = renderDialog(container);
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).toContain("New issue");
|
|
|
|
|
expect(container.textContent).toContain("Create Issue");
|
|
|
|
|
expect(container.textContent).not.toContain("Sub-issue of");
|
|
|
|
|
|
|
|
|
|
act(() => rerendered.root.unmount());
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("submits parent and goal context for sub-issues", async () => {
|
2026-04-06 11:34:11 -05:00
|
|
|
mockProjectsApi.list.mockResolvedValue([
|
|
|
|
|
{
|
|
|
|
|
id: "project-1",
|
|
|
|
|
name: "Alpha",
|
|
|
|
|
description: null,
|
|
|
|
|
archivedAt: null,
|
|
|
|
|
color: "#445566",
|
|
|
|
|
executionWorkspacePolicy: {
|
|
|
|
|
enabled: true,
|
|
|
|
|
defaultMode: "shared_workspace",
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
mockExecutionWorkspacesApi.list.mockResolvedValue([
|
|
|
|
|
{
|
|
|
|
|
id: "workspace-1",
|
|
|
|
|
name: "Parent workspace",
|
|
|
|
|
status: "active",
|
|
|
|
|
branchName: "feature/pap-1",
|
|
|
|
|
cwd: "/tmp/workspace-1",
|
|
|
|
|
lastUsedAt: new Date("2026-04-06T16:00:00.000Z"),
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: true });
|
2026-04-06 10:58:59 -05:00
|
|
|
dialogState.newIssueDefaults = {
|
|
|
|
|
parentId: "issue-1",
|
|
|
|
|
parentIdentifier: "PAP-1",
|
|
|
|
|
parentTitle: "Parent issue",
|
|
|
|
|
title: "Child issue",
|
|
|
|
|
projectId: "project-1",
|
2026-04-06 11:34:11 -05:00
|
|
|
executionWorkspaceId: "workspace-1",
|
2026-04-06 10:58:59 -05:00
|
|
|
goalId: "goal-1",
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const { root } = renderDialog(container);
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
const submitButton = Array.from(container.querySelectorAll("button"))
|
|
|
|
|
.find((button) => button.textContent?.includes("Create Sub-Issue"));
|
|
|
|
|
expect(submitButton).not.toBeUndefined();
|
|
|
|
|
expect(submitButton?.hasAttribute("disabled")).toBe(false);
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
submitButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
expect(mockIssuesApi.create).toHaveBeenCalledWith(
|
|
|
|
|
"company-1",
|
|
|
|
|
expect.objectContaining({
|
|
|
|
|
title: "Child issue",
|
|
|
|
|
parentId: "issue-1",
|
|
|
|
|
goalId: "goal-1",
|
|
|
|
|
projectId: "project-1",
|
2026-04-06 11:34:11 -05:00
|
|
|
executionWorkspaceId: "workspace-1",
|
2026-04-06 10:58:59 -05:00
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
act(() => root.unmount());
|
|
|
|
|
});
|
2026-04-06 11:34:11 -05:00
|
|
|
|
[codex] Split PR #4692 UI/QoL updates (#4701)
## Thinking Path
> - Paperclip orchestrates AI agents through a company-scoped control
plane.
> - The affected surface is the board UI for issue threads, issue lists,
routines, dialogs, navigation, and issue review indicators.
> - Closed PR #4692 bundled backend, schema, docs, workflow, and UI/QoL
work into one oversized change set.
> - Greptile could not keep reviewing that broad PR because it exceeded
the 100-file review limit and mixed unrelated concerns.
> - This pull request extracts the UI/QoL slice into a fresh branch
under the review limit while leaving workflow and lockfile churn out.
> - The benefit is a focused review path for the board UI performance
and workflow improvements without reopening the oversized PR.
## What Changed
- Added long issue-thread virtualization, scroll-container binding,
anchor preservation, latest-comment jump targeting, and related
regression/perf fixtures.
- Improved issue list scalability with scroll-based loading, server
offset parameters, and pagination-focused UI tests.
- Reduced new issue dialog typing churn and split dialog action
subscriptions so broad layout/nav surfaces avoid unnecessary renders.
- Added routine variables help and routine description mention options
for users, agents, and projects.
- Added productivity review badge/link UI and fixed the badge to use
Paperclip's company-prefixed router link.
- Kept the split PR below Greptile's review limit and excluded
`.github/workflows/pr.yml` and `pnpm-lock.yaml`.
## Verification
- `pnpm install --no-frozen-lockfile` in the clean worktree to install
`@tanstack/react-virtual` locally without committing lockfile churn.
- `pnpm --filter @paperclipai/ui exec vitest run --config
vitest.config.ts src/components/IssueChatThread.test.tsx
src/components/IssuesList.test.tsx
src/components/NewIssueDialog.test.tsx src/pages/Routines.test.tsx
src/pages/Issues.test.tsx` passed: 5 files, 83 tests.
- `pnpm --filter @paperclipai/ui typecheck` passed.
- `git diff --check origin/master..HEAD` passed.
- Split-scope checks: 53 changed files; no `.github/workflows/pr.yml`;
no `pnpm-lock.yaml`.
- Screenshots were not captured in this heartbeat; the changes are
primarily virtualization, routing, pagination, and editor behavior
covered by focused regression tests.
## Risks
- Moderate UI risk because issue-thread virtualization changes scroll
behavior on long conversations; regression tests cover anchor jumps,
latest-comment targeting, row metadata, and short-thread fallback.
- Moderate integration risk because the issue-list offset parameter and
productivity review field depend on matching API behavior.
- Dependency risk: the UI package adds `@tanstack/react-virtual` while
repository policy keeps `pnpm-lock.yaml` out of PRs, so CI must resolve
dependency changes through the repo's normal lockfile policy.
> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.
## Model Used
- OpenAI Codex, GPT-5 coding agent, tool-enabled local repository and
GitHub workflow. Exact runtime context window was not exposed by the
harness.
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-28 17:18:58 -05:00
|
|
|
it("submits the latest locally typed title and description", async () => {
|
|
|
|
|
const { root } = renderDialog(container);
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
const titleInput = container.querySelector('textarea[placeholder="Issue title"]') as HTMLTextAreaElement | null;
|
|
|
|
|
const descriptionInput = container.querySelector('textarea[aria-label="Add description..."]') as HTMLTextAreaElement | null;
|
|
|
|
|
expect(titleInput).not.toBeNull();
|
|
|
|
|
expect(descriptionInput).not.toBeNull();
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
|
|
|
HTMLTextAreaElement.prototype,
|
|
|
|
|
"value",
|
|
|
|
|
)?.set;
|
|
|
|
|
valueSetter?.call(titleInput, "Typed issue");
|
|
|
|
|
titleInput!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
|
|
|
HTMLTextAreaElement.prototype,
|
|
|
|
|
"value",
|
|
|
|
|
)?.set;
|
|
|
|
|
valueSetter?.call(descriptionInput, "Typed description");
|
|
|
|
|
descriptionInput!.dispatchEvent(new Event("input", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
const submitButton = Array.from(container.querySelectorAll("button"))
|
|
|
|
|
.find((button) => button.textContent?.includes("Create Issue"));
|
|
|
|
|
expect(submitButton).not.toBeUndefined();
|
|
|
|
|
expect(submitButton?.hasAttribute("disabled")).toBe(false);
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
submitButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
expect(mockIssuesApi.create).toHaveBeenCalledWith(
|
|
|
|
|
"company-1",
|
|
|
|
|
expect.objectContaining({
|
|
|
|
|
title: "Typed issue",
|
|
|
|
|
description: "Typed description",
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
act(() => root.unmount());
|
|
|
|
|
});
|
|
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
it("submits the parent assignee when a sub-issue opens with inherited defaults", async () => {
|
|
|
|
|
dialogState.newIssueDefaults = {
|
|
|
|
|
parentId: "issue-1",
|
|
|
|
|
parentIdentifier: "PAP-1",
|
|
|
|
|
parentTitle: "Parent issue",
|
|
|
|
|
title: "Child issue",
|
|
|
|
|
projectId: "project-1",
|
|
|
|
|
goalId: "goal-1",
|
|
|
|
|
assigneeAgentId: "agent-1",
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const { root } = renderDialog(container);
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
const submitButton = Array.from(container.querySelectorAll("button"))
|
|
|
|
|
.find((button) => button.textContent?.includes("Create Sub-Issue"));
|
|
|
|
|
expect(submitButton).not.toBeUndefined();
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
submitButton!.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
expect(mockIssuesApi.create).toHaveBeenCalledWith(
|
|
|
|
|
"company-1",
|
|
|
|
|
expect.objectContaining({
|
|
|
|
|
title: "Child issue",
|
|
|
|
|
parentId: "issue-1",
|
|
|
|
|
goalId: "goal-1",
|
|
|
|
|
projectId: "project-1",
|
|
|
|
|
assigneeAgentId: "agent-1",
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
act(() => root.unmount());
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-09 10:26:17 -05:00
|
|
|
it("keeps the mobile dialog bounded with an internal flexible scroll region", async () => {
|
|
|
|
|
const { root } = renderDialog(container);
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
const dialogContent = Array.from(container.querySelectorAll("div")).find((element) =>
|
|
|
|
|
typeof element.className === "string" && element.className.includes("max-h-[calc(100dvh-2rem)]"),
|
|
|
|
|
);
|
|
|
|
|
expect(dialogContent?.className).toContain("h-[calc(100dvh-2rem)]");
|
|
|
|
|
expect(dialogContent?.className).toContain("overflow-hidden");
|
|
|
|
|
|
2026-04-10 22:26:21 -05:00
|
|
|
const titleInput = container.querySelector('textarea[placeholder="Issue title"]');
|
2026-04-09 10:26:17 -05:00
|
|
|
const descriptionInput = container.querySelector('textarea[aria-label="Add description..."]');
|
2026-04-10 22:26:21 -05:00
|
|
|
const bodyScrollRegion = Array.from(container.querySelectorAll("div")).find((element) =>
|
|
|
|
|
typeof element.className === "string" && element.className.includes("overscroll-contain"),
|
|
|
|
|
);
|
|
|
|
|
expect(bodyScrollRegion?.className).toContain("flex-1");
|
|
|
|
|
expect(bodyScrollRegion?.className).toContain("overflow-y-auto");
|
|
|
|
|
expect(bodyScrollRegion?.contains(titleInput ?? null)).toBe(true);
|
|
|
|
|
expect(bodyScrollRegion?.contains(descriptionInput ?? null)).toBe(true);
|
2026-04-09 10:26:17 -05:00
|
|
|
|
|
|
|
|
act(() => root.unmount());
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-06 11:34:11 -05:00
|
|
|
it("warns when a sub-issue stops matching the parent workspace", async () => {
|
|
|
|
|
mockProjectsApi.list.mockResolvedValue([
|
|
|
|
|
{
|
|
|
|
|
id: "project-1",
|
|
|
|
|
name: "Alpha",
|
|
|
|
|
description: null,
|
|
|
|
|
archivedAt: null,
|
|
|
|
|
color: "#445566",
|
|
|
|
|
executionWorkspacePolicy: {
|
|
|
|
|
enabled: true,
|
|
|
|
|
defaultMode: "shared_workspace",
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
mockExecutionWorkspacesApi.list.mockResolvedValue([
|
|
|
|
|
{
|
|
|
|
|
id: "workspace-1",
|
|
|
|
|
name: "Parent workspace",
|
|
|
|
|
status: "active",
|
|
|
|
|
branchName: "feature/pap-1",
|
|
|
|
|
cwd: "/tmp/workspace-1",
|
|
|
|
|
lastUsedAt: new Date("2026-04-06T16:00:00.000Z"),
|
|
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
id: "workspace-2",
|
|
|
|
|
name: "Other workspace",
|
|
|
|
|
status: "active",
|
|
|
|
|
branchName: "feature/pap-2",
|
|
|
|
|
cwd: "/tmp/workspace-2",
|
|
|
|
|
lastUsedAt: new Date("2026-04-06T16:01:00.000Z"),
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: true });
|
|
|
|
|
dialogState.newIssueDefaults = {
|
|
|
|
|
parentId: "issue-1",
|
|
|
|
|
parentIdentifier: "PAP-1",
|
|
|
|
|
parentTitle: "Parent issue",
|
|
|
|
|
title: "Child issue",
|
|
|
|
|
projectId: "project-1",
|
|
|
|
|
executionWorkspaceId: "workspace-1",
|
|
|
|
|
parentExecutionWorkspaceLabel: "Parent workspace",
|
|
|
|
|
goalId: "goal-1",
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const { root } = renderDialog(container);
|
|
|
|
|
await flush();
|
2026-04-09 10:26:17 -05:00
|
|
|
await flush();
|
2026-04-06 11:34:11 -05:00
|
|
|
|
|
|
|
|
expect(container.textContent).not.toContain("will no longer use the parent issue workspace");
|
|
|
|
|
|
2026-04-10 22:26:21 -05:00
|
|
|
const selects = Array.from(container.querySelectorAll("select"));
|
|
|
|
|
const modeSelect = selects[0] as HTMLSelectElement | undefined;
|
|
|
|
|
expect(modeSelect).not.toBeUndefined();
|
2026-04-06 11:34:11 -05:00
|
|
|
|
|
|
|
|
await act(async () => {
|
2026-04-10 22:26:21 -05:00
|
|
|
modeSelect!.value = "shared_workspace";
|
|
|
|
|
modeSelect!.dispatchEvent(new Event("change", { bubbles: true }));
|
2026-04-06 11:34:11 -05:00
|
|
|
});
|
|
|
|
|
await flush();
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).toContain("will no longer use the parent issue workspace");
|
|
|
|
|
expect(container.textContent).toContain("Parent workspace");
|
|
|
|
|
|
|
|
|
|
act(() => root.unmount());
|
|
|
|
|
});
|
2026-04-06 10:58:59 -05:00
|
|
|
});
|