mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-18 19:50:38 +09:00
203 lines
6 KiB
TypeScript
203 lines
6 KiB
TypeScript
|
|
import express from "express";
|
||
|
|
import request from "supertest";
|
||
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||
|
|
import { errorHandler } from "../middleware/index.js";
|
||
|
|
import { issueRoutes } from "../routes/issues.js";
|
||
|
|
|
||
|
|
const ASSIGNEE_AGENT_ID = "11111111-1111-4111-8111-111111111111";
|
||
|
|
|
||
|
|
const mockIssueService = vi.hoisted(() => ({
|
||
|
|
getById: vi.fn(),
|
||
|
|
update: vi.fn(),
|
||
|
|
addComment: vi.fn(),
|
||
|
|
findMentionedAgents: vi.fn(),
|
||
|
|
getRelationSummaries: vi.fn(),
|
||
|
|
listWakeableBlockedDependents: vi.fn(),
|
||
|
|
getWakeableParentAfterChildCompletion: vi.fn(),
|
||
|
|
}));
|
||
|
|
|
||
|
|
const mockHeartbeatService = vi.hoisted(() => ({
|
||
|
|
wakeup: vi.fn(async () => undefined),
|
||
|
|
reportRunActivity: vi.fn(async () => undefined),
|
||
|
|
getRun: vi.fn(async () => null),
|
||
|
|
getActiveRunForAgent: vi.fn(async () => null),
|
||
|
|
cancelRun: vi.fn(async () => null),
|
||
|
|
}));
|
||
|
|
|
||
|
|
vi.mock("../services/index.js", () => ({
|
||
|
|
accessService: () => ({
|
||
|
|
canUser: vi.fn(async () => true),
|
||
|
|
hasPermission: vi.fn(async () => true),
|
||
|
|
}),
|
||
|
|
agentService: () => ({
|
||
|
|
getById: vi.fn(async () => null),
|
||
|
|
}),
|
||
|
|
documentService: () => ({}),
|
||
|
|
executionWorkspaceService: () => ({}),
|
||
|
|
feedbackService: () => ({
|
||
|
|
listIssueVotesForUser: vi.fn(async () => []),
|
||
|
|
saveIssueVote: vi.fn(async () => ({ vote: null, consentEnabledNow: false, sharingEnabled: false })),
|
||
|
|
}),
|
||
|
|
goalService: () => ({}),
|
||
|
|
heartbeatService: () => mockHeartbeatService,
|
||
|
|
instanceSettingsService: () => ({
|
||
|
|
get: vi.fn(async () => ({
|
||
|
|
id: "instance-settings-1",
|
||
|
|
general: {
|
||
|
|
censorUsernameInLogs: false,
|
||
|
|
feedbackDataSharingPreference: "prompt",
|
||
|
|
},
|
||
|
|
})),
|
||
|
|
listCompanyIds: vi.fn(async () => ["company-1"]),
|
||
|
|
}),
|
||
|
|
issueApprovalService: () => ({}),
|
||
|
|
issueService: () => mockIssueService,
|
||
|
|
logActivity: vi.fn(async () => undefined),
|
||
|
|
projectService: () => ({}),
|
||
|
|
routineService: () => ({
|
||
|
|
syncRunStatusForIssue: vi.fn(async () => undefined),
|
||
|
|
}),
|
||
|
|
workProductService: () => ({}),
|
||
|
|
}));
|
||
|
|
|
||
|
|
function createApp() {
|
||
|
|
const app = express();
|
||
|
|
app.use(express.json());
|
||
|
|
app.use((req, _res, next) => {
|
||
|
|
(req as any).actor = {
|
||
|
|
type: "board",
|
||
|
|
userId: "local-board",
|
||
|
|
companyIds: ["company-1"],
|
||
|
|
source: "local_implicit",
|
||
|
|
isInstanceAdmin: false,
|
||
|
|
};
|
||
|
|
next();
|
||
|
|
});
|
||
|
|
app.use("/api", issueRoutes({} as any, {} as any));
|
||
|
|
app.use(errorHandler);
|
||
|
|
return app;
|
||
|
|
}
|
||
|
|
|
||
|
|
function makeIssue(overrides: Record<string, unknown> = {}) {
|
||
|
|
return {
|
||
|
|
id: "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa",
|
||
|
|
companyId: "company-1",
|
||
|
|
status: "todo",
|
||
|
|
priority: "medium",
|
||
|
|
projectId: null,
|
||
|
|
goalId: null,
|
||
|
|
parentId: null,
|
||
|
|
assigneeAgentId: null,
|
||
|
|
assigneeUserId: "local-board",
|
||
|
|
createdByUserId: "local-board",
|
||
|
|
identifier: "PAP-999",
|
||
|
|
title: "Wake test",
|
||
|
|
executionPolicy: null,
|
||
|
|
executionState: null,
|
||
|
|
hiddenAt: null,
|
||
|
|
...overrides,
|
||
|
|
};
|
||
|
|
}
|
||
|
|
|
||
|
|
describe("issue update comment wakeups", () => {
|
||
|
|
beforeEach(() => {
|
||
|
|
vi.clearAllMocks();
|
||
|
|
mockIssueService.findMentionedAgents.mockResolvedValue([]);
|
||
|
|
mockIssueService.getRelationSummaries.mockResolvedValue({ blockedBy: [], blocks: [] });
|
||
|
|
mockIssueService.listWakeableBlockedDependents.mockResolvedValue([]);
|
||
|
|
mockIssueService.getWakeableParentAfterChildCompletion.mockResolvedValue(null);
|
||
|
|
});
|
||
|
|
|
||
|
|
it("includes the new comment in assignment wakes from issue updates", async () => {
|
||
|
|
const existing = makeIssue();
|
||
|
|
const updated = makeIssue({
|
||
|
|
assigneeAgentId: ASSIGNEE_AGENT_ID,
|
||
|
|
assigneeUserId: null,
|
||
|
|
});
|
||
|
|
mockIssueService.getById.mockResolvedValue(existing);
|
||
|
|
mockIssueService.update.mockResolvedValue(updated);
|
||
|
|
mockIssueService.addComment.mockResolvedValue({
|
||
|
|
id: "comment-1",
|
||
|
|
issueId: existing.id,
|
||
|
|
companyId: existing.companyId,
|
||
|
|
body: "write the whole thing",
|
||
|
|
});
|
||
|
|
|
||
|
|
const res = await request(createApp())
|
||
|
|
.patch(`/api/issues/${existing.id}`)
|
||
|
|
.send({
|
||
|
|
assigneeAgentId: ASSIGNEE_AGENT_ID,
|
||
|
|
assigneeUserId: null,
|
||
|
|
comment: "write the whole thing",
|
||
|
|
});
|
||
|
|
|
||
|
|
expect(res.status).toBe(200);
|
||
|
|
expect(mockHeartbeatService.wakeup).toHaveBeenCalledTimes(1);
|
||
|
|
expect(mockHeartbeatService.wakeup).toHaveBeenCalledWith(
|
||
|
|
ASSIGNEE_AGENT_ID,
|
||
|
|
expect.objectContaining({
|
||
|
|
source: "assignment",
|
||
|
|
reason: "issue_assigned",
|
||
|
|
payload: expect.objectContaining({
|
||
|
|
issueId: existing.id,
|
||
|
|
commentId: "comment-1",
|
||
|
|
mutation: "update",
|
||
|
|
}),
|
||
|
|
contextSnapshot: expect.objectContaining({
|
||
|
|
issueId: existing.id,
|
||
|
|
taskId: existing.id,
|
||
|
|
commentId: "comment-1",
|
||
|
|
wakeCommentId: "comment-1",
|
||
|
|
source: "issue.update",
|
||
|
|
}),
|
||
|
|
}),
|
||
|
|
);
|
||
|
|
});
|
||
|
|
|
||
|
|
it("wakes the assignee on comment-only issue updates", async () => {
|
||
|
|
const existing = makeIssue({
|
||
|
|
assigneeAgentId: ASSIGNEE_AGENT_ID,
|
||
|
|
assigneeUserId: null,
|
||
|
|
status: "in_progress",
|
||
|
|
});
|
||
|
|
const updated = { ...existing };
|
||
|
|
mockIssueService.getById.mockResolvedValue(existing);
|
||
|
|
mockIssueService.update.mockResolvedValue(updated);
|
||
|
|
mockIssueService.addComment.mockResolvedValue({
|
||
|
|
id: "comment-2",
|
||
|
|
issueId: existing.id,
|
||
|
|
companyId: existing.companyId,
|
||
|
|
body: "please revise this",
|
||
|
|
});
|
||
|
|
|
||
|
|
const res = await request(createApp())
|
||
|
|
.patch(`/api/issues/${existing.id}`)
|
||
|
|
.send({
|
||
|
|
comment: "please revise this",
|
||
|
|
});
|
||
|
|
|
||
|
|
expect(res.status).toBe(200);
|
||
|
|
expect(mockHeartbeatService.wakeup).toHaveBeenCalledTimes(1);
|
||
|
|
expect(mockHeartbeatService.wakeup).toHaveBeenCalledWith(
|
||
|
|
ASSIGNEE_AGENT_ID,
|
||
|
|
expect.objectContaining({
|
||
|
|
source: "automation",
|
||
|
|
reason: "issue_commented",
|
||
|
|
payload: expect.objectContaining({
|
||
|
|
issueId: existing.id,
|
||
|
|
commentId: "comment-2",
|
||
|
|
mutation: "comment",
|
||
|
|
}),
|
||
|
|
contextSnapshot: expect.objectContaining({
|
||
|
|
issueId: existing.id,
|
||
|
|
taskId: existing.id,
|
||
|
|
commentId: "comment-2",
|
||
|
|
wakeCommentId: "comment-2",
|
||
|
|
wakeReason: "issue_commented",
|
||
|
|
source: "issue.comment",
|
||
|
|
}),
|
||
|
|
}),
|
||
|
|
);
|
||
|
|
});
|
||
|
|
});
|