2026-04-06 20:30:50 -05:00
|
|
|
// @vitest-environment jsdom
|
|
|
|
|
|
|
|
|
|
import { act } from "react";
|
|
|
|
|
import { createRoot } from "react-dom/client";
|
|
|
|
|
import type { ReactNode } from "react";
|
|
|
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
|
|
|
import type { Issue } from "@paperclipai/shared";
|
|
|
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
|
import { IssuesList } from "./IssuesList";
|
2026-04-10 22:26:21 -05:00
|
|
|
import { TooltipProvider } from "@/components/ui/tooltip";
|
2026-04-06 20:30:50 -05:00
|
|
|
|
|
|
|
|
const companyState = vi.hoisted(() => ({
|
|
|
|
|
selectedCompanyId: "company-1",
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const dialogState = vi.hoisted(() => ({
|
|
|
|
|
openNewIssue: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockIssuesApi = vi.hoisted(() => ({
|
|
|
|
|
list: vi.fn(),
|
|
|
|
|
listLabels: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockAuthApi = vi.hoisted(() => ({
|
|
|
|
|
getSession: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
2026-04-07 16:45:57 -05:00
|
|
|
const mockExecutionWorkspacesApi = vi.hoisted(() => ({
|
|
|
|
|
list: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
const mockInstanceSettingsApi = vi.hoisted(() => ({
|
|
|
|
|
getExperimental: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
2026-04-06 20:30:50 -05:00
|
|
|
vi.mock("../context/CompanyContext", () => ({
|
|
|
|
|
useCompany: () => companyState,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../context/DialogContext", () => ({
|
|
|
|
|
useDialog: () => dialogState,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/issues", () => ({
|
|
|
|
|
issuesApi: mockIssuesApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/auth", () => ({
|
|
|
|
|
authApi: mockAuthApi,
|
|
|
|
|
}));
|
|
|
|
|
|
2026-04-07 16:45:57 -05:00
|
|
|
vi.mock("../api/execution-workspaces", () => ({
|
|
|
|
|
executionWorkspacesApi: mockExecutionWorkspacesApi,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../api/instanceSettings", () => ({
|
|
|
|
|
instanceSettingsApi: mockInstanceSettingsApi,
|
|
|
|
|
}));
|
|
|
|
|
|
2026-04-06 20:30:50 -05:00
|
|
|
vi.mock("./IssueRow", () => ({
|
2026-04-07 16:45:57 -05:00
|
|
|
IssueRow: ({
|
|
|
|
|
issue,
|
|
|
|
|
desktopMetaLeading,
|
|
|
|
|
desktopTrailing,
|
|
|
|
|
}: {
|
|
|
|
|
issue: Issue;
|
|
|
|
|
desktopMetaLeading?: ReactNode;
|
|
|
|
|
desktopTrailing?: ReactNode;
|
|
|
|
|
}) => (
|
|
|
|
|
<div data-testid="issue-row">
|
|
|
|
|
<span>{issue.title}</span>
|
|
|
|
|
{desktopMetaLeading}
|
|
|
|
|
{desktopTrailing}
|
|
|
|
|
</div>
|
|
|
|
|
),
|
2026-04-06 20:30:50 -05:00
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./KanbanBoard", () => ({
|
|
|
|
|
KanbanBoard: () => null,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
|
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
|
|
|
|
|
|
function createIssue(overrides: Partial<Issue> = {}): Issue {
|
|
|
|
|
return {
|
|
|
|
|
id: "issue-1",
|
|
|
|
|
identifier: "PAP-1",
|
|
|
|
|
companyId: "company-1",
|
|
|
|
|
projectId: null,
|
|
|
|
|
projectWorkspaceId: null,
|
|
|
|
|
goalId: null,
|
|
|
|
|
parentId: null,
|
|
|
|
|
title: "Issue title",
|
|
|
|
|
description: null,
|
|
|
|
|
status: "todo",
|
|
|
|
|
priority: "medium",
|
|
|
|
|
assigneeAgentId: null,
|
|
|
|
|
assigneeUserId: null,
|
|
|
|
|
createdByAgentId: null,
|
|
|
|
|
createdByUserId: null,
|
|
|
|
|
issueNumber: 1,
|
|
|
|
|
requestDepth: 0,
|
|
|
|
|
billingCode: null,
|
|
|
|
|
assigneeAdapterOverrides: null,
|
|
|
|
|
executionWorkspaceId: null,
|
|
|
|
|
executionWorkspacePreference: null,
|
|
|
|
|
executionWorkspaceSettings: null,
|
|
|
|
|
checkoutRunId: null,
|
|
|
|
|
executionRunId: null,
|
|
|
|
|
executionAgentNameKey: null,
|
|
|
|
|
executionLockedAt: null,
|
|
|
|
|
startedAt: null,
|
|
|
|
|
completedAt: null,
|
|
|
|
|
cancelledAt: null,
|
|
|
|
|
hiddenAt: null,
|
|
|
|
|
createdAt: new Date("2026-04-07T00:00:00.000Z"),
|
|
|
|
|
updatedAt: new Date("2026-04-07T00:00:00.000Z"),
|
|
|
|
|
labels: [],
|
|
|
|
|
labelIds: [],
|
|
|
|
|
myLastTouchAt: null,
|
|
|
|
|
lastExternalCommentAt: null,
|
2026-04-07 16:45:57 -05:00
|
|
|
lastActivityAt: null,
|
2026-04-06 20:30:50 -05:00
|
|
|
isUnreadForMe: false,
|
|
|
|
|
...overrides,
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
async function flush() {
|
|
|
|
|
await act(async () => {
|
|
|
|
|
await Promise.resolve();
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
2026-04-06 21:47:17 -05:00
|
|
|
async function waitForAssertion(assertion: () => void, attempts = 20) {
|
|
|
|
|
let lastError: unknown;
|
|
|
|
|
|
|
|
|
|
for (let attempt = 0; attempt < attempts; attempt += 1) {
|
|
|
|
|
try {
|
|
|
|
|
assertion();
|
|
|
|
|
return;
|
|
|
|
|
} catch (error) {
|
|
|
|
|
lastError = error;
|
|
|
|
|
await flush();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
throw lastError;
|
|
|
|
|
}
|
|
|
|
|
|
2026-04-06 20:30:50 -05:00
|
|
|
function renderWithQueryClient(node: ReactNode, container: HTMLDivElement) {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
const queryClient = new QueryClient({
|
|
|
|
|
defaultOptions: {
|
|
|
|
|
queries: {
|
|
|
|
|
retry: false,
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<QueryClientProvider client={queryClient}>
|
2026-04-10 22:26:21 -05:00
|
|
|
<TooltipProvider>
|
|
|
|
|
{node}
|
|
|
|
|
</TooltipProvider>
|
2026-04-06 20:30:50 -05:00
|
|
|
</QueryClientProvider>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return { root, queryClient };
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
describe("IssuesList", () => {
|
|
|
|
|
let container: HTMLDivElement;
|
|
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
|
container = document.createElement("div");
|
|
|
|
|
document.body.appendChild(container);
|
|
|
|
|
dialogState.openNewIssue.mockReset();
|
|
|
|
|
mockIssuesApi.list.mockReset();
|
|
|
|
|
mockIssuesApi.listLabels.mockReset();
|
|
|
|
|
mockAuthApi.getSession.mockReset();
|
2026-04-07 16:45:57 -05:00
|
|
|
mockExecutionWorkspacesApi.list.mockReset();
|
|
|
|
|
mockInstanceSettingsApi.getExperimental.mockReset();
|
2026-04-07 09:35:05 -05:00
|
|
|
mockIssuesApi.list.mockResolvedValue([]);
|
2026-04-06 20:30:50 -05:00
|
|
|
mockIssuesApi.listLabels.mockResolvedValue([]);
|
|
|
|
|
mockAuthApi.getSession.mockResolvedValue({ user: null, session: null });
|
2026-04-07 16:45:57 -05:00
|
|
|
mockExecutionWorkspacesApi.list.mockResolvedValue([]);
|
|
|
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: false });
|
|
|
|
|
localStorage.clear();
|
2026-04-06 20:30:50 -05:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
afterEach(() => {
|
2026-04-07 09:35:05 -05:00
|
|
|
vi.useRealTimers();
|
2026-04-06 20:30:50 -05:00
|
|
|
container.remove();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("renders server search results instead of filtering the full issue list locally", async () => {
|
|
|
|
|
const localIssue = createIssue({ id: "issue-local", identifier: "PAP-1", title: "Local issue" });
|
|
|
|
|
const serverIssue = createIssue({ id: "issue-server", identifier: "PAP-2", title: "Server result" });
|
|
|
|
|
|
|
|
|
|
mockIssuesApi.list.mockResolvedValue([serverIssue]);
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[localIssue]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
initialSearch="server"
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
2026-04-06 21:47:17 -05:00
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(mockIssuesApi.list).toHaveBeenCalledWith("company-1", { q: "server", projectId: undefined });
|
|
|
|
|
expect(container.textContent).toContain("Server result");
|
|
|
|
|
expect(container.textContent).not.toContain("Local issue");
|
|
|
|
|
});
|
2026-04-06 20:30:50 -05:00
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-07 09:35:05 -05:00
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
it("keeps server-side search scoped to the provided parent issue filters", async () => {
|
|
|
|
|
const localIssue = createIssue({ id: "issue-local", identifier: "PAP-1", title: "Local issue" });
|
|
|
|
|
const serverIssue = createIssue({ id: "issue-server", identifier: "PAP-2", title: "Server result" });
|
|
|
|
|
|
|
|
|
|
mockIssuesApi.list.mockResolvedValue([serverIssue]);
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[localIssue]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
initialSearch="server"
|
|
|
|
|
searchFilters={{ parentId: "parent-1" }}
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(mockIssuesApi.list).toHaveBeenCalledWith("company-1", {
|
|
|
|
|
q: "server",
|
|
|
|
|
projectId: undefined,
|
|
|
|
|
parentId: "parent-1",
|
|
|
|
|
});
|
|
|
|
|
expect(container.textContent).toContain("Server result");
|
|
|
|
|
expect(container.textContent).not.toContain("Local issue");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("uses the supplied create defaults and label for sub-issue lists", async () => {
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[createIssue()]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
baseCreateIssueDefaults={{ parentId: "parent-1", projectId: "project-1" }}
|
|
|
|
|
createIssueLabel="Sub-issue"
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
const button = Array.from(container.querySelectorAll("button")).find(
|
|
|
|
|
(candidate) => candidate.textContent?.includes("New Sub-issue"),
|
|
|
|
|
);
|
|
|
|
|
expect(button).not.toBeUndefined();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
const button = Array.from(container.querySelectorAll("button")).find(
|
|
|
|
|
(candidate) => candidate.textContent?.includes("New Sub-issue"),
|
|
|
|
|
);
|
|
|
|
|
button?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
await Promise.resolve();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(dialogState.openNewIssue).toHaveBeenCalledWith({
|
|
|
|
|
parentId: "parent-1",
|
|
|
|
|
projectId: "project-1",
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-07 09:35:05 -05:00
|
|
|
it("debounces search updates so typing does not notify the page on every keystroke", async () => {
|
|
|
|
|
vi.useFakeTimers();
|
|
|
|
|
|
|
|
|
|
const onSearchChange = vi.fn();
|
|
|
|
|
const localIssue = createIssue({ id: "issue-local", identifier: "PAP-1", title: "Local issue" });
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[localIssue]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
onSearchChange={onSearchChange}
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const input = container.querySelector('input[aria-label="Search issues"]') as HTMLInputElement | null;
|
|
|
|
|
expect(input).not.toBeNull();
|
|
|
|
|
const valueSetter = Object.getOwnPropertyDescriptor(window.HTMLInputElement.prototype, "value")?.set;
|
|
|
|
|
expect(valueSetter).toBeTypeOf("function");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
if (!input || !valueSetter) return;
|
|
|
|
|
valueSetter.call(input, "a");
|
|
|
|
|
input.dispatchEvent(new Event("input", { bubbles: true }));
|
|
|
|
|
valueSetter.call(input, "ab");
|
|
|
|
|
input.dispatchEvent(new Event("input", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(onSearchChange).not.toHaveBeenCalled();
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
vi.advanceTimersByTime(149);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(onSearchChange).not.toHaveBeenCalled();
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
vi.advanceTimersByTime(1);
|
|
|
|
|
await Promise.resolve();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(onSearchChange).toHaveBeenCalledTimes(1);
|
|
|
|
|
expect(onSearchChange).toHaveBeenCalledWith("ab");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-07 16:45:57 -05:00
|
|
|
|
[codex] Improve workspace runtime and navigation ergonomics (#3680)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - That operator experience depends not just on issue chat, but also on
how workspaces, inbox groups, and navigation state behave over
long-running sessions
> - The current branch included a separate cluster of workspace-runtime
controls, inbox grouping, sidebar ordering, and worktree lifecycle fixes
> - Those changes cross server, shared contracts, database state, and UI
navigation, but they still form one coherent operator workflow area
> - This pull request isolates the workspace/runtime and navigation
ergonomics work into one standalone branch
> - The benefit is better workspace recovery and navigation persistence
without forcing reviewers through the unrelated issue-detail/chat work
## What Changed
- Improved execution workspace and project workspace controls, request
wiring, layout, and JSON editor ergonomics
- Hardened linked worktree reuse/startup behavior and documented the
`worktree repair` flow for recovering linked worktrees safely
- Added inbox workspace grouping, mobile collapse, archive undo,
keyboard navigation, shared group-header styling, and persisted
collapsed-group behavior
- Added persistent sidebar order preferences with the supporting DB
migration, shared/server contracts, routes, services, hooks, and UI
integration
- Scoped issue-list preferences by context and added targeted UI/server
tests for workspace controls, inbox behavior, sidebar preferences, and
worktree validation
## Verification
- `pnpm vitest run
server/src/__tests__/sidebar-preferences-routes.test.ts
ui/src/pages/Inbox.test.tsx
ui/src/components/ProjectWorkspaceSummaryCard.test.tsx
ui/src/components/WorkspaceRuntimeControls.test.tsx
ui/src/api/workspace-runtime-control.test.ts`
- `server/src/__tests__/workspace-runtime.test.ts` was attempted, but
the embedded Postgres suite self-skipped/hung on this host after
reporting an init-script issue, so it is not counted as a local pass
here
## Risks
- Medium: this branch includes migration-backed preference storage plus
worktree/runtime behavior, so merge review should pay attention to state
persistence and worktree recovery semantics
- The sidebar preference migration is standalone, but it should still be
watched for conflicts if another migration lands first
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:57:11 -05:00
|
|
|
it("uses context-scoped persisted column visibility", async () => {
|
|
|
|
|
localStorage.setItem("paperclip:test-issues:company-1:issue-columns", JSON.stringify(["id", "assignee"]));
|
2026-04-07 16:45:57 -05:00
|
|
|
|
|
|
|
|
const assignedIssue = createIssue({
|
|
|
|
|
id: "issue-assigned",
|
|
|
|
|
identifier: "PAP-9",
|
|
|
|
|
title: "Assigned issue",
|
|
|
|
|
assigneeAgentId: "agent-1",
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[assignedIssue]}
|
|
|
|
|
agents={[{ id: "agent-1", name: "Agent One" }]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
2026-04-10 22:26:21 -05:00
|
|
|
const columnsButton = Array.from(document.body.querySelectorAll("button")).find(
|
|
|
|
|
(button) => button.getAttribute("title") === "Columns",
|
|
|
|
|
);
|
|
|
|
|
expect(columnsButton).not.toBeUndefined();
|
2026-04-07 16:45:57 -05:00
|
|
|
expect(container.textContent).toContain("PAP-9");
|
|
|
|
|
expect(container.textContent).toContain("Agent One");
|
|
|
|
|
expect(container.textContent).not.toContain("Updated");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-09 10:26:17 -05:00
|
|
|
|
[codex] Improve workspace runtime and navigation ergonomics (#3680)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - That operator experience depends not just on issue chat, but also on
how workspaces, inbox groups, and navigation state behave over
long-running sessions
> - The current branch included a separate cluster of workspace-runtime
controls, inbox grouping, sidebar ordering, and worktree lifecycle fixes
> - Those changes cross server, shared contracts, database state, and UI
navigation, but they still form one coherent operator workflow area
> - This pull request isolates the workspace/runtime and navigation
ergonomics work into one standalone branch
> - The benefit is better workspace recovery and navigation persistence
without forcing reviewers through the unrelated issue-detail/chat work
## What Changed
- Improved execution workspace and project workspace controls, request
wiring, layout, and JSON editor ergonomics
- Hardened linked worktree reuse/startup behavior and documented the
`worktree repair` flow for recovering linked worktrees safely
- Added inbox workspace grouping, mobile collapse, archive undo,
keyboard navigation, shared group-header styling, and persisted
collapsed-group behavior
- Added persistent sidebar order preferences with the supporting DB
migration, shared/server contracts, routes, services, hooks, and UI
integration
- Scoped issue-list preferences by context and added targeted UI/server
tests for workspace controls, inbox behavior, sidebar preferences, and
worktree validation
## Verification
- `pnpm vitest run
server/src/__tests__/sidebar-preferences-routes.test.ts
ui/src/pages/Inbox.test.tsx
ui/src/components/ProjectWorkspaceSummaryCard.test.tsx
ui/src/components/WorkspaceRuntimeControls.test.tsx
ui/src/api/workspace-runtime-control.test.ts`
- `server/src/__tests__/workspace-runtime.test.ts` was attempted, but
the embedded Postgres suite self-skipped/hung on this host after
reporting an init-script issue, so it is not counted as a local pass
here
## Risks
- Medium: this branch includes migration-backed preference storage plus
worktree/runtime behavior, so merge review should pay attention to state
persistence and worktree recovery semantics
- The sidebar preference migration is standalone, but it should still be
watched for conflicts if another migration lands first
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:57:11 -05:00
|
|
|
it("preserves stored grouping across refresh when initial assignees are applied", async () => {
|
|
|
|
|
localStorage.setItem(
|
|
|
|
|
"paperclip:test-issues:company-1",
|
|
|
|
|
JSON.stringify({ groupBy: "status", sortField: "updated", sortDir: "desc" }),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
const todoIssue = createIssue({ id: "issue-todo", title: "Alpha", status: "todo", assigneeAgentId: "agent-1" });
|
|
|
|
|
const doneIssue = createIssue({ id: "issue-done", title: "Beta", status: "done", assigneeAgentId: "agent-1" });
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[todoIssue, doneIssue]}
|
|
|
|
|
agents={[{ id: "agent-1", name: "Agent One" }]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
initialAssignees={["agent-1"]}
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(container.textContent).toContain("Todo");
|
|
|
|
|
expect(container.textContent).toContain("Done");
|
|
|
|
|
expect(container.textContent).toContain("Alpha");
|
|
|
|
|
expect(container.textContent).toContain("Beta");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-10 22:26:21 -05:00
|
|
|
it("filters the list to a single workspace when a workspace name is clicked", async () => {
|
[codex] Improve workspace runtime and navigation ergonomics (#3680)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - That operator experience depends not just on issue chat, but also on
how workspaces, inbox groups, and navigation state behave over
long-running sessions
> - The current branch included a separate cluster of workspace-runtime
controls, inbox grouping, sidebar ordering, and worktree lifecycle fixes
> - Those changes cross server, shared contracts, database state, and UI
navigation, but they still form one coherent operator workflow area
> - This pull request isolates the workspace/runtime and navigation
ergonomics work into one standalone branch
> - The benefit is better workspace recovery and navigation persistence
without forcing reviewers through the unrelated issue-detail/chat work
## What Changed
- Improved execution workspace and project workspace controls, request
wiring, layout, and JSON editor ergonomics
- Hardened linked worktree reuse/startup behavior and documented the
`worktree repair` flow for recovering linked worktrees safely
- Added inbox workspace grouping, mobile collapse, archive undo,
keyboard navigation, shared group-header styling, and persisted
collapsed-group behavior
- Added persistent sidebar order preferences with the supporting DB
migration, shared/server contracts, routes, services, hooks, and UI
integration
- Scoped issue-list preferences by context and added targeted UI/server
tests for workspace controls, inbox behavior, sidebar preferences, and
worktree validation
## Verification
- `pnpm vitest run
server/src/__tests__/sidebar-preferences-routes.test.ts
ui/src/pages/Inbox.test.tsx
ui/src/components/ProjectWorkspaceSummaryCard.test.tsx
ui/src/components/WorkspaceRuntimeControls.test.tsx
ui/src/api/workspace-runtime-control.test.ts`
- `server/src/__tests__/workspace-runtime.test.ts` was attempted, but
the embedded Postgres suite self-skipped/hung on this host after
reporting an init-script issue, so it is not counted as a local pass
here
## Risks
- Medium: this branch includes migration-backed preference storage plus
worktree/runtime behavior, so merge review should pay attention to state
persistence and worktree recovery semantics
- The sidebar preference migration is standalone, but it should still be
watched for conflicts if another migration lands first
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:57:11 -05:00
|
|
|
localStorage.setItem("paperclip:test-issues:company-1:issue-columns", JSON.stringify(["id", "workspace"]));
|
2026-04-10 22:26:21 -05:00
|
|
|
mockInstanceSettingsApi.getExperimental.mockResolvedValue({ enableIsolatedWorkspaces: true });
|
|
|
|
|
mockExecutionWorkspacesApi.list.mockResolvedValue([
|
|
|
|
|
{
|
|
|
|
|
id: "workspace-alpha",
|
|
|
|
|
name: "Alpha",
|
|
|
|
|
mode: "isolated_workspace",
|
|
|
|
|
status: "active",
|
|
|
|
|
projectWorkspaceId: null,
|
|
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
id: "workspace-beta",
|
|
|
|
|
name: "Beta",
|
|
|
|
|
mode: "isolated_workspace",
|
|
|
|
|
status: "active",
|
|
|
|
|
projectWorkspaceId: null,
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
const alphaIssue = createIssue({
|
|
|
|
|
id: "issue-alpha",
|
|
|
|
|
identifier: "PAP-20",
|
|
|
|
|
title: "Alpha issue",
|
|
|
|
|
executionWorkspaceId: "workspace-alpha",
|
|
|
|
|
});
|
|
|
|
|
const betaIssue = createIssue({
|
|
|
|
|
id: "issue-beta",
|
|
|
|
|
identifier: "PAP-21",
|
|
|
|
|
title: "Beta issue",
|
|
|
|
|
executionWorkspaceId: "workspace-beta",
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[alphaIssue, betaIssue]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(container.textContent).toContain("Alpha issue");
|
|
|
|
|
expect(container.textContent).toContain("Beta issue");
|
|
|
|
|
const workspaceButton = Array.from(container.querySelectorAll("button")).find(
|
|
|
|
|
(button) => button.textContent === "Alpha",
|
|
|
|
|
);
|
|
|
|
|
expect(workspaceButton).not.toBeUndefined();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
const workspaceButton = Array.from(container.querySelectorAll("button")).find(
|
|
|
|
|
(button) => button.textContent === "Alpha",
|
|
|
|
|
);
|
|
|
|
|
workspaceButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
await Promise.resolve();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(container.textContent).toContain("Alpha issue");
|
|
|
|
|
expect(container.textContent).not.toContain("Beta issue");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-09 10:26:17 -05:00
|
|
|
it("hides routine-backed issues by default and reveals them when the routine filter is enabled", async () => {
|
|
|
|
|
const manualIssue = createIssue({
|
|
|
|
|
id: "issue-manual",
|
|
|
|
|
identifier: "PAP-10",
|
|
|
|
|
title: "Manual issue",
|
|
|
|
|
originKind: "manual",
|
|
|
|
|
});
|
|
|
|
|
const routineIssue = createIssue({
|
|
|
|
|
id: "issue-routine",
|
|
|
|
|
identifier: "PAP-11",
|
|
|
|
|
title: "Routine issue",
|
|
|
|
|
originKind: "routine_execution",
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[manualIssue, routineIssue]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
enableRoutineVisibilityFilter
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(container.textContent).toContain("Manual issue");
|
|
|
|
|
expect(container.textContent).not.toContain("Routine issue");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
const filterButton = Array.from(document.body.querySelectorAll("button")).find(
|
2026-04-10 22:26:21 -05:00
|
|
|
(button) => button.getAttribute("title") === "Filter",
|
2026-04-09 10:26:17 -05:00
|
|
|
);
|
|
|
|
|
filterButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
await Promise.resolve();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
const toggle = Array.from(document.body.querySelectorAll("label")).find(
|
|
|
|
|
(label) => label.textContent?.includes("Show routine runs"),
|
|
|
|
|
);
|
|
|
|
|
expect(toggle).not.toBeUndefined();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
const toggle = Array.from(document.body.querySelectorAll("label")).find(
|
|
|
|
|
(label) => label.textContent?.includes("Show routine runs"),
|
|
|
|
|
);
|
|
|
|
|
toggle?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
|
|
|
await Promise.resolve();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
expect(container.textContent).toContain("Routine issue");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-10 22:26:21 -05:00
|
|
|
|
|
|
|
|
it("blurs the search input on Enter without clearing the query", async () => {
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[createIssue()]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
initialSearch="bug"
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
const input = container.querySelector('input[aria-label="Search issues"]') as HTMLInputElement | null;
|
|
|
|
|
expect(input).not.toBeNull();
|
|
|
|
|
input?.focus();
|
|
|
|
|
expect(document.activeElement).toBe(input);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const input = container.querySelector('input[aria-label="Search issues"]') as HTMLInputElement;
|
|
|
|
|
act(() => {
|
|
|
|
|
input.dispatchEvent(new KeyboardEvent("keydown", {
|
|
|
|
|
key: "Enter",
|
|
|
|
|
bubbles: true,
|
|
|
|
|
}));
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(document.activeElement).not.toBe(input);
|
|
|
|
|
expect(input.value).toBe("bug");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("blurs the search input on Escape once the field is empty", async () => {
|
|
|
|
|
const { root } = renderWithQueryClient(
|
|
|
|
|
<IssuesList
|
|
|
|
|
issues={[createIssue()]}
|
|
|
|
|
agents={[]}
|
|
|
|
|
projects={[]}
|
|
|
|
|
viewStateKey="paperclip:test-issues"
|
|
|
|
|
initialSearch=""
|
|
|
|
|
onUpdateIssue={() => undefined}
|
|
|
|
|
/>,
|
|
|
|
|
container,
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
await waitForAssertion(() => {
|
|
|
|
|
const input = container.querySelector('input[aria-label="Search issues"]') as HTMLInputElement | null;
|
|
|
|
|
expect(input).not.toBeNull();
|
|
|
|
|
input?.focus();
|
|
|
|
|
expect(document.activeElement).toBe(input);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const input = container.querySelector('input[aria-label="Search issues"]') as HTMLInputElement;
|
|
|
|
|
act(() => {
|
|
|
|
|
input.dispatchEvent(new KeyboardEvent("keydown", {
|
|
|
|
|
key: "Escape",
|
|
|
|
|
bubbles: true,
|
|
|
|
|
}));
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(document.activeElement).not.toBe(input);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-06 20:30:50 -05:00
|
|
|
});
|