2026-04-06 09:28:03 -05:00
|
|
|
// @vitest-environment jsdom
|
|
|
|
|
|
2026-04-08 09:24:32 -05:00
|
|
|
import { act, createRef, forwardRef, useImperativeHandle } from "react";
|
2026-04-06 09:28:03 -05:00
|
|
|
import type { ReactNode } from "react";
|
|
|
|
|
import { createRoot } from "react-dom/client";
|
|
|
|
|
import { MemoryRouter } from "react-router-dom";
|
|
|
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
import { IssueChatThread, canStopIssueChatRun, resolveAssistantMessageFoldedState } from "./IssueChatThread";
|
2026-04-06 09:28:03 -05:00
|
|
|
|
2026-04-08 09:24:32 -05:00
|
|
|
const { markdownEditorFocusMock } = vi.hoisted(() => ({
|
|
|
|
|
markdownEditorFocusMock: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
const { appendMock } = vi.hoisted(() => ({
|
|
|
|
|
appendMock: vi.fn(async () => undefined),
|
|
|
|
|
}));
|
|
|
|
|
|
2026-04-08 17:14:02 -05:00
|
|
|
const { threadMessagesMock } = vi.hoisted(() => ({
|
|
|
|
|
threadMessagesMock: vi.fn(() => <div data-testid="thread-messages" />),
|
|
|
|
|
}));
|
|
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
const {
|
|
|
|
|
captureComposerViewportSnapshotMock,
|
|
|
|
|
restoreComposerViewportSnapshotMock,
|
|
|
|
|
shouldPreserveComposerViewportMock,
|
|
|
|
|
} = vi.hoisted(() => ({
|
|
|
|
|
captureComposerViewportSnapshotMock: vi.fn(),
|
|
|
|
|
restoreComposerViewportSnapshotMock: vi.fn(),
|
|
|
|
|
shouldPreserveComposerViewportMock: vi.fn(),
|
|
|
|
|
}));
|
|
|
|
|
|
2026-04-06 09:28:03 -05:00
|
|
|
vi.mock("@assistant-ui/react", () => ({
|
|
|
|
|
AssistantRuntimeProvider: ({ children }: { children: ReactNode }) => <div>{children}</div>,
|
|
|
|
|
ThreadPrimitive: {
|
|
|
|
|
Root: ({ children, className }: { children: ReactNode; className?: string }) => (
|
|
|
|
|
<div data-testid="thread-root" className={className}>{children}</div>
|
|
|
|
|
),
|
|
|
|
|
Viewport: ({ children, className }: { children: ReactNode; className?: string }) => (
|
|
|
|
|
<div data-testid="thread-viewport" className={className}>{children}</div>
|
|
|
|
|
),
|
|
|
|
|
Empty: ({ children }: { children: ReactNode }) => <div>{children}</div>,
|
2026-04-08 17:14:02 -05:00
|
|
|
Messages: () => threadMessagesMock(),
|
2026-04-06 09:28:03 -05:00
|
|
|
},
|
|
|
|
|
MessagePrimitive: {
|
|
|
|
|
Root: ({ children }: { children: ReactNode }) => <div>{children}</div>,
|
|
|
|
|
Content: () => null,
|
2026-04-06 11:00:12 -05:00
|
|
|
Parts: () => null,
|
2026-04-06 09:28:03 -05:00
|
|
|
},
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
useAui: () => ({ thread: () => ({ append: appendMock }) }),
|
2026-04-06 09:28:03 -05:00
|
|
|
useAuiState: () => false,
|
|
|
|
|
useMessage: () => ({
|
|
|
|
|
id: "message",
|
|
|
|
|
role: "assistant",
|
|
|
|
|
createdAt: new Date("2026-04-06T12:00:00.000Z"),
|
|
|
|
|
content: [],
|
|
|
|
|
metadata: { custom: {} },
|
|
|
|
|
status: { type: "complete" },
|
|
|
|
|
}),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./transcript/useLiveRunTranscripts", () => ({
|
|
|
|
|
useLiveRunTranscripts: () => ({
|
|
|
|
|
transcriptByRun: new Map(),
|
|
|
|
|
hasOutputForRun: () => false,
|
|
|
|
|
}),
|
|
|
|
|
}));
|
|
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
vi.mock("../lib/issue-chat-scroll", async (importOriginal) => {
|
|
|
|
|
const actual = await importOriginal<typeof import("../lib/issue-chat-scroll")>();
|
|
|
|
|
return {
|
|
|
|
|
...actual,
|
|
|
|
|
captureComposerViewportSnapshot: captureComposerViewportSnapshotMock.mockImplementation(actual.captureComposerViewportSnapshot),
|
|
|
|
|
restoreComposerViewportSnapshot: restoreComposerViewportSnapshotMock.mockImplementation(actual.restoreComposerViewportSnapshot),
|
|
|
|
|
shouldPreserveComposerViewport: shouldPreserveComposerViewportMock.mockImplementation(actual.shouldPreserveComposerViewport),
|
|
|
|
|
};
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-06 09:28:03 -05:00
|
|
|
vi.mock("./MarkdownBody", () => ({
|
|
|
|
|
MarkdownBody: ({ children }: { children: ReactNode }) => <div>{children}</div>,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./MarkdownEditor", () => ({
|
2026-04-08 09:24:32 -05:00
|
|
|
MarkdownEditor: forwardRef(({
|
2026-04-06 11:00:12 -05:00
|
|
|
value = "",
|
|
|
|
|
onChange,
|
2026-04-06 11:43:45 -05:00
|
|
|
placeholder,
|
2026-04-08 09:11:21 -05:00
|
|
|
className,
|
|
|
|
|
contentClassName,
|
2026-04-06 11:00:12 -05:00
|
|
|
}: {
|
|
|
|
|
value?: string;
|
|
|
|
|
onChange?: (value: string) => void;
|
2026-04-06 11:43:45 -05:00
|
|
|
placeholder?: string;
|
2026-04-08 09:11:21 -05:00
|
|
|
className?: string;
|
|
|
|
|
contentClassName?: string;
|
2026-04-08 09:24:32 -05:00
|
|
|
}, ref) => {
|
|
|
|
|
useImperativeHandle(ref, () => ({
|
|
|
|
|
focus: markdownEditorFocusMock,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
return (
|
|
|
|
|
<textarea
|
|
|
|
|
aria-label="Issue chat editor"
|
|
|
|
|
data-class-name={className}
|
|
|
|
|
data-content-class-name={contentClassName}
|
|
|
|
|
placeholder={placeholder}
|
|
|
|
|
value={value}
|
|
|
|
|
onChange={(event) => onChange?.(event.target.value)}
|
|
|
|
|
/>
|
|
|
|
|
);
|
|
|
|
|
}),
|
2026-04-06 09:28:03 -05:00
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./InlineEntitySelector", () => ({
|
|
|
|
|
InlineEntitySelector: () => null,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./Identity", () => ({
|
|
|
|
|
Identity: ({ name }: { name: string }) => <span>{name}</span>,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./OutputFeedbackButtons", () => ({
|
|
|
|
|
OutputFeedbackButtons: () => null,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./AgentIconPicker", () => ({
|
|
|
|
|
AgentIcon: () => null,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("./StatusBadge", () => ({
|
|
|
|
|
StatusBadge: ({ status }: { status: string }) => <span>{status}</span>,
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
vi.mock("../hooks/usePaperclipIssueRuntime", () => ({
|
|
|
|
|
usePaperclipIssueRuntime: () => ({}),
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
|
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
|
|
|
|
|
|
describe("IssueChatThread", () => {
|
|
|
|
|
let container: HTMLDivElement;
|
|
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
|
container = document.createElement("div");
|
|
|
|
|
document.body.appendChild(container);
|
2026-04-06 11:00:12 -05:00
|
|
|
localStorage.clear();
|
2026-04-08 17:14:02 -05:00
|
|
|
threadMessagesMock.mockImplementation(() => <div data-testid="thread-messages" />);
|
2026-04-06 09:28:03 -05:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
|
container.remove();
|
2026-04-06 11:00:12 -05:00
|
|
|
vi.useRealTimers();
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
appendMock.mockReset();
|
2026-04-08 09:24:32 -05:00
|
|
|
markdownEditorFocusMock.mockReset();
|
2026-04-08 17:14:02 -05:00
|
|
|
threadMessagesMock.mockReset();
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
captureComposerViewportSnapshotMock.mockClear();
|
|
|
|
|
restoreComposerViewportSnapshotMock.mockClear();
|
|
|
|
|
shouldPreserveComposerViewportMock.mockClear();
|
2026-04-06 09:28:03 -05:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("drops the count heading and does not use an internal scrollbox", () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
showComposer={false}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).toContain("Jump to latest");
|
|
|
|
|
expect(container.textContent).not.toContain("Chat (");
|
|
|
|
|
|
|
|
|
|
const viewport = container.querySelector('[data-testid="thread-viewport"]') as HTMLDivElement | null;
|
|
|
|
|
expect(viewport).not.toBeNull();
|
|
|
|
|
expect(viewport?.className).not.toContain("overflow-y-auto");
|
|
|
|
|
expect(viewport?.className).not.toContain("max-h-[70vh]");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-06 11:00:12 -05:00
|
|
|
|
2026-04-07 18:17:29 -05:00
|
|
|
it("supports the embedded read-only variant without the jump control", () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
showComposer={false}
|
|
|
|
|
showJumpToLatest={false}
|
|
|
|
|
variant="embedded"
|
|
|
|
|
emptyMessage="No run output captured."
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).toContain("No run output captured.");
|
|
|
|
|
expect(container.textContent).not.toContain("Jump to latest");
|
|
|
|
|
|
|
|
|
|
const viewport = container.querySelector('[data-testid="thread-viewport"]') as HTMLDivElement | null;
|
|
|
|
|
expect(viewport?.className).toContain("space-y-3");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-08 17:14:02 -05:00
|
|
|
it("falls back to a safe transcript warning when assistant-ui throws during message rendering", () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
const consoleErrorSpy = vi.spyOn(console, "error").mockImplementation(() => {});
|
|
|
|
|
threadMessagesMock.mockImplementation(() => {
|
|
|
|
|
throw new Error("tapClientLookup: Index 8 out of bounds (length: 8)");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[{
|
|
|
|
|
id: "comment-1",
|
|
|
|
|
companyId: "company-1",
|
|
|
|
|
issueId: "issue-1",
|
|
|
|
|
authorAgentId: "agent-1",
|
|
|
|
|
authorUserId: null,
|
|
|
|
|
body: "Agent summary",
|
|
|
|
|
createdAt: new Date("2026-04-06T12:00:00.000Z"),
|
|
|
|
|
updatedAt: new Date("2026-04-06T12:00:00.000Z"),
|
|
|
|
|
}]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
showComposer={false}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).toContain("Chat renderer hit an internal state error.");
|
|
|
|
|
expect(container.textContent).toContain("Agent summary");
|
|
|
|
|
expect(consoleErrorSpy).toHaveBeenCalled();
|
|
|
|
|
|
|
|
|
|
consoleErrorSpy.mockRestore();
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-06 11:00:12 -05:00
|
|
|
it("stores and restores the composer draft per issue key", () => {
|
|
|
|
|
vi.useFakeTimers();
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
draftKey="issue-chat-draft:test-1"
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const editor = container.querySelector('textarea[aria-label="Issue chat editor"]') as HTMLTextAreaElement | null;
|
|
|
|
|
expect(editor).not.toBeNull();
|
2026-04-06 11:43:45 -05:00
|
|
|
expect(editor?.placeholder).toBe("Reply");
|
2026-04-06 11:00:12 -05:00
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
|
|
|
window.HTMLTextAreaElement.prototype,
|
|
|
|
|
"value",
|
|
|
|
|
)?.set;
|
|
|
|
|
valueSetter?.call(editor, "Draft survives refresh");
|
|
|
|
|
editor?.dispatchEvent(new Event("input", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
vi.advanceTimersByTime(900);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(localStorage.getItem("issue-chat-draft:test-1")).toBe("Draft survives refresh");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const remount = createRoot(container);
|
|
|
|
|
act(() => {
|
|
|
|
|
remount.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
draftKey="issue-chat-draft:test-1"
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const restoredEditor = container.querySelector('textarea[aria-label="Issue chat editor"]') as HTMLTextAreaElement | null;
|
|
|
|
|
expect(restoredEditor?.value).toBe("Draft survives refresh");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
remount.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-07 17:02:48 -05:00
|
|
|
|
2026-04-08 11:21:11 -05:00
|
|
|
it("keeps the composer inline with bottom breathing room and a capped editor height", () => {
|
2026-04-08 09:11:21 -05:00
|
|
|
const root = createRoot(container);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const composer = container.querySelector('[data-testid="issue-chat-composer"]') as HTMLDivElement | null;
|
|
|
|
|
expect(composer).not.toBeNull();
|
2026-04-08 11:21:11 -05:00
|
|
|
expect(composer?.className).not.toContain("sticky");
|
|
|
|
|
expect(composer?.className).not.toContain("bottom-0");
|
|
|
|
|
expect(composer?.className).toContain("pb-[calc(env(safe-area-inset-bottom)+1.5rem)]");
|
2026-04-08 09:11:21 -05:00
|
|
|
|
|
|
|
|
const editor = container.querySelector('textarea[aria-label="Issue chat editor"]') as HTMLTextAreaElement | null;
|
2026-04-08 09:51:45 -05:00
|
|
|
expect(editor?.dataset.contentClassName).toContain("max-h-[28dvh]");
|
2026-04-08 09:11:21 -05:00
|
|
|
expect(editor?.dataset.contentClassName).toContain("overflow-y-auto");
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
it("hides the reopen control and infers reopen for closed agent-assigned issue replies", async () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
issueStatus="done"
|
|
|
|
|
currentAssigneeValue="agent:agent-1"
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(container.textContent).not.toContain("Re-open");
|
|
|
|
|
|
|
|
|
|
const editor = container.querySelector('textarea[aria-label="Issue chat editor"]') as HTMLTextAreaElement | null;
|
|
|
|
|
const submitButton = Array.from(container.querySelectorAll("button")).find(
|
|
|
|
|
(element) => element.textContent === "Send",
|
|
|
|
|
) as HTMLButtonElement | undefined;
|
|
|
|
|
expect(editor).not.toBeNull();
|
|
|
|
|
expect(submitButton).toBeDefined();
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
const valueSetter = Object.getOwnPropertyDescriptor(
|
|
|
|
|
window.HTMLTextAreaElement.prototype,
|
|
|
|
|
"value",
|
|
|
|
|
)?.set;
|
|
|
|
|
valueSetter?.call(editor, "Please pick this back up");
|
|
|
|
|
editor?.dispatchEvent(new Event("input", { bubbles: true }));
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await act(async () => {
|
|
|
|
|
submitButton?.click();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(appendMock).toHaveBeenCalledWith(
|
|
|
|
|
expect.objectContaining({
|
|
|
|
|
content: [{ type: "text", text: "Please pick this back up" }],
|
|
|
|
|
runConfig: {
|
|
|
|
|
custom: {
|
|
|
|
|
reopen: true,
|
|
|
|
|
},
|
|
|
|
|
},
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-08 09:24:32 -05:00
|
|
|
it("exposes a composer focus handle that forwards to the editor", () => {
|
|
|
|
|
const root = createRoot(container);
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
const composerRef = createRef<{ focus: () => void; restoreDraft: (submittedBody: string) => void }>();
|
2026-04-08 16:41:13 -05:00
|
|
|
const scrollByMock = vi.spyOn(window, "scrollBy").mockImplementation(() => {});
|
2026-04-08 09:24:32 -05:00
|
|
|
const requestAnimationFrameMock = vi
|
|
|
|
|
.spyOn(window, "requestAnimationFrame")
|
|
|
|
|
.mockImplementation((callback: FrameRequestCallback) => {
|
|
|
|
|
callback(0);
|
|
|
|
|
return 1;
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
composerRef={composerRef}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const composer = container.querySelector('[data-testid="issue-chat-composer"]') as HTMLDivElement | null;
|
|
|
|
|
expect(composerRef.current).not.toBeNull();
|
|
|
|
|
expect(composer).not.toBeNull();
|
|
|
|
|
|
|
|
|
|
const scrollIntoViewMock = vi.fn();
|
|
|
|
|
composer!.scrollIntoView = scrollIntoViewMock;
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
composerRef.current?.focus();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(scrollIntoViewMock).toHaveBeenCalledWith({ behavior: "smooth", block: "end" });
|
2026-04-08 16:41:13 -05:00
|
|
|
expect(scrollByMock).toHaveBeenCalledWith({ top: 96, behavior: "smooth" });
|
2026-04-08 09:24:32 -05:00
|
|
|
expect(markdownEditorFocusMock).toHaveBeenCalledTimes(1);
|
2026-04-08 16:41:13 -05:00
|
|
|
scrollByMock.mockRestore();
|
2026-04-08 09:24:32 -05:00
|
|
|
requestAnimationFrameMock.mockRestore();
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
it("restores a cancelled queued draft into the composer handle", () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
const composerRef = createRef<{ focus: () => void; restoreDraft: (submittedBody: string) => void }>();
|
|
|
|
|
const scrollByMock = vi.spyOn(window, "scrollBy").mockImplementation(() => {});
|
|
|
|
|
const requestAnimationFrameMock = vi
|
|
|
|
|
.spyOn(window, "requestAnimationFrame")
|
|
|
|
|
.mockImplementation((callback: FrameRequestCallback) => {
|
|
|
|
|
callback(0);
|
|
|
|
|
return 1;
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
composerRef={composerRef}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const editor = container.querySelector('textarea[aria-label="Issue chat editor"]') as HTMLTextAreaElement | null;
|
|
|
|
|
expect(editor).not.toBeNull();
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
composerRef.current?.restoreDraft("Queued message");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(editor?.value).toBe("Queued message");
|
|
|
|
|
expect(markdownEditorFocusMock).toHaveBeenCalledTimes(1);
|
|
|
|
|
expect(scrollByMock).toHaveBeenCalledWith({ top: 96, behavior: "smooth" });
|
|
|
|
|
|
|
|
|
|
scrollByMock.mockRestore();
|
|
|
|
|
requestAnimationFrameMock.mockRestore();
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("does not restore the composer viewport for passive live updates by default", () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[{
|
|
|
|
|
id: "run-1",
|
|
|
|
|
issueId: "issue-1",
|
|
|
|
|
status: "running",
|
|
|
|
|
invocationSource: "comment",
|
|
|
|
|
triggerDetail: null,
|
|
|
|
|
startedAt: "2026-04-06T12:00:00.000Z",
|
|
|
|
|
finishedAt: null,
|
|
|
|
|
createdAt: "2026-04-06T12:00:00.000Z",
|
|
|
|
|
agentId: "agent-1",
|
|
|
|
|
agentName: "Agent 1",
|
|
|
|
|
adapterType: "codex_local",
|
|
|
|
|
}]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(restoreComposerViewportSnapshotMock).not.toHaveBeenCalled();
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("requests composer viewport restoration when live messages arrive during active composer interaction", () => {
|
|
|
|
|
const root = createRoot(container);
|
|
|
|
|
const scrollByMock = vi.spyOn(window, "scrollBy").mockImplementation(() => {});
|
|
|
|
|
shouldPreserveComposerViewportMock.mockReturnValue(true);
|
|
|
|
|
captureComposerViewportSnapshotMock.mockReturnValue({ composerViewportTop: 420 });
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
act(() => {
|
|
|
|
|
root.render(
|
|
|
|
|
<MemoryRouter>
|
|
|
|
|
<IssueChatThread
|
|
|
|
|
comments={[]}
|
|
|
|
|
linkedRuns={[]}
|
|
|
|
|
timelineEvents={[]}
|
|
|
|
|
liveRuns={[{
|
|
|
|
|
id: "run-1",
|
|
|
|
|
issueId: "issue-1",
|
|
|
|
|
status: "running",
|
|
|
|
|
invocationSource: "comment",
|
|
|
|
|
triggerDetail: null,
|
|
|
|
|
startedAt: "2026-04-06T12:00:00.000Z",
|
|
|
|
|
finishedAt: null,
|
|
|
|
|
createdAt: "2026-04-06T12:00:00.000Z",
|
|
|
|
|
agentId: "agent-1",
|
|
|
|
|
agentName: "Agent 1",
|
|
|
|
|
adapterType: "codex_local",
|
|
|
|
|
}]}
|
|
|
|
|
onAdd={async () => {}}
|
|
|
|
|
enableLiveTranscriptPolling={false}
|
|
|
|
|
/>
|
|
|
|
|
</MemoryRouter>,
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
expect(restoreComposerViewportSnapshotMock).toHaveBeenCalled();
|
|
|
|
|
|
|
|
|
|
scrollByMock.mockRestore();
|
|
|
|
|
act(() => {
|
|
|
|
|
root.unmount();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-07 17:02:48 -05:00
|
|
|
it("folds chain-of-thought when the same message transitions from running to complete", () => {
|
|
|
|
|
expect(resolveAssistantMessageFoldedState({
|
|
|
|
|
messageId: "message-1",
|
|
|
|
|
currentFolded: false,
|
|
|
|
|
isFoldable: true,
|
|
|
|
|
previousMessageId: "message-1",
|
|
|
|
|
previousIsFoldable: false,
|
|
|
|
|
})).toBe(true);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("preserves a manually opened completed message across rerenders", () => {
|
|
|
|
|
expect(resolveAssistantMessageFoldedState({
|
|
|
|
|
messageId: "message-1",
|
|
|
|
|
currentFolded: false,
|
|
|
|
|
isFoldable: true,
|
|
|
|
|
previousMessageId: "message-1",
|
|
|
|
|
previousIsFoldable: true,
|
|
|
|
|
})).toBe(false);
|
|
|
|
|
});
|
[codex] Improve issue detail and issue-list UX (#3678)
## Thinking Path
> - Paperclip orchestrates AI agents for zero-human companies
> - A core part of that is the operator experience around reading issue
state, agent chat, and sub-task structure
> - The current branch had a long run of issue-detail and issue-list UX
fixes that all improve how humans follow and steer active work
> - Those changes mostly live in the UI/chat surface and should be
reviewed together instead of mixed with workspace/runtime work
> - This pull request packages the issue-detail, chat, markdown, and
sub-issue list improvements into one standalone change
> - The benefit is a cleaner, less jumpy, more reliable issue workflow
on desktop and mobile without coupling it to unrelated server/runtime
refactors
## What Changed
- Stabilized issue chat runtime wiring, optimistic comment handling,
queued-comment cancellation, and composer anchoring during live updates
- Fixed several issue-detail rendering and navigation regressions
including placeholder bleed, local polling scope, mobile inbox-to-issue
transitions, and visible refresh resets
- Improved markdown and rich-content handling with advisory image
normalization, editor fallback behavior, touch mention recovery, and
`issue:` quicklook links
- Refined sub-issue behavior with parent-derived defaults, current-user
inheritance fixes, empty-state cleanup, and a reusable issue-list
presentation for sub-issues
- Added targeted UI tests for the new issue-detail, chat scroll/message,
placeholder-data, markdown, and issue-list behaviors
## Verification
- `pnpm vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/components/MarkdownEditor.test.tsx
ui/src/components/IssuesList.test.tsx
ui/src/context/LiveUpdatesProvider.test.tsx
ui/src/lib/issue-chat-messages.test.ts
ui/src/lib/issue-chat-scroll.test.ts
ui/src/lib/issue-detail-subissues.test.ts
ui/src/lib/query-placeholder-data.test.tsx
ui/src/hooks/usePaperclipIssueRuntime.test.tsx`
## Risks
- Medium: this branch touches the highest-traffic issue-detail UI paths,
so regressions would show up as chat/thread or sub-issue UX glitches
- The changes are UI-heavy and would benefit from reviewer screenshots
or a quick manual browser pass before merge
## Model Used
- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled
## Checklist
- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [ ] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
---------
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-14 12:50:48 -05:00
|
|
|
|
|
|
|
|
it("shows the stop-run action for active run-linked messages even without embedded run status", () => {
|
|
|
|
|
expect(canStopIssueChatRun({
|
|
|
|
|
runId: "run-1",
|
|
|
|
|
runStatus: null,
|
|
|
|
|
activeRunIds: new Set(["run-1"]),
|
|
|
|
|
})).toBe(true);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("hides the stop-run action for completed historical runs", () => {
|
|
|
|
|
expect(canStopIssueChatRun({
|
|
|
|
|
runId: "run-1",
|
|
|
|
|
runStatus: "cancelled",
|
|
|
|
|
activeRunIds: new Set<string>(),
|
|
|
|
|
})).toBe(false);
|
|
|
|
|
});
|
2026-04-06 09:28:03 -05:00
|
|
|
});
|