Revert "fix(ui): improve routine properties panel and history UX" (#5723)

## Thinking Path

> - Paperclip orchestrates AI agents through visible, governable task
and routine workflows.
> - The routines UI includes the routine detail page, properties panel,
history tab, and shared sidebar components.
> - PR #5703 changed that workflow by widening the routine properties
panel and moving revision inspection/comparison into dialogs.
> - The product direction for that change is being paused for now, so
the safest path is a direct revert instead of partial edits.
> - This pull request reverts merge commit
`74cb560c41` from #5703.
> - The benefit is restoring the prior routines UI behavior while
keeping the revert easy to review and re-apply later if needed.

## What Changed

- Reverted #5703: `fix(ui): improve routine properties panel and history
UX`.
- Restored the previous routine properties panel sizing, panel context
API, routine detail layout, and routine history rendering behavior.
- Removed the reverted sidebar pane test additions and restored the
previous focused routine history test expectations.

## Verification

- `git diff --check origin/master..HEAD`
- `pnpm vitest run ui/src/components/RoutineHistoryTab.test.tsx`
- `pnpm --filter @paperclipai/ui typecheck`

### Screenshots

This is a direct revert of #5703. The visual state after this PR
corresponds to the "Before" screenshots from #5703, and the state being
removed corresponds to the "After" screenshots from #5703.

#### Trigger Panel Width

| Before this revert | After this revert |
| --- | --- |
| <img width="1742" height="1288" alt="triggers-before-this-revert"
src="https://github.com/user-attachments/assets/9e818978-283c-49a3-9401-879be550c67b"
/> | <img width="1741" height="1289" alt="triggers-after-this-revert"
src="https://github.com/user-attachments/assets/2a391769-c355-4219-8da3-d1ea18698430"
/> |

#### History Panel

| Before this revert | After this revert |
| --- | --- |
| <img width="1741" height="1290" alt="history-before-this-revert"
src="https://github.com/user-attachments/assets/4c139238-8494-4438-89e1-4277d05bc3aa"
/> | <img width="1739" height="1289" alt="history-after-this-revert"
src="https://github.com/user-attachments/assets/eaea4f3d-bb65-4af6-b67f-3ba3026fe0c9"
/> |

## Risks

- Low technical risk: this is a clean Git revert of a recently merged
UI-only PR.
- Product risk: the routine properties panel and revision history return
to the older, narrower workflow that #5703 was improving.
- Re-application risk: future work that wants the #5703 behavior back
should re-apply it deliberately rather than cherry-picking around this
revert.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, GPT-5 coding agent, tool-enabled with local shell and
GitHub CLI access. Context window size was not exposed in this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta 2026-05-11 13:10:40 -05:00 committed by GitHub
parent 21404e8a34
commit 0c6f9bdcf8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 553 additions and 584 deletions

View file

@ -1,59 +1,29 @@
import { X } from "lucide-react"; import { X } from "lucide-react";
import { usePanel } from "../context/PanelContext"; import { usePanel } from "../context/PanelContext";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { ResizableSidebarPane } from "./ResizableSidebarPane"; import { ScrollArea } from "@/components/ui/scroll-area";
const PROPERTIES_PANEL_DEFAULT = 320;
const PROPERTIES_PANEL_MIN = 320;
const PROPERTIES_PANEL_MAX = 640;
const PROPERTIES_PANEL_STORAGE_KEY = "paperclip.properties.width";
export function PropertiesPanel() { export function PropertiesPanel() {
const { panelContent, panelLayout, panelVisible, setPanelVisible } = usePanel(); const { panelContent, panelVisible, setPanelVisible } = usePanel();
if (!panelContent) return null; if (!panelContent) return null;
const storageKey = panelLayout.storageKey ?? PROPERTIES_PANEL_STORAGE_KEY;
const defaultWidth = panelLayout.defaultWidth ?? PROPERTIES_PANEL_DEFAULT;
const minWidth = panelLayout.minWidth ?? PROPERTIES_PANEL_MIN;
const maxWidth = panelLayout.maxWidth ?? PROPERTIES_PANEL_MAX;
const compactBelowViewport = panelLayout.compactBelowViewport;
const compactMaxWidth = panelLayout.compactMaxWidth;
return ( return (
<aside className="hidden md:flex border-l border-border bg-card shrink-0 h-full"> <aside
<ResizableSidebarPane className="hidden md:flex border-l border-border bg-card flex-col shrink-0 overflow-hidden transition-[width,opacity] duration-200 ease-in-out h-full"
// Remount when the layout key changes so the stored width is re-read fresh. style={{ width: panelVisible ? 320 : 0, opacity: panelVisible ? 1 : 0 }}
key={storageKey} >
open={panelVisible} <div className="w-80 flex-1 flex flex-col min-w-[320px] min-h-0">
resizable <div className="flex items-center justify-between px-4 py-2 border-b border-border">
side="right" <span className="text-sm font-medium">Properties</span>
storageKey={storageKey} <Button variant="ghost" size="icon-xs" onClick={() => setPanelVisible(false)}>
defaultWidth={defaultWidth} <X className="h-4 w-4" />
minWidth={minWidth} </Button>
maxWidth={maxWidth}
compactBelowViewport={compactBelowViewport}
compactMaxWidth={compactMaxWidth}
widthVariable="--properties-panel-width"
className="h-full"
>
<div className="flex h-full w-full flex-col min-h-0">
<div className="flex items-center justify-between px-4 py-2 border-b border-border">
<span className="text-sm font-medium">Properties</span>
<Button
variant="ghost"
size="icon-xs"
onClick={() => setPanelVisible(false)}
aria-label="Close properties panel"
>
<X className="h-4 w-4" />
</Button>
</div>
<div className="flex-1 min-h-0 overflow-y-auto overflow-x-hidden">
<div className="p-4 min-w-0">{panelContent}</div>
</div>
</div> </div>
</ResizableSidebarPane> <ScrollArea className="flex-1">
<div className="p-4">{panelContent}</div>
</ScrollArea>
</div>
</aside> </aside>
); );
} }

View file

@ -17,10 +17,8 @@ function pointerEvent(type: string, clientX: number) {
describe("ResizableSidebarPane", () => { describe("ResizableSidebarPane", () => {
let container: HTMLDivElement; let container: HTMLDivElement;
let root: Root; let root: Root;
let originalInnerWidth: number;
beforeEach(() => { beforeEach(() => {
originalInnerWidth = window.innerWidth;
window.localStorage.clear(); window.localStorage.clear();
container = document.createElement("div"); container = document.createElement("div");
document.body.appendChild(container); document.body.appendChild(container);
@ -33,8 +31,6 @@ describe("ResizableSidebarPane", () => {
}); });
container.remove(); container.remove();
window.localStorage.clear(); window.localStorage.clear();
document.documentElement.style.removeProperty("--test-sidebar-width");
setInnerWidth(originalInnerWidth);
}); });
function pane() { function pane() {
@ -45,14 +41,6 @@ describe("ResizableSidebarPane", () => {
return container.querySelector('[role="separator"]') as HTMLDivElement | null; return container.querySelector('[role="separator"]') as HTMLDivElement | null;
} }
function setInnerWidth(width: number) {
Object.defineProperty(window, "innerWidth", {
configurable: true,
writable: true,
value: width,
});
}
it("uses a persisted width when open", () => { it("uses a persisted width when open", () => {
window.localStorage.setItem("test.sidebar.width", "320"); window.localStorage.setItem("test.sidebar.width", "320");
@ -130,135 +118,4 @@ describe("ResizableSidebarPane", () => {
expect(handle()).toBeNull(); expect(handle()).toBeNull();
expect(pane().style.width).toBe("240px"); expect(pane().style.width).toBe("240px");
}); });
it("supports custom defaults and bounds", () => {
act(() => {
root.render(
<ResizableSidebarPane
open
resizable
storageKey="test.properties.width"
defaultWidth={400}
minWidth={320}
maxWidth={640}
>
<div>Properties</div>
</ResizableSidebarPane>,
);
});
expect(pane().style.width).toBe("400px");
expect(handle()?.getAttribute("aria-valuemin")).toBe("320");
expect(handle()?.getAttribute("aria-valuemax")).toBe("640");
});
it("uses right-side drag and keyboard semantics", () => {
act(() => {
root.render(
<ResizableSidebarPane
open
resizable
side="right"
storageKey="test.properties.width"
defaultWidth={400}
minWidth={320}
maxWidth={640}
>
<div>Properties</div>
</ResizableSidebarPane>,
);
});
const separator = handle();
expect(separator).not.toBeNull();
separator!.setPointerCapture = vi.fn();
act(() => {
separator!.dispatchEvent(pointerEvent("pointerdown", 400));
separator!.dispatchEvent(pointerEvent("pointermove", 360));
separator!.dispatchEvent(pointerEvent("pointerup", 360));
});
expect(pane().style.width).toBe("440px");
expect(window.localStorage.getItem("test.properties.width")).toBe("440");
act(() => {
separator?.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowLeft", bubbles: true }));
});
expect(pane().style.width).toBe("456px");
expect(window.localStorage.getItem("test.properties.width")).toBe("456");
});
it("exposes the visible width as a CSS variable", () => {
act(() => {
root.render(
<ResizableSidebarPane
open
resizable
storageKey="test.properties.width"
defaultWidth={400}
minWidth={320}
maxWidth={640}
widthVariable="--test-sidebar-width"
>
<div>Properties</div>
</ResizableSidebarPane>,
);
});
expect(document.documentElement.style.getPropertyValue("--test-sidebar-width")).toBe("400px");
act(() => {
root.render(
<ResizableSidebarPane
open={false}
resizable
storageKey="test.properties.width"
defaultWidth={400}
minWidth={320}
maxWidth={640}
widthVariable="--test-sidebar-width"
>
<div>Properties</div>
</ResizableSidebarPane>,
);
});
expect(document.documentElement.style.getPropertyValue("--test-sidebar-width")).toBe("0px");
});
it("clamps to compact width below the configured viewport without overwriting the stored wide width", () => {
window.localStorage.setItem("test.properties.width", "520");
setInnerWidth(900);
act(() => {
root.render(
<ResizableSidebarPane
open
resizable
storageKey="test.properties.width"
defaultWidth={400}
minWidth={320}
maxWidth={640}
compactBelowViewport={1024}
compactMaxWidth={320}
>
<div>Properties</div>
</ResizableSidebarPane>,
);
});
expect(pane().style.width).toBe("320px");
expect(handle()).toBeNull();
expect(window.localStorage.getItem("test.properties.width")).toBe("520");
act(() => {
setInnerWidth(1200);
window.dispatchEvent(new Event("resize"));
});
expect(pane().style.width).toBe("520px");
expect(handle()?.getAttribute("aria-valuemax")).toBe("640");
});
}); });

View file

@ -15,29 +15,29 @@ const MIN_SIDEBAR_WIDTH = 208;
const MAX_SIDEBAR_WIDTH = 420; const MAX_SIDEBAR_WIDTH = 420;
const SIDEBAR_WIDTH_STEP = 16; const SIDEBAR_WIDTH_STEP = 16;
function clampSidebarWidth(width: number, min: number, max: number) { function clampSidebarWidth(width: number) {
return Math.min(max, Math.max(min, width)); return Math.min(MAX_SIDEBAR_WIDTH, Math.max(MIN_SIDEBAR_WIDTH, width));
} }
function readStoredSidebarWidth(storageKey: string, fallback: number, min: number, max: number) { function readStoredSidebarWidth(storageKey: string) {
if (typeof window === "undefined") return fallback; if (typeof window === "undefined") return DEFAULT_SIDEBAR_WIDTH;
try { try {
const stored = window.localStorage.getItem(storageKey); const stored = window.localStorage.getItem(storageKey);
if (!stored) return fallback; if (!stored) return DEFAULT_SIDEBAR_WIDTH;
const parsed = Number.parseInt(stored, 10); const parsed = Number.parseInt(stored, 10);
if (!Number.isFinite(parsed)) return fallback; if (!Number.isFinite(parsed)) return DEFAULT_SIDEBAR_WIDTH;
return clampSidebarWidth(parsed, min, max); return clampSidebarWidth(parsed);
} catch { } catch {
return fallback; return DEFAULT_SIDEBAR_WIDTH;
} }
} }
function writeStoredSidebarWidth(storageKey: string, width: number, min: number, max: number) { function writeStoredSidebarWidth(storageKey: string, width: number) {
if (typeof window === "undefined") return; if (typeof window === "undefined") return;
try { try {
window.localStorage.setItem(storageKey, String(clampSidebarWidth(width, min, max))); window.localStorage.setItem(storageKey, String(clampSidebarWidth(width)));
} catch { } catch {
// Storage can be unavailable in private contexts; resizing should still work. // Storage can be unavailable in private contexts; resizing should still work.
} }
@ -49,68 +49,25 @@ type ResizableSidebarPaneProps = {
resizable?: boolean; resizable?: boolean;
storageKey?: string; storageKey?: string;
className?: string; className?: string;
/** Which side of the viewport this pane sits on. Determines handle position and drag direction. */
side?: "left" | "right";
defaultWidth?: number;
minWidth?: number;
maxWidth?: number;
/** Below this viewport width, clamp the pane to compactMaxWidth. */
compactBelowViewport?: number;
compactMaxWidth?: number;
/** Optional CSS custom property name to expose the live pane width on :root (e.g. "--properties-panel-width"). */
widthVariable?: string;
}; };
function readViewportWidth() {
if (typeof window === "undefined") return Number.POSITIVE_INFINITY;
return window.innerWidth;
}
export function ResizableSidebarPane({ export function ResizableSidebarPane({
children, children,
open, open,
resizable = false, resizable = false,
storageKey = "paperclip.sidebar.width", storageKey = "paperclip.sidebar.width",
className, className,
side = "left",
defaultWidth = DEFAULT_SIDEBAR_WIDTH,
minWidth = MIN_SIDEBAR_WIDTH,
maxWidth = MAX_SIDEBAR_WIDTH,
compactBelowViewport,
compactMaxWidth,
widthVariable,
}: ResizableSidebarPaneProps) { }: ResizableSidebarPaneProps) {
const [viewportWidth, setViewportWidth] = useState(readViewportWidth); const [width, setWidth] = useState(() => readStoredSidebarWidth(storageKey));
const compactModeActive =
compactBelowViewport !== undefined
&& compactMaxWidth !== undefined
&& viewportWidth < compactBelowViewport;
const effectiveMaxWidth =
compactModeActive
? Math.max(minWidth, Math.min(maxWidth, compactMaxWidth))
: maxWidth;
const canResizeAtCurrentViewport = effectiveMaxWidth > minWidth;
const fallbackWidth = clampSidebarWidth(defaultWidth, minWidth, effectiveMaxWidth);
const [width, setWidth] = useState(() =>
readStoredSidebarWidth(storageKey, fallbackWidth, minWidth, effectiveMaxWidth),
);
const [isResizing, setIsResizing] = useState(false); const [isResizing, setIsResizing] = useState(false);
const widthRef = useRef(width); const widthRef = useRef(width);
const dragState = useRef<{ startX: number; startWidth: number } | null>(null); const dragState = useRef<{ startX: number; startWidth: number } | null>(null);
useEffect(() => { useEffect(() => {
if (typeof window === "undefined") return; const storedWidth = readStoredSidebarWidth(storageKey);
const handleResize = () => setViewportWidth(window.innerWidth);
window.addEventListener("resize", handleResize);
return () => window.removeEventListener("resize", handleResize);
}, []);
useEffect(() => {
const storedWidth = readStoredSidebarWidth(storageKey, fallbackWidth, minWidth, effectiveMaxWidth);
widthRef.current = storedWidth; widthRef.current = storedWidth;
setWidth(storedWidth); setWidth(storedWidth);
}, [storageKey, fallbackWidth, minWidth, effectiveMaxWidth]); }, [storageKey]);
const visibleWidth = open ? width : 0; const visibleWidth = open ? width : 0;
const paneStyle = useMemo( const paneStyle = useMemo(
@ -118,25 +75,14 @@ export function ResizableSidebarPane({
[visibleWidth], [visibleWidth],
); );
useEffect(() => {
if (!widthVariable || typeof document === "undefined") return;
const root = document.documentElement;
root.style.setProperty(widthVariable, `${visibleWidth}px`);
return () => {
root.style.removeProperty(widthVariable);
};
}, [widthVariable, visibleWidth]);
const commitWidth = useCallback( const commitWidth = useCallback(
(nextWidth: number) => { (nextWidth: number) => {
const clamped = clampSidebarWidth(nextWidth, minWidth, effectiveMaxWidth); const clamped = clampSidebarWidth(nextWidth);
widthRef.current = clamped; widthRef.current = clamped;
setWidth(clamped); setWidth(clamped);
if (!compactModeActive) { writeStoredSidebarWidth(storageKey, clamped);
writeStoredSidebarWidth(storageKey, clamped, minWidth, maxWidth);
}
}, },
[storageKey, minWidth, maxWidth, effectiveMaxWidth, compactModeActive], [storageKey],
); );
const handlePointerDown = useCallback( const handlePointerDown = useCallback(
@ -155,15 +101,12 @@ export function ResizableSidebarPane({
(event: PointerEvent<HTMLDivElement>) => { (event: PointerEvent<HTMLDivElement>) => {
if (!dragState.current) return; if (!dragState.current) return;
const delta = event.clientX - dragState.current.startX; const nextWidth = dragState.current.startWidth + event.clientX - dragState.current.startX;
// For a right-side pane the handle is on the left edge, so dragging left increases width. const clamped = clampSidebarWidth(nextWidth);
const directional = side === "right" ? -delta : delta;
const nextWidth = dragState.current.startWidth + directional;
const clamped = clampSidebarWidth(nextWidth, minWidth, effectiveMaxWidth);
widthRef.current = clamped; widthRef.current = clamped;
setWidth(clamped); setWidth(clamped);
}, },
[side, minWidth, effectiveMaxWidth], [],
); );
const endResize = useCallback(() => { const endResize = useCallback(() => {
@ -171,34 +114,28 @@ export function ResizableSidebarPane({
dragState.current = null; dragState.current = null;
setIsResizing(false); setIsResizing(false);
if (!compactModeActive) { writeStoredSidebarWidth(storageKey, widthRef.current);
writeStoredSidebarWidth(storageKey, widthRef.current, minWidth, maxWidth); }, [storageKey]);
}
}, [storageKey, minWidth, maxWidth, compactModeActive]);
const handleKeyDown = useCallback( const handleKeyDown = useCallback(
(event: KeyboardEvent<HTMLDivElement>) => { (event: KeyboardEvent<HTMLDivElement>) => {
if (!open || !resizable || !canResizeAtCurrentViewport) return; if (!open || !resizable) return;
// Match drag semantics: on a right-side pane, ArrowLeft grows the pane. if (event.key === "ArrowLeft") {
const growKey = side === "right" ? "ArrowLeft" : "ArrowRight";
const shrinkKey = side === "right" ? "ArrowRight" : "ArrowLeft";
if (event.key === growKey) {
event.preventDefault();
commitWidth(width + SIDEBAR_WIDTH_STEP);
} else if (event.key === shrinkKey) {
event.preventDefault(); event.preventDefault();
commitWidth(width - SIDEBAR_WIDTH_STEP); commitWidth(width - SIDEBAR_WIDTH_STEP);
} else if (event.key === "ArrowRight") {
event.preventDefault();
commitWidth(width + SIDEBAR_WIDTH_STEP);
} else if (event.key === "Home") { } else if (event.key === "Home") {
event.preventDefault(); event.preventDefault();
commitWidth(minWidth); commitWidth(MIN_SIDEBAR_WIDTH);
} else if (event.key === "End") { } else if (event.key === "End") {
event.preventDefault(); event.preventDefault();
commitWidth(effectiveMaxWidth); commitWidth(MAX_SIDEBAR_WIDTH);
} }
}, },
[commitWidth, open, resizable, side, width, minWidth, effectiveMaxWidth, canResizeAtCurrentViewport], [commitWidth, open, resizable, width],
); );
return ( return (
@ -211,18 +148,17 @@ export function ResizableSidebarPane({
style={paneStyle} style={paneStyle}
> >
{children} {children}
{resizable && open && canResizeAtCurrentViewport ? ( {resizable && open ? (
<div <div
role="separator" role="separator"
aria-label="Resize sidebar" aria-label="Resize sidebar"
aria-orientation="vertical" aria-orientation="vertical"
aria-valuemin={minWidth} aria-valuemin={MIN_SIDEBAR_WIDTH}
aria-valuemax={effectiveMaxWidth} aria-valuemax={MAX_SIDEBAR_WIDTH}
aria-valuenow={width} aria-valuenow={width}
tabIndex={0} tabIndex={0}
className={cn( className={cn(
"absolute inset-y-0 z-20 w-3 cursor-col-resize touch-none outline-none", "absolute inset-y-0 right-0 z-20 w-3 cursor-col-resize touch-none outline-none",
side === "right" ? "left-0" : "right-0",
"before:absolute before:inset-y-0 before:left-1/2 before:w-px before:-translate-x-1/2 before:bg-transparent before:transition-colors", "before:absolute before:inset-y-0 before:left-1/2 before:w-px before:-translate-x-1/2 before:bg-transparent before:transition-colors",
"hover:before:bg-border focus-visible:before:bg-ring", "hover:before:bg-border focus-visible:before:bg-ring",
isResizing && "before:bg-ring", isResizing && "before:bg-ring",

View file

@ -301,8 +301,6 @@ describe("RoutineHistoryTab", () => {
}); });
await flush(); await flush();
expect(container.querySelector("[data-testid='dialog']")).not.toBeNull(); expect(container.querySelector("[data-testid='dialog']")).not.toBeNull();
expect(container.textContent).not.toContain("Viewing revision 1 (read-only)");
expect(container.textContent).toContain("Restore revision 1?");
const confirmButtons = Array.from(container.querySelectorAll("button")).filter((b) => const confirmButtons = Array.from(container.querySelectorAll("button")).filter((b) =>
(b.textContent ?? "").includes("Restore as revision 3"), (b.textContent ?? "").includes("Restore as revision 3"),
); );

View file

@ -1,6 +1,6 @@
import { useMemo, useState } from "react"; import { useEffect, useMemo, useState } from "react";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query"; import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { History as HistoryIcon, RotateCcw } from "lucide-react"; import { History as HistoryIcon, RotateCcw, Search } from "lucide-react";
import type { import type {
Routine, Routine,
RoutineRevision, RoutineRevision,
@ -13,6 +13,7 @@ import {
} from "../api/routines"; } from "../api/routines";
import { ApiError } from "../api/client"; import { ApiError } from "../api/client";
import { queryKeys } from "../lib/queryKeys"; import { queryKeys } from "../lib/queryKeys";
import { buildLineDiff, type DiffRow } from "../lib/line-diff";
import { relativeTime } from "../lib/utils"; import { relativeTime } from "../lib/utils";
import { useToastActions } from "../context/ToastContext"; import { useToastActions } from "../context/ToastContext";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
@ -64,11 +65,10 @@ export function RoutineHistoryTab({
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const { pushToast } = useToastActions(); const { pushToast } = useToastActions();
const [selectedRevisionId, setSelectedRevisionId] = useState<string | null>(null); const [selectedRevisionId, setSelectedRevisionId] = useState<string | null>(null);
const [snapshotOpen, setSnapshotOpen] = useState(false);
const [compareOn, setCompareOn] = useState(false);
const [highlightedRevisionId, setHighlightedRevisionId] = useState<string | null>(null); const [highlightedRevisionId, setHighlightedRevisionId] = useState<string | null>(null);
const [showOlder, setShowOlder] = useState(false); const [showOlder, setShowOlder] = useState(false);
const [confirmOpen, setConfirmOpen] = useState(false); const [confirmOpen, setConfirmOpen] = useState(false);
const [diffOpen, setDiffOpen] = useState(false);
const [restoreSummary, setRestoreSummary] = useState(""); const [restoreSummary, setRestoreSummary] = useState("");
const revisionsQuery = useQuery({ const revisionsQuery = useQuery({
@ -86,6 +86,12 @@ export function RoutineHistoryTab({
[sortedRevisions, routine.latestRevisionId], [sortedRevisions, routine.latestRevisionId],
); );
useEffect(() => {
if (selectedRevisionId === null && currentRevision) {
setSelectedRevisionId(currentRevision.id);
}
}, [currentRevision, selectedRevisionId]);
const selectedRevision = useMemo( const selectedRevision = useMemo(
() => sortedRevisions.find((r) => r.id === selectedRevisionId) ?? null, () => sortedRevisions.find((r) => r.id === selectedRevisionId) ?? null,
[sortedRevisions, selectedRevisionId], [sortedRevisions, selectedRevisionId],
@ -114,8 +120,6 @@ export function RoutineHistoryTab({
onRestoreSecretMaterials(data); onRestoreSecretMaterials(data);
onRestored?.(data); onRestored?.(data);
setConfirmOpen(false); setConfirmOpen(false);
setSnapshotOpen(false);
setCompareOn(false);
setRestoreSummary(""); setRestoreSummary("");
setSelectedRevisionId(data.revision.id); setSelectedRevisionId(data.revision.id);
setHighlightedRevisionId(data.revision.id); setHighlightedRevisionId(data.revision.id);
@ -146,15 +150,15 @@ export function RoutineHistoryTab({
const handleSelectRevision = (revisionId: string) => { const handleSelectRevision = (revisionId: string) => {
if (isEditDirty) return; if (isEditDirty) return;
setSelectedRevisionId(revisionId); setSelectedRevisionId(revisionId);
setCompareOn(false); };
setSnapshotOpen(true);
const handleReturnToCurrent = () => {
if (currentRevision) setSelectedRevisionId(currentRevision.id);
}; };
const openRestoreConfirm = () => { const openRestoreConfirm = () => {
if (!selectedRevision || !isHistoricalSelected) return; if (!selectedRevision || !isHistoricalSelected) return;
setRestoreSummary(""); setRestoreSummary("");
setSnapshotOpen(false);
setCompareOn(false);
setConfirmOpen(true); setConfirmOpen(true);
}; };
@ -168,7 +172,7 @@ export function RoutineHistoryTab({
if (revisionsQuery.isLoading) { if (revisionsQuery.isLoading) {
return ( return (
<div className="grid gap-5"> <div className="grid gap-5 md:grid-cols-[300px_minmax(0,1fr)]">
<div className="space-y-2"> <div className="space-y-2">
{Array.from({ length: 5 }).map((_, idx) => ( {Array.from({ length: 5 }).map((_, idx) => (
<Skeleton key={idx} className="h-10 w-full" /> <Skeleton key={idx} className="h-10 w-full" />
@ -200,55 +204,64 @@ export function RoutineHistoryTab({
const onlyBootstrapRevision = revisions.length <= 1; const onlyBootstrapRevision = revisions.length <= 1;
return ( return (
<div className="grid gap-5"> <div className="grid gap-5 md:grid-cols-[300px_minmax(0,1fr)]">
{isEditDirty && ( <RevisionList
<ConflictBanner revisions={visibleRevisions}
dirtyFields={dirtyFields} latestRevisionId={routine.latestRevisionId}
onDiscard={onDiscardEdits} selectedRevisionId={selectedRevisionId}
onSave={onSaveEdits} highlightedRevisionId={highlightedRevisionId}
/> isEditDirty={isEditDirty}
)} totalRevisions={sortedRevisions.length}
{!isEditDirty && onlyBootstrapRevision ? ( onSelect={handleSelectRevision}
<div className="space-y-2"> onShowOlder={() => setShowOlder(true)}
<EmptyState icon={HistoryIcon} message="No edits yet" /> showOlder={showOlder}
<p className="text-center text-xs text-muted-foreground"> />
Revision 1 is the only history this routine has. Saving an edit creates the first <div className="space-y-4 min-w-0">
additional revision. {isEditDirty && (
</p> <ConflictBanner
</div> dirtyFields={dirtyFields}
) : ( onDiscard={onDiscardEdits}
<RevisionList onSave={onSaveEdits}
revisions={visibleRevisions} />
latestRevisionId={routine.latestRevisionId} )}
selectedRevisionId={selectedRevisionId} {!isEditDirty && onlyBootstrapRevision ? (
highlightedRevisionId={highlightedRevisionId} <div className="space-y-2">
isEditDirty={isEditDirty} <EmptyState
totalRevisions={sortedRevisions.length} icon={HistoryIcon}
onSelect={handleSelectRevision} message="No edits yet"
onShowOlder={() => setShowOlder(true)} />
showOlder={showOlder} <p className="text-center text-xs text-muted-foreground">
/> Revision 1 is the only history this routine has. Saving an edit creates the first
)} additional revision.
</p>
{selectedRevision && ( </div>
<RevisionSnapshotDialog ) : (
open={snapshotOpen} selectedRevision && (
onOpenChange={(next) => { <>
setSnapshotOpen(next); {isHistoricalSelected && currentRevision && (
if (!next) setCompareOn(false); <HistoricalPreviewBanner
}} revisionNumber={selectedRevision.revisionNumber}
revision={selectedRevision} nextRevisionNumber={currentRevision.revisionNumber + 1}
currentRevision={currentRevision} onReturn={handleReturnToCurrent}
isHistorical={isHistoricalSelected} onRestore={openRestoreConfirm}
compareOn={compareOn} pending={restoreMutation.isPending}
onCompareToggle={setCompareOn} />
agents={agents} )}
projects={projects} <RevisionPreview
onRestore={openRestoreConfirm} revision={selectedRevision}
restorePending={restoreMutation.isPending} currentRevision={currentRevision}
highlighted={highlightedRevisionId === selectedRevision.id} isHistorical={isHistoricalSelected}
/> agents={agents}
)} projects={projects}
onCompare={() => setDiffOpen(true)}
onRestore={openRestoreConfirm}
restorePending={restoreMutation.isPending}
highlighted={highlightedRevisionId === selectedRevision.id}
/>
</>
)
)}
</div>
{selectedRevision && currentRevision && ( {selectedRevision && currentRevision && (
<RestoreConfirmDialog <RestoreConfirmDialog
@ -266,149 +279,67 @@ export function RoutineHistoryTab({
)} )}
/> />
)} )}
{currentRevision && selectedRevision && (
<RoutineRevisionDiffModal
open={diffOpen}
onOpenChange={setDiffOpen}
revisions={sortedRevisions}
initialOldRevisionId={selectedRevision.id}
initialNewRevisionId={currentRevision.id}
agents={agents}
projects={projects}
onRestore={(rev) => {
setSelectedRevisionId(rev.id);
setDiffOpen(false);
setRestoreSummary("");
setConfirmOpen(true);
}}
/>
)}
</div> </div>
); );
} }
function RevisionSnapshotDialog({ function HistoricalPreviewBanner({
open, revisionNumber,
onOpenChange, nextRevisionNumber,
revision, onReturn,
currentRevision,
isHistorical,
compareOn,
onCompareToggle,
agents,
projects,
onRestore, onRestore,
restorePending, pending,
highlighted,
}: { }: {
open: boolean; revisionNumber: number;
onOpenChange: (open: boolean) => void; nextRevisionNumber: number;
revision: RoutineRevision; onReturn: () => void;
currentRevision: RoutineRevision | null;
isHistorical: boolean;
compareOn: boolean;
onCompareToggle: (next: boolean) => void;
agents: AgentLookup;
projects: ProjectLookup;
onRestore: () => void; onRestore: () => void;
restorePending: boolean; pending: boolean;
highlighted: boolean;
}) { }) {
const showCompare = compareOn && !!currentRevision && isHistorical;
return ( return (
<Dialog open={open} onOpenChange={onOpenChange}> <div className="rounded-md border border-amber-500/30 bg-amber-500/5 px-4 py-3">
<DialogContent <div className="flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
className={`${ <div className="space-y-1">
showCompare ? "!max-w-[95%]" : "!max-w-[90%]" <p className="text-sm font-medium text-amber-200">
} w-full max-h-[85vh] overflow-hidden flex flex-col`} Viewing revision {revisionNumber} (read-only)
> </p>
<DialogHeader> <p className="text-xs text-muted-foreground">
<div className="flex flex-wrap items-center justify-between gap-3 pr-8"> Restoring this revision creates a new revision {nextRevisionNumber} with the same content.
<DialogTitle> History stays append-only.
{isHistorical </p>
? `Viewing revision ${revision.revisionNumber} (read-only)`
: `Revision ${revision.revisionNumber} (current)`}
</DialogTitle>
{isHistorical && currentRevision && (
<Button
variant="outline"
size="sm"
onClick={() => onCompareToggle(!compareOn)}
>
{compareOn ? "Hide current" : "Compare with current"}
</Button>
)}
</div>
{isHistorical && currentRevision && (
<DialogDescription>
Restoring this revision creates a new revision {currentRevision.revisionNumber + 1}{" "}
with the same content. History stays append-only.
</DialogDescription>
)}
</DialogHeader>
<div className="overflow-auto flex-1">
{showCompare && currentRevision ? (
<div className="grid grid-cols-1 md:grid-cols-2 gap-4">
<div className="space-y-3 min-w-0">
<ColumnLabel
tone="amber"
title={`rev ${revision.revisionNumber} (selected)`}
/>
<RevisionPreview
revision={revision}
currentRevision={currentRevision}
agents={agents}
projects={projects}
highlighted={highlighted}
/>
</div>
<div className="space-y-3 min-w-0">
<ColumnLabel
tone="emerald"
title={`rev ${currentRevision.revisionNumber} (current)`}
/>
<RevisionPreview
revision={currentRevision}
currentRevision={revision}
agents={agents}
projects={projects}
highlighted={false}
/>
</div>
</div>
) : (
<RevisionPreview
revision={revision}
currentRevision={currentRevision}
agents={agents}
projects={projects}
highlighted={highlighted}
/>
)}
</div> </div>
<DialogFooter className="justify-between sm:justify-between"> <div className="flex flex-wrap items-center gap-2">
<Button variant="outline" onClick={() => onOpenChange(false)} disabled={restorePending}> <Button variant="outline" size="sm" onClick={onReturn} disabled={pending}>
Close Return to current
</Button> </Button>
{isHistorical && ( <Button size="sm" onClick={onRestore} disabled={pending}>
<Button onClick={onRestore} disabled={restorePending}> <RotateCcw className="mr-1.5 h-3.5 w-3.5" />
<RotateCcw className="mr-1.5 h-3.5 w-3.5" /> Restore as new revision
Restore as new revision </Button>
</Button> </div>
)} </div>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
function DiffPill({ kind }: { kind: "differs" | "only-here" }) {
const label = kind === "differs" ? "differs" : "only here";
return (
<span className="ml-1 rounded-full border border-amber-400 bg-amber-300 px-1.5 text-[10px] font-medium uppercase tracking-[0.12em] text-amber-950">
{label}
</span>
);
}
function ColumnLabel({ tone, title }: { tone: "amber" | "emerald"; title: string }) {
const cls =
tone === "amber"
? "border-amber-400 bg-amber-300 text-amber-950"
: "border-emerald-400 bg-emerald-300 text-emerald-950";
return (
<div
className={`rounded-md border px-3 py-1.5 text-[11px] font-semibold uppercase tracking-[0.16em] ${cls}`}
>
{title}
</div> </div>
); );
} }
function ConflictBanner({ function ConflictBanner({
dirtyFields, dirtyFields,
onDiscard, onDiscard,
@ -424,7 +355,7 @@ function ConflictBanner({
const fieldsText = formatDirtyFieldList(labels); const fieldsText = formatDirtyFieldList(labels);
return ( return (
<div className="rounded-md border border-amber-500/30 bg-amber-500/5 px-4 py-3"> <div className="rounded-md border border-amber-500/30 bg-amber-500/5 px-4 py-3">
<div className="flex flex-col gap-3"> <div className="flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
<div className="space-y-1"> <div className="space-y-1">
<p className="text-sm font-medium text-amber-200">Unsaved routine edits</p> <p className="text-sm font-medium text-amber-200">Unsaved routine edits</p>
<p className="text-xs text-muted-foreground"> <p className="text-xs text-muted-foreground">
@ -541,30 +472,31 @@ function RevisionList({
function RevisionPreview({ function RevisionPreview({
revision, revision,
currentRevision, currentRevision,
isHistorical,
agents, agents,
projects, projects,
onCompare,
onRestore,
restorePending,
highlighted, highlighted,
}: { }: {
revision: RoutineRevision; revision: RoutineRevision;
currentRevision: RoutineRevision | null; currentRevision: RoutineRevision | null;
isHistorical: boolean;
agents: AgentLookup; agents: AgentLookup;
projects: ProjectLookup; projects: ProjectLookup;
onCompare: () => void;
onRestore: () => void;
restorePending: boolean;
highlighted: boolean; highlighted: boolean;
}) { }) {
const snapshot = revision.snapshot.routine; const snapshot = revision.snapshot.routine;
const triggers = revision.snapshot.triggers; const triggers = revision.snapshot.triggers;
const currentSnapshot = currentRevision?.snapshot.routine ?? null; const currentSnapshot = currentRevision?.snapshot.routine ?? null;
const otherTriggers = currentRevision?.snapshot.triggers ?? []; const restoreLabel = isHistorical ? "Restore this revision" : "Restore this revision";
const otherTriggerById = new Map(otherTriggers.map((t) => [t.id, t]));
const otherVariableByName = new Map(
(currentSnapshot?.variables ?? []).map((v) => [v.name, v]),
);
const cardWrapper = `rounded-md border transition-colors duration-1000 ${ const cardWrapper = `rounded-md border transition-colors duration-1000 ${
highlighted ? "border-emerald-500/40 bg-emerald-500/10" : "border-border" highlighted ? "border-emerald-500/40 bg-emerald-500/10" : "border-border"
}`; }`;
const descriptionDiffers =
!!currentSnapshot &&
(currentSnapshot.description ?? "") !== (snapshot.description ?? "");
const fieldRows: Array<{ key: string; label: string; value: string; differs: boolean }> = [ const fieldRows: Array<{ key: string; label: string; value: string; differs: boolean }> = [
{ {
@ -611,29 +543,33 @@ function RevisionPreview({
}, },
]; ];
const triggerStatus = (trigger: RoutineRevisionSnapshotTriggerV1): "same" | "differs" | "only-here" => {
if (!currentRevision) return "same";
const other = otherTriggerById.get(trigger.id);
if (!other) return "only-here";
return JSON.stringify(other) === JSON.stringify(trigger) ? "same" : "differs";
};
const variableStatus = (variable: RoutineVariable): "same" | "differs" | "only-here" => {
if (!currentRevision) return "same";
const other = otherVariableByName.get(variable.name);
if (!other) return "only-here";
return JSON.stringify(other) === JSON.stringify(variable) ? "same" : "differs";
};
return ( return (
<div className="space-y-4"> <div className="space-y-4">
<header className={`${cardWrapper} p-4 space-y-2`}> <header className={`${cardWrapper} p-4 space-y-2`}>
<div className="space-y-1 min-w-0"> <div className="flex flex-wrap items-start justify-between gap-3">
<p className="text-sm font-medium">rev {revision.revisionNumber}</p> <div className="space-y-1 min-w-0">
<p className="text-xs text-muted-foreground truncate"> <p className="text-sm font-medium">rev {revision.revisionNumber}</p>
Saved {relativeTime(revision.createdAt)} by {getActorLabel(revision)} <p className="text-xs text-muted-foreground truncate">
{revision.changeSummary ? ` · ${revision.changeSummary}` : ""} Saved {relativeTime(revision.createdAt)} by {getActorLabel(revision)}
</p> {revision.changeSummary ? ` · ${revision.changeSummary}` : ""}
</p>
</div>
<div className="flex flex-wrap items-center gap-2">
<Button variant="outline" size="sm" onClick={onCompare}>
<Search className="mr-1.5 h-3.5 w-3.5" />
Compare with current
</Button>
<Button
size="sm"
onClick={onRestore}
disabled={!isHistorical || restorePending}
aria-label={restoreLabel}
className={!isHistorical ? "text-muted-foreground/60" : undefined}
>
<RotateCcw className="mr-1.5 h-3.5 w-3.5" />
{restoreLabel}
</Button>
</div>
</div> </div>
</header> </header>
@ -641,13 +577,17 @@ function RevisionPreview({
<p className="pb-2 text-xs font-medium uppercase tracking-[0.18em] text-muted-foreground"> <p className="pb-2 text-xs font-medium uppercase tracking-[0.18em] text-muted-foreground">
Structured fields Structured fields
</p> </p>
<div className="grid gap-3 divide-y divide-border"> <div className="grid gap-3 md:grid-cols-2 divide-y md:divide-y-0 divide-border">
{fieldRows.map((row) => ( {fieldRows.map((row) => (
<div key={row.key} className="space-y-1 p-2"> <div key={row.key} className="space-y-1 p-2">
<p className="text-[11px] uppercase tracking-wide text-muted-foreground">{row.label}</p> <p className="text-[11px] uppercase tracking-wide text-muted-foreground">{row.label}</p>
<p className="text-sm"> <p className="text-sm">
{row.value || <span className="text-muted-foreground"></span>} {row.value || <span className="text-muted-foreground"></span>}
{row.differs && <DiffPill kind="differs" />} {row.differs && (
<span className="ml-2 rounded-full border border-amber-500/40 bg-amber-500/10 px-1.5 text-[10px] uppercase tracking-[0.12em] text-amber-200">
differs from current
</span>
)}
</p> </p>
</div> </div>
))} ))}
@ -655,12 +595,9 @@ function RevisionPreview({
</div> </div>
<div className={`${cardWrapper} p-3 space-y-2`}> <div className={`${cardWrapper} p-3 space-y-2`}>
<div className="flex items-center gap-2"> <p className="text-xs font-medium uppercase tracking-[0.18em] text-muted-foreground">
<p className="text-xs font-medium uppercase tracking-[0.18em] text-muted-foreground"> Description
Description </p>
</p>
{descriptionDiffers && <DiffPill kind="differs" />}
</div>
<div className="rounded-md bg-background/40 p-3 text-sm leading-7"> <div className="rounded-md bg-background/40 p-3 text-sm leading-7">
{snapshot.description ? ( {snapshot.description ? (
<MarkdownBody>{snapshot.description}</MarkdownBody> <MarkdownBody>{snapshot.description}</MarkdownBody>
@ -678,26 +615,22 @@ function RevisionPreview({
<p className="text-sm text-muted-foreground">No triggers in this revision.</p> <p className="text-sm text-muted-foreground">No triggers in this revision.</p>
) : ( ) : (
<ul className="divide-y divide-border"> <ul className="divide-y divide-border">
{triggers.map((trigger) => { {triggers.map((trigger) => (
const status = triggerStatus(trigger); <li key={trigger.id} className="py-2 flex flex-wrap items-center gap-2 text-sm">
return ( <span className="rounded-full border border-border px-2 py-0.5 text-[10px] uppercase tracking-[0.12em] text-muted-foreground">
<li key={trigger.id} className="py-2 flex flex-wrap items-center gap-2 text-sm"> {trigger.kind}
<span className="rounded-full border border-border px-2 py-0.5 text-[10px] uppercase tracking-[0.12em] text-muted-foreground"> </span>
{trigger.kind} <span className="font-medium">{trigger.label ?? trigger.kind}</span>
</span> <span className="text-xs text-muted-foreground">
<span className="font-medium">{trigger.label ?? trigger.kind}</span> {summarizeTriggerSnapshot(trigger)}
<span className="text-xs text-muted-foreground"> </span>
{summarizeTriggerSnapshot(trigger)} <span
</span> className={`ml-auto text-xs ${trigger.enabled ? "text-emerald-400" : "text-muted-foreground"}`}
{status !== "same" && <DiffPill kind={status} />} >
<span {trigger.enabled ? "enabled" : "disabled"}
className={`ml-auto text-xs ${trigger.enabled ? "text-emerald-400" : "text-muted-foreground"}`} </span>
> </li>
{trigger.enabled ? "enabled" : "disabled"} ))}
</span>
</li>
);
})}
</ul> </ul>
)} )}
<p className="text-xs text-muted-foreground"> <p className="text-xs text-muted-foreground">
@ -712,18 +645,14 @@ function RevisionPreview({
Variables ({snapshot.variables.length}) Variables ({snapshot.variables.length})
</p> </p>
<ul className="divide-y divide-border"> <ul className="divide-y divide-border">
{snapshot.variables.map((variable) => { {snapshot.variables.map((variable) => (
const status = variableStatus(variable); <li key={variable.name} className="py-2 flex items-center justify-between text-sm">
return ( <span className="font-mono text-xs">{variable.name}</span>
<li key={variable.name} className="py-2 flex flex-wrap items-center gap-2 text-sm"> <span className="text-xs text-muted-foreground">
<span className="font-mono text-xs">{variable.name}</span> default: {formatVariableDefault(variable)}
<span className="text-xs text-muted-foreground"> </span>
default: {formatVariableDefault(variable)} </li>
</span> ))}
{status !== "same" && <DiffPill kind={status} />}
</li>
);
})}
</ul> </ul>
</div> </div>
)} )}
@ -806,6 +735,213 @@ function RestoreConfirmDialog({
); );
} }
function RoutineRevisionDiffModal({
open,
onOpenChange,
revisions,
initialOldRevisionId,
initialNewRevisionId,
agents,
projects,
onRestore,
}: {
open: boolean;
onOpenChange: (open: boolean) => void;
revisions: RoutineRevision[];
initialOldRevisionId: string;
initialNewRevisionId: string;
agents: AgentLookup;
projects: ProjectLookup;
onRestore: (revision: RoutineRevision) => void;
}) {
const [leftId, setLeftId] = useState<string>(initialOldRevisionId);
const [rightId, setRightId] = useState<string>(initialNewRevisionId);
useEffect(() => {
if (open) {
setLeftId(initialOldRevisionId);
setRightId(initialNewRevisionId);
}
}, [open, initialOldRevisionId, initialNewRevisionId]);
const left = revisions.find((r) => r.id === leftId) ?? null;
const right = revisions.find((r) => r.id === rightId) ?? null;
const fieldChanges = useMemo(
() => (left && right ? computeFieldChanges(left, right, agents, projects) : []),
[left, right, agents, projects],
);
const descriptionDiff = useMemo<DiffRow[]>(
() => (left && right
? buildLineDiff(left.snapshot.routine.description ?? "", right.snapshot.routine.description ?? "")
: []),
[left, right],
);
const newest = revisions[0] ?? null;
const leftIsHistorical = !!left && !!newest && left.id !== newest.id;
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="!max-w-[90%] w-full max-h-[85vh] overflow-hidden flex flex-col">
<DialogHeader>
<DialogTitle>Compare routine revisions</DialogTitle>
</DialogHeader>
<div className="flex flex-wrap items-center gap-3">
<RevisionPicker
label="Old"
value={leftId}
onChange={setLeftId}
revisions={revisions}
tone="red"
/>
<RevisionPicker
label="New"
value={rightId}
onChange={setRightId}
revisions={revisions}
tone="green"
/>
</div>
<div className="overflow-auto flex-1 space-y-4">
<section className="space-y-2">
<p className="text-xs font-medium uppercase tracking-[0.18em] text-muted-foreground">
Field changes
</p>
{fieldChanges.length === 0 ? (
<p className="text-sm text-muted-foreground">No structural field changes.</p>
) : (
<table className="w-full text-sm border border-border rounded-md overflow-hidden">
<thead>
<tr className="text-xs uppercase tracking-wide bg-muted/30 text-muted-foreground">
<th className="px-3 py-2 text-left">Field</th>
<th className="px-3 py-2 text-left">Old value</th>
<th className="px-3 py-2 text-left">New value</th>
</tr>
</thead>
<tbody>
{fieldChanges.map((change) => (
<tr key={change.field} className="border-t border-border/60">
<td className="px-3 py-2 align-top text-xs font-medium">{change.field}</td>
<td className="px-3 py-2 align-top text-xs text-red-300">
{change.oldValue ?? "—"}
</td>
<td className="px-3 py-2 align-top text-xs text-emerald-300">
{change.newValue ?? "—"}
</td>
</tr>
))}
</tbody>
</table>
)}
</section>
<section className="space-y-2">
<p className="text-xs font-medium uppercase tracking-[0.18em] text-muted-foreground">
Description diff
</p>
<DiffTable rows={descriptionDiff} />
</section>
</div>
<DialogFooter className="justify-between sm:justify-between">
<Button variant="outline" onClick={() => onOpenChange(false)}>
Close
</Button>
{leftIsHistorical && left && (
<Button onClick={() => onRestore(left)}>
<RotateCcw className="mr-1.5 h-3.5 w-3.5" />
Restore rev {left.revisionNumber} as new revision
</Button>
)}
</DialogFooter>
</DialogContent>
</Dialog>
);
}
function RevisionPicker({
label,
value,
onChange,
revisions,
tone,
}: {
label: string;
value: string;
onChange: (id: string) => void;
revisions: RoutineRevision[];
tone: "red" | "green";
}) {
const toneClass = tone === "red"
? "border-red-500/30 bg-red-500/10 text-red-300"
: "border-green-500/30 bg-green-500/10 text-green-300";
return (
<div className="flex items-center gap-2">
<span
className={`rounded-full border px-2 py-0.5 text-[10px] font-medium uppercase tracking-wider ${toneClass}`}
>
{label}
</span>
<select
value={value}
onChange={(event) => onChange(event.target.value)}
className="h-8 min-w-[12rem] rounded-md border border-border/60 bg-background px-2 text-xs"
>
{revisions.map((revision) => (
<option key={revision.id} value={revision.id}>
rev {revision.revisionNumber} {relativeTime(revision.createdAt)}
{revision.changeSummary ? `${revision.changeSummary}` : ""}
</option>
))}
</select>
</div>
);
}
function DiffTable({ rows }: { rows: DiffRow[] }) {
if (rows.length === 0) {
return <p className="text-sm text-muted-foreground">No description on either revision.</p>;
}
if (rows.every((row) => row.kind === "context")) {
return <p className="text-sm text-muted-foreground">Descriptions are identical.</p>;
}
const lineClassesByKind: Record<DiffRow["kind"], string> = {
context: "bg-transparent",
removed: "bg-red-500/10 text-red-100",
added: "bg-green-500/10 text-green-100",
};
const markerByKind: Record<DiffRow["kind"], string> = {
context: " ",
removed: "-",
added: "+",
};
return (
<div className="rounded-md border border-border text-xs font-mono leading-6 overflow-hidden">
<div className="grid grid-cols-[56px_56px_24px_minmax(0,1fr)] border-b border-border/60 bg-muted/30 px-3 py-2 text-[11px] uppercase tracking-wide text-muted-foreground">
<span>Old</span>
<span>New</span>
<span />
<span>Content</span>
</div>
{rows.map((row, index) => (
<div
key={`${row.kind}-${index}-${row.oldLineNumber ?? "x"}-${row.newLineNumber ?? "x"}`}
className={`grid grid-cols-[56px_56px_24px_minmax(0,1fr)] gap-0 border-b border-border/30 px-3 ${lineClassesByKind[row.kind]}`}
>
<span className="select-none border-r border-border/30 pr-3 text-right text-muted-foreground">
{row.oldLineNumber ?? ""}
</span>
<span className="select-none border-r border-border/30 px-3 text-right text-muted-foreground">
{row.newLineNumber ?? ""}
</span>
<span className="select-none px-3 text-center text-muted-foreground">
{markerByKind[row.kind]}
</span>
<pre className="overflow-x-auto whitespace-pre-wrap break-words px-3 py-0 text-inherit">
{row.text.length > 0 ? row.text : " "}
</pre>
</div>
))}
</div>
);
}
function getActorLabel(revision: RoutineRevision): string { function getActorLabel(revision: RoutineRevision): string {
if (revision.createdByUserId) return "board"; if (revision.createdByUserId) return "board";
@ -856,6 +992,104 @@ function collectWebhookTriggerDifferences(
.map((trigger) => trigger.label ?? "webhook"); .map((trigger) => trigger.label ?? "webhook");
} }
function describeSnapshotField(value: unknown): string {
if (value == null) return "—";
if (typeof value === "string") return value;
return JSON.stringify(value);
}
function computeFieldChanges(
left: RoutineRevision,
right: RoutineRevision,
agents: AgentLookup,
projects: ProjectLookup,
): Array<{ field: string; oldValue: string | null; newValue: string | null }> {
const oldRoutine = left.snapshot.routine;
const newRoutine = right.snapshot.routine;
const changes: Array<{ field: string; oldValue: string | null; newValue: string | null }> = [];
const compareScalar = (
_field: string,
label: string,
oldVal: unknown,
newVal: unknown,
transform: (value: unknown) => string = describeSnapshotField,
) => {
if (JSON.stringify(oldVal) !== JSON.stringify(newVal)) {
changes.push({ field: label, oldValue: transform(oldVal), newValue: transform(newVal) });
}
};
compareScalar("title", "Title", oldRoutine.title, newRoutine.title);
compareScalar("priority", "Priority", oldRoutine.priority, newRoutine.priority);
compareScalar(
"assigneeAgentId",
"Default agent",
resolveAgentName(oldRoutine.assigneeAgentId, agents),
resolveAgentName(newRoutine.assigneeAgentId, agents),
);
compareScalar(
"projectId",
"Project",
resolveProjectName(oldRoutine.projectId, projects),
resolveProjectName(newRoutine.projectId, projects),
);
compareScalar("concurrencyPolicy", "Concurrency", oldRoutine.concurrencyPolicy, newRoutine.concurrencyPolicy);
compareScalar("catchUpPolicy", "Catch-up", oldRoutine.catchUpPolicy, newRoutine.catchUpPolicy);
compareScalar("status", "Status", oldRoutine.status, newRoutine.status);
if (JSON.stringify(oldRoutine.variables) !== JSON.stringify(newRoutine.variables)) {
changes.push({
field: "Variables",
oldValue: summarizeVariables(oldRoutine.variables),
newValue: summarizeVariables(newRoutine.variables),
});
}
compareTriggers(left.snapshot.triggers, right.snapshot.triggers, changes);
return changes;
}
function summarizeVariables(variables: RoutineVariable[]): string {
if (variables.length === 0) return "(none)";
return variables
.map((variable) => `${variable.name}=${formatVariableDefault(variable)}`)
.join(", ");
}
function compareTriggers(
oldTriggers: RoutineRevisionSnapshotTriggerV1[],
newTriggers: RoutineRevisionSnapshotTriggerV1[],
changes: Array<{ field: string; oldValue: string | null; newValue: string | null }>,
) {
const byId = new Map<string, { old?: RoutineRevisionSnapshotTriggerV1; next?: RoutineRevisionSnapshotTriggerV1 }>();
for (const trigger of oldTriggers) byId.set(trigger.id, { old: trigger });
for (const trigger of newTriggers) {
const existing = byId.get(trigger.id) ?? {};
byId.set(trigger.id, { ...existing, next: trigger });
}
for (const [, pair] of byId) {
if (pair.old && !pair.next) {
changes.push({
field: `Trigger removed (${pair.old.label ?? pair.old.kind})`,
oldValue: summarizeTriggerSnapshot(pair.old),
newValue: null,
});
} else if (!pair.old && pair.next) {
changes.push({
field: `Trigger added (${pair.next.label ?? pair.next.kind})`,
oldValue: null,
newValue: summarizeTriggerSnapshot(pair.next),
});
} else if (pair.old && pair.next) {
const oldSummary = summarizeTriggerSnapshot(pair.old);
const newSummary = summarizeTriggerSnapshot(pair.next);
if (oldSummary !== newSummary || pair.old.enabled !== pair.next.enabled) {
changes.push({
field: `Trigger ${pair.next.label ?? pair.next.kind}`,
oldValue: `${oldSummary} (${pair.old.enabled ? "enabled" : "disabled"})`,
newValue: `${newSummary} (${pair.next.enabled ? "enabled" : "disabled"})`,
});
}
}
}
}
export function isUpdateConflictError(error: unknown): error is ApiError { export function isUpdateConflictError(error: unknown): error is ApiError {
return error instanceof ApiError && error.status === 409; return error instanceof ApiError && error.status === 409;

View file

@ -75,7 +75,7 @@ export function ScrollToBottom() {
onClick={scroll} onClick={scroll}
className={cn( className={cn(
"fixed bottom-[calc(1.5rem+5rem+env(safe-area-inset-bottom))] right-6 z-40 flex h-9 w-9 items-center justify-center rounded-full border border-border bg-background shadow-md hover:bg-accent transition-[background-color,right] duration-200 md:bottom-6", "fixed bottom-[calc(1.5rem+5rem+env(safe-area-inset-bottom))] right-6 z-40 flex h-9 w-9 items-center justify-center rounded-full border border-border bg-background shadow-md hover:bg-accent transition-[background-color,right] duration-200 md:bottom-6",
panelVisible && panelContent && "md:right-[calc(var(--properties-panel-width,320px)+1.5rem)]", panelVisible && panelContent && "md:right-[calc(320px+1.5rem)]",
)} )}
aria-label="Scroll to bottom" aria-label="Scroll to bottom"
> >

View file

@ -2,23 +2,10 @@ import { createContext, useCallback, useContext, useState, type ReactNode } from
const STORAGE_KEY = "paperclip:panel-visible"; const STORAGE_KEY = "paperclip:panel-visible";
export interface PanelLayoutOptions {
/** localStorage key under which the user's preferred panel width is saved. */
storageKey?: string;
/** Width applied when no stored value exists. */
defaultWidth?: number;
minWidth?: number;
maxWidth?: number;
/** Below this viewport width, clamp the panel to compactMaxWidth. */
compactBelowViewport?: number;
compactMaxWidth?: number;
}
interface PanelContextValue { interface PanelContextValue {
panelContent: ReactNode | null; panelContent: ReactNode | null;
panelLayout: PanelLayoutOptions;
panelVisible: boolean; panelVisible: boolean;
openPanel: (content: ReactNode, layout?: PanelLayoutOptions) => void; openPanel: (content: ReactNode) => void;
closePanel: () => void; closePanel: () => void;
setPanelVisible: (visible: boolean) => void; setPanelVisible: (visible: boolean) => void;
togglePanelVisible: () => void; togglePanelVisible: () => void;
@ -43,21 +30,16 @@ function writePreference(visible: boolean) {
} }
} }
const EMPTY_LAYOUT: PanelLayoutOptions = {};
export function PanelProvider({ children }: { children: ReactNode }) { export function PanelProvider({ children }: { children: ReactNode }) {
const [panelContent, setPanelContent] = useState<ReactNode | null>(null); const [panelContent, setPanelContent] = useState<ReactNode | null>(null);
const [panelLayout, setPanelLayout] = useState<PanelLayoutOptions>(EMPTY_LAYOUT);
const [panelVisible, setPanelVisibleState] = useState(readPreference); const [panelVisible, setPanelVisibleState] = useState(readPreference);
const openPanel = useCallback((content: ReactNode, layout?: PanelLayoutOptions) => { const openPanel = useCallback((content: ReactNode) => {
setPanelContent(content); setPanelContent(content);
setPanelLayout(layout ?? EMPTY_LAYOUT);
}, []); }, []);
const closePanel = useCallback(() => { const closePanel = useCallback(() => {
setPanelContent(null); setPanelContent(null);
setPanelLayout(EMPTY_LAYOUT);
}, []); }, []);
const setPanelVisible = useCallback((visible: boolean) => { const setPanelVisible = useCallback((visible: boolean) => {
@ -75,7 +57,7 @@ export function PanelProvider({ children }: { children: ReactNode }) {
return ( return (
<PanelContext.Provider <PanelContext.Provider
value={{ panelContent, panelLayout, panelVisible, openPanel, closePanel, setPanelVisible, togglePanelVisible }} value={{ panelContent, panelVisible, openPanel, closePanel, setPanelVisible, togglePanelVisible }}
> >
{children} {children}
</PanelContext.Provider> </PanelContext.Provider>

View file

@ -591,22 +591,22 @@ export function RoutineDetail() {
const activityTabsPanel = useMemo(() => { const activityTabsPanel = useMemo(() => {
if (!routine) return null; if (!routine) return null;
return ( return (
<Tabs value={activeTab} onValueChange={setActiveTab} className="space-y-3 min-w-0"> <Tabs value={activeTab} onValueChange={setActiveTab} className="space-y-3">
<TabsList variant="line" className="w-full justify-start gap-1 overflow-x-auto"> <TabsList variant="line" className="w-full justify-start gap-1">
<TabsTrigger value="triggers" className="gap-1.5 flex-none px-2"> <TabsTrigger value="triggers" className="gap-1.5">
<Clock3 className="h-3.5 w-3.5" /> <Clock3 className="h-3.5 w-3.5" />
Triggers Triggers
</TabsTrigger> </TabsTrigger>
<TabsTrigger value="runs" className="gap-1.5 flex-none px-2"> <TabsTrigger value="runs" className="gap-1.5">
<Play className="h-3.5 w-3.5" /> <Play className="h-3.5 w-3.5" />
Runs Runs
{hasLiveRun && <span className="h-2 w-2 rounded-full bg-blue-500 animate-pulse" />} {hasLiveRun && <span className="h-2 w-2 rounded-full bg-blue-500 animate-pulse" />}
</TabsTrigger> </TabsTrigger>
<TabsTrigger value="activity" className="gap-1.5 flex-none px-2"> <TabsTrigger value="activity" className="gap-1.5">
<ActivityIcon className="h-3.5 w-3.5" /> <ActivityIcon className="h-3.5 w-3.5" />
Activity Activity
</TabsTrigger> </TabsTrigger>
<TabsTrigger value="history" className="gap-1.5 flex-none px-2"> <TabsTrigger value="history" className="gap-1.5">
<HistoryIcon className="h-3.5 w-3.5" /> <HistoryIcon className="h-3.5 w-3.5" />
History History
</TabsTrigger> </TabsTrigger>
@ -815,14 +815,7 @@ export function RoutineDetail() {
closePanel(); closePanel();
return; return;
} }
openPanel(activityTabsPanel, { openPanel(activityTabsPanel);
storageKey: "paperclip.properties.width.routines",
defaultWidth: 400,
minWidth: 320,
maxWidth: 640,
compactBelowViewport: 1024,
compactMaxWidth: 320,
});
return () => closePanel(); return () => closePanel();
}, [activityTabsPanel, closePanel, openPanel]); }, [activityTabsPanel, closePanel, openPanel]);
@ -861,7 +854,7 @@ export function RoutineDetail() {
return ( return (
<div className="max-w-2xl space-y-6"> <div className="max-w-2xl space-y-6">
{/* Header: editable title + actions */} {/* Header: editable title + actions */}
<div className="flex flex-col items-stretch gap-3 min-[1120px]:flex-row min-[1120px]:items-start min-[1120px]:gap-4"> <div className="flex items-start gap-4">
<div className="min-w-0 flex-1 space-y-2"> <div className="min-w-0 flex-1 space-y-2">
<textarea <textarea
ref={titleInputRef} ref={titleInputRef}
@ -900,7 +893,7 @@ export function RoutineDetail() {
</Badge> </Badge>
) : null} ) : null}
</div> </div>
<div className="flex w-full shrink-0 flex-wrap items-center gap-3 pt-1 min-[1120px]:w-auto min-[1120px]:flex-nowrap"> <div className="flex shrink-0 items-center gap-3 pt-1">
<RunButton <RunButton
onClick={() => { onClick={() => {
setRunVariablesOpen(true); setRunVariablesOpen(true);
@ -935,7 +928,6 @@ export function RoutineDetail() {
panelVisible ? "opacity-0 pointer-events-none w-0 overflow-hidden" : "opacity-100", panelVisible ? "opacity-0 pointer-events-none w-0 overflow-hidden" : "opacity-100",
)} )}
onClick={() => setPanelVisible(true)} onClick={() => setPanelVisible(true)}
aria-label="Show triggers, runs and activity"
title="Show triggers, runs and activity" title="Show triggers, runs and activity"
> >
<SlidersHorizontal className="h-4 w-4" /> <SlidersHorizontal className="h-4 w-4" />