From 0cb42f49eafe95c78683e385e70acdfbba4ab7a4 Mon Sep 17 00:00:00 2001 From: Dotta Date: Sun, 12 Apr 2026 21:18:57 -0500 Subject: [PATCH] Fix rebased issue detail prefetch typing --- ui/src/lib/issueDetailCache.test.ts | 15 +++------------ ui/src/pages/IssueDetail.tsx | 1 - 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/ui/src/lib/issueDetailCache.test.ts b/ui/src/lib/issueDetailCache.test.ts index a2fbe0e3..dd55ba72 100644 --- a/ui/src/lib/issueDetailCache.test.ts +++ b/ui/src/lib/issueDetailCache.test.ts @@ -84,23 +84,14 @@ describe("issueDetailCache", () => { expect(queryClient.getQueryData(queryKeys.issues.detail(issue.id))).toEqual(issue); }); - it("prefetches with the provided issue snapshot before the network result lands", async () => { + it("prefetches with the provided issue snapshot without forcing a fresh fetch", async () => { const issue = createIssue(); - let releaseFetch: (() => void) | null = null; - vi.mocked(issuesApi.get).mockImplementation( - () => - new Promise((resolve) => { - releaseFetch = () => resolve(issue); - }), - ); - const prefetchPromise = prefetchIssueDetail(queryClient, issue.identifier!, { issue }); + await prefetchIssueDetail(queryClient, issue.identifier!, { issue }); expect(getCachedIssueDetail(queryClient, issue.identifier)).toEqual(issue); expect(getCachedIssueDetail(queryClient, issue.id)).toEqual(issue); - - releaseFetch?.(); - await prefetchPromise; + expect(issuesApi.get).not.toHaveBeenCalled(); }); it("hydrates both cache aliases from a fetched issue detail response", async () => { diff --git a/ui/src/pages/IssueDetail.tsx b/ui/src/pages/IssueDetail.tsx index ceceea11..982d7ace 100644 --- a/ui/src/pages/IssueDetail.tsx +++ b/ui/src/pages/IssueDetail.tsx @@ -1651,7 +1651,6 @@ export function IssueDetail() { rememberIssueDetailLocationState( ancestor.identifier ?? ancestor.id,