ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-17 11:20:37 +09:00
Code Issues Projects Releases Packages Wiki Activity

Add issue detail shortcut for comment composer

Browse source 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
dotta 2026-04-08 09:24:32 -05:00
parent 15b0f11275
commit 1079f21ac4
6 changed files with 164 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

25
ui/src/lib/keyboardShortcuts.test.ts
View file

@ -4,7 +4,7 @@ import { describe, expect, it } from "vitest";
import {
hasBlockingShortcutDialog,
isKeyboardShortcutTextInputTarget,
resolveGoToInboxKeyAction,
resolveIssueDetailGoKeyAction,
resolveInboxQuickArchiveKeyAction,
} from "./keyboardShortcuts";
@ -114,7 +114,7 @@ describe("keyboardShortcuts helpers", () => {
it("arms go-to-inbox on a clean g press", () => {
const button = document.createElement("button");
expect(resolveGoToInboxKeyAction({
expect(resolveIssueDetailGoKeyAction({
armed: false,
defaultPrevented: false,
key: "g",
@ -129,7 +129,7 @@ describe("keyboardShortcuts helpers", () => {
it("navigates to inbox on i after g", () => {
const button = document.createElement("button");
expect(resolveGoToInboxKeyAction({
expect(resolveIssueDetailGoKeyAction({
armed: true,
defaultPrevented: false,
key: "i",
@ -138,13 +138,28 @@ describe("keyboardShortcuts helpers", () => {
altKey: false,
target: button,
hasOpenDialog: false,
})).toBe("navigate");
})).toBe("navigate_inbox");
});
it("focuses the comment composer on c after g", () => {
const button = document.createElement("button");
expect(resolveIssueDetailGoKeyAction({
armed: true,
defaultPrevented: false,
key: "c",
metaKey: false,
ctrlKey: false,
altKey: false,
target: button,
hasOpenDialog: false,
})).toBe("focus_comment");
});
it("disarms go-to-inbox instead of firing from an editor", () => {
const input = document.createElement("textarea");
expect(resolveGoToInboxKeyAction({
expect(resolveIssueDetailGoKeyAction({
armed: true,
defaultPrevented: false,
key: "i",

9
ui/src/lib/keyboardShortcuts.ts
View file

@ -11,7 +11,7 @@ export const KEYBOARD_SHORTCUT_TEXT_INPUT_SELECTOR = [
const MODIFIER_ONLY_KEYS = new Set(["Shift", "Meta", "Control", "Alt"]);
export type InboxQuickArchiveKeyAction = "ignore" | "archive" | "disarm";
export type GoToInboxKeyAction = "ignore" | "arm" | "navigate" | "disarm";
export type IssueDetailGoKeyAction = "ignore" | "arm" | "navigate_inbox" | "focus_comment" | "disarm";
export function isKeyboardShortcutTextInputTarget(target: EventTarget | null): boolean {
if (!(target instanceof HTMLElement)) return false;
@ -54,7 +54,7 @@ export function resolveInboxQuickArchiveKeyAction({
return "ignore";
}
export function resolveGoToInboxKeyAction({
export function resolveIssueDetailGoKeyAction({
armed,
defaultPrevented,
key,
@ -72,7 +72,7 @@ export function resolveGoToInboxKeyAction({
altKey: boolean;
target: EventTarget | null;
hasOpenDialog: boolean;
}): GoToInboxKeyAction {
}): IssueDetailGoKeyAction {
if (defaultPrevented) return armed ? "disarm" : "ignore";
if (metaKey || ctrlKey || altKey || isModifierOnlyKey(key)) return "ignore";
if (hasOpenDialog || isKeyboardShortcutTextInputTarget(target)) {
@ -81,7 +81,8 @@ export function resolveGoToInboxKeyAction({
const normalizedKey = key.toLowerCase();
if (!armed) return normalizedKey === "g" ? "arm" : "ignore";
if (normalizedKey === "i") return "navigate";
if (normalizedKey === "i") return "navigate_inbox";
if (normalizedKey === "c") return "focus_comment";
if (normalizedKey === "g") return "arm";
return "disarm";
}