ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-14 01:50:39 +09:00
Code Issues Projects Releases Packages Wiki Activity

fix(server): prevent identifier collision in issue creation

Browse source 
Use GREATEST(counter, MAX(issue_number)) + 1 when incrementing the
company issue counter. This self-corrects any desync between the
companies.issue_counter column and the actual max issues.issue_number,
preventing duplicate key violations on the identifier unique index.

Fixes #2705
This commit is contained in:
Matt Van Horn 2026-04-04 22:57:25 -07:00
parent 6c8569156c
commit 21a1e97a81
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
server/src/services/issues.ts
View file

@ -1183,9 +1183,19 @@ export function issueService(db: Db) {
if (executionWorkspaceId) {
await assertValidExecutionWorkspace(companyId, issueData.projectId, executionWorkspaceId, tx);
}
// Self-correcting counter: use MAX(issue_number) + 1 if the counter
// has drifted below the actual max, preventing identifier collisions.
const [maxRow] = await tx
.select({ maxNum: sql<number>`coalesce(max(${issues.issueNumber}), 0)` })
.from(issues)
.where(eq(issues.companyId, companyId));
const currentMax = maxRow?.maxNum ?? 0;
const [company] = await tx
.update(companies)
.set({ issueCounter: sql`${companies.issueCounter} + 1` })
.set({
issueCounter: sql`greatest(${companies.issueCounter}, ${currentMax}) + 1`,
})
.where(eq(companies.id, companyId))
.returning({ issueCounter: companies.issueCounter, issuePrefix: companies.issuePrefix });