mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-16 19:00:38 +09:00
Fix typing lag in long comment threads (PAPA-63) (#3163)
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The issue detail page displays comment threads with rich timeline rendering > - Long threads (100+ items) cause severe typing lag in the comment composer because every keystroke re-renders the entire timeline > - CDP tracing confirmed 110ms avg key→paint latency and 60 long tasks blocking the main thread for 3.7s total > - This pull request memoizes the timeline, stabilizes callback props, debounces editor observers, and reduces idle polling frequency > - The benefit is responsive typing (21ms avg, 5.3× faster) even on threads with 100+ timeline items ## What Changed - **CommentThread.tsx**: Memoize `TimelineList` with `useMemo` so typing state changes don't re-render 143 timeline items; extract `handleFeedbackVote` to `useCallback`; added missing deps (`pendingApprovalAction`, `onApproveApproval`, `onRejectApproval`) to useMemo array - **IssueDetail.tsx**: Extract inline callbacks (`handleCommentAdd`, `handleCommentVote`, `handleCommentImageUpload`, `handleCommentAttachImage`, `handleInterruptQueued`) to `useCallback` with `.mutateAsync` deps (not full mutation objects) for stable references; add conditional polling intervals (3s active / 30s idle) for `liveRuns`, `activeRun`, `linkedRuns`, and timeline queries - **MarkdownEditor.tsx**: Debounce `MutationObserver` and `selectionchange` handlers via `requestAnimationFrame` coalescing - **LiveRunWidget.tsx**: Accept optional `liveRunsData` and `activeRunData` props to reuse parent-fetched data instead of duplicate polling ## Verification - Navigated to [IP address]:3105/PAPA/issues/PAPA-32 (thread with 100+ items) - Typed in comment composer — lag eliminated, characters appear instantly - CDP trace test script (`test-typing-lag.mjs`) confirmed: avg 21ms key→paint (was 110ms), 5 long tasks (was 60), 0.5s blocking (was 3.7s) - Ran `pnpm test:run` locally — all tests pass ## Risks - Low risk. All changes are additive memoization and callback stabilization — no behavioral changes. Polling intervals are only reduced for idle state; active runs still poll at 3–5s. ## Model Used - Claude Opus 4.6 (`claude-opus-4-6`) via Claude Code CLI, with tool use and extended context ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
parent
642188f900
commit
3264f9c1f6
5 changed files with 372 additions and 229 deletions
|
|
@ -1,7 +1,7 @@
|
|||
import { useMemo, useState } from "react";
|
||||
import { Link } from "@/lib/router";
|
||||
import { useQuery, useQueryClient } from "@tanstack/react-query";
|
||||
import { heartbeatsApi, type LiveRunForIssue } from "../api/heartbeats";
|
||||
import { heartbeatsApi, type ActiveRunForIssue, type LiveRunForIssue } from "../api/heartbeats";
|
||||
import { queryKeys } from "../lib/queryKeys";
|
||||
import { formatDateTime } from "../lib/utils";
|
||||
import { ExternalLink, Square } from "lucide-react";
|
||||
|
|
@ -13,6 +13,8 @@ import { useLiveRunTranscripts } from "./transcript/useLiveRunTranscripts";
|
|||
interface LiveRunWidgetProps {
|
||||
issueId: string;
|
||||
companyId?: string | null;
|
||||
liveRunsData?: LiveRunForIssue[];
|
||||
activeRunData?: ActiveRunForIssue | null;
|
||||
}
|
||||
|
||||
function toIsoString(value: string | Date | null | undefined): string | null {
|
||||
|
|
@ -24,24 +26,34 @@ function isRunActive(status: string): boolean {
|
|||
return status === "queued" || status === "running";
|
||||
}
|
||||
|
||||
export function LiveRunWidget({ issueId, companyId }: LiveRunWidgetProps) {
|
||||
export function LiveRunWidget({
|
||||
issueId,
|
||||
companyId,
|
||||
liveRunsData,
|
||||
activeRunData,
|
||||
}: LiveRunWidgetProps) {
|
||||
const queryClient = useQueryClient();
|
||||
const [cancellingRunIds, setCancellingRunIds] = useState(new Set<string>());
|
||||
const shouldFetchLiveRuns = liveRunsData === undefined;
|
||||
const shouldFetchActiveRun = activeRunData === undefined;
|
||||
|
||||
const { data: liveRuns } = useQuery({
|
||||
const { data: fetchedLiveRuns } = useQuery({
|
||||
queryKey: queryKeys.issues.liveRuns(issueId),
|
||||
queryFn: () => heartbeatsApi.liveRunsForIssue(issueId),
|
||||
enabled: !!issueId,
|
||||
enabled: !!issueId && shouldFetchLiveRuns,
|
||||
refetchInterval: 3000,
|
||||
});
|
||||
|
||||
const { data: activeRun } = useQuery({
|
||||
const { data: fetchedActiveRun } = useQuery({
|
||||
queryKey: queryKeys.issues.activeRun(issueId),
|
||||
queryFn: () => heartbeatsApi.activeRunForIssue(issueId),
|
||||
enabled: !!issueId,
|
||||
enabled: !!issueId && shouldFetchActiveRun,
|
||||
refetchInterval: 3000,
|
||||
});
|
||||
|
||||
const liveRuns = liveRunsData ?? fetchedLiveRuns;
|
||||
const activeRun = activeRunData ?? fetchedActiveRun;
|
||||
|
||||
const runs = useMemo(() => {
|
||||
const deduped = new Map<string, LiveRunForIssue>();
|
||||
for (const run of liveRuns ?? []) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue