mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-18 11:40:39 +09:00
Harden control-plane safety and issue identifiers (#5292)
## Thinking Path > - Paperclip relies on issue identifiers, execution policies, and agent heartbeat rules to keep autonomous work auditable. > - Safety checks need to reject ambiguous agent handoffs, and identifier parsing needs to support Cloud tenant prefixes. > - Agent instructions also need to make final-disposition rules explicit so work does not stall in vague states. > - This pull request isolates backend correctness and governance hardening from the UI and recovery-system-notice branches. > - The benefit is safer in-review transitions, better identifier compatibility, and clearer agent operating contracts. ## What Changed - Fixed run-aware confirmation ordering and interrupted-run state cleanup. - Added Cloud tenant identity bootstrap and alphanumeric issue identifier support across shared parsing and server routes. - Guarded agent-authored `in_review` updates unless a real review path exists. - Tightened heartbeat disposition instructions in adapter utilities/default AGENTS/Paperclip skill. ## Verification - `pnpm install --frozen-lockfile` - `pnpm exec vitest run packages/shared/src/issue-references.test.ts server/src/__tests__/issue-identifier-routes.test.ts server/src/__tests__/issue-execution-policy-routes.test.ts packages/adapter-utils/src/server-utils.test.ts` initially had the first execution-policy test hit Vitest's 5s timeout under the parallel bundle while the rest passed. - `pnpm exec vitest run server/src/__tests__/issue-execution-policy-routes.test.ts --testTimeout=20000` passed with 10/10 tests. - Follow-up: `pnpm run typecheck:build-gaps` passed. - Follow-up: `pnpm --filter @paperclipai/ui typecheck` passed. - Follow-up: `pnpm vitest run server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/company-portability.test.ts server/src/__tests__/costs-service.test.ts` passed. - Follow-up: `pnpm vitest run ui/src/context/LiveUpdatesProvider.test.ts ui/src/lib/issue-chat-messages.test.ts ui/src/lib/issue-reference.test.ts ui/src/lib/issue-timeline-events.test.ts` passed. ## Risks - Medium control-plane risk: in-review update validation changes agent behavior. The error message is explicit and tests cover allowed review paths. ## Model Used - OpenAI GPT-5 Codex via Paperclip `codex_local` adapter, with shell/git/GitHub CLI tool use. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
parent
a1b30c9f35
commit
68f69975a4
17 changed files with 875 additions and 90 deletions
|
|
@ -89,6 +89,11 @@ type MessageWithOrder = {
|
|||
message: ThreadMessage;
|
||||
};
|
||||
|
||||
type SortBoundaryItem = {
|
||||
createdAtMs: number;
|
||||
runId?: string | null;
|
||||
};
|
||||
|
||||
export interface StableThreadMessageCacheEntry {
|
||||
fingerprint: string;
|
||||
message: ThreadMessage;
|
||||
|
|
@ -145,6 +150,64 @@ function sortByCreated<T extends { createdAt: Date | string; id: string }>(items
|
|||
});
|
||||
}
|
||||
|
||||
function latestSameRunHandoffTimestamp(args: {
|
||||
interactionCreatedAtMs: number;
|
||||
sourceRunId: string;
|
||||
comments: readonly IssueChatComment[];
|
||||
timelineEvents: readonly IssueTimelineEvent[];
|
||||
linkedRuns: readonly IssueChatLinkedRun[];
|
||||
liveRuns: readonly LiveRunForIssue[];
|
||||
}) {
|
||||
const {
|
||||
interactionCreatedAtMs,
|
||||
sourceRunId,
|
||||
comments,
|
||||
timelineEvents,
|
||||
linkedRuns,
|
||||
liveRuns,
|
||||
} = args;
|
||||
const handoffItems: SortBoundaryItem[] = [
|
||||
...comments.map((comment) => ({
|
||||
createdAtMs: toTimestamp(comment.createdAt),
|
||||
runId: comment.runId ?? null,
|
||||
})),
|
||||
...timelineEvents.map((event) => ({
|
||||
createdAtMs: toTimestamp(event.createdAt),
|
||||
runId: event.runId ?? null,
|
||||
})),
|
||||
];
|
||||
const barrierItems: SortBoundaryItem[] = [
|
||||
...handoffItems,
|
||||
...linkedRuns.map((run) => ({
|
||||
createdAtMs: toTimestamp(runTimestamp(run)),
|
||||
runId: run.runId,
|
||||
})),
|
||||
...liveRuns.map((run) => ({
|
||||
createdAtMs: toTimestamp(run.startedAt ?? run.createdAt),
|
||||
runId: run.id,
|
||||
})),
|
||||
];
|
||||
const barrierAtMs = barrierItems
|
||||
.filter((item) => item.createdAtMs > interactionCreatedAtMs && item.runId !== sourceRunId)
|
||||
.reduce<number | null>(
|
||||
(earliest, item) =>
|
||||
earliest === null ? item.createdAtMs : Math.min(earliest, item.createdAtMs),
|
||||
null,
|
||||
);
|
||||
|
||||
return handoffItems
|
||||
.filter((item) =>
|
||||
item.createdAtMs > interactionCreatedAtMs
|
||||
&& item.runId === sourceRunId
|
||||
&& (barrierAtMs === null || item.createdAtMs < barrierAtMs)
|
||||
)
|
||||
.reduce<number | null>(
|
||||
(latest, item) =>
|
||||
latest === null ? item.createdAtMs : Math.max(latest, item.createdAtMs),
|
||||
null,
|
||||
);
|
||||
}
|
||||
|
||||
function normalizeJsonValue(input: unknown): JsonValue {
|
||||
if (
|
||||
input === null ||
|
||||
|
|
@ -832,8 +895,19 @@ export function buildIssueChatMessages(args: {
|
|||
}
|
||||
|
||||
for (const interaction of sortByCreated(interactions)) {
|
||||
const createdAtMs = toTimestamp(interaction.createdAt);
|
||||
const handoffAtMs = interaction.kind === "request_confirmation" && interaction.sourceRunId
|
||||
? latestSameRunHandoffTimestamp({
|
||||
interactionCreatedAtMs: createdAtMs,
|
||||
sourceRunId: interaction.sourceRunId,
|
||||
comments,
|
||||
timelineEvents,
|
||||
linkedRuns,
|
||||
liveRuns,
|
||||
})
|
||||
: null;
|
||||
orderedMessages.push({
|
||||
createdAtMs: toTimestamp(interaction.createdAt),
|
||||
createdAtMs: handoffAtMs ?? createdAtMs,
|
||||
order: 2,
|
||||
message: createInteractionMessage(interaction),
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue