Polish operator UI task controls (#5427)

## Thinking Path

> - Paperclip orchestrates AI agents for zero-human companies
> - Operators spend most of their day scanning skills, routines, inbox
groups, and activity cards
> - Several small UI rough edges made those surfaces harder to scan or
easier to crash on real API payloads
> - These fixes are grouped together because they are low-risk operator
quality-of-life improvements rather than separate control-plane
contracts
> - This pull request polishes skills metadata, routine run-now access,
grouped issue creation defaults, monitor activity rendering, and
activity row identity layout
> - The benefit is a smoother board workflow with fewer small
interruptions while keeping the change set compact

## What Changed

- Improves company skill source display and the used-by agent list.
- Truncates long skill source paths and adds a copy affordance.
- Adds a row-level run-now button to the routines table.
- Adds grouped issue creation defaults for inbox issue groups and aligns
grouped add buttons to the right.
- Fixes `IssueMonitorActivityCard` when `monitorNextCheckAt` arrives as
an ISO string.
- Polishes activity row actor avatar/name layout by using the shared
avatar primitive.

## Verification

- `pnpm run preflight:workspace-links && pnpm exec vitest run
ui/src/pages/Routines.test.tsx ui/src/components/IssuesList.test.tsx
ui/src/lib/inbox.test.ts
ui/src/components/IssueMonitorActivityCard.test.tsx` — 91 passed.
- The routines test emitted the pre-existing Radix warning about missing
`DialogTitle`/description in dialog content; tests still passed.
- Pairwise merge checks against the other two PR branches reported no
textual conflicts.

## Risks

- Low: changes are UI-focused and covered by targeted component/lib
tests.
- Low-to-medium: activity row layout changes could affect dense feed
scanability; the implementation uses the shared avatar component and
keeps truncation behavior.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool-enabled
Paperclip heartbeat environment. Context window and internal reasoning
mode are not exposed by the runtime.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta 2026-05-07 12:24:02 -05:00 committed by GitHub
parent 772fc92619
commit 6f30003421
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 431 additions and 47 deletions

View file

@ -13,6 +13,7 @@ import type {
import {
DEFAULT_INBOX_ISSUE_COLUMNS,
buildGroupedInboxSections,
buildInboxIssueGroupCreateDefaults,
buildInboxKeyboardNavEntries,
buildInboxDismissedAtByKey,
computeInboxBadgeData,
@ -1379,6 +1380,61 @@ describe("inbox helpers", () => {
]);
});
it("builds new issue defaults from inbox project, assignee, and workspace groups", () => {
const projectIssue = makeIssue("project", true);
projectIssue.projectId = "project-1";
const executionIssue = makeIssue("exec", false);
executionIssue.projectId = "project-1";
executionIssue.projectWorkspaceId = "project-workspace-1";
executionIssue.executionWorkspaceId = "execution-workspace-1";
const agentIssue = makeIssue("agent", false);
agentIssue.assigneeAgentId = "agent-1";
const options = {
executionWorkspaceById: new Map([
[
"execution-workspace-1",
{
name: "Feature Branch",
mode: "isolated_workspace" as const,
projectWorkspaceId: "project-workspace-1",
},
],
]),
projectWorkspaceById: new Map([
["project-workspace-1", { name: "Primary workspace", projectId: "project-1" }],
]),
};
expect(buildInboxIssueGroupCreateDefaults(
"project:project-1",
"project",
[{ kind: "issue", timestamp: 1, issue: projectIssue }],
options,
)).toEqual({ projectId: "project-1" });
expect(buildInboxIssueGroupCreateDefaults(
"workspace:execution:execution-workspace-1",
"workspace",
[{ kind: "issue", timestamp: 1, issue: executionIssue }],
options,
)).toEqual({
executionWorkspaceId: "execution-workspace-1",
executionWorkspaceMode: "reuse_existing",
projectId: "project-1",
projectWorkspaceId: "project-workspace-1",
});
expect(buildInboxIssueGroupCreateDefaults(
"assignee:agent:agent-1",
"assignee",
[{ kind: "issue", timestamp: 1, issue: agentIssue }],
options,
)).toEqual({ assigneeAgentId: "agent-1" });
});
it("persists inbox grouping preferences", () => {
saveInboxWorkItemGroupBy("workspace");
expect(loadInboxWorkItemGroupBy()).toBe("workspace");

View file

@ -126,12 +126,14 @@ export type InboxKeyboardNavEntry =
export interface InboxProjectWorkspaceLookup {
name: string;
projectId?: string | null;
}
export interface InboxExecutionWorkspaceLookup {
name: string;
mode: "shared_workspace" | "isolated_workspace" | "operator_branch" | "adapter_managed" | "cloud_sandbox";
projectWorkspaceId: string | null;
projectId?: string | null;
}
export interface InboxWorkspaceGroupingOptions {
@ -144,6 +146,15 @@ export interface InboxWorkspaceGroupingOptions {
currentUserId?: string | null;
}
export interface InboxIssueGroupCreateDefaults {
projectId?: string;
projectWorkspaceId?: string;
executionWorkspaceId?: string;
executionWorkspaceMode?: string;
assigneeAgentId?: string;
assigneeUserId?: string;
}
const defaultInboxFilterPreferences: InboxFilterPreferences = {
allCategoryFilter: "everything",
allApprovalFilter: "all",
@ -931,6 +942,85 @@ export function groupInboxWorkItems(
return orderedGroups;
}
function stripInboxSearchGroupPrefix(groupKey: string) {
return groupKey
.replace(/^archived-search:/, "")
.replace(/^other-search:/, "");
}
function firstIssueFromInboxWorkItems(items: InboxWorkItem[]): Issue | null {
return items.find((item): item is InboxWorkItem & { kind: "issue" } => item.kind === "issue")?.issue ?? null;
}
function projectIdForProjectWorkspace(
projectWorkspaceId: string | null | undefined,
options: InboxWorkspaceGroupingOptions,
fallbackIssue: Issue | null,
) {
if (!projectWorkspaceId) return fallbackIssue?.projectId ?? null;
return options.projectWorkspaceById?.get(projectWorkspaceId)?.projectId
?? (fallbackIssue?.projectWorkspaceId === projectWorkspaceId ? fallbackIssue.projectId : null);
}
export function buildInboxIssueGroupCreateDefaults(
groupKey: string,
groupBy: InboxWorkItemGroupBy,
items: InboxWorkItem[],
options: InboxWorkspaceGroupingOptions = {},
): InboxIssueGroupCreateDefaults | null {
const fallbackIssue = firstIssueFromInboxWorkItems(items);
if (!fallbackIssue) return null;
const key = stripInboxSearchGroupPrefix(groupKey);
if (groupBy === "project") {
if (!key.startsWith("project:")) return {};
const projectId = key.slice("project:".length);
return projectId && projectId !== "none" ? { projectId } : {};
}
if (groupBy === "assignee") {
if (key.startsWith("assignee:agent:")) {
const assigneeAgentId = key.slice("assignee:agent:".length);
return assigneeAgentId ? { assigneeAgentId } : {};
}
if (key.startsWith("assignee:user:")) {
const assigneeUserId = key.slice("assignee:user:".length);
return assigneeUserId ? { assigneeUserId } : {};
}
return {};
}
if (groupBy === "workspace") {
if (key.startsWith("workspace:execution:")) {
const executionWorkspaceId = key.slice("workspace:execution:".length);
if (!executionWorkspaceId) return {};
const executionWorkspace = options.executionWorkspaceById?.get(executionWorkspaceId) ?? null;
const projectWorkspaceId = executionWorkspace?.projectWorkspaceId
?? (fallbackIssue.executionWorkspaceId === executionWorkspaceId ? fallbackIssue.projectWorkspaceId : null);
const projectId = executionWorkspace?.projectId
?? projectIdForProjectWorkspace(projectWorkspaceId, options, fallbackIssue);
return {
executionWorkspaceId,
executionWorkspaceMode: "reuse_existing",
...(projectId ? { projectId } : {}),
...(projectWorkspaceId ? { projectWorkspaceId } : {}),
};
}
if (key.startsWith("workspace:project:")) {
const projectWorkspaceId = key.slice("workspace:project:".length);
if (!projectWorkspaceId) return {};
const projectId = projectIdForProjectWorkspace(projectWorkspaceId, options, fallbackIssue);
return {
...(projectId ? { projectId } : {}),
projectWorkspaceId,
};
}
}
return {};
}
/**
* Groups parent-child issues in a flat InboxWorkItem list.
*