[codex] Harden execution reliability and heartbeat tooling (#3679)

## Thinking Path

> - Paperclip orchestrates AI agents for zero-human companies
> - Reliable execution depends on heartbeat routing, issue lifecycle
semantics, telemetry, and a fast enough local verification loop to keep
regressions visible
> - The remaining commits on this branch were mostly server/runtime
correctness fixes plus test and documentation follow-ups in that area
> - Those changes are logically separate from the UI-focused
issue-detail and workspace/navigation branches even when they touch
overlapping issue APIs
> - This pull request groups the execution reliability, heartbeat,
telemetry, and tooling changes into one standalone branch
> - The benefit is a focused review of the control-plane correctness
work, including the follow-up fix that restored the implicit
comment-reopen helpers after branch splitting

## What Changed

- Hardened issue/heartbeat execution behavior, including self-review
stage skipping, deferred mention wakes during active execution, stranded
execution recovery, active-run scoping, assignee resolution, and
blocked-to-todo wake resumption
- Reduced noisy polling/logging overhead by trimming issue run payloads,
compacting persisted run logs, silencing high-volume request logs, and
capping heartbeat-run queries in dashboard/inbox surfaces
- Expanded telemetry and status semantics with adapter/model fields on
task completion plus clearer status guidance in docs/onboarding material
- Updated test infrastructure and verification defaults with faster
route-test module isolation, cheaper default `pnpm test`, e2e isolation
from local state, and repo verification follow-ups
- Included docs/release housekeeping from the branch and added a small
follow-up commit restoring the implicit comment-reopen helpers that were
dropped during branch reconstruction

## Verification

- `pnpm vitest run
server/src/__tests__/issue-comment-reopen-routes.test.ts
server/src/__tests__/issue-telemetry-routes.test.ts`
- `pnpm vitest run server/src/__tests__/http-log-policy.test.ts
server/src/__tests__/heartbeat-run-log.test.ts
server/src/__tests__/health.test.ts`
- `server/src/__tests__/activity-service.test.ts`,
`server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and
`server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted
on this host but the embedded Postgres harness reported
init-script/data-dir problems and skipped or failed to start, so they
are noted as environment-limited

## Risks

- Medium: this branch changes core issue/heartbeat routing and
reopen/wakeup behavior, so regressions would affect agent execution flow
rather than isolated UI polish
- Because it also updates verification infrastructure, reviewers should
pay attention to whether the new tests are asserting the right failure
modes and not just reshaping harness behavior

## Model Used

- OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact
deployed model ID is not exposed in this environment), reasoning
enabled, tool use and local code execution enabled

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [ ] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta 2026-04-14 13:34:52 -05:00 committed by GitHub
parent e89076148a
commit 7f893ac4ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
106 changed files with 4682 additions and 713 deletions

View file

@ -7,7 +7,7 @@ import { issuesApi } from "../api/issues";
import { authApi } from "../api/auth";
import { useCompany } from "./CompanyContext";
import type { ToastInput } from "./ToastContext";
import { useToast } from "./ToastContext";
import { useToastActions } from "./ToastContext";
import { upsertIssueCommentInPages } from "../lib/optimistic-issue-comments";
import { queryKeys } from "../lib/queryKeys";
import { toCompanyRelativePath } from "../lib/company-routes";
@ -841,7 +841,7 @@ export const __liveUpdatesTestUtils = {
export function LiveUpdatesProvider({ children }: { children: ReactNode }) {
const { selectedCompanyId, selectedCompany } = useCompany();
const queryClient = useQueryClient();
const { pushToast } = useToast();
const { pushToast } = useToastActions();
const location = useLocation();
const gateRef = useRef<ToastGate>({ cooldownHits: new Map(), suppressUntil: 0 });
const pathnameRef = useRef(location.pathname);

View file

@ -0,0 +1,72 @@
// @vitest-environment jsdom
import { act } from "react";
import { createRoot } from "react-dom/client";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { ToastProvider, useToastActions, useToastState } from "./ToastContext";
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
describe("ToastContext", () => {
let container: HTMLDivElement;
beforeEach(() => {
container = document.createElement("div");
document.body.appendChild(container);
});
afterEach(() => {
document.body.innerHTML = "";
});
it("does not rerender action-only consumers when toast state changes", () => {
const root = createRoot(container);
let actionOnlyRenderCount = 0;
let pushToastRef: ((input: { title: string }) => string | null) | null = null;
let clearToastsRef: (() => void) | null = null;
function ActionOnlyConsumer() {
actionOnlyRenderCount += 1;
const { pushToast, clearToasts } = useToastActions();
pushToastRef = pushToast;
clearToastsRef = clearToasts;
return null;
}
function ToastCount() {
const toasts = useToastState();
return <div data-testid="toast-count">{String(toasts.length)}</div>;
}
act(() => {
root.render(
<ToastProvider>
<ActionOnlyConsumer />
<ToastCount />
</ToastProvider>,
);
});
expect(actionOnlyRenderCount).toBe(1);
expect(container.querySelector('[data-testid="toast-count"]')?.textContent).toBe("0");
act(() => {
pushToastRef?.({ title: "Saved" });
});
expect(actionOnlyRenderCount).toBe(1);
expect(container.querySelector('[data-testid="toast-count"]')?.textContent).toBe("1");
act(() => {
clearToastsRef?.();
});
expect(actionOnlyRenderCount).toBe(1);
expect(container.querySelector('[data-testid="toast-count"]')?.textContent).toBe("0");
act(() => {
root.unmount();
});
});
});

View file

@ -36,13 +36,16 @@ export interface ToastItem {
createdAt: number;
}
interface ToastContextValue {
toasts: ToastItem[];
interface ToastActionsContextValue {
pushToast: (input: ToastInput) => string | null;
dismissToast: (id: string) => void;
clearToasts: () => void;
}
interface ToastContextValue extends ToastActionsContextValue {
toasts: ToastItem[];
}
const DEFAULT_TTL_BY_TONE: Record<ToastTone, number> = {
info: 4000,
success: 3500,
@ -55,7 +58,8 @@ const MAX_TOASTS = 5;
const DEDUPE_WINDOW_MS = 3500;
const DEDUPE_MAX_AGE_MS = 20000;
const ToastContext = createContext<ToastContextValue | null>(null);
const ToastStateContext = createContext<ToastItem[] | null>(null);
const ToastActionsContext = createContext<ToastActionsContextValue | null>(null);
function normalizeTtl(value: number | undefined, tone: ToastTone) {
const fallback = DEFAULT_TTL_BY_TONE[tone];
@ -150,23 +154,40 @@ export function ToastProvider({ children }: { children: ReactNode }) {
timersRef.current.clear();
}, []);
const value = useMemo<ToastContextValue>(
const actions = useMemo<ToastActionsContextValue>(
() => ({
toasts,
pushToast,
dismissToast,
clearToasts,
}),
[toasts, pushToast, dismissToast, clearToasts],
[pushToast, dismissToast, clearToasts],
);
return <ToastContext.Provider value={value}>{children}</ToastContext.Provider>;
return (
<ToastActionsContext.Provider value={actions}>
<ToastStateContext.Provider value={toasts}>{children}</ToastStateContext.Provider>
</ToastActionsContext.Provider>
);
}
export function useToast() {
const context = useContext(ToastContext);
export function useToastState() {
const context = useContext(ToastStateContext);
if (!context) {
throw new Error("useToast must be used within a ToastProvider");
throw new Error("useToastState must be used within a ToastProvider");
}
return context;
}
export function useToastActions() {
const context = useContext(ToastActionsContext);
if (!context) {
throw new Error("useToastActions must be used within a ToastProvider");
}
return context;
}
export function useToast() {
const toasts = useToastState();
const actions = useToastActions();
return useMemo<ToastContextValue>(() => ({ toasts, ...actions }), [toasts, actions]);
}