Address Greptile review on board CLI auth

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
dotta 2026-03-23 08:45:56 -05:00
parent 01b6b7e66a
commit 7f9a76411a
9 changed files with 207 additions and 54 deletions

View file

@ -1671,8 +1671,12 @@ export function accessRoutes(
);
if (approved.status === "approved") {
const accessSnapshot = await boardAuth.resolveBoardAccess(userId);
for (const companyId of accessSnapshot.companyIds) {
const companyIds = await boardAuth.resolveBoardActivityCompanyIds({
userId,
requestedCompanyId: approved.challenge.requestedCompanyId,
boardApiKeyId: approved.challenge.boardApiKeyId,
});
for (const companyId of companyIds) {
await logActivity(db, {
companyId,
actorType: "user",
@ -1737,8 +1741,11 @@ export function accessRoutes(
req.actor.userId,
);
await boardAuth.revokeBoardApiKey(key.id);
const accessSnapshot = await boardAuth.resolveBoardAccess(key.userId);
for (const companyId of accessSnapshot.companyIds) {
const companyIds = await boardAuth.resolveBoardActivityCompanyIds({
userId: key.userId,
boardApiKeyId: key.id,
});
for (const companyId of companyIds) {
await logActivity(db, {
companyId,
actorType: "user",