ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-19 20:10:39 +09:00
Code Issues Projects Releases Packages Wiki Activity

Detect misclassified video attachments

Browse source 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta 2026-06-01 19:12:53 +00:00
parent e86d000c7b
commit 8af359b656
4 changed files with 89 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
server/src/__tests__/issue-attachment-routes.test.ts
View file

@ -412,6 +412,25 @@ describe("issue attachment routes", () => {
);
});
it("serves mp4 attachments inline when stored with a generic binary content type", async () => {
const storage = createStorageService(Buffer.from("abcdef"));
mockIssueService.getAttachmentById.mockResolvedValue({
...makeAttachment("application/octet-stream", "clip.mp4"),
byteSize: 6,
});
const app = await createApp(storage);
const res = await request(app)
.get("/api/attachments/attachment-1/content")
.set("Range", "bytes=1-3");
expect(res.status).toBe(206);
expect(res.headers["content-type"]).toContain("video/mp4");
expect(res.headers["content-disposition"]).toBe('inline; filename="clip.mp4"');
expect(res.headers["content-range"]).toBe("bytes 1-3/6");
expect(Buffer.from(res.body).toString("utf8")).toBe("bcd");
});
it("forces video downloads when the download path is requested", async () => {
const storage = createStorageService();
mockIssueService.getAttachmentById.mockResolvedValue(makeAttachment("video/webm", "clip.webm"));