mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-17 19:20:39 +09:00
fix: harden release registry verification against npm lag (#4816)
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Its release automation publishes canary packages to npm and then validates the published registry state before considering the release healthy > - The failing canary run `25139465018` showed that npm can expose a newly published version through version-specific endpoints before the root package document has fully converged > - That made a successful canary publish look like a failed release because the verifier trusted stale root metadata too early > - This pull request hardens the registry verification path by preferring version-specific manifest checks, retrying convergence-sensitive failures, and distinguishing permanent failures from propagation lag > - While validating that change in CI, a separate teardown race in `heartbeat-stale-queue-invalidation.test.ts` surfaced and was hardened so the PR could pass reliably > - The benefit is that transient npm propagation lag no longer fails a successful canary publish, while genuine registry-state and dependency-integrity failures still stop the release flow promptly ## What Changed - Hardened `scripts/verify-release-registry-state.mjs` so it prefers version-specific manifest resolution over stale root metadata, adds bounded registry-fetch timeouts, and classifies failures as retriable vs non-retriable. - Updated `scripts/release-lib.sh` and `scripts/release.sh` so post-publish registry verification retries only convergence-sensitive failures and reports immediate permanent failures clearly. - Expanded `scripts/verify-release-registry-state.test.mjs` with regression coverage for stale root metadata, fetch timeout behavior, peer dependency range handling, non-retriable canary-latest cases, and related verifier edge cases. - Hardened `server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts` teardown to tolerate the late-comment foreign-key race that CI exposed while validating this branch. ## Verification - `pnpm run test:release-registry` - `node --check scripts/verify-release-registry-state.mjs` - `bash -n scripts/release.sh && bash -n scripts/release-lib.sh` - PR checks passed on head `5c422600fc12acac61f6b7c267a4dc915df622b1`: `policy`, `verify`, `e2e`, `security/snyk`, and `Greptile Review` ## Risks - Low risk. The main behavioral changes are limited to release automation and verifier retry semantics, plus a test-only teardown hardening for a CI race. > I checked [`ROADMAP.md`](ROADMAP.md). This is a narrow release bugfix and does not overlap planned core feature work. ## Model Used - OpenAI Codex via Paperclip `codex_local` with tool use and local code execution enabled. This agent session runs on a GPT-5-class coding model; the exact backend model ID/context window is not exposed by the local adapter runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I have addressed all Greptile and reviewer comments before requesting merge
This commit is contained in:
parent
a1b2875165
commit
a72731f118
9 changed files with 785 additions and 125 deletions
|
|
@ -104,6 +104,7 @@ import {
|
|||
issueTreeControlService,
|
||||
} from "./issue-tree-control.js";
|
||||
import {
|
||||
continuationSummaryParksExecutor,
|
||||
getIssueContinuationSummaryDocument,
|
||||
refreshIssueContinuationSummary,
|
||||
} from "./issue-continuation-summary.js";
|
||||
|
|
@ -5977,7 +5978,8 @@ export function heartbeatService(db: Db, options: HeartbeatServiceOptions = {})
|
|||
| "issue_terminal_status"
|
||||
| "issue_not_in_progress"
|
||||
| "issue_execution_lock_changed"
|
||||
| "issue_review_participant_changed";
|
||||
| "issue_review_participant_changed"
|
||||
| "issue_continuation_waiting_on_review";
|
||||
details: Record<string, unknown>;
|
||||
};
|
||||
|
||||
|
|
@ -6010,8 +6012,38 @@ export function heartbeatService(db: Db, options: HeartbeatServiceOptions = {})
|
|||
const wakeCommentId = deriveCommentId(context, null);
|
||||
const isInteractionWake = allowsIssueInteractionWake(context);
|
||||
const resumeIntent = context.resumeIntent === true || context.followUpRequested === true;
|
||||
const wakeReason = readNonEmptyString(context.wakeReason);
|
||||
const retryReason = readNonEmptyString(context.retryReason) ?? run.scheduledRetryReason ?? null;
|
||||
|
||||
if (
|
||||
issue.status === "in_progress" &&
|
||||
!wakeCommentId &&
|
||||
(wakeReason === "issue_continuation_needed" || retryReason === "issue_continuation_needed")
|
||||
) {
|
||||
const queuedWake = parseObject(context.paperclipWake);
|
||||
const queuedContinuationSummary =
|
||||
readNonEmptyString(parseObject(context.paperclipContinuationSummary).body) ??
|
||||
readNonEmptyString(parseObject(queuedWake.continuationSummary).body);
|
||||
const currentContinuationSummary = queuedContinuationSummary
|
||||
? null
|
||||
: await getIssueContinuationSummaryDocument(db, issueId);
|
||||
const continuationSummaryBody = queuedContinuationSummary ?? currentContinuationSummary?.body ?? null;
|
||||
if (continuationSummaryParksExecutor(continuationSummaryBody)) {
|
||||
return {
|
||||
stale: true,
|
||||
errorCode: "issue_continuation_waiting_on_review",
|
||||
reason:
|
||||
"Cancelled because the continuation summary says the executor should wait for reviewer feedback or approval before more work starts",
|
||||
details: {
|
||||
issueId,
|
||||
wakeReason,
|
||||
retryReason,
|
||||
nextAction: continuationSummaryBody,
|
||||
},
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
if (issue.assigneeAgentId !== run.agentId && !isInteractionWake) {
|
||||
return {
|
||||
stale: true,
|
||||
|
|
|
|||
|
|
@ -9,6 +9,8 @@ export const ISSUE_CONTINUATION_SUMMARY_TITLE = "Continuation Summary";
|
|||
export const ISSUE_CONTINUATION_SUMMARY_MAX_BODY_CHARS = 8_000;
|
||||
const SUMMARY_SECTION_MAX_CHARS = 1_200;
|
||||
const PATH_CANDIDATE_RE = /(?:^|[\s`"'(])((?:server|ui|packages|doc|scripts|\.github)\/[A-Za-z0-9._/-]+)/g;
|
||||
const WAITING_FOR_REVIEW_OR_APPROVAL_RE =
|
||||
/\bwait(?:ing)? for\b.{0,160}\b(?:review(?:er)?(?: feedback)?|approval|board|human|user|operator)\b/i;
|
||||
|
||||
type IssueSummaryInput = {
|
||||
id: string;
|
||||
|
|
@ -120,6 +122,16 @@ function extractPreviousNextAction(previousBody: string | null | undefined) {
|
|||
.find(Boolean) ?? null;
|
||||
}
|
||||
|
||||
export function extractContinuationSummaryNextAction(body: string | null | undefined) {
|
||||
return extractPreviousNextAction(body);
|
||||
}
|
||||
|
||||
export function continuationSummaryParksExecutor(body: string | null | undefined) {
|
||||
const nextAction = extractContinuationSummaryNextAction(body);
|
||||
if (!nextAction) return false;
|
||||
return WAITING_FOR_REVIEW_OR_APPROVAL_RE.test(nextAction);
|
||||
}
|
||||
|
||||
export function buildContinuationSummaryMarkdown(input: {
|
||||
issue: IssueSummaryInput;
|
||||
run: RunSummaryInput;
|
||||
|
|
|
|||
|
|
@ -231,6 +231,36 @@ function formatIssueLinksForComment(relations: Array<{ identifier?: string | nul
|
|||
.join(", ");
|
||||
}
|
||||
|
||||
function unwrapDatabaseConflictError(error: unknown) {
|
||||
if (!error || typeof error !== "object") return null;
|
||||
|
||||
const candidate = error as {
|
||||
code?: string;
|
||||
constraint?: string;
|
||||
constraint_name?: string;
|
||||
message?: string;
|
||||
cause?: unknown;
|
||||
};
|
||||
|
||||
if (
|
||||
typeof candidate.code === "string" ||
|
||||
typeof candidate.constraint === "string" ||
|
||||
typeof candidate.constraint_name === "string"
|
||||
) {
|
||||
return candidate;
|
||||
}
|
||||
|
||||
const cause = candidate.cause;
|
||||
if (!cause || typeof cause !== "object") return candidate;
|
||||
|
||||
return cause as {
|
||||
code?: string;
|
||||
constraint?: string;
|
||||
constraint_name?: string;
|
||||
message?: string;
|
||||
};
|
||||
}
|
||||
|
||||
function isAgentInvokable(agent: typeof agents.$inferSelect | null | undefined) {
|
||||
return Boolean(agent && !["paused", "terminated", "pending_approval"].includes(agent.status));
|
||||
}
|
||||
|
|
@ -928,21 +958,23 @@ export function recoveryService(db: Db, deps: { enqueueWakeup: RecoveryWakeup })
|
|||
}
|
||||
|
||||
function isUniqueStaleRunEvaluationConflict(error: unknown) {
|
||||
if (!error || typeof error !== "object") return false;
|
||||
const maybe = error as { code?: string; constraint?: string; message?: string };
|
||||
const maybe = unwrapDatabaseConflictError(error);
|
||||
if (!maybe) return false;
|
||||
return maybe.code === "23505" &&
|
||||
(
|
||||
maybe.constraint === "issues_active_stale_run_evaluation_uq" ||
|
||||
maybe.constraint_name === "issues_active_stale_run_evaluation_uq" ||
|
||||
typeof maybe.message === "string" && maybe.message.includes("issues_active_stale_run_evaluation_uq")
|
||||
);
|
||||
}
|
||||
|
||||
function isUniqueStrandedIssueRecoveryConflict(error: unknown) {
|
||||
if (!error || typeof error !== "object") return false;
|
||||
const maybe = error as { code?: string; constraint?: string; message?: string };
|
||||
const maybe = unwrapDatabaseConflictError(error);
|
||||
if (!maybe) return false;
|
||||
return maybe.code === "23505" &&
|
||||
(
|
||||
maybe.constraint === "issues_active_stranded_issue_recovery_uq" ||
|
||||
maybe.constraint_name === "issues_active_stranded_issue_recovery_uq" ||
|
||||
typeof maybe.message === "string" && maybe.message.includes("issues_active_stranded_issue_recovery_uq")
|
||||
);
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue