mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-16 10:50:38 +09:00
[codex] Add structured issue-thread interactions (#4244)
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators supervise that work through issues, comments, approvals, and the board UI. > - Some agent proposals need structured board/user decisions, not hidden markdown conventions or heavyweight governed approvals. > - Issue-thread interactions already provide a natural thread-native surface for proposed tasks and questions. > - This pull request extends that surface with request confirmations, richer interaction cards, and agent/plugin/MCP helpers. > - The benefit is that plan approvals and yes/no decisions become explicit, auditable, and resumable without losing the single-issue workflow. ## What Changed - Added persisted issue-thread interactions for suggested tasks, structured questions, and request confirmations. - Added board UI cards for interaction review, selection, question answers, and accept/reject confirmation flows. - Added MCP and plugin SDK helpers for creating interaction cards from agents/plugins. - Updated agent wake instructions, onboarding assets, Paperclip skill docs, and public docs to prefer structured confirmations for issue-scoped decisions. - Rebased the branch onto `public-gh/master` and renumbered branch migrations to `0063` and `0064`; the idempotency migration uses `ADD COLUMN IF NOT EXISTS` for old branch users. ## Verification - `git diff --check public-gh/master..HEAD` - `pnpm exec vitest run packages/adapter-utils/src/server-utils.test.ts packages/mcp-server/src/tools.test.ts packages/shared/src/issue-thread-interactions.test.ts ui/src/lib/issue-thread-interactions.test.ts ui/src/lib/issue-chat-messages.test.ts ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/components/IssueChatThread.test.tsx server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/services/issue-thread-interactions.test.ts` -> 9 files / 79 tests passed - `pnpm -r typecheck` -> passed, including `packages/db` migration numbering check ## Risks - Medium: this adds a new issue-thread interaction model across db/shared/server/ui/plugin surfaces. - Migration risk is reduced by placing this branch after current master migrations (`0063`, `0064`) and making the idempotency column add idempotent for users who applied the old branch numbering. - UI interaction behavior is covered by component tests, but this PR does not include browser screenshots. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-class coding agent runtime. Exact model ID and context window are not exposed in this Paperclip run; tool use and local shell/code execution were enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta
GitHub
parent
014aa0eb2d
commit
a957394420
93 changed files with 10089 additions and 752 deletions
215
server/src/services/issue-thread-interactions.test.ts
Normal file
215
server/src/services/issue-thread-interactions.test.ts
Normal file
|
|
@ -0,0 +1,215 @@
|
|||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
const mockCreateChild = vi.fn();
|
||||
|
||||
vi.mock("./issues.js", () => ({
|
||||
issueService: () => ({
|
||||
createChild: mockCreateChild,
|
||||
}),
|
||||
}));
|
||||
|
||||
type SelectRow = Record<string, unknown>;
|
||||
|
||||
function createSelectChain(rows: SelectRow[]) {
|
||||
return {
|
||||
from() {
|
||||
return {
|
||||
where() {
|
||||
return {
|
||||
then(callback: (rows: SelectRow[]) => unknown) {
|
||||
return Promise.resolve(callback(rows));
|
||||
},
|
||||
};
|
||||
},
|
||||
};
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
function createFakeDb(args: {
|
||||
interactionRow: Record<string, unknown>;
|
||||
parentRows?: SelectRow[];
|
||||
}) {
|
||||
let interactionRow = { ...args.interactionRow };
|
||||
const issueTouches: Array<Record<string, unknown>> = [];
|
||||
const interactionUpdates: Array<Record<string, unknown>> = [];
|
||||
let selectCallCount = 0;
|
||||
|
||||
const db: any = {
|
||||
select: vi.fn(() => {
|
||||
selectCallCount += 1;
|
||||
return createSelectChain(selectCallCount === 1 ? [interactionRow] : (args.parentRows ?? []));
|
||||
}),
|
||||
update: vi.fn((table: unknown) => ({
|
||||
set(values: Record<string, unknown>) {
|
||||
return {
|
||||
where() {
|
||||
if ("status" in values || "result" in values || "resolvedAt" in values) {
|
||||
interactionUpdates.push(values);
|
||||
interactionRow = { ...interactionRow, ...values };
|
||||
return {
|
||||
returning: async () => [interactionRow],
|
||||
};
|
||||
}
|
||||
if ("updatedAt" in values) {
|
||||
issueTouches.push(values);
|
||||
return Promise.resolve(undefined);
|
||||
}
|
||||
throw new Error(`Unexpected update target: ${String(table)}`);
|
||||
},
|
||||
};
|
||||
},
|
||||
})),
|
||||
insert: vi.fn(),
|
||||
transaction: async (callback: (tx: typeof db) => Promise<void>) => callback(db),
|
||||
};
|
||||
|
||||
return {
|
||||
db,
|
||||
getInteractionRow: () => interactionRow,
|
||||
issueTouches,
|
||||
interactionUpdates,
|
||||
};
|
||||
}
|
||||
|
||||
describe("issueThreadInteractionService", () => {
|
||||
beforeEach(() => {
|
||||
vi.resetModules();
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
it("create reuses an existing interaction for the same idempotency key", async () => {
|
||||
const { issueThreadInteractionService } = await import("./issue-thread-interactions.js");
|
||||
|
||||
const existingRow = {
|
||||
id: "interaction-1",
|
||||
companyId: "company-1",
|
||||
issueId: "11111111-1111-4111-8111-111111111111",
|
||||
kind: "suggest_tasks",
|
||||
status: "pending",
|
||||
continuationPolicy: "wake_assignee",
|
||||
idempotencyKey: "run-1:suggest",
|
||||
sourceCommentId: null,
|
||||
sourceRunId: "22222222-2222-4222-8222-222222222222",
|
||||
title: "Break the work down",
|
||||
summary: "Created from the current agent run.",
|
||||
createdByAgentId: "agent-1",
|
||||
createdByUserId: null,
|
||||
resolvedByAgentId: null,
|
||||
resolvedByUserId: null,
|
||||
payload: {
|
||||
version: 1,
|
||||
tasks: [{ clientKey: "task-1", title: "One" }],
|
||||
},
|
||||
result: null,
|
||||
resolvedAt: null,
|
||||
createdAt: new Date("2026-04-20T10:00:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T10:00:00.000Z"),
|
||||
};
|
||||
|
||||
const db: any = {
|
||||
select: vi.fn(() => createSelectChain([existingRow])),
|
||||
insert: vi.fn(),
|
||||
update: vi.fn(),
|
||||
};
|
||||
|
||||
const svc = issueThreadInteractionService(db as never);
|
||||
const created = await svc.create({
|
||||
id: "11111111-1111-4111-8111-111111111111",
|
||||
companyId: "company-1",
|
||||
}, {
|
||||
kind: "suggest_tasks",
|
||||
idempotencyKey: "run-1:suggest",
|
||||
sourceRunId: "22222222-2222-4222-8222-222222222222",
|
||||
title: "Break the work down",
|
||||
summary: "Created from the current agent run.",
|
||||
continuationPolicy: "wake_assignee",
|
||||
payload: {
|
||||
version: 1,
|
||||
tasks: [{ clientKey: "task-1", title: "One" }],
|
||||
},
|
||||
}, {
|
||||
agentId: "agent-1",
|
||||
});
|
||||
|
||||
expect(created.id).toBe("interaction-1");
|
||||
expect(created.idempotencyKey).toBe("run-1:suggest");
|
||||
expect(db.insert).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("answerQuestions normalizes duplicate option ids and persists answered results", async () => {
|
||||
const { issueThreadInteractionService } = await import("./issue-thread-interactions.js");
|
||||
|
||||
const interactionRow = {
|
||||
id: "interaction-2",
|
||||
companyId: "company-1",
|
||||
issueId: "11111111-1111-4111-8111-111111111111",
|
||||
kind: "ask_user_questions",
|
||||
status: "pending",
|
||||
continuationPolicy: "wake_assignee",
|
||||
sourceCommentId: null,
|
||||
sourceRunId: null,
|
||||
title: null,
|
||||
summary: null,
|
||||
createdByAgentId: null,
|
||||
createdByUserId: "local-board",
|
||||
resolvedByAgentId: null,
|
||||
resolvedByUserId: null,
|
||||
payload: {
|
||||
version: 1,
|
||||
questions: [
|
||||
{
|
||||
id: "scope",
|
||||
prompt: "Pick one scope",
|
||||
selectionMode: "single",
|
||||
required: true,
|
||||
options: [
|
||||
{ id: "phase-1", label: "Phase 1" },
|
||||
{ id: "phase-2", label: "Phase 2" },
|
||||
],
|
||||
},
|
||||
{
|
||||
id: "extras",
|
||||
prompt: "Pick extras",
|
||||
selectionMode: "multi",
|
||||
options: [
|
||||
{ id: "tests", label: "Tests" },
|
||||
{ id: "docs", label: "Docs" },
|
||||
],
|
||||
},
|
||||
],
|
||||
},
|
||||
result: null,
|
||||
resolvedAt: null,
|
||||
createdAt: new Date("2026-04-20T10:00:00.000Z"),
|
||||
updatedAt: new Date("2026-04-20T10:00:00.000Z"),
|
||||
};
|
||||
const state = createFakeDb({ interactionRow });
|
||||
const svc = issueThreadInteractionService(state.db as never);
|
||||
|
||||
const result = await svc.answerQuestions({
|
||||
id: "11111111-1111-4111-8111-111111111111",
|
||||
companyId: "company-1",
|
||||
}, "interaction-2", {
|
||||
answers: [
|
||||
{ questionId: "scope", optionIds: ["phase-1"] },
|
||||
{ questionId: "extras", optionIds: ["docs", "tests", "docs"] },
|
||||
],
|
||||
summaryMarkdown: "Phase 1 with tests and docs.",
|
||||
}, {
|
||||
userId: "local-board",
|
||||
});
|
||||
|
||||
expect(result.status).toBe("answered");
|
||||
expect(result.result).toEqual({
|
||||
version: 1,
|
||||
answers: [
|
||||
{ questionId: "scope", optionIds: ["phase-1"] },
|
||||
{ questionId: "extras", optionIds: ["docs", "tests"] },
|
||||
],
|
||||
summaryMarkdown: "Phase 1 with tests and docs.",
|
||||
});
|
||||
expect(state.interactionUpdates).toHaveLength(1);
|
||||
expect(state.issueTouches).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue