ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-17 03:10:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

fix(ui): address final Greptile follow-up

Browse source 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
dotta 2026-04-02 12:21:35 -05:00
parent bd6d07d0b4
commit ad1ef6a8c6
3 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ui/src/lib/keyboardShortcuts.test.ts
View file

@ -33,6 +33,13 @@ describe("keyboardShortcuts helpers", () => {
expect(hasBlockingShortcutDialog(document.createElement("div"))).toBe(false);
});
it("ignores non-dialog elements that happen to be aria-modal", () => {
const root = document.createElement("div");
root.innerHTML = `<section aria-modal="true"></section>`;
expect(hasBlockingShortcutDialog(root)).toBe(false);
});
it("archives only the first clean y press", () => {
const button = document.createElement("button");

2
ui/src/lib/keyboardShortcuts.ts
View file

@ -19,7 +19,7 @@ export function isKeyboardShortcutTextInputTarget(target: EventTarget | null): b
}
export function hasBlockingShortcutDialog(root: ParentNode = document): boolean {
return !!root.querySelector("[role='dialog'], [aria-modal='true']");
return !!root.querySelector("[role='dialog'][aria-modal='true']");
}
export function isModifierOnlyKey(key: string): boolean {