From b1e457365b5ab2df0721b58417df2c70ef3e1168 Mon Sep 17 00:00:00 2001
From: Aron Prins <pwf.aron@gmail.com>
Date: Tue, 7 Apr 2026 10:55:32 +0200
Subject: [PATCH] fix: clean up orphaned .sql on compression failure and fix
 stale startup log

- backup-lib: delete uncompressed .sql file in catch block when gzip
  compression fails, preventing silent disk usage accumulation
- server: replace stale retentionDays scalar with retentionSource in
  startup log since retention is now read from DB on each backup tick
---
 packages/db/src/backup-lib.ts | 3 +++
 server/src/index.ts           | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/db/src/backup-lib.ts b/packages/db/src/backup-lib.ts
index 0fe70f13..e1e88724 100644
--- a/packages/db/src/backup-lib.ts
+++ b/packages/db/src/backup-lib.ts
@@ -763,6 +763,9 @@ export async function runDatabaseBackup(opts: RunDatabaseBackupOptions): Promise
     if (existsSync(backupFile)) {
       try { unlinkSync(backupFile); } catch { /* ignore */ }
     }
+    if (existsSync(sqlFile)) {
+      try { unlinkSync(sqlFile); } catch { /* ignore */ }
+    }
     throw error;
   } finally {
     await sql.end();
diff --git a/server/src/index.ts b/server/src/index.ts
index b63789a2..c3f4a8b1 100644
--- a/server/src/index.ts
+++ b/server/src/index.ts
@@ -670,7 +670,7 @@ export async function startServer(): Promise<StartedServer> {
     logger.info(
       {
         intervalMinutes: config.databaseBackupIntervalMinutes,
-        retentionDays: config.databaseBackupRetentionDays,
+        retentionSource: "instance-settings-db",
         backupDir: config.databaseBackupDir,
       },
       "Automatic database backups enabled",