ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-17 03:10:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

Improve issue approval visibility

Browse source 
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
dotta 2026-04-06 11:20:46 -05:00
parent 977e9f3e9a
commit bd0f56e523
4 changed files with 162 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

50
ui/src/components/ApprovalPayload.tsx
View file

@ -8,11 +8,26 @@ export const typeLabel: Record<string, string> = {
request_board_approval: "Board Approval",
};
function firstNonEmptyString(...values: unknown[]): string | null {
for (const value of values) {
if (typeof value === "string" && value.trim().length > 0) {
return value.trim();
}
}
return null;
}
/** Build a contextual label for an approval, e.g. "Hire Agent: Designer" */
export function approvalLabel(type: string, payload?: Record<string, unknown> | null): string {
const base = typeLabel[type] ?? type;
if (type === "hire_agent" && payload?.name) {
return `${base}: ${String(payload.name)}`;
const subject = firstNonEmptyString(
payload?.title,
payload?.name,
payload?.summary,
payload?.recommendedAction,
);
if (subject) {
return `${base}: ${subject}`;
}
return base;
}
@ -129,8 +144,39 @@ export function BudgetOverridePayload({ payload }: { payload: Record<string, unk
);
}
export function BoardApprovalPayload({ payload }: { payload: Record<string, unknown> }) {
return (
<div className="mt-3 space-y-2 text-sm">
<PayloadField label="Title" value={payload.title} />
{!!payload.summary && (
<div className="flex items-start gap-2">
<span className="text-muted-foreground w-20 sm:w-24 shrink-0 text-xs pt-0.5">Summary</span>
<span className="text-muted-foreground">{String(payload.summary)}</span>
</div>
)}
{!!payload.recommendedAction && (
<div className="rounded-md bg-muted/40 px-3 py-2 text-xs text-muted-foreground">
Recommended: {String(payload.recommendedAction)}
</div>
)}
{!!payload.nextActionOnApproval && (
<div className="flex items-start gap-2">
<span className="text-muted-foreground w-20 sm:w-24 shrink-0 text-xs pt-0.5">On approval</span>
<span>{String(payload.nextActionOnApproval)}</span>
</div>
)}
{!!payload.proposedComment && (
<div className="rounded-md bg-muted/40 px-3 py-2 text-xs text-muted-foreground whitespace-pre-wrap font-mono max-h-48 overflow-y-auto">
{String(payload.proposedComment)}
</div>
)}
</div>
);
}
export function ApprovalPayloadRenderer({ type, payload }: { type: string; payload: Record<string, unknown> }) {
if (type === "hire_agent") return <HireAgentPayload payload={payload} />;
if (type === "budget_override_required") return <BudgetOverridePayload payload={payload} />;
if (type === "request_board_approval") return <BoardApprovalPayload payload={payload} />;
return <CeoStrategyPayload payload={payload} />;
}