ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-19 12:10:37 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix signoff e2e for auto-checked out issues

Browse source
This commit is contained in:
Dotta 2026-04-12 20:43:50 -05:00
parent ab5eeca94e
commit be82a912b2
1 changed files with 28 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

28
tests/e2e/signoff-policy.spec.ts
View file

@ -42,6 +42,12 @@ interface TestContext {
issueIds: string[]; issueIds: string[];
} }
interface IssueRunLockState {
assigneeAgentId: string | null;
checkoutRunId: string | null;
executionRunId: string | null;
}
/** Create an authenticated APIRequestContext for an agent (token set, no run ID yet). */ /** Create an authenticated APIRequestContext for an agent (token set, no run ID yet). */
async function createAgentRequest(token: string): Promise<APIRequestContext> { async function createAgentRequest(token: string): Promise<APIRequestContext> {
return pwRequest.newContext({ return pwRequest.newContext({
@ -58,6 +64,17 @@ async function invokeHeartbeat(board: APIRequestContext, agentId: string): Promi
return run.id; return run.id;
} }
async function getIssueRunLockState(board: APIRequestContext, issueId: string): Promise<IssueRunLockState> {
const res = await board.get(`${BASE_URL}/api/issues/${issueId}`);
expect(res.ok()).toBe(true);
const issue = await res.json();
return {
assigneeAgentId: issue.assigneeAgentId ?? null,
checkoutRunId: issue.checkoutRunId ?? null,
executionRunId: issue.executionRunId ?? null,
};
}
/** PATCH an issue as an agent with a fresh heartbeat run ID. */ /** PATCH an issue as an agent with a fresh heartbeat run ID. */
async function agentPatch( async function agentPatch(
board: APIRequestContext, board: APIRequestContext,
@ -88,6 +105,17 @@ async function agentCheckoutAndPatch(
data: { agentId: agent.agentId, expectedStatuses }, data: { agentId: agent.agentId, expectedStatuses },
}); });
if (!checkoutRes.ok()) { if (!checkoutRes.ok()) {
if (checkoutRes.status() === 409) {
const issueRunLock = await getIssueRunLockState(board, issueId);
const lockedRunId = issueRunLock.checkoutRunId ?? issueRunLock.executionRunId;
const res = await agent.request.patch(`${BASE_URL}/api/issues/${issueId}`, {
headers: { "X-Paperclip-Run-Id": lockedRunId ?? runId },
data: patchData,
});
if (res.ok() && issueRunLock.assigneeAgentId === agent.agentId) {
return res;
}
}
// If agent checkout fails (e.g. run expired), fall back to board checkout // If agent checkout fails (e.g. run expired), fall back to board checkout
// then PATCH with the agent's identity // then PATCH with the agent's identity
const boardCheckout = await board.post(`${BASE_URL}/api/issues/${issueId}/checkout`, { const boardCheckout = await board.post(`${BASE_URL}/api/issues/${issueId}/checkout`, {