ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-15 02:20:38 +09:00
Code Issues Projects Releases Packages Wiki Activity

Fix shared workspace close semantics

Browse source 
Allow shared execution workspace sessions to be archived with warnings instead of hard-blocking on open linked issues, clear issue workspace links when those shared sessions are archived, and update the close dialog copy and coverage.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
dotta 2026-03-28 19:19:49 -05:00
parent 84d4c328f5
commit caa7550e9f
4 changed files with 32 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
server/src/__tests__/execution-workspaces-service.test.ts
View file

@ -148,7 +148,7 @@ describeEmbeddedPostgres("executionWorkspaceService.getCloseReadiness", () => {
await tempDb?.cleanup();
});
it("blocks close for shared workspaces that still have open linked issues", async () => {
it("allows archiving shared workspace sessions with warnings even when issues are still open", async () => {
const companyId = randomUUID();
const projectId = randomUUID();
const projectWorkspaceId = randomUUID();
@ -209,14 +209,15 @@ describeEmbeddedPostgres("executionWorkspaceService.getCloseReadiness", () => {
expect(readiness).toMatchObject({
workspaceId: executionWorkspaceId,
state: "blocked",
state: "ready_with_warnings",
isSharedWorkspace: true,
isProjectPrimaryWorkspace: true,
isDestructiveCloseAllowed: false,
isDestructiveCloseAllowed: true,
});
expect(readiness?.blockingReasons).toEqual(expect.arrayContaining([
"This workspace is still linked to an open issue.",
"Shared execution workspaces are project infrastructure and cannot be destructively closed.",
expect(readiness?.blockingReasons).toEqual([]);
expect(readiness?.warnings).toEqual(expect.arrayContaining([
"This workspace is still linked to an open issue. Archiving it will detach this shared workspace session from those issues, but keep the underlying project workspace available.",
"This shared workspace session points at project workspace infrastructure. Archiving it only removes the session record.",
]));
});