Merge pull request #1363 from amit221/fix/issue-1255

fix(issues): normalize HTML entities in @mention tokens before agent lookup
This commit is contained in:
Devin Foley 2026-03-24 20:19:47 -07:00 committed by GitHub
commit cbca599625
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 80 additions and 2 deletions

View file

@ -0,0 +1,41 @@
import { describe, expect, it } from "vitest";
import { normalizeAgentMentionToken } from "../services/issues.ts";
describe("normalizeAgentMentionToken", () => {
it("decodes hex numeric entities such as space ( )", () => {
expect(normalizeAgentMentionToken("Baba ")).toBe("Baba");
});
it("decodes decimal numeric entities", () => {
expect(normalizeAgentMentionToken("Baba ")).toBe("Baba");
});
it("decodes common named whitespace entities", () => {
expect(normalizeAgentMentionToken("Baba ")).toBe("Baba");
});
// Mid-token entity (review asked for this shape); we decode &→&, not strip to "Baba" (that broke M&M).
it("decodes a named entity in the middle of the token", () => {
expect(normalizeAgentMentionToken("Ba&ba")).toBe("Ba&ba");
});
it("decodes & so agent names with ampersands still match", () => {
expect(normalizeAgentMentionToken("M&M")).toBe("M&M");
});
it("decodes additional named entities used in rich text (e.g. ©)", () => {
expect(normalizeAgentMentionToken("Agent©Name")).toBe("Agent©Name");
});
it("leaves unknown semicolon-terminated named references unchanged", () => {
expect(normalizeAgentMentionToken("Baba&notarealentity;")).toBe("Baba&notarealentity;");
});
it("returns plain names unchanged", () => {
expect(normalizeAgentMentionToken("Baba")).toBe("Baba");
});
it("trims after decoding entities", () => {
expect(normalizeAgentMentionToken("Baba  ")).toBe("Baba");
});
});