mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 02:20:38 +09:00
Guard assigned backlog liveness (#5428)
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The issue graph and liveness recovery system decide whether assigned work is executable or parked > - Assigned issues created without an explicit status could silently land in backlog, making parents look blocked with no productive wake path > - The server, shared validators, recovery analysis, and UI all need to agree on that execution semantic > - This pull request makes assigned issue creation default to `todo`, flags assigned backlog blockers, and surfaces the state in the board > - The benefit is that parked assigned work becomes intentional and visible instead of creating silent liveness stalls ## What Changed - Adds contract tests for assigned issue creation defaults. - Defaults assigned issue creation to `todo` when status is omitted while preserving explicit `backlog` parking. - Exposes `resolveCreateIssueStatusDefault` through shared validators. - Teaches liveness/blocker attention paths to distinguish assigned backlog blockers. - Adds UI notices, row/header badges, and issue detail safeguards for assigned backlog blockers. - Adds Storybook fixtures and execution-semantics documentation for the assigned-backlog behavior. ## Verification - `pnpm run preflight:workspace-links && pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-assigned-backlog-contract-routes.test.ts server/src/__tests__/issue-blocker-attention.test.ts server/src/__tests__/issue-liveness.test.ts server/src/__tests__/heartbeat-issue-liveness-escalation.test.ts ui/src/components/IssueAssignedBacklogNotice.test.tsx ui/src/components/IssueRow.test.tsx` — 50 passed, 23 skipped. - Skipped tests were embedded Postgres suites on this host with the repo skip message: `Postgres init script exited with code null. Please check the logs for extra info. The data directory might already exist.` - Pairwise merge check against the issue-controls PR branch completed without conflicts via `git merge --no-commit --no-ff` in a temporary worktree. - Screenshots for assigned-backlog UI states: [light](docs/pr-screenshots/pr-5428/assigned-backlog-light.png), [dark](docs/pr-screenshots/pr-5428/assigned-backlog-dark.png). - Follow-up checks: `pnpm --filter /ui typecheck`; `pnpm --filter /mcp-server build`; `pnpm --filter /mcp-server test`; `pnpm exec vitest run packages/shared/src/validators/issue.test.ts`; focused UI component tests. - Remote PR checks on head `6300b3c`: policy, verify, serialized server shards 1/4-4/4, Canary Dry Run, e2e, Greptile Review, and Snyk all passed. ## Risks - Medium: changes status defaulting for assigned issue creation when the caller omits status. Explicit `backlog` remains supported, and server/shared tests cover both paths. - Medium: liveness classification changes can affect blocker attention labels; focused service and UI tests cover the new assigned-backlog state. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool-enabled Paperclip heartbeat environment. Context window and internal reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta
GitHub
parent
6f30003421
commit
e400315cbf
28 changed files with 1303 additions and 22 deletions
115
ui/src/components/IssueAssignedBacklogNotice.test.tsx
Normal file
115
ui/src/components/IssueAssignedBacklogNotice.test.tsx
Normal file
|
|
@ -0,0 +1,115 @@
|
|||
// @vitest-environment jsdom
|
||||
|
||||
import { act } from "react";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
|
||||
import type { Agent } from "@paperclipai/shared";
|
||||
import { IssueAssignedBacklogNotice } from "./IssueAssignedBacklogNotice";
|
||||
|
||||
(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
||||
|
||||
const baseAgent = {
|
||||
id: "agent-1",
|
||||
companyId: "co-1",
|
||||
name: "ClaudeCoder",
|
||||
role: "engineer",
|
||||
status: "active",
|
||||
} as unknown as Agent;
|
||||
|
||||
let container: HTMLDivElement;
|
||||
let root: ReturnType<typeof createRoot>;
|
||||
|
||||
beforeEach(() => {
|
||||
container = document.createElement("div");
|
||||
document.body.appendChild(container);
|
||||
root = createRoot(container);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
act(() => {
|
||||
root.unmount();
|
||||
});
|
||||
container.remove();
|
||||
});
|
||||
|
||||
describe("IssueAssignedBacklogNotice", () => {
|
||||
it("renders nothing when status is not backlog", () => {
|
||||
act(() => {
|
||||
root.render(
|
||||
<IssueAssignedBacklogNotice
|
||||
issueStatus="todo"
|
||||
assigneeAgent={baseAgent}
|
||||
assigneeUserId={null}
|
||||
/>,
|
||||
);
|
||||
});
|
||||
expect(container.querySelector('[data-testid="issue-assigned-backlog-notice"]')).toBeNull();
|
||||
});
|
||||
|
||||
it("renders nothing when there is no assignee", () => {
|
||||
act(() => {
|
||||
root.render(
|
||||
<IssueAssignedBacklogNotice
|
||||
issueStatus="backlog"
|
||||
assigneeAgent={null}
|
||||
assigneeUserId={null}
|
||||
/>,
|
||||
);
|
||||
});
|
||||
expect(container.querySelector('[data-testid="issue-assigned-backlog-notice"]')).toBeNull();
|
||||
});
|
||||
|
||||
it("warns when an agent is assigned and the issue is parked in backlog", () => {
|
||||
act(() => {
|
||||
root.render(
|
||||
<IssueAssignedBacklogNotice
|
||||
issueStatus="backlog"
|
||||
assigneeAgent={baseAgent}
|
||||
assigneeUserId={null}
|
||||
/>,
|
||||
);
|
||||
});
|
||||
const notice = container.querySelector('[data-testid="issue-assigned-backlog-notice"]');
|
||||
expect(notice).not.toBeNull();
|
||||
expect(notice?.textContent).toContain("Parked");
|
||||
expect(notice?.textContent).toContain("ClaudeCoder");
|
||||
});
|
||||
|
||||
it("calls onResume when the resume button is clicked", () => {
|
||||
const onResume = vi.fn();
|
||||
act(() => {
|
||||
root.render(
|
||||
<IssueAssignedBacklogNotice
|
||||
issueStatus="backlog"
|
||||
assigneeAgent={baseAgent}
|
||||
assigneeUserId={null}
|
||||
onResume={onResume}
|
||||
/>,
|
||||
);
|
||||
});
|
||||
const button = container.querySelector('[data-testid="issue-assigned-backlog-resume"]') as HTMLButtonElement | null;
|
||||
expect(button).not.toBeNull();
|
||||
act(() => {
|
||||
button?.click();
|
||||
});
|
||||
expect(onResume).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("disables the resume button while resuming", () => {
|
||||
act(() => {
|
||||
root.render(
|
||||
<IssueAssignedBacklogNotice
|
||||
issueStatus="backlog"
|
||||
assigneeAgent={baseAgent}
|
||||
assigneeUserId={null}
|
||||
onResume={() => undefined}
|
||||
resuming
|
||||
/>,
|
||||
);
|
||||
});
|
||||
const button = container.querySelector('[data-testid="issue-assigned-backlog-resume"]') as HTMLButtonElement | null;
|
||||
expect(button).not.toBeNull();
|
||||
expect(button?.disabled).toBe(true);
|
||||
expect(button?.textContent).toContain("Resuming");
|
||||
});
|
||||
});
|
||||
63
ui/src/components/IssueAssignedBacklogNotice.tsx
Normal file
63
ui/src/components/IssueAssignedBacklogNotice.tsx
Normal file
|
|
@ -0,0 +1,63 @@
|
|||
import { Flag } from "lucide-react";
|
||||
import type { Agent } from "@paperclipai/shared";
|
||||
import { Button } from "@/components/ui/button";
|
||||
|
||||
interface IssueAssignedBacklogNoticeProps {
|
||||
issueStatus: string;
|
||||
assigneeAgent: Agent | null;
|
||||
assigneeUserId?: string | null;
|
||||
onResume?: () => void;
|
||||
resuming?: boolean;
|
||||
}
|
||||
|
||||
export function IssueAssignedBacklogNotice({
|
||||
issueStatus,
|
||||
assigneeAgent,
|
||||
assigneeUserId,
|
||||
onResume,
|
||||
resuming,
|
||||
}: IssueAssignedBacklogNoticeProps) {
|
||||
if (issueStatus !== "backlog") return null;
|
||||
if (!assigneeAgent && !assigneeUserId) return null;
|
||||
|
||||
const assigneeLabel = assigneeAgent?.name ?? "the assignee";
|
||||
|
||||
return (
|
||||
<div
|
||||
data-testid="issue-assigned-backlog-notice"
|
||||
data-issue-status={issueStatus}
|
||||
className="mb-3 rounded-md border border-amber-300/70 bg-amber-50/90 px-3 py-2.5 text-sm text-amber-950 shadow-sm dark:border-amber-500/40 dark:bg-amber-500/10 dark:text-amber-100"
|
||||
>
|
||||
<div className="flex items-start gap-2">
|
||||
<Flag className="mt-0.5 h-4 w-4 shrink-0 text-amber-600 dark:text-amber-300" />
|
||||
<div className="min-w-0 flex-1 space-y-1.5">
|
||||
<p className="leading-5">
|
||||
<span className="font-medium">Parked</span> —{" "}
|
||||
<span className="font-medium">{assigneeLabel}</span> will not be woken until status changes to{" "}
|
||||
<code className="rounded bg-amber-100 px-1 py-0.5 text-[12px] dark:bg-amber-400/15">todo</code> or{" "}
|
||||
<code className="rounded bg-amber-100 px-1 py-0.5 text-[12px] dark:bg-amber-400/15">in_progress</code>.
|
||||
</p>
|
||||
{assigneeAgent ? (
|
||||
<p className="text-xs leading-5 text-amber-800 dark:text-amber-200">
|
||||
Comments still wake the assignee for questions or triage. Leave this parked only if the work is intentionally on hold.
|
||||
</p>
|
||||
) : null}
|
||||
{onResume ? (
|
||||
<div className="pt-0.5">
|
||||
<Button
|
||||
size="sm"
|
||||
variant="outline"
|
||||
className="h-7 border-amber-400/70 bg-background/80 text-amber-950 hover:bg-amber-100 dark:border-amber-500/40 dark:bg-background/40 dark:text-amber-100 dark:hover:bg-amber-500/15"
|
||||
onClick={onResume}
|
||||
disabled={resuming}
|
||||
data-testid="issue-assigned-backlog-resume"
|
||||
>
|
||||
{resuming ? "Resuming…" : "Resume now"}
|
||||
</Button>
|
||||
</div>
|
||||
) : null}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
|
@ -1,8 +1,9 @@
|
|||
import type { IssueBlockerAttention, IssueRelationIssueSummary, SuccessfulRunHandoffState } from "@paperclipai/shared";
|
||||
import { AlertTriangle } from "lucide-react";
|
||||
import { AlertTriangle, Flag } from "lucide-react";
|
||||
import { Link } from "@/lib/router";
|
||||
import { createIssueDetailPath } from "../lib/issueDetailBreadcrumb";
|
||||
import { IssueLinkQuicklook } from "./IssueLinkQuicklook";
|
||||
import { isAssignedBacklogBlocker } from "../lib/issue-blockers";
|
||||
|
||||
export function IssueBlockedNotice({
|
||||
issueStatus,
|
||||
|
|
@ -27,6 +28,24 @@ export function IssueBlockedNotice({
|
|||
.filter((blocker, index, all) => all.findIndex((candidate) => candidate.id === blocker.id) === index);
|
||||
|
||||
const isStalled = blockerAttention?.state === "stalled";
|
||||
const parkedBlockers = (() => {
|
||||
const seen = new Set<string>();
|
||||
const collected: IssueRelationIssueSummary[] = [];
|
||||
const sources: IssueRelationIssueSummary[] = [...blockers];
|
||||
for (const blocker of blockers) {
|
||||
for (const terminal of blocker.terminalBlockers ?? []) {
|
||||
sources.push(terminal);
|
||||
}
|
||||
}
|
||||
for (const blocker of sources) {
|
||||
if (!isAssignedBacklogBlocker(blocker)) continue;
|
||||
if (seen.has(blocker.id)) continue;
|
||||
seen.add(blocker.id);
|
||||
collected.push(blocker);
|
||||
}
|
||||
return collected;
|
||||
})();
|
||||
const showParkedRow = parkedBlockers.length > 0;
|
||||
const stalledLeafIdentifier =
|
||||
blockerAttention?.sampleStalledBlockerIdentifier ?? blockerAttention?.sampleBlockerIdentifier ?? null;
|
||||
const stalledLeafBlockers = (() => {
|
||||
|
|
@ -148,6 +167,18 @@ export function IssueBlockedNotice({
|
|||
{terminalBlockers.map(renderBlockerChip)}
|
||||
</div>
|
||||
) : null}
|
||||
{showParkedRow ? (
|
||||
<div
|
||||
data-testid="issue-blocked-notice-parked-row"
|
||||
className="flex flex-wrap items-center gap-1.5 pt-0.5"
|
||||
>
|
||||
<span className="inline-flex items-center gap-1 text-xs font-medium text-amber-800 dark:text-amber-200">
|
||||
<Flag className="h-3 w-3" aria-hidden />
|
||||
Blocked by parked work
|
||||
</span>
|
||||
{parkedBlockers.map(renderBlockerChip)}
|
||||
</div>
|
||||
) : null}
|
||||
</>
|
||||
) : null}
|
||||
</div>
|
||||
|
|
|
|||
|
|
@ -133,6 +133,7 @@ import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover
|
|||
import { Textarea } from "@/components/ui/textarea";
|
||||
import { AlertTriangle, ArrowRight, Brain, Check, ChevronDown, ClipboardList, Copy, Hammer, Loader2, MoreHorizontal, Paperclip, PauseCircle, Search, Square, ThumbsDown, ThumbsUp } from "lucide-react";
|
||||
import { IssueBlockedNotice } from "./IssueBlockedNotice";
|
||||
import { IssueAssignedBacklogNotice } from "./IssueAssignedBacklogNotice";
|
||||
|
||||
interface IssueChatMessageContext {
|
||||
feedbackDataSharingPreference: FeedbackDataSharingPreference;
|
||||
|
|
@ -296,6 +297,9 @@ interface IssueChatThreadProps {
|
|||
blockedBy?: IssueRelationIssueSummary[];
|
||||
blockerAttention?: IssueBlockerAttention | null;
|
||||
successfulRunHandoff?: SuccessfulRunHandoffState | null;
|
||||
assigneeUserId?: string | null;
|
||||
onResumeFromBacklog?: () => Promise<void> | void;
|
||||
resumeFromBacklogPending?: boolean;
|
||||
companyId?: string | null;
|
||||
projectId?: string | null;
|
||||
issueStatus?: string;
|
||||
|
|
@ -3650,6 +3654,9 @@ export function IssueChatThread({
|
|||
issueWorkMode,
|
||||
onWorkModeChange,
|
||||
onRefreshLatestComments,
|
||||
assigneeUserId = null,
|
||||
onResumeFromBacklog,
|
||||
resumeFromBacklogPending = false,
|
||||
}: IssueChatThreadProps) {
|
||||
const location = useLocation();
|
||||
const lastScrolledHashRef = useRef<string | null>(null);
|
||||
|
|
@ -4230,6 +4237,13 @@ export function IssueChatThread({
|
|||
)}
|
||||
{showComposer ? (
|
||||
<div data-testid="issue-chat-thread-notices" className="space-y-2">
|
||||
<IssueAssignedBacklogNotice
|
||||
issueStatus={issueStatus ?? ""}
|
||||
assigneeAgent={assignedAgent}
|
||||
assigneeUserId={assigneeUserId}
|
||||
onResume={onResumeFromBacklog}
|
||||
resuming={resumeFromBacklogPending}
|
||||
/>
|
||||
<IssueBlockedNotice
|
||||
issueStatus={issueStatus}
|
||||
blockers={unresolvedBlockers}
|
||||
|
|
|
|||
|
|
@ -258,4 +258,60 @@ describe("IssueRow", () => {
|
|||
root.unmount();
|
||||
});
|
||||
});
|
||||
|
||||
it("flags rows blocked by an assigned-backlog leaf with a parked-work badge", () => {
|
||||
const root = createRoot(container);
|
||||
const issue = createIssue({
|
||||
blockedBy: [
|
||||
{
|
||||
id: "blocker-1",
|
||||
identifier: "PAP-2",
|
||||
title: "Parked child",
|
||||
status: "backlog",
|
||||
priority: "high",
|
||||
assigneeAgentId: "agent-99",
|
||||
assigneeUserId: null,
|
||||
},
|
||||
],
|
||||
});
|
||||
|
||||
act(() => {
|
||||
root.render(<IssueRow issue={issue} />);
|
||||
});
|
||||
|
||||
const badges = container.querySelectorAll('[data-testid="issue-row-parked-blocker"]');
|
||||
expect(badges.length).toBeGreaterThan(0);
|
||||
expect(badges[0]?.textContent).toContain("Blocked by parked work");
|
||||
|
||||
act(() => {
|
||||
root.unmount();
|
||||
});
|
||||
});
|
||||
|
||||
it("does not show the parked-work badge when assigned blocker is not in backlog", () => {
|
||||
const root = createRoot(container);
|
||||
const issue = createIssue({
|
||||
blockedBy: [
|
||||
{
|
||||
id: "blocker-1",
|
||||
identifier: "PAP-2",
|
||||
title: "Active child",
|
||||
status: "in_progress",
|
||||
priority: "high",
|
||||
assigneeAgentId: "agent-99",
|
||||
assigneeUserId: null,
|
||||
},
|
||||
],
|
||||
});
|
||||
|
||||
act(() => {
|
||||
root.render(<IssueRow issue={issue} />);
|
||||
});
|
||||
|
||||
expect(container.querySelector('[data-testid="issue-row-parked-blocker"]')).toBeNull();
|
||||
|
||||
act(() => {
|
||||
root.unmount();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
import type { ReactNode } from "react";
|
||||
import type { Issue } from "@paperclipai/shared";
|
||||
import { Link } from "@/lib/router";
|
||||
import { Eye, X } from "lucide-react";
|
||||
import { Eye, Flag, X } from "lucide-react";
|
||||
import {
|
||||
createIssueDetailPath,
|
||||
rememberIssueDetailLocationState,
|
||||
|
|
@ -10,6 +10,7 @@ import {
|
|||
import { cn } from "../lib/utils";
|
||||
import { StatusIcon } from "./StatusIcon";
|
||||
import { productivityReviewTriggerLabel } from "./ProductivityReviewBadge";
|
||||
import { hasAssignedBacklogBlocker } from "../lib/issue-blockers";
|
||||
|
||||
type UnreadState = "hidden" | "visible" | "fading";
|
||||
|
||||
|
|
@ -91,6 +92,16 @@ export function IssueRow({
|
|||
Planning
|
||||
</span>
|
||||
) : null;
|
||||
const parkedBlockerIndicator = hasAssignedBacklogBlocker(issue.blockedBy) ? (
|
||||
<span
|
||||
data-testid="issue-row-parked-blocker"
|
||||
className="ml-1.5 inline-flex shrink-0 items-center gap-0.5 rounded-full border border-amber-500/60 bg-amber-500/15 px-2 py-0.5 text-[10px] font-medium text-amber-700 dark:text-amber-300"
|
||||
title="Blocked by parked work — at least one assigned blocker is in backlog and will not wake its assignee."
|
||||
>
|
||||
<Flag className="h-2.5 w-2.5" aria-hidden />
|
||||
Blocked by parked work
|
||||
</span>
|
||||
) : null;
|
||||
|
||||
return (
|
||||
<Link
|
||||
|
|
@ -113,6 +124,7 @@ export function IssueRow({
|
|||
{mobileLeading ?? <StatusIcon status={issue.status} blockerAttention={issue.blockerAttention} className={selectedStatusClass} />}
|
||||
{productivityReviewIndicator}
|
||||
{planningModeIndicator}
|
||||
{parkedBlockerIndicator}
|
||||
</span>
|
||||
<span className="flex min-w-0 flex-1 flex-col gap-1 sm:contents">
|
||||
<span className={cn("line-clamp-2 text-sm sm:order-2 sm:min-w-0 sm:flex-1 sm:truncate sm:line-clamp-none", titleClassName)}>
|
||||
|
|
@ -138,6 +150,7 @@ export function IssueRow({
|
|||
{identifier}
|
||||
</span>
|
||||
{planningModeIndicator}
|
||||
{parkedBlockerIndicator}
|
||||
</>
|
||||
)}
|
||||
{mobileMeta ? (
|
||||
|
|
|
|||
|
|
@ -54,6 +54,7 @@ import {
|
|||
Calendar,
|
||||
Paperclip,
|
||||
FileText,
|
||||
Flag,
|
||||
Loader2,
|
||||
ListTree,
|
||||
X,
|
||||
|
|
@ -218,9 +219,19 @@ function formatFileSize(file: File) {
|
|||
return `${(file.size / (1024 * 1024)).toFixed(1)} MB`;
|
||||
}
|
||||
|
||||
const statuses = [
|
||||
{ value: "backlog", label: "Backlog", color: issueStatusText.backlog ?? issueStatusTextDefault },
|
||||
{ value: "todo", label: "Todo", color: issueStatusText.todo ?? issueStatusTextDefault },
|
||||
const statuses: ReadonlyArray<{ value: string; label: string; color: string; description?: string }> = [
|
||||
{
|
||||
value: "backlog",
|
||||
label: "Backlog",
|
||||
color: issueStatusText.backlog ?? issueStatusTextDefault,
|
||||
description: "Parked — assignee will not be woken",
|
||||
},
|
||||
{
|
||||
value: "todo",
|
||||
label: "Todo",
|
||||
color: issueStatusText.todo ?? issueStatusTextDefault,
|
||||
description: "Executable — assignee will be woken",
|
||||
},
|
||||
{ value: "in_progress", label: "In Progress", color: issueStatusText.in_progress ?? issueStatusTextDefault },
|
||||
{ value: "in_review", label: "In Review", color: issueStatusText.in_review ?? issueStatusTextDefault },
|
||||
{ value: "done", label: "Done", color: issueStatusText.done ?? issueStatusTextDefault },
|
||||
|
|
@ -1337,6 +1348,10 @@ export function NewIssueDialog() {
|
|||
trackRecentAssignee(nextAssignee.assigneeAgentId);
|
||||
}
|
||||
setAssigneeValue(value);
|
||||
const hasAssignee = Boolean(nextAssignee.assigneeAgentId || nextAssignee.assigneeUserId);
|
||||
if (hasAssignee && status === "backlog") {
|
||||
setStatus("todo");
|
||||
}
|
||||
}}
|
||||
onConfirm={() => {
|
||||
if (projectId) {
|
||||
|
|
@ -1828,18 +1843,23 @@ export function NewIssueDialog() {
|
|||
{currentStatus.label}
|
||||
</button>
|
||||
</PopoverTrigger>
|
||||
<PopoverContent className="w-36 p-1" align="start">
|
||||
<PopoverContent className="w-56 p-1" align="start">
|
||||
{statuses.map((s) => (
|
||||
<button
|
||||
key={s.value}
|
||||
className={cn(
|
||||
"flex items-center gap-2 w-full px-2 py-1.5 text-xs rounded hover:bg-accent/50",
|
||||
"flex w-full items-start gap-2 px-2 py-1.5 text-xs rounded hover:bg-accent/50",
|
||||
s.value === status && "bg-accent"
|
||||
)}
|
||||
onClick={() => { setStatus(s.value); setStatusOpen(false); }}
|
||||
>
|
||||
<CircleDot className={cn("h-3 w-3", s.color)} />
|
||||
{s.label}
|
||||
<CircleDot className={cn("h-3 w-3 mt-0.5 shrink-0", s.color)} />
|
||||
<span className="flex flex-col text-left leading-tight">
|
||||
<span>{s.label}</span>
|
||||
{s.description ? (
|
||||
<span className="text-[10px] text-muted-foreground">{s.description}</span>
|
||||
) : null}
|
||||
</span>
|
||||
</button>
|
||||
))}
|
||||
</PopoverContent>
|
||||
|
|
@ -1964,6 +1984,18 @@ export function NewIssueDialog() {
|
|||
</Popover>
|
||||
</div>
|
||||
|
||||
{assigneeValue && status === "backlog" ? (
|
||||
<div
|
||||
data-testid="new-issue-assigned-backlog-note"
|
||||
className="mx-4 mb-2 flex items-start gap-2 rounded-md border border-amber-300/70 bg-amber-50/90 px-3 py-2 text-xs text-amber-900 dark:border-amber-500/40 dark:bg-amber-500/10 dark:text-amber-100"
|
||||
>
|
||||
<Flag className="mt-0.5 h-3.5 w-3.5 shrink-0 text-amber-600 dark:text-amber-300" />
|
||||
<span className="leading-snug">
|
||||
Assigning implies executable intent — leave status as <span className="font-medium">Backlog</span> only to deliberately park this. The assignee will not be woken until status moves to <span className="font-medium">Todo</span> or <span className="font-medium">In Progress</span>.
|
||||
</span>
|
||||
</div>
|
||||
) : null}
|
||||
|
||||
{/* Footer */}
|
||||
<div className="flex items-center justify-between px-4 py-2.5 border-t border-border shrink-0">
|
||||
<Button
|
||||
|
|
|
|||
16
ui/src/lib/issue-blockers.ts
Normal file
16
ui/src/lib/issue-blockers.ts
Normal file
|
|
@ -0,0 +1,16 @@
|
|||
import type { IssueRelationIssueSummary } from "@paperclipai/shared";
|
||||
|
||||
export function isAssignedBacklogBlocker(blocker: IssueRelationIssueSummary): boolean {
|
||||
return blocker.status === "backlog" && Boolean(blocker.assigneeAgentId);
|
||||
}
|
||||
|
||||
export function hasAssignedBacklogBlocker(
|
||||
blockers: IssueRelationIssueSummary[] | undefined | null,
|
||||
): boolean {
|
||||
if (!blockers || blockers.length === 0) return false;
|
||||
return blockers.some((blocker) => {
|
||||
if (isAssignedBacklogBlocker(blocker)) return true;
|
||||
if (blocker.terminalBlockers?.some(isAssignedBacklogBlocker)) return true;
|
||||
return false;
|
||||
});
|
||||
}
|
||||
|
|
@ -110,6 +110,7 @@ import {
|
|||
SUCCESSFUL_RUN_HANDOFF_REQUIRED_ACTION,
|
||||
successfulRunHandoffActivityTone,
|
||||
} from "../lib/successful-run-handoff";
|
||||
import { hasAssignedBacklogBlocker } from "../lib/issue-blockers";
|
||||
import {
|
||||
Activity as ActivityIcon,
|
||||
AlertTriangle,
|
||||
|
|
@ -120,6 +121,7 @@ import {
|
|||
Copy,
|
||||
Eye,
|
||||
EyeOff,
|
||||
Flag,
|
||||
Hexagon,
|
||||
ListTree,
|
||||
MessageSquare,
|
||||
|
|
@ -644,6 +646,9 @@ type IssueDetailChatTabProps = {
|
|||
answers: AskUserQuestionsAnswer[],
|
||||
) => Promise<void>;
|
||||
onCancelInteraction: (interaction: AskUserQuestionsInteraction) => Promise<void>;
|
||||
assigneeUserId: string | null;
|
||||
onResumeFromBacklog?: () => Promise<void> | void;
|
||||
resumeFromBacklogPending?: boolean;
|
||||
};
|
||||
|
||||
const IssueDetailChatTab = memo(function IssueDetailChatTab({
|
||||
|
|
@ -694,6 +699,9 @@ const IssueDetailChatTab = memo(function IssueDetailChatTab({
|
|||
onRejectInteraction,
|
||||
onSubmitInteractionAnswers,
|
||||
onCancelInteraction,
|
||||
assigneeUserId,
|
||||
onResumeFromBacklog,
|
||||
resumeFromBacklogPending,
|
||||
}: IssueDetailChatTabProps) {
|
||||
const { data: activity } = useQuery({
|
||||
queryKey: queryKeys.issues.activity(issueId),
|
||||
|
|
@ -901,6 +909,9 @@ const IssueDetailChatTab = memo(function IssueDetailChatTab({
|
|||
: undefined}
|
||||
onImageClick={onImageClick}
|
||||
onRefreshLatestComments={onRefreshLatestComments}
|
||||
assigneeUserId={assigneeUserId}
|
||||
onResumeFromBacklog={onResumeFromBacklog}
|
||||
resumeFromBacklogPending={resumeFromBacklogPending}
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
|
|
@ -2894,6 +2905,10 @@ export function IssueDetail() {
|
|||
const handleCancelInteraction = useCallback(async (interaction: AskUserQuestionsInteraction) => {
|
||||
await cancelInteraction.mutateAsync({ interaction });
|
||||
}, [cancelInteraction]);
|
||||
const canResumeFromBacklog = issue?.status === "backlog" && Boolean(issue.assigneeAgentId || issue.assigneeUserId);
|
||||
const handleResumeFromBacklog = useCallback(async () => {
|
||||
await updateIssue.mutateAsync({ status: "todo" });
|
||||
}, [updateIssue.mutateAsync]);
|
||||
|
||||
const treePreviewAffectedIssues = useMemo(
|
||||
() => (treeControlPreview?.issues ?? []).filter((candidate) => !candidate.skipped),
|
||||
|
|
@ -3240,6 +3255,17 @@ export function IssueDetail() {
|
|||
</span>
|
||||
) : null}
|
||||
|
||||
{hasAssignedBacklogBlocker(issue.blockedBy) ? (
|
||||
<span
|
||||
data-testid="issue-detail-parked-blocker"
|
||||
className="inline-flex items-center gap-1 rounded-full border border-amber-500/60 bg-amber-500/15 px-2 py-0.5 text-[10px] font-medium text-amber-700 dark:text-amber-300 shrink-0"
|
||||
title="Blocked by parked work — at least one assigned blocker is in backlog and will not wake its assignee."
|
||||
>
|
||||
<Flag className="h-3 w-3" />
|
||||
Blocked by parked work
|
||||
</span>
|
||||
) : null}
|
||||
|
||||
{issue.projectId ? (
|
||||
<Link
|
||||
to={`/projects/${issue.projectId}`}
|
||||
|
|
@ -3805,6 +3831,11 @@ export function IssueDetail() {
|
|||
onRejectInteraction={handleRejectInteraction}
|
||||
onSubmitInteractionAnswers={handleSubmitInteractionAnswers}
|
||||
onCancelInteraction={handleCancelInteraction}
|
||||
assigneeUserId={issue.assigneeUserId ?? null}
|
||||
onResumeFromBacklog={canResumeFromBacklog ? handleResumeFromBacklog : undefined}
|
||||
resumeFromBacklogPending={
|
||||
updateIssue.isPending && updateIssue.variables?.status === "todo"
|
||||
}
|
||||
/>
|
||||
) : null}
|
||||
</TabsContent>
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue