mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-17 19:20:39 +09:00
Render rich issue attachment previews
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
parent
96feaa331a
commit
e86d000c7b
6 changed files with 640 additions and 132 deletions
190
ui/src/components/IssueAttachmentsSection.test.tsx
Normal file
190
ui/src/components/IssueAttachmentsSection.test.tsx
Normal file
|
|
@ -0,0 +1,190 @@
|
|||
// @vitest-environment jsdom
|
||||
|
||||
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
||||
import type { IssueAttachment } from "@paperclipai/shared";
|
||||
import { act, type ComponentProps, type ReactNode } from "react";
|
||||
import { createRoot, type Root } from "react-dom/client";
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { IssueAttachmentsSection } from "./IssueAttachmentsSection";
|
||||
|
||||
vi.mock("./MarkdownBody", () => ({
|
||||
MarkdownBody: ({ children, className }: { children: string; className?: string }) => (
|
||||
<div className={className} data-testid="markdown-body">{children}</div>
|
||||
),
|
||||
}));
|
||||
|
||||
vi.mock("./FoldCurtain", () => ({
|
||||
FoldCurtain: ({ children }: { children?: ReactNode }) => <div data-testid="fold-curtain">{children}</div>,
|
||||
}));
|
||||
|
||||
vi.mock("@/components/ui/button", () => ({
|
||||
Button: ({
|
||||
asChild,
|
||||
children,
|
||||
onClick,
|
||||
type = "button",
|
||||
...props
|
||||
}: ComponentProps<"button"> & { asChild?: boolean }) => {
|
||||
if (asChild) return <>{children}</>;
|
||||
return <button type={type} onClick={onClick} {...props}>{children}</button>;
|
||||
},
|
||||
}));
|
||||
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
||||
|
||||
function makeAttachment(overrides: Partial<IssueAttachment> = {}): IssueAttachment {
|
||||
return {
|
||||
id: "attachment-1",
|
||||
companyId: "company-1",
|
||||
issueId: "issue-1",
|
||||
issueCommentId: null,
|
||||
assetId: "asset-1",
|
||||
provider: "local_disk",
|
||||
objectKey: "attachments/attachment-1",
|
||||
contentType: "text/plain",
|
||||
byteSize: 1024,
|
||||
sha256: "sha",
|
||||
originalFilename: "notes.txt",
|
||||
createdByAgentId: null,
|
||||
createdByUserId: "user-1",
|
||||
createdAt: new Date("2026-06-01T00:00:00.000Z"),
|
||||
updatedAt: new Date("2026-06-01T00:00:00.000Z"),
|
||||
contentPath: "/api/attachments/attachment-1/content",
|
||||
openPath: "/api/attachments/attachment-1/content",
|
||||
downloadPath: "/api/attachments/attachment-1/content?download=1",
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
async function flushReact() {
|
||||
await act(async () => {
|
||||
await Promise.resolve();
|
||||
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
||||
});
|
||||
}
|
||||
|
||||
describe("IssueAttachmentsSection", () => {
|
||||
let container: HTMLDivElement;
|
||||
let root: Root;
|
||||
let queryClient: QueryClient;
|
||||
let fetchSpy: ReturnType<typeof vi.fn>;
|
||||
|
||||
beforeEach(() => {
|
||||
container = document.createElement("div");
|
||||
document.body.appendChild(container);
|
||||
root = createRoot(container);
|
||||
queryClient = new QueryClient({
|
||||
defaultOptions: {
|
||||
queries: { retry: false },
|
||||
},
|
||||
});
|
||||
fetchSpy = vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
text: () => Promise.resolve("# Imported plan\n\n- Use the document renderer"),
|
||||
});
|
||||
vi.stubGlobal("fetch", fetchSpy);
|
||||
});
|
||||
|
||||
afterEach(async () => {
|
||||
await act(async () => {
|
||||
root.unmount();
|
||||
});
|
||||
queryClient.clear();
|
||||
container.remove();
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
it("renders markdown attachments with the document markdown presentation", async () => {
|
||||
const attachment = makeAttachment({
|
||||
id: "markdown-attachment",
|
||||
originalFilename: "plan.md",
|
||||
contentType: "text/plain",
|
||||
contentPath: "/api/attachments/markdown-attachment/content",
|
||||
});
|
||||
|
||||
await act(async () => {
|
||||
root.render(
|
||||
<QueryClientProvider client={queryClient}>
|
||||
<IssueAttachmentsSection
|
||||
attachments={[attachment]}
|
||||
onDelete={vi.fn()}
|
||||
onImageClick={vi.fn()}
|
||||
/>
|
||||
</QueryClientProvider>,
|
||||
);
|
||||
});
|
||||
await flushReact();
|
||||
|
||||
expect(fetchSpy).toHaveBeenCalledWith(
|
||||
"/api/attachments/markdown-attachment/content",
|
||||
expect.objectContaining({
|
||||
headers: expect.objectContaining({ Accept: expect.stringContaining("text/markdown") }),
|
||||
}),
|
||||
);
|
||||
expect(container.querySelector('[data-testid="fold-curtain"]')).toBeTruthy();
|
||||
const markdownBody = container.querySelector('[data-testid="markdown-body"]');
|
||||
expect(markdownBody?.textContent).toContain("Imported plan");
|
||||
expect(markdownBody?.className).toContain("paperclip-edit-in-place-content");
|
||||
});
|
||||
|
||||
it("renders video attachments through the same player used for artifact outputs", async () => {
|
||||
const attachment = makeAttachment({
|
||||
id: "video-attachment",
|
||||
originalFilename: "demo.webm",
|
||||
contentType: "video/webm",
|
||||
contentPath: "/api/attachments/video-attachment/content",
|
||||
});
|
||||
|
||||
await act(async () => {
|
||||
root.render(
|
||||
<QueryClientProvider client={queryClient}>
|
||||
<IssueAttachmentsSection
|
||||
attachments={[attachment]}
|
||||
onDelete={vi.fn()}
|
||||
onImageClick={vi.fn()}
|
||||
/>
|
||||
</QueryClientProvider>,
|
||||
);
|
||||
});
|
||||
await flushReact();
|
||||
|
||||
const video = container.querySelector("video");
|
||||
expect(video?.getAttribute("src")).toBe("/api/attachments/video-attachment/content");
|
||||
expect(video?.getAttribute("controls")).not.toBeNull();
|
||||
expect(fetchSpy).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("keeps generic attachments as compact file rows with open and download actions", async () => {
|
||||
const attachment = makeAttachment({
|
||||
id: "pdf-attachment",
|
||||
originalFilename: "report.pdf",
|
||||
contentType: "application/pdf",
|
||||
contentPath: "/api/attachments/pdf-attachment/content",
|
||||
openPath: "/api/attachments/pdf-attachment/content",
|
||||
downloadPath: "/api/attachments/pdf-attachment/content?download=1",
|
||||
});
|
||||
|
||||
await act(async () => {
|
||||
root.render(
|
||||
<QueryClientProvider client={queryClient}>
|
||||
<IssueAttachmentsSection
|
||||
attachments={[attachment]}
|
||||
onDelete={vi.fn()}
|
||||
onImageClick={vi.fn()}
|
||||
/>
|
||||
</QueryClientProvider>,
|
||||
);
|
||||
});
|
||||
await flushReact();
|
||||
|
||||
expect(container.textContent).toContain("report.pdf");
|
||||
expect(container.textContent).toContain("application/pdf");
|
||||
expect(container.querySelector('a[aria-label="Open report.pdf"]')?.getAttribute("href")).toBe(
|
||||
"/api/attachments/pdf-attachment/content",
|
||||
);
|
||||
expect(container.querySelector('a[aria-label="Download report.pdf"]')?.getAttribute("href")).toBe(
|
||||
"/api/attachments/pdf-attachment/content?download=1",
|
||||
);
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue