mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-16 02:40:39 +09:00
[codex] UI and dev ops quality-of-life (#6384)
## Thinking Path > - Paperclip operators spend most of their time scanning the board, inbox, sidebar, and local dev status surfaces > - Small UI and dev-ops frictions make repeated operator workflows feel slower than they need to be > - The working branch contained several independent quality-of-life improvements mixed with larger cloud work > - Grouping these smaller UI/dev-ops changes together keeps review overhead reasonable without merging them into feature PRs > - This pull request collects the operator-facing QoL polish into one standalone branch > - The benefit is a cleaner board navigation and local dev recovery experience without depending on cloud upstream sync ## What Changed - Relaxed forced 44px touch targets for small inline widgets. - Fixed mobile mention menu scrolling and sidebar spacing on touch/mobile layouts. - Synced inbox hover state with j/k selection. - Moved plugin sidebar entries into the Work section. - Added manual dev-server restart action/banner behavior. - Logged plugin bridge 502 causes for better diagnosis. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `pnpm --filter @paperclipai/plugin-sdk build` - `pnpm exec vitest run ui/src/components/MarkdownEditor.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarProjects.test.tsx ui/src/pages/Inbox.test.tsx ui/src/components/DevRestartBanner.test.tsx server/src/__tests__/dev-server-status.test.ts server/src/__tests__/health-dev-server-token.test.ts server/src/__tests__/plugin-routes-authz.test.ts` initially failed only because plugin SDK `dist` was not built in the fresh worktree. - Rerun after build: `pnpm exec vitest run server/src/__tests__/plugin-routes-authz.test.ts` passed. - The remaining targeted UI/dev-server tests passed on the first post-install run. ## Visual Evidence - Sidebar layout and plugin Work section:  - Inbox/task row selection and hover-state surface:  - Dev restart banner desktop:  - Dev restart banner mobile:  ## Risks - Mostly UI/dev ergonomics with low data risk. - Sidebar and inbox changes touch frequently used navigation surfaces, so visual review on desktop/mobile is still useful. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent with local shell/git/tool use. Exact hosted model ID and context-window size are not exposed by the local Paperclip adapter runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Dotta
GitHub
parent
43c5bb81b6
commit
f257530537
29 changed files with 870 additions and 45 deletions
|
|
@ -4,7 +4,7 @@ import type { Db } from "@paperclipai/db";
|
|||
import { and, count, eq, gt, inArray, isNull, sql } from "drizzle-orm";
|
||||
import { heartbeatRuns, instanceUserRoles, invites } from "@paperclipai/db";
|
||||
import type { DeploymentExposure, DeploymentMode } from "@paperclipai/shared";
|
||||
import { readPersistedDevServerStatus, toDevServerHealthStatus } from "../dev-server-status.js";
|
||||
import { readPersistedDevServerStatus, toDevServerHealthStatus, writeDevServerRestartRequest } from "../dev-server-status.js";
|
||||
import { logger } from "../middleware/logger.js";
|
||||
import { instanceSettingsService } from "../services/instance-settings.js";
|
||||
import { serverVersion } from "../version.js";
|
||||
|
|
@ -44,6 +44,40 @@ export function healthRoutes(
|
|||
) {
|
||||
const router = Router();
|
||||
|
||||
router.post("/dev-server/restart", async (req, res) => {
|
||||
const actorType = "actor" in req ? req.actor?.type : null;
|
||||
if (opts.deploymentMode === "authenticated" && actorType !== "board") {
|
||||
res.status(403).json({ error: "board_access_required" });
|
||||
return;
|
||||
}
|
||||
|
||||
const persistedDevServerStatus = readPersistedDevServerStatus();
|
||||
if (!persistedDevServerStatus) {
|
||||
res.status(404).json({ error: "dev_server_supervisor_unavailable" });
|
||||
return;
|
||||
}
|
||||
|
||||
const restartRequired =
|
||||
persistedDevServerStatus.dirty ||
|
||||
persistedDevServerStatus.changedPathCount > 0 ||
|
||||
persistedDevServerStatus.pendingMigrations.length > 0;
|
||||
if (!restartRequired) {
|
||||
res.status(409).json({ error: "restart_not_required" });
|
||||
return;
|
||||
}
|
||||
|
||||
const written = writeDevServerRestartRequest({
|
||||
requestedAt: new Date().toISOString(),
|
||||
reason: "manual_restart_now",
|
||||
});
|
||||
if (!written) {
|
||||
res.status(404).json({ error: "dev_server_supervisor_unavailable" });
|
||||
return;
|
||||
}
|
||||
|
||||
res.status(202).json({ status: "restart_requested" });
|
||||
});
|
||||
|
||||
router.get("/", async (req, res) => {
|
||||
const actorType = "actor" in req ? req.actor?.type : null;
|
||||
const exposeFullDetails = shouldExposeFullHealthDetails(
|
||||
|
|
|
|||
|
|
@ -1021,6 +1021,34 @@ export function pluginRoutes(
|
|||
};
|
||||
}
|
||||
|
||||
function attachPluginBridgeErrorContext(
|
||||
req: Request,
|
||||
res: Response,
|
||||
err: unknown,
|
||||
bridgeError: PluginBridgeErrorResponse,
|
||||
metadata: Record<string, unknown>,
|
||||
): void {
|
||||
const rootError = err instanceof Error ? err : new Error(String(err));
|
||||
(res as any).__errorContext = {
|
||||
error: {
|
||||
message: bridgeError.message,
|
||||
stack: rootError.stack,
|
||||
name: rootError.name,
|
||||
details: {
|
||||
...metadata,
|
||||
bridgeCode: bridgeError.code,
|
||||
bridgeDetails: bridgeError.details,
|
||||
},
|
||||
},
|
||||
method: req.method,
|
||||
url: req.originalUrl,
|
||||
reqBody: req.body,
|
||||
reqParams: req.params,
|
||||
reqQuery: req.query,
|
||||
};
|
||||
(res as any).err = rootError;
|
||||
}
|
||||
|
||||
/**
|
||||
* POST /api/plugins/:pluginId/bridge/data
|
||||
*
|
||||
|
|
@ -1072,6 +1100,11 @@ export function pluginRoutes(
|
|||
code: "WORKER_UNAVAILABLE",
|
||||
message: `Plugin is not ready (current status: ${plugin.status})`,
|
||||
};
|
||||
attachPluginBridgeErrorContext(req, res, new Error(bridgeError.message), bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "getData",
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
return;
|
||||
}
|
||||
|
|
@ -1098,6 +1131,12 @@ export function pluginRoutes(
|
|||
res.json({ data: result });
|
||||
} catch (err) {
|
||||
const bridgeError = mapRpcErrorToBridgeError(err);
|
||||
attachPluginBridgeErrorContext(req, res, err, bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "getData",
|
||||
dataKey: body.key,
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
}
|
||||
});
|
||||
|
|
@ -1153,6 +1192,11 @@ export function pluginRoutes(
|
|||
code: "WORKER_UNAVAILABLE",
|
||||
message: `Plugin is not ready (current status: ${plugin.status})`,
|
||||
};
|
||||
attachPluginBridgeErrorContext(req, res, new Error(bridgeError.message), bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "performAction",
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
return;
|
||||
}
|
||||
|
|
@ -1179,6 +1223,12 @@ export function pluginRoutes(
|
|||
res.json({ data: result });
|
||||
} catch (err) {
|
||||
const bridgeError = mapRpcErrorToBridgeError(err);
|
||||
attachPluginBridgeErrorContext(req, res, err, bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "performAction",
|
||||
actionKey: body.key,
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
}
|
||||
});
|
||||
|
|
@ -1235,6 +1285,12 @@ export function pluginRoutes(
|
|||
code: "WORKER_UNAVAILABLE",
|
||||
message: `Plugin is not ready (current status: ${plugin.status})`,
|
||||
};
|
||||
attachPluginBridgeErrorContext(req, res, new Error(bridgeError.message), bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "getData",
|
||||
dataKey: key,
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
return;
|
||||
}
|
||||
|
|
@ -1260,6 +1316,12 @@ export function pluginRoutes(
|
|||
res.json({ data: result });
|
||||
} catch (err) {
|
||||
const bridgeError = mapRpcErrorToBridgeError(err);
|
||||
attachPluginBridgeErrorContext(req, res, err, bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "getData",
|
||||
dataKey: key,
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
}
|
||||
});
|
||||
|
|
@ -1312,6 +1374,12 @@ export function pluginRoutes(
|
|||
code: "WORKER_UNAVAILABLE",
|
||||
message: `Plugin is not ready (current status: ${plugin.status})`,
|
||||
};
|
||||
attachPluginBridgeErrorContext(req, res, new Error(bridgeError.message), bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "performAction",
|
||||
actionKey: key,
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
return;
|
||||
}
|
||||
|
|
@ -1337,6 +1405,12 @@ export function pluginRoutes(
|
|||
res.json({ data: result });
|
||||
} catch (err) {
|
||||
const bridgeError = mapRpcErrorToBridgeError(err);
|
||||
attachPluginBridgeErrorContext(req, res, err, bridgeError, {
|
||||
pluginId: plugin.id,
|
||||
pluginKey: plugin.pluginKey,
|
||||
bridgeMethod: "performAction",
|
||||
actionKey: key,
|
||||
});
|
||||
res.status(502).json(bridgeError);
|
||||
}
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue