Add inbox issue search fallback

This commit is contained in:
Dotta 2026-04-11 06:49:23 -05:00
parent 03a2cf5c8a
commit fcab770518
3 changed files with 140 additions and 6 deletions

View file

@ -98,6 +98,7 @@ import {
getArchivedInboxSearchIssues,
getInboxWorkItems,
getInboxKeyboardSelectionIndex,
getInboxSearchFallbackIssues,
getLatestFailedRunsByAgent,
matchesInboxIssueSearch,
getRecentTouchedIssues,
@ -642,6 +643,7 @@ export function Inbox() {
retry: false,
});
const [searchQuery, setSearchQuery] = useState("");
const normalizedSearchQuery = searchQuery.trim();
const [filterPreferences, setFilterPreferences] = useState<InboxFilterPreferences>(
() => loadInboxFilterPreferences(selectedCompanyId),
);
@ -945,7 +947,7 @@ export function Inbox() {
);
const filteredWorkItems = useMemo(() => {
const q = searchQuery.trim().toLowerCase();
const q = normalizedSearchQuery.toLowerCase();
if (!q) return workItemsToRender;
return workItemsToRender.filter((item) => {
if (item.kind === "issue") {
@ -987,12 +989,12 @@ export function Inbox() {
});
}, [
workItemsToRender,
searchQuery,
agentById,
defaultProjectWorkspaceIdByProjectId,
executionWorkspaceById,
issueById,
isolatedWorkspacesEnabled,
normalizedSearchQuery,
projectWorkspaceById,
]);
@ -1002,7 +1004,7 @@ export function Inbox() {
? getArchivedInboxSearchIssues({
visibleIssues: visibleMineIssues,
searchableIssues: visibleTouchedIssues,
query: searchQuery,
query: normalizedSearchQuery,
isolatedWorkspacesEnabled,
executionWorkspaceById,
projectWorkspaceById,
@ -1013,13 +1015,60 @@ export function Inbox() {
defaultProjectWorkspaceIdByProjectId,
executionWorkspaceById,
isolatedWorkspacesEnabled,
normalizedSearchQuery,
projectWorkspaceById,
searchQuery,
tab,
visibleMineIssues,
visibleTouchedIssues,
],
);
const shouldUseIssueSearchFallback =
!!selectedCompanyId
&& normalizedSearchQuery.length > 0
&& filteredWorkItems.length === 0
&& archivedSearchIssues.length === 0;
const { data: remoteIssueSearchResults = [] } = useQuery({
queryKey: [
...queryKeys.issues.search(selectedCompanyId!, normalizedSearchQuery, undefined, 25),
"inbox-fallback",
issueFilters,
],
queryFn: () =>
issuesApi.list(selectedCompanyId!, {
q: normalizedSearchQuery,
limit: 25,
includeRoutineExecutions: true,
}),
enabled: shouldUseIssueSearchFallback,
placeholderData: (previousData) => previousData,
});
const issueSearchFallbackResults = useMemo(
() =>
getInboxSearchFallbackIssues({
query: normalizedSearchQuery,
filteredWorkItems,
archivedSearchIssues,
remoteIssues: remoteIssueSearchResults,
issueFilters,
currentUserId,
enableRoutineVisibilityFilter: true,
}),
[
archivedSearchIssues,
currentUserId,
filteredWorkItems,
issueFilters,
normalizedSearchQuery,
remoteIssueSearchResults,
],
);
const effectiveWorkItems = useMemo(
() =>
issueSearchFallbackResults.length > 0
? getInboxWorkItems({ issues: issueSearchFallbackResults, approvals: [] })
: filteredWorkItems,
[filteredWorkItems, issueSearchFallbackResults],
);
const archivedSearchIssueIds = useMemo(
() => new Set(archivedSearchIssues.map((issue) => issue.id)),
[archivedSearchIssues],
@ -1037,14 +1086,14 @@ export function Inbox() {
}, []);
const [collapsedInboxParents, setCollapsedInboxParents] = useState<Set<string>>(new Set());
const groupedSections = useMemo<InboxGroupedSection[]>(() => [
...buildGroupedInboxSections(filteredWorkItems, groupBy, nestingEnabled),
...buildGroupedInboxSections(effectiveWorkItems, groupBy, nestingEnabled),
...buildGroupedInboxSections(
getInboxWorkItems({ issues: archivedSearchIssues, approvals: [] }),
groupBy,
nestingEnabled,
{ keyPrefix: "archived-search:", isArchivedSearch: true },
),
], [archivedSearchIssues, filteredWorkItems, groupBy, nestingEnabled]);
], [archivedSearchIssues, effectiveWorkItems, groupBy, nestingEnabled]);
const totalVisibleWorkItems = useMemo(
() => groupedSections.reduce((count, group) => count + group.displayItems.length, 0),
[groupedSections],