ake/paperclip
1
0
Fork 0
mirror of https://github.com/alkimake/paperclip.git synced 2026-06-17 11:20:37 +09:00
Code Issues Projects Releases Packages Wiki Activity

test(server): isolate route modules in endpoint tests

Browse source
This commit is contained in:
dotta 2026-04-09 06:12:39 -05:00
parent 3264f9c1f6
commit fe21ab324b
23 changed files with 1003 additions and 580 deletions
Download patch file Download diff file Expand all files Collapse all files

46
server/src/__tests__/assets.test.ts
View file

@ -1,8 +1,7 @@
import { afterEach, describe, expect, it, vi } from "vitest";
import { beforeEach, describe, expect, it, vi } from "vitest";
import express from "express";
import request from "supertest";
import { MAX_ATTACHMENT_BYTES } from "../attachment-types.js";
import { assetRoutes } from "../routes/assets.js";
import type { StorageService } from "../storage/types.js";
const { createAssetMock, getAssetByIdMock, logActivityMock } = vi.hoisted(() => ({
@ -11,13 +10,15 @@ const { createAssetMock, getAssetByIdMock, logActivityMock } = vi.hoisted(() =>
logActivityMock: vi.fn(),
}));
vi.mock("../services/index.js", () => ({
assetService: vi.fn(() => ({
create: createAssetMock,
getById: getAssetByIdMock,
})),
logActivity: logActivityMock,
}));
function registerServiceMocks() {
vi.doMock("../services/index.js", () => ({
assetService: vi.fn(() => ({
create: createAssetMock,
getById: getAssetByIdMock,
})),
logActivity: logActivityMock,
}));
}
function createAsset() {
const now = new Date("2026-01-01T00:00:00.000Z");
@ -64,7 +65,8 @@ function createStorageService(contentType = "image/png"): StorageService {
};
}
function createApp(storage: ReturnType<typeof createStorageService>) {
async function createApp(storage: ReturnType<typeof createStorageService>) {
const { assetRoutes } = await import("../routes/assets.js");
const app = express();
app.use((req, _res, next) => {
req.actor = {
@ -79,7 +81,9 @@ function createApp(storage: ReturnType<typeof createStorageService>) {
}
describe("POST /api/companies/:companyId/assets/images", () => {
afterEach(() => {
beforeEach(() => {
vi.resetModules();
registerServiceMocks();
createAssetMock.mockReset();
getAssetByIdMock.mockReset();
logActivityMock.mockReset();
@ -87,7 +91,7 @@ describe("POST /api/companies/:companyId/assets/images", () => {
it("accepts PNG image uploads and returns an asset path", async () => {
const png = createStorageService("image/png");
const app = createApp(png);
const app = await createApp(png);
createAssetMock.mockResolvedValue(createAsset());
@ -110,7 +114,7 @@ describe("POST /api/companies/:companyId/assets/images", () => {
it("allows supported non-image attachments outside the company logo flow", async () => {
const text = createStorageService("text/plain");
const app = createApp(text);
const app = await createApp(text);
createAssetMock.mockResolvedValue({
...createAsset(),
@ -135,7 +139,9 @@ describe("POST /api/companies/:companyId/assets/images", () => {
});
describe("POST /api/companies/:companyId/logo", () => {
afterEach(() => {
beforeEach(() => {
vi.resetModules();
registerServiceMocks();
createAssetMock.mockReset();
getAssetByIdMock.mockReset();
logActivityMock.mockReset();
@ -143,7 +149,7 @@ describe("POST /api/companies/:companyId/logo", () => {
it("accepts PNG logo uploads and returns an asset path", async () => {
const png = createStorageService("image/png");
const app = createApp(png);
const app = await createApp(png);
createAssetMock.mockResolvedValue(createAsset());
@ -165,7 +171,7 @@ describe("POST /api/companies/:companyId/logo", () => {
it("sanitizes SVG logo uploads before storing them", async () => {
const svg = createStorageService("image/svg+xml");
const app = createApp(svg);
const app = await createApp(svg);
createAssetMock.mockResolvedValue({
...createAsset(),
@ -198,7 +204,7 @@ describe("POST /api/companies/:companyId/logo", () => {
it("allows logo uploads within the general attachment limit", async () => {
const png = createStorageService("image/png");
const app = createApp(png);
const app = await createApp(png);
createAssetMock.mockResolvedValue(createAsset());
const file = Buffer.alloc(150 * 1024, "a");
@ -210,7 +216,7 @@ describe("POST /api/companies/:companyId/logo", () => {
});
it("rejects logo files larger than the general attachment limit", async () => {
const app = createApp(createStorageService());
const app = await createApp(createStorageService());
createAssetMock.mockResolvedValue(createAsset());
const file = Buffer.alloc(MAX_ATTACHMENT_BYTES + 1, "a");
@ -223,7 +229,7 @@ describe("POST /api/companies/:companyId/logo", () => {
});
it("rejects unsupported image types", async () => {
const app = createApp(createStorageService("text/plain"));
const app = await createApp(createStorageService("text/plain"));
createAssetMock.mockResolvedValue(createAsset());
const res = await request(app)
@ -236,7 +242,7 @@ describe("POST /api/companies/:companyId/logo", () => {
});
it("rejects SVG image uploads that cannot be sanitized", async () => {
const app = createApp(createStorageService("image/svg+xml"));
const app = await createApp(createStorageService("image/svg+xml"));
createAssetMock.mockResolvedValue(createAsset());
const res = await request(app)