mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 01:50:39 +09:00
7623f679cf
Address two Greptile review comments: 1. Collapsed parent badge now shows total descendant count at all depths rather than direct-child count only. Add `countDescendants` utility to issue-tree.ts (recursive, uses existing childMap) and replace `children.length` with it in the titleSuffix badge. 2. Add a useEffect that prunes stale IDs from `collapsedParents` whenever the issues prop changes. Deleted or reassigned issues previously left orphan IDs in localStorage indefinitely; the effect filters to only IDs that appear as a parentId in the current issue list and persists the cleaned array via updateView. Add four unit tests for countDescendants: leaf node, single-level, multi-level, and unknown ID. Co-Authored-By: Paperclip <noreply@paperclip.ing>
36 lines
1.3 KiB
TypeScript
36 lines
1.3 KiB
TypeScript
import type { Issue } from "@paperclipai/shared";
|
|
|
|
export interface IssueTree {
|
|
roots: Issue[];
|
|
childMap: Map<string, Issue[]>;
|
|
}
|
|
|
|
/**
|
|
* Builds a parent→children tree from a flat list of issues.
|
|
*
|
|
* - `roots` contains issues whose parent is absent from the list (or have no
|
|
* parent at all), so orphaned sub-tasks are always visible at root level.
|
|
* - `childMap` maps each parent id to its direct children in list order.
|
|
*/
|
|
export function buildIssueTree(items: Issue[]): IssueTree {
|
|
const itemIds = new Set(items.map((i) => i.id));
|
|
const roots = items.filter((i) => !i.parentId || !itemIds.has(i.parentId));
|
|
const childMap = new Map<string, Issue[]>();
|
|
for (const item of items) {
|
|
if (item.parentId && itemIds.has(item.parentId)) {
|
|
const arr = childMap.get(item.parentId) ?? [];
|
|
arr.push(item);
|
|
childMap.set(item.parentId, arr);
|
|
}
|
|
}
|
|
return { roots, childMap };
|
|
}
|
|
|
|
/**
|
|
* Returns the total number of descendants (all depths) of `id` in `childMap`.
|
|
* Used to accurately label collapsed parent badges like "(3 sub-tasks)".
|
|
*/
|
|
export function countDescendants(id: string, childMap: Map<string, Issue[]>): number {
|
|
const children = childMap.get(id) ?? [];
|
|
return children.reduce((sum, c) => sum + 1 + countDescendants(c.id, childMap), 0);
|
|
}
|