mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 01:50:39 +09:00
03e1e3abd2
Reverts paperclipai/paperclip#7423 Decided to keep this in place so we can automate issue reproduction in the future. We all make mistakes. Even me, if you can believe it.
111 lines
3.7 KiB
JavaScript
111 lines
3.7 KiB
JavaScript
import { test } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { checkLinkedIssue } from '../check-pr-linked-issue.mjs';
|
|
|
|
// Existing tests with title parameter added (defaults to no prefix, so still required)
|
|
|
|
test('passes with bare #NNN reference', () => {
|
|
assert.equal(checkLinkedIssue('This fixes the bug in #123', 'fix: something').passed, true);
|
|
});
|
|
|
|
test('passes with "Fixes #NNN"', () => {
|
|
assert.equal(checkLinkedIssue('Fixes #456\n\nSome description', 'fix: something').passed, true);
|
|
});
|
|
|
|
test('passes with "Closes #NNN" (case-insensitive)', () => {
|
|
assert.equal(checkLinkedIssue('closes #789', 'fix: something').passed, true);
|
|
});
|
|
|
|
test('passes with "Resolves #NNN"', () => {
|
|
assert.equal(checkLinkedIssue('Resolves #101', 'fix: something').passed, true);
|
|
});
|
|
|
|
test('passes with full github.com URL', () => {
|
|
assert.equal(
|
|
checkLinkedIssue('See https://github.com/paperclipai/paperclip/issues/202', 'fix: bug').passed,
|
|
true
|
|
);
|
|
});
|
|
|
|
test('passes with a full github.com URL followed by punctuation', () => {
|
|
assert.equal(
|
|
checkLinkedIssue('See (https://github.com/paperclipai/paperclip/issues/202).', 'fix: bug').passed,
|
|
true
|
|
);
|
|
});
|
|
|
|
test('fails with empty body when no skip prefix', () => {
|
|
const result = checkLinkedIssue('', 'fix: bug');
|
|
assert.equal(result.passed, false);
|
|
assert.ok(result.failures.length > 0);
|
|
});
|
|
|
|
test('fails with no issue reference when no skip prefix', () => {
|
|
const result = checkLinkedIssue('Added a cool feature, no issue linked', 'feat: something');
|
|
assert.equal(result.passed, false);
|
|
assert.ok(result.failures[0].includes('Fixes #NNN'));
|
|
});
|
|
|
|
test('fails with cross-repo issue reference', () => {
|
|
const result = checkLinkedIssue('See https://github.com/other/repo/issues/123', 'fix: bug');
|
|
assert.equal(result.passed, false);
|
|
});
|
|
|
|
test('fails when the Paperclip issue URL is embedded inside another host', () => {
|
|
const result = checkLinkedIssue(
|
|
'See https://evil.example/https://github.com/paperclipai/paperclip/issues/123',
|
|
'fix: bug'
|
|
);
|
|
assert.equal(result.passed, false);
|
|
});
|
|
|
|
test('fails when the Paperclip issue URL continues into another host', () => {
|
|
const result = checkLinkedIssue(
|
|
'See https://github.com/paperclipai/paperclip/issues/123.evil.example',
|
|
'fix: bug'
|
|
);
|
|
assert.equal(result.passed, false);
|
|
});
|
|
|
|
test('fails when #NNN is part of a word (no space before)', () => {
|
|
const result = checkLinkedIssue('This is version#123 not an issue link', 'fix: bug');
|
|
assert.equal(result.passed, false);
|
|
});
|
|
|
|
// New tests for prefix-aware skip behavior
|
|
|
|
test('skips check for docs: prefix', () => {
|
|
assert.equal(checkLinkedIssue('', 'docs: update README').passed, true);
|
|
});
|
|
|
|
test('skips check for chore: prefix', () => {
|
|
assert.equal(checkLinkedIssue('', 'chore: bump deps').passed, true);
|
|
});
|
|
|
|
test('skips check for build: prefix', () => {
|
|
assert.equal(checkLinkedIssue('', 'build: update Dockerfile').passed, true);
|
|
});
|
|
|
|
test('skips check for ci: prefix', () => {
|
|
assert.equal(checkLinkedIssue('', 'ci: add workflow').passed, true);
|
|
});
|
|
|
|
test('skips check for test: prefix', () => {
|
|
assert.equal(checkLinkedIssue('', 'test: add coverage').passed, true);
|
|
});
|
|
|
|
test('skips check with scoped prefix like docs(api):', () => {
|
|
assert.equal(checkLinkedIssue('', 'docs(api): document endpoint').passed, true);
|
|
});
|
|
|
|
test('requires issue for feat: prefix', () => {
|
|
assert.equal(checkLinkedIssue('Some description without issue', 'feat: new thing').passed, false);
|
|
});
|
|
|
|
test('requires issue for refactor: prefix', () => {
|
|
assert.equal(checkLinkedIssue('Some refactor', 'refactor: rewrite thing').passed, false);
|
|
});
|
|
|
|
test('requires issue when no prefix (encourages prefix usage)', () => {
|
|
assert.equal(checkLinkedIssue('No prefix here', 'Add some feature').passed, false);
|
|
});
|