mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 18:10:39 +09:00
15eac43b43
## Thinking Path > - Paperclip orchestrates AI agents for autonomous companies, and heartbeat execution is the control-plane loop that keeps assigned work moving. > - Max-turn exhaustion is a recoverable local-adapter stop condition for Claude and Gemini agents when a run needs another heartbeat to continue safely. > - The previous behavior could leave max-turn continuation details hard to inspect, and duplicate/stale continuation wakes could keep running after issue state changed. > - The adapter layer also needed to avoid trusting arbitrary stdout/stderr text as scheduler control metadata. > - This pull request adds bounded max-turn continuation scheduling, visible retry state, structured stop metadata handling, and stale/duplicate continuation guards. > - The benefit is safer automatic continuation after max-turn stops, clearer operator visibility, and fewer duplicate or stale agent runs. ## What Changed - Replaces closed PR #4952, whose head repository was deleted. - Rebases the recovered max-turn continuation branch onto current `paperclipai/paperclip:master`. - Adds max-turn continuation scheduling and retry-state plumbing for heartbeat runs. - Adds stale/duplicate continuation suppression when issue status, ownership, or execution locks change. - Normalizes Claude/Gemini max-turn detection around structured stop metadata instead of unstructured stdout/stderr text. - Surfaces max-turn continuation settings and retry visibility in the board UI. - Adds focused server, adapter, and UI tests for max-turn stop metadata, retry scheduling, stale queued-run invalidation, adapter parsing/execution, run ledger display, and agent config patching. ## Verification - `pnpm install --no-frozen-lockfile` to refresh local dependencies after rebasing onto current `master`. - `pnpm run preflight:workspace-links && pnpm exec vitest run server/src/__tests__/claude-local-adapter.test.ts server/src/__tests__/claude-local-execute.test.ts server/src/__tests__/gemini-local-adapter.test.ts server/src/__tests__/gemini-local-execute.test.ts server/src/__tests__/heartbeat-retry-scheduling.test.ts server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts server/src/services/heartbeat-stop-metadata.test.ts ui/src/components/IssueRunLedger.test.tsx ui/src/lib/agent-config-patch.test.ts ui/src/lib/runRetryState.test.ts --testTimeout=20000` - `pnpm --filter @paperclipai/adapter-claude-local typecheck && pnpm --filter @paperclipai/adapter-gemini-local typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter @paperclipai/ui typecheck` - UI screenshot note: the UI changes are limited to config/ledger state rendering rather than layout changes; component/unit coverage above verifies the rendered behavior. ## Risks - Medium behavior risk: heartbeat retry gating now suppresses max-turn continuations when issue state or execution locks drift, so any callers that relied on stale continuations running will now see cancellation instead. - Low adapter risk: Claude/Gemini unstructured text no longer triggers max-turn scheduler metadata, so only structured stop signals and Gemini exit code 53 are trusted. - No database migrations. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent, GPT-5-class model, tool-enabled local repository editing and command execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots (not applicable: state/default rendering only; covered by component/unit tests) - [x] I have updated relevant documentation to reflect my changes (not applicable: no user-facing command or docs contract changed) - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| access | ||
| transcript | ||
| ui | ||
| AccountingModelCard.tsx | ||
| ActiveAgentsPanel.test.tsx | ||
| ActiveAgentsPanel.tsx | ||
| ActivityCharts.test.tsx | ||
| ActivityCharts.tsx | ||
| ActivityRow.tsx | ||
| agent-config-defaults.ts | ||
| agent-config-primitives.tsx | ||
| AgentActionButtons.tsx | ||
| AgentConfigForm.tsx | ||
| AgentIconPicker.tsx | ||
| AgentProperties.tsx | ||
| ApprovalCard.tsx | ||
| ApprovalPayload.test.tsx | ||
| ApprovalPayload.tsx | ||
| AsciiArtAnimation.tsx | ||
| BillerSpendCard.tsx | ||
| BreadcrumbBar.tsx | ||
| BudgetIncidentCard.tsx | ||
| BudgetPolicyCard.tsx | ||
| BudgetSidebarMarker.tsx | ||
| ClaudeSubscriptionPanel.tsx | ||
| CloudAccessGate.tsx | ||
| CodexSubscriptionPanel.tsx | ||
| CommandPalette.test.tsx | ||
| CommandPalette.tsx | ||
| CommentThread.test.tsx | ||
| CommentThread.tsx | ||
| CompanyPatternIcon.tsx | ||
| CompanyRail.tsx | ||
| CompanySettingsSidebar.test.tsx | ||
| CompanySettingsSidebar.tsx | ||
| CompanySwitcher.tsx | ||
| CopyText.tsx | ||
| DevRestartBanner.tsx | ||
| DocumentDiffModal.tsx | ||
| EmptyState.tsx | ||
| EntityRow.tsx | ||
| EnvVarEditor.tsx | ||
| ExecutionParticipantPicker.tsx | ||
| ExecutionWorkspaceCloseDialog.tsx | ||
| FilterBar.tsx | ||
| FinanceBillerCard.tsx | ||
| FinanceKindCard.tsx | ||
| FinanceTimelineCard.tsx | ||
| FoldCurtain.tsx | ||
| GoalProperties.tsx | ||
| GoalTree.tsx | ||
| HermesIcon.tsx | ||
| Identity.tsx | ||
| ImageGalleryModal.tsx | ||
| InlineEditor.test.tsx | ||
| InlineEditor.tsx | ||
| InlineEntitySelector.test.tsx | ||
| InlineEntitySelector.tsx | ||
| InstanceSidebar.tsx | ||
| IssueBlockedNotice.tsx | ||
| IssueChatThread.test.tsx | ||
| IssueChatThread.tsx | ||
| IssueColumns.tsx | ||
| IssueContinuationHandoff.test.tsx | ||
| IssueContinuationHandoff.tsx | ||
| IssueDocumentsSection.test.tsx | ||
| IssueDocumentsSection.tsx | ||
| IssueFiltersPopover.test.tsx | ||
| IssueFiltersPopover.tsx | ||
| IssueGroupHeader.tsx | ||
| IssueLinkQuicklook.tsx | ||
| IssueMonitorActivityCard.test.tsx | ||
| IssueMonitorActivityCard.tsx | ||
| IssueProperties.test.tsx | ||
| IssueProperties.tsx | ||
| IssueReferenceActivitySummary.tsx | ||
| IssueReferencePill.tsx | ||
| IssueRelatedWorkPanel.test.tsx | ||
| IssueRelatedWorkPanel.tsx | ||
| IssueRow.test.tsx | ||
| IssueRow.tsx | ||
| IssueRunLedger.test.tsx | ||
| IssueRunLedger.tsx | ||
| IssuesList.test.tsx | ||
| IssuesList.tsx | ||
| IssuesQuicklook.tsx | ||
| IssueThreadInteractionCard.test.tsx | ||
| IssueThreadInteractionCard.tsx | ||
| IssueWorkspaceCard.test.tsx | ||
| IssueWorkspaceCard.tsx | ||
| JsonSchemaForm.tsx | ||
| KanbanBoard.tsx | ||
| KeyboardShortcutsCheatsheet.tsx | ||
| Layout.test.tsx | ||
| Layout.tsx | ||
| LiveRunWidget.tsx | ||
| MarkdownBody.test.tsx | ||
| MarkdownBody.tsx | ||
| MarkdownEditor.test.tsx | ||
| MarkdownEditor.tsx | ||
| MetricCard.tsx | ||
| MobileBottomNav.tsx | ||
| NewAgentDialog.tsx | ||
| NewGoalDialog.tsx | ||
| NewIssueDialog.test.tsx | ||
| NewIssueDialog.tsx | ||
| NewProjectDialog.tsx | ||
| OnboardingWizard.tsx | ||
| OpenCodeLogoIcon.tsx | ||
| OutputFeedbackButtons.tsx | ||
| PackageFileTree.tsx | ||
| PageSkeleton.tsx | ||
| PageTabBar.tsx | ||
| PathInstructionsModal.tsx | ||
| PriorityIcon.tsx | ||
| ProductivityReviewBadge.tsx | ||
| ProjectProperties.tsx | ||
| ProjectWorkspacesContent.tsx | ||
| ProjectWorkspaceSummaryCard.test.tsx | ||
| ProjectWorkspaceSummaryCard.tsx | ||
| PropertiesPanel.tsx | ||
| ProviderQuotaCard.tsx | ||
| QuotaBar.tsx | ||
| ReportsToPicker.tsx | ||
| RoutineRunVariablesDialog.test.tsx | ||
| RoutineRunVariablesDialog.tsx | ||
| RoutineVariablesEditor.tsx | ||
| RunChatSurface.tsx | ||
| RunInvocationCard.test.tsx | ||
| ScheduleEditor.tsx | ||
| ScrollToBottom.tsx | ||
| Sidebar.test.tsx | ||
| Sidebar.tsx | ||
| SidebarAccountMenu.test.tsx | ||
| SidebarAccountMenu.tsx | ||
| SidebarAgents.test.tsx | ||
| SidebarAgents.tsx | ||
| SidebarCompanyMenu.test.tsx | ||
| SidebarCompanyMenu.tsx | ||
| SidebarNavItem.tsx | ||
| SidebarProjects.tsx | ||
| SidebarSection.tsx | ||
| StatusBadge.tsx | ||
| StatusIcon.test.tsx | ||
| StatusIcon.tsx | ||
| SwipeToArchive.test.tsx | ||
| SwipeToArchive.tsx | ||
| ToastViewport.tsx | ||
| WorkspaceRuntimeControls.test.tsx | ||
| WorkspaceRuntimeControls.tsx | ||
| WorktreeBanner.tsx | ||