mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 10:30:37 +09:00
## Thinking Path > - Paperclip is the control plane for autonomous AI companies. > - V1 needs to stay local-first while also supporting shared, authenticated deployments. > - Human operators need real identities, company membership, invite flows, profile surfaces, and company-scoped access controls. > - Agents and operators also need the existing issue, inbox, workspace, approval, and plugin flows to keep working under those authenticated boundaries. > - This branch accumulated the multi-user implementation, follow-up QA fixes, workspace/runtime refinements, invite UX improvements, release-branch conflict resolution, and review hardening. > - This pull request consolidates that branch onto the current `master` branch as a single reviewable PR. > - The benefit is a complete multi-user implementation path with tests and docs carried forward without dropping existing branch work. ## What Changed - Added authenticated human-user access surfaces: auth/session routes, company user directory, profile settings, company access/member management, join requests, and invite management. - Added invite creation, invite landing, onboarding, logo/branding, invite grants, deduped join requests, and authenticated multi-user E2E coverage. - Tightened company-scoped and instance-admin authorization across board, plugin, adapter, access, issue, and workspace routes. - Added profile-image URL validation hardening, avatar preservation on name-only profile updates, and join-request uniqueness migration cleanup for pending human requests. - Added an atomic member role/status/grants update path so Company Access saves no longer leave partially updated permissions. - Improved issue chat, inbox, assignee identity rendering, sidebar/account/company navigation, workspace routing, and execution workspace reuse behavior for multi-user operation. - Added and updated server/UI tests covering auth, invites, membership, issue workspace inheritance, plugin authz, inbox/chat behavior, and multi-user flows. - Merged current `public-gh/master` into this branch, resolved all conflicts, and verified no `pnpm-lock.yaml` change is included in this PR diff. ## Verification - `pnpm exec vitest run server/src/__tests__/issues-service.test.ts ui/src/components/IssueChatThread.test.tsx ui/src/pages/Inbox.test.tsx` - `pnpm run preflight:workspace-links && pnpm exec vitest run server/src/__tests__/plugin-routes-authz.test.ts` - `pnpm exec vitest run server/src/__tests__/plugin-routes-authz.test.ts server/src/__tests__/workspace-runtime-service-authz.test.ts server/src/__tests__/access-validators.test.ts` - `pnpm exec vitest run server/src/__tests__/authz-company-access.test.ts server/src/__tests__/routines-routes.test.ts server/src/__tests__/sidebar-preferences-routes.test.ts server/src/__tests__/approval-routes-idempotency.test.ts server/src/__tests__/openclaw-invite-prompt-route.test.ts server/src/__tests__/agent-cross-tenant-authz-routes.test.ts server/src/__tests__/routines-e2e.test.ts` - `pnpm exec vitest run server/src/__tests__/auth-routes.test.ts ui/src/pages/CompanyAccess.test.tsx` - `pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/db typecheck && pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` - `pnpm db:generate` - `npx playwright test --config tests/e2e/playwright.config.ts --list` - Confirmed branch has no uncommitted changes and is `0` commits behind `public-gh/master` before PR creation. - Confirmed no `pnpm-lock.yaml` change is staged or present in the PR diff. ## Risks - High review surface area: this PR contains the accumulated multi-user branch plus follow-up fixes, so reviewers should focus especially on company-boundary enforcement and authenticated-vs-local deployment behavior. - UI behavior changed across invites, inbox, issue chat, access settings, and sidebar navigation; no browser screenshots are included in this branch-consolidation PR. - Plugin install, upgrade, and lifecycle/config mutations now require instance-admin access, which is intentional but may change expectations for non-admin board users. - A join-request dedupe migration rejects duplicate pending human requests before creating unique indexes; deployments with unusual historical duplicates should review the migration behavior. - Company member role/status/grant saves now use a new combined endpoint; older separate endpoints remain for compatibility. - Full production build was not run locally in this heartbeat; CI should cover the full matrix. ## Model Used - OpenAI Codex coding agent, GPT-5-based model, CLI/tool-use environment. Exact deployed model identifier and context window were not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Note on screenshots: this is a branch-consolidation PR for an already-developed multi-user branch, and no browser screenshots were captured during this heartbeat. --------- Co-authored-by: dotta <dotta@example.com> Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
267 lines
9.7 KiB
TypeScript
267 lines
9.7 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { MemoryRouter } from "react-router-dom";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { CompanyInvites } from "./CompanyInvites";
|
|
import { queryKeys } from "@/lib/queryKeys";
|
|
|
|
const listInvitesMock = vi.hoisted(() => vi.fn());
|
|
const createCompanyInviteMock = vi.hoisted(() => vi.fn());
|
|
const revokeInviteMock = vi.hoisted(() => vi.fn());
|
|
const pushToastMock = vi.hoisted(() => vi.fn());
|
|
const setBreadcrumbsMock = vi.hoisted(() => vi.fn());
|
|
const clipboardWriteTextMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@/api/access", () => ({
|
|
accessApi: {
|
|
listInvites: (companyId: string, options?: unknown) => listInvitesMock(companyId, options),
|
|
createCompanyInvite: (companyId: string, input: unknown) =>
|
|
createCompanyInviteMock(companyId, input),
|
|
revokeInvite: (inviteId: string) => revokeInviteMock(inviteId),
|
|
},
|
|
}));
|
|
|
|
vi.mock("@/context/CompanyContext", () => ({
|
|
useCompany: () => ({
|
|
selectedCompanyId: "company-1",
|
|
selectedCompany: { id: "company-1", name: "Paperclip", issuePrefix: "PAP" },
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/context/BreadcrumbContext", () => ({
|
|
useBreadcrumbs: () => ({ setBreadcrumbs: setBreadcrumbsMock }),
|
|
}));
|
|
|
|
vi.mock("@/context/ToastContext", () => ({
|
|
useToast: () => ({ pushToast: pushToastMock }),
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
async function flushReact() {
|
|
await act(async () => {
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
|
|
describe("CompanyInvites", () => {
|
|
let container: HTMLDivElement;
|
|
const inviteHistory = Array.from({ length: 25 }, (_, index) => {
|
|
const inviteNumber = 25 - index;
|
|
const isActive = inviteNumber === 25;
|
|
return {
|
|
id: `invite-${inviteNumber}`,
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
tokenHash: `hash-${inviteNumber}`,
|
|
allowedJoinTypes: "human",
|
|
defaultsPayload: null,
|
|
expiresAt: "2026-04-20T00:00:00.000Z",
|
|
invitedByUserId: "user-1",
|
|
revokedAt: null,
|
|
acceptedAt: isActive ? null : "2026-04-11T00:00:00.000Z",
|
|
createdAt: `2026-04-${String(inviteNumber).padStart(2, "0")}T00:00:00.000Z`,
|
|
updatedAt: `2026-04-${String(inviteNumber).padStart(2, "0")}T00:00:00.000Z`,
|
|
companyName: "Paperclip",
|
|
humanRole: isActive ? "operator" : "viewer",
|
|
inviteMessage: null,
|
|
state: isActive ? "active" : "accepted",
|
|
invitedByUser: {
|
|
id: "user-1",
|
|
name: `Board User ${inviteNumber}`,
|
|
email: `board${inviteNumber}@paperclip.local`,
|
|
image: null,
|
|
},
|
|
relatedJoinRequestId: isActive ? "join-1" : null,
|
|
};
|
|
});
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
|
|
listInvitesMock.mockImplementation((_companyId: string, options?: { limit?: number; offset?: number }) => {
|
|
const limit = options?.limit ?? 20;
|
|
const offset = options?.offset ?? 0;
|
|
const invites = inviteHistory.slice(offset, offset + limit);
|
|
const nextOffset = offset + invites.length < inviteHistory.length ? offset + invites.length : null;
|
|
return Promise.resolve({ invites, nextOffset });
|
|
});
|
|
|
|
createCompanyInviteMock.mockResolvedValue({
|
|
inviteUrl: "https://paperclip.local/invite/new-token",
|
|
onboardingTextUrl: null,
|
|
onboardingTextPath: null,
|
|
humanRole: "viewer",
|
|
allowedJoinTypes: "human",
|
|
});
|
|
|
|
revokeInviteMock.mockResolvedValue(undefined);
|
|
|
|
Object.defineProperty(globalThis.navigator, "clipboard", {
|
|
configurable: true,
|
|
value: { writeText: clipboardWriteTextMock },
|
|
});
|
|
});
|
|
|
|
afterEach(() => {
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("renders a human-only invite flow and keeps invite history in a table", async () => {
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<MemoryRouter>
|
|
<QueryClientProvider client={queryClient}>
|
|
<CompanyInvites />
|
|
</QueryClientProvider>
|
|
</MemoryRouter>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
await flushReact();
|
|
|
|
expect(container.textContent).toContain("Company Invites");
|
|
expect(container.textContent).toContain("Create invite");
|
|
expect(container.textContent).toContain("Invite history");
|
|
expect(container.textContent).toContain("Board User 25");
|
|
expect(container.textContent).toContain("Board User 21");
|
|
expect(container.textContent).not.toContain("Board User 20");
|
|
expect(container.textContent).toContain("Review request");
|
|
expect(container.textContent).toContain("View more");
|
|
expect(container.textContent).not.toContain("Human or agent");
|
|
expect(container.textContent).not.toContain("Invite message");
|
|
expect(container.textContent).not.toContain("Latest generated invite");
|
|
expect(container.textContent).not.toContain("Active invites");
|
|
expect(container.textContent).not.toContain("Consumed invites");
|
|
expect(container.textContent).not.toContain("Expired invites");
|
|
expect(container.textContent).not.toContain("OpenClaw shortcut");
|
|
|
|
expect(container.textContent).toContain("Choose a role");
|
|
expect(container.textContent).toContain("Each invite link is single-use.");
|
|
expect(container.textContent).toContain("Can create agents, invite users, assign tasks, and approve join requests.");
|
|
expect(container.textContent).toContain("Everything in Admin, plus managing members and permission grants.");
|
|
expect(listInvitesMock).toHaveBeenCalledWith("company-1", { limit: 5, offset: 0 });
|
|
|
|
const viewMoreButton = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent === "View more",
|
|
);
|
|
|
|
await act(async () => {
|
|
viewMoreButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
await flushReact();
|
|
await flushReact();
|
|
|
|
expect(listInvitesMock).toHaveBeenCalledWith("company-1", { limit: 5, offset: 5 });
|
|
expect(container.textContent).toContain("Board User 20");
|
|
expect(container.textContent).toContain("Board User 16");
|
|
expect(container.textContent).toContain("View more");
|
|
|
|
await act(async () => {
|
|
const viewerRadio = container.querySelector('input[type="radio"][value="viewer"]') as HTMLInputElement | null;
|
|
viewerRadio?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
viewerRadio?.dispatchEvent(new Event("change", { bubbles: true }));
|
|
});
|
|
|
|
const buttons = Array.from(container.querySelectorAll("button"));
|
|
const createButton = buttons.find((button) => button.textContent === "Create invite");
|
|
const revokeButton = buttons.find((button) => button.textContent === "Revoke");
|
|
|
|
expect(createButton).toBeTruthy();
|
|
expect(revokeButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
createButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
await flushReact();
|
|
await flushReact();
|
|
|
|
expect(createCompanyInviteMock).toHaveBeenCalledWith("company-1", {
|
|
allowedJoinTypes: "human",
|
|
humanRole: "viewer",
|
|
agentMessage: null,
|
|
});
|
|
expect(clipboardWriteTextMock).toHaveBeenCalledWith("https://paperclip.local/invite/new-token");
|
|
expect(container.textContent).toContain("Latest invite link");
|
|
expect(container.textContent).toContain("This URL includes the current Paperclip domain returned by the server.");
|
|
expect(container.textContent).toContain("https://paperclip.local/invite/new-token");
|
|
expect(container.textContent).toContain("Open invite");
|
|
expect(pushToastMock).toHaveBeenCalledWith({
|
|
title: "Invite created",
|
|
body: "Invite ready below and copied to clipboard.",
|
|
tone: "success",
|
|
});
|
|
|
|
const inviteFieldButton = Array.from(container.querySelectorAll("button")).find(
|
|
(button) => button.textContent?.includes("https://paperclip.local/invite/new-token"),
|
|
);
|
|
|
|
await act(async () => {
|
|
inviteFieldButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
await flushReact();
|
|
|
|
expect(clipboardWriteTextMock).toHaveBeenCalledTimes(2);
|
|
expect(container.textContent).toContain("Copied");
|
|
|
|
await act(async () => {
|
|
revokeButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
await flushReact();
|
|
|
|
expect(revokeInviteMock).toHaveBeenCalledWith("invite-25");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
|
|
it("ignores legacy cached invite arrays and refetches paginated history", async () => {
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
queryClient.setQueryData(["access", "invites", "company-1", "all"], inviteHistory.slice(0, 2));
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<MemoryRouter>
|
|
<QueryClientProvider client={queryClient}>
|
|
<CompanyInvites />
|
|
</QueryClientProvider>
|
|
</MemoryRouter>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
await flushReact();
|
|
|
|
expect(container.textContent).toContain("Board User 25");
|
|
expect(container.textContent).not.toContain("Board User 20");
|
|
expect(listInvitesMock).toHaveBeenCalledWith("company-1", { limit: 5, offset: 0 });
|
|
expect(queryClient.getQueryData(queryKeys.access.invites("company-1", "all", 5))).toMatchObject({
|
|
pages: [
|
|
{
|
|
invites: expect.any(Array),
|
|
nextOffset: 5,
|
|
},
|
|
],
|
|
});
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|