mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 10:30:37 +09:00
1991ec9d6f
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so backend task ownership, recovery, review visibility, and company-scoped limits need to stay enforceable without UI-only coupling. > - Closed PR #4692 bundled those backend changes with UI workflow, docs, skills, workflow, and lockfile churn. > - PAP-2694 asks for a clean backend/control-plane slice from that closed branch. > - This branch starts from current `master` and mines only the `cli`, `packages/db`, `packages/shared`, and `server` contracts/tests needed for the backend behavior. > - It explicitly excludes UI workflow/performance work, `.github/workflows/pr.yml`, `pnpm-lock.yaml`, docs, skills, package-script, adapter UI build-config, and perf fixture script changes; the only UI files are fixture/test updates required by the tightened shared `Company` contract. > - The benefit is a smaller reviewable PR that preserves the control-plane fixes while staying under Greptile s 100-file review limit. ## What Changed - Added company-scoped attachment-size limits through DB schema/migrations, shared company portability contracts, CLI import/export coverage, and server attachment upload enforcement. - Added productivity review service/API behavior for no-comment streak, long-active, and high-churn review issues, including request-depth clamping and issue summary exposure. - Hardened issue ownership and recovery/control-plane paths: peer-agent mutation denial, issue tree pause/resume behavior, stranded recovery origins, and related activity/test coverage. - Preserved related backend contract updates for routine timestamp variables and managed agent instruction bundles because they live in shared/server contracts from the source branch. - Addressed Greptile feedback by making `Company.attachmentMaxBytes` non-optional, simplifying review request-depth clamping, fixing the migration final newline, and enforcing the process-level attachment cap as the final ceiling for uploads. - Added minimal company fixtures needed for repo-wide typecheck/build and kept the PR to 66 changed files with forbidden/non-slice paths excluded. ## Verification - `pnpm install --frozen-lockfile` - `git diff --check origin/master..HEAD` - `git diff --name-only origin/master..HEAD | wc -l` -> 66 files - `git diff --name-only origin/master..HEAD -- .github/workflows/pr.yml pnpm-lock.yaml package.json doc skills .agents scripts packages/adapters` -> no output - `pnpm exec vitest run --config vitest.config.ts packages/shared/src/validators/issue.test.ts packages/shared/src/routine-variables.test.ts packages/shared/src/adapter-types.test.ts cli/src/__tests__/company-import-export-e2e.test.ts cli/src/__tests__/company.test.ts server/src/__tests__/productivity-review-service.test.ts server/src/__tests__/issue-tree-control-service.test.ts server/src/__tests__/issue-tree-control-routes.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/issue-attachment-routes.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts server/src/__tests__/issues-service.test.ts` -> 12 files, 147 tests passed - `pnpm exec vitest run --config vitest.config.ts cli/src/__tests__/company-delete.test.ts cli/src/__tests__/company-import-export-e2e.test.ts server/src/__tests__/productivity-review-service.test.ts` -> 3 files, 18 tests passed - `pnpm exec vitest run --config vitest.config.ts server/src/__tests__/issue-attachment-routes.test.ts` -> 1 file, 6 tests passed - `pnpm --filter @paperclipai/db typecheck && pnpm --filter @paperclipai/shared typecheck && pnpm --filter @paperclipai/server typecheck && pnpm --filter paperclipai typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck && pnpm --filter @paperclipai/ui build` ## Risks - Includes migrations `0073_shiny_salo.sql` and `0074_striped_genesis.sql`; merge ordering matters if another PR adds migrations first. - This is intentionally backend-only apart from fixture/test updates forced by shared type correctness; UI affordances from PR #4692 are not present here and should land in separate UI slices. - The worktree install emitted plugin SDK bin-link warnings for unbuilt plugin packages, but the targeted tests and package typechecks completed successfully. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected; check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool-enabled terminal/GitHub workflow. Exact runtime context window was not exposed by the harness. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| meta | ||
| 0000_mature_masked_marvel.sql | ||
| 0001_fast_northstar.sql | ||
| 0002_big_zaladane.sql | ||
| 0003_shallow_quentin_quire.sql | ||
| 0004_issue_identifiers.sql | ||
| 0005_chief_luke_cage.sql | ||
| 0006_overjoyed_mister_sinister.sql | ||
| 0007_new_quentin_quire.sql | ||
| 0008_amused_zzzax.sql | ||
| 0009_fast_jackal.sql | ||
| 0010_stale_justin_hammer.sql | ||
| 0011_windy_corsair.sql | ||
| 0012_perpetual_ser_duncan.sql | ||
| 0013_dashing_wasp.sql | ||
| 0014_many_mikhail_rasputin.sql | ||
| 0015_project_color_archived.sql | ||
| 0016_agent_icon.sql | ||
| 0017_tiresome_gabe_jones.sql | ||
| 0018_flat_sleepwalker.sql | ||
| 0019_public_victor_mancha.sql | ||
| 0020_white_anita_blake.sql | ||
| 0021_chief_vindicator.sql | ||
| 0022_company_brand_color.sql | ||
| 0023_fair_lethal_legion.sql | ||
| 0024_far_beast.sql | ||
| 0025_nasty_salo.sql | ||
| 0026_lying_pete_wisdom.sql | ||
| 0027_tranquil_tenebrous.sql | ||
| 0028_harsh_goliath.sql | ||
| 0029_plugin_tables.sql | ||
| 0030_rich_magneto.sql | ||
| 0031_zippy_magma.sql | ||
| 0032_pretty_doctor_octopus.sql | ||
| 0033_shiny_black_tarantula.sql | ||
| 0034_fat_dormammu.sql | ||
| 0035_marvelous_satana.sql | ||
| 0036_cheerful_nitro.sql | ||
| 0037_friendly_eddie_brock.sql | ||
| 0038_careless_iron_monger.sql | ||
| 0039_fat_magneto.sql | ||
| 0040_eager_shotgun.sql | ||
| 0041_curly_maria_hill.sql | ||
| 0042_spotty_the_renegades.sql | ||
| 0043_reflective_captain_universe.sql | ||
| 0044_illegal_toad.sql | ||
| 0045_workable_shockwave.sql | ||
| 0046_smooth_sentinels.sql | ||
| 0047_overjoyed_groot.sql | ||
| 0048_flashy_marrow.sql | ||
| 0049_flawless_abomination.sql | ||
| 0050_stiff_luckman.sql | ||
| 0051_young_korg.sql | ||
| 0052_mushy_trauma.sql | ||
| 0053_sharp_wild_child.sql | ||
| 0054_draft_routines.sql | ||
| 0055_kind_weapon_omega.sql | ||
| 0056_spooky_ultragirl.sql | ||
| 0057_tidy_join_requests.sql | ||
| 0058_wealthy_starbolt.sql | ||
| 0059_plugin_database_namespaces.sql | ||
| 0060_orange_annihilus.sql | ||
| 0061_lively_thor_girl.sql | ||
| 0062_routine_run_dispatch_fingerprint.sql | ||
| 0063_issue_thread_interactions.sql | ||
| 0064_issue_thread_interaction_idempotency.sql | ||
| 0065_environments.sql | ||
| 0066_issue_tree_holds.sql | ||
| 0067_agent_default_environment.sql | ||
| 0068_environment_local_driver_unique.sql | ||
| 0069_liveness_recovery_dedupe.sql | ||
| 0070_active_run_output_watchdog.sql | ||
| 0071_default_hire_approval_off.sql | ||
| 0072_large_sandman.sql | ||
| 0073_shiny_salo.sql | ||
| 0074_striped_genesis.sql | ||