paperclip/ui/src/lib/router.tsx
Dotta 5f45712846
Sync/master post pap1497 followups 2026 04 15 (#3779)
## Thinking Path

> - Paperclip orchestrates AI agents for zero-human companies
> - The board depends on issue, inbox, cost, and company-skill surfaces
to stay accurate and fast while agents are actively working
> - The PAP-1497 follow-up branch exposed a few rough edges in those
surfaces: stale active-run state on completed issues, missing creator
filters, oversized issue payload scans, and placeholder issue-route
parsing
> - Those gaps make the control plane harder to trust because operators
can see misleading run state, miss the right subset of work, or pay
extra query/render cost on large issue records
> - This pull request tightens those follow-ups across server and UI
code, and adds regression coverage for the affected paths
> - The benefit is a more reliable issue workflow, safer high-volume
cost aggregation, and clearer board/operator navigation

## What Changed

- Added the `v2026.415.0` release changelog entry.
- Fixed stale issue-run presentation after completion and reused the
shared issue-path parser so literal route placeholders no longer become
issue links.
- Added creator filters to the Issues page and Inbox, including
persisted filter-state normalization and regression coverage.
- Bounded issue detail/list project-mention scans and trimmed large
issue-list payload fields to keep issue reads lighter.
- Hardened company-skill list projection and cost/finance aggregation so
large markdown blobs and large summed values do not leak into list
responses or overflow 32-bit casts.
- Added targeted server/UI regression tests for company skills,
costs/finance, issue mention scanning, creator filters, inbox
normalization, and issue reference parsing.

## Verification

- `pnpm exec vitest run
server/src/__tests__/company-skills-service.test.ts
server/src/__tests__/costs-service.test.ts
server/src/__tests__/issues-goal-context-routes.test.ts
server/src/__tests__/issues-service.test.ts ui/src/lib/inbox.test.ts
ui/src/lib/issue-filters.test.ts ui/src/lib/issue-reference.test.ts`
- `gh pr checks 3779`
Current pass set on the PR head: `policy`, `verify`, `e2e`,
`security/snyk (cryppadotta)`, `Greptile Review`

## Risks

- Creator filter options are derived from the currently loaded
issue/agent data, so very sparse result sets may not surface every
historical creator until they appear in the active dataset.
- Cost/finance aggregate casts now use `double precision`; that removes
the current overflow risk, but future schema changes should keep
large-value aggregation behavior under review.
- Issue detail mention scanning now skips comment-body scans on the
detail route, so any consumer that relied on comment-only project
mentions there would need to fetch them separately.

## Model Used

- OpenAI Codex, GPT-5-based coding agent with terminal tool use and
local code execution in the Paperclip workspace. Exact internal model
ID/context-window exposure is not surfaced in this session.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-15 21:13:56 -05:00

100 lines
3.2 KiB
TypeScript

import * as React from "react";
import * as RouterDom from "react-router-dom";
import type { NavigateOptions, To } from "react-router-dom";
import type { Issue } from "@paperclipai/shared";
import { useCompany } from "@/context/CompanyContext";
import { IssueLinkQuicklook } from "@/components/IssueLinkQuicklook";
import {
applyCompanyPrefix,
extractCompanyPrefixFromPath,
normalizeCompanyPrefix,
} from "@/lib/company-routes";
import { parseIssuePathIdFromPath } from "@/lib/issue-reference";
function resolveTo(to: To, companyPrefix: string | null): To {
if (typeof to === "string") {
return applyCompanyPrefix(to, companyPrefix);
}
if (to.pathname && to.pathname.startsWith("/")) {
const pathname = applyCompanyPrefix(to.pathname, companyPrefix);
if (pathname !== to.pathname) {
return { ...to, pathname };
}
}
return to;
}
function useActiveCompanyPrefix(): string | null {
const { selectedCompany } = useCompany();
const params = RouterDom.useParams<{ companyPrefix?: string }>();
const location = RouterDom.useLocation();
if (params.companyPrefix) {
return normalizeCompanyPrefix(params.companyPrefix);
}
const pathPrefix = extractCompanyPrefixFromPath(location.pathname);
if (pathPrefix) return pathPrefix;
return selectedCompany ? normalizeCompanyPrefix(selectedCompany.issuePrefix) : null;
}
export * from "react-router-dom";
type CompanyLinkProps = React.ComponentProps<typeof RouterDom.Link> & {
disableIssueQuicklook?: boolean;
issuePrefetch?: Issue | null;
};
export const Link = React.forwardRef<HTMLAnchorElement, CompanyLinkProps>(
function CompanyLink({ to, disableIssueQuicklook = false, issuePrefetch = null, ...props }, ref) {
const companyPrefix = useActiveCompanyPrefix();
const resolvedTo = resolveTo(to, companyPrefix);
const issuePathId = parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname);
if (issuePathId) {
return (
<IssueLinkQuicklook
ref={ref}
to={resolvedTo}
issuePathId={issuePathId}
disableIssueQuicklook={disableIssueQuicklook}
issuePrefetch={issuePrefetch}
{...props}
/>
);
}
return <RouterDom.Link ref={ref} to={resolvedTo} {...props} />;
},
);
export const NavLink = React.forwardRef<HTMLAnchorElement, React.ComponentProps<typeof RouterDom.NavLink>>(
function CompanyNavLink({ to, ...props }, ref) {
const companyPrefix = useActiveCompanyPrefix();
return <RouterDom.NavLink ref={ref} to={resolveTo(to, companyPrefix)} {...props} />;
},
);
export function Navigate({ to, ...props }: React.ComponentProps<typeof RouterDom.Navigate>) {
const companyPrefix = useActiveCompanyPrefix();
return <RouterDom.Navigate to={resolveTo(to, companyPrefix)} {...props} />;
}
export function useNavigate(): ReturnType<typeof RouterDom.useNavigate> {
const navigate = RouterDom.useNavigate();
const companyPrefix = useActiveCompanyPrefix();
return React.useCallback(
((to: To | number, options?: NavigateOptions) => {
if (typeof to === "number") {
navigate(to);
return;
}
navigate(resolveTo(to, companyPrefix), options);
}) as ReturnType<typeof RouterDom.useNavigate>,
[navigate, companyPrefix],
);
}