mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-19 12:10:37 +09:00
1f70fd9a22
## Thinking Path > - Paperclip orchestrates AI agents across isolated execution workspaces; the local cwd is the only persistence boundary between runs. > - Workspace lifecycle (worktree_prepare → execute → workspace_finalize) and the wake/accept flow are what guarantee that dependent issues see a consistent worktree. > - PAPA-380 / PAPA-431 / PAPA-432 / PAPA-440 surfaced three holes in that contract: silent env reuse across assignees, dependent wakes firing before finalize, and `issue.interaction.accept` advancing before finalize landed. > - PAPA-441 / PAPA-442 then needed to document the "no remote git" contract and prevent future adapter/runtime code from quietly reintroducing `git push` as a backdoor sync. > - This pull request lands those server fixes, the static `check-no-git-push` enforcement, the AUTHORING.md cross-link, and the Cody-review follow-ups on the PAPA-430 thread. > - The benefit is that finalize is a real barrier — board accepts, dependent wakes, and operator-set env all respect it — and adapter code can't bypass it via raw `git push`. ## What Changed - **server (PAPA-380, PAPA-431):** `execution-workspace-policy` refuses silent env reuse when the assignee's resolved env disagrees with the workspace it would inherit. The inheritance protection is now scoped to the actual inheritance signal — explicit issue-level `environmentId` is honored even when the agent's default env is `null`. - **server (PAPA-432):** `heartbeat.ts` gates dependent wakes on `listUnfinalizedExecutionWorkspaceIds`, and writes a `workspace_finalize` row on the succeeded path. Write failures now surface instead of being swallowed so dependents aren't silently stranded behind a missing row. - **server (PAPA-440):** `issue-thread-interactions.acceptInteraction` adds a workspace_finalize precondition for `request_confirmation` (not `suggest_tasks`). Accept returns 409 if finalize hasn't succeeded for the latest workspace operation. - **ci (PAPA-442):** new `scripts/check-no-git-push.mjs` static check scans `packages/adapters/`, `packages/adapter-utils/`, `server/src/`, and `cli/src/` for any `git push` invocation (string or args-array). Wired into the `policy` PR job and `test:release-registry`. Operators can opt in per-call with `// paperclip:allow-git-push: <reason>`. Release scripts are out of scope by design. - **docs (PAPA-441):** `AUTHORING.md` documents the no-remote-git contract and cross-links the static check so adapter authors learn the rule and the enforcement together. - **review follow-up (PAPA-430, Cody):** three fixes — env resolver bug, accept-gate scope (request_confirmation only), and finalize record write on the succeeded path. ## Verification - `pnpm exec vitest run server/src/__tests__/execution-workspace-policy.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts` → 33/33 pass - `node scripts/check-no-git-push.test.mjs` → check covers string form, args-array form, comment exclusions, and per-line allow-comment. - Manual: server compiles; the policy job runs the check in <1s before heavier jobs. ## Risks - **Behavioral shift in accept:** boards accepting `request_confirmation` while finalize is in-flight now get 409s. This is intentional — they can retry — but it changes timing on a hot path. `suggest_tasks` is unaffected. - **Workspace policy:** the env-reuse refusal is a new error path. Issues that previously silently reused an env from a different-assignee workspace will now fail-loud; the resolver still honors explicit issue-level `executionWorkspaceSettings.environmentId`. - **CI rule:** any future legitimate `git push` in scoped dirs must be marked with the allow-comment, which is the intended ergonomic. ## Model Used - Claude Opus 4.7 (`claude-opus-4-7`, extended thinking), via Claude Code in the Paperclip executor adapter. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots (N/A — server/CI/docs only) - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Closes related issues: PAPA-430, PAPA-380, PAPA-431, PAPA-432, PAPA-440, PAPA-441, PAPA-442 --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| activity_log.ts | ||
| agent_api_keys.ts | ||
| agent_config_revisions.ts | ||
| agent_memberships.ts | ||
| agent_runtime_state.ts | ||
| agent_task_sessions.ts | ||
| agent_wakeup_requests.ts | ||
| agents.ts | ||
| approval_comments.ts | ||
| approvals.ts | ||
| assets.ts | ||
| auth.ts | ||
| board_api_keys.ts | ||
| budget_incidents.ts | ||
| budget_policies.ts | ||
| cli_auth_challenges.ts | ||
| cloud_upstreams.ts | ||
| companies.ts | ||
| company_logos.ts | ||
| company_memberships.ts | ||
| company_secret_bindings.ts | ||
| company_secret_provider_configs.ts | ||
| company_secret_versions.ts | ||
| company_secrets.ts | ||
| company_skills.ts | ||
| company_user_sidebar_preferences.ts | ||
| cost_events.ts | ||
| document_annotation_anchor_snapshots.ts | ||
| document_annotation_comments.ts | ||
| document_annotation_threads.ts | ||
| document_revisions.ts | ||
| documents.ts | ||
| environment_leases.ts | ||
| environments.ts | ||
| execution_workspaces.ts | ||
| feedback_exports.ts | ||
| feedback_votes.ts | ||
| finance_events.ts | ||
| goals.ts | ||
| heartbeat_run_events.ts | ||
| heartbeat_run_watchdog_decisions.ts | ||
| heartbeat_runs.ts | ||
| inbox_dismissals.ts | ||
| index.ts | ||
| instance_settings.ts | ||
| instance_user_roles.ts | ||
| invites.ts | ||
| issue_approvals.ts | ||
| issue_attachments.ts | ||
| issue_comments.ts | ||
| issue_documents.ts | ||
| issue_execution_decisions.ts | ||
| issue_inbox_archives.ts | ||
| issue_labels.ts | ||
| issue_plan_decompositions.ts | ||
| issue_read_states.ts | ||
| issue_recovery_actions.ts | ||
| issue_reference_mentions.ts | ||
| issue_relations.ts | ||
| issue_thread_interactions.ts | ||
| issue_tree_hold_members.ts | ||
| issue_tree_holds.ts | ||
| issue_work_products.ts | ||
| issues.ts | ||
| join_requests.ts | ||
| labels.ts | ||
| plugin_company_settings.ts | ||
| plugin_config.ts | ||
| plugin_database.ts | ||
| plugin_entities.ts | ||
| plugin_jobs.ts | ||
| plugin_logs.ts | ||
| plugin_managed_resources.ts | ||
| plugin_state.ts | ||
| plugin_webhooks.ts | ||
| plugins.ts | ||
| principal_permission_grants.ts | ||
| project_goals.ts | ||
| project_memberships.ts | ||
| project_workspaces.ts | ||
| projects.ts | ||
| routines.ts | ||
| secret_access_events.ts | ||
| user_sidebar_preferences.ts | ||
| workspace_operations.ts | ||
| workspace_runtime_services.ts | ||