mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-17 19:20:39 +09:00
b6e40fec54
Closes #2412 Related: #2681, #498, #128 ## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The Claude Code adapter spawns the `claude` CLI to run agent tasks > - The adapter detects auth mode by checking for `ANTHROPIC_API_KEY` — recognizing only "api" and "subscription" modes > - But users running Claude Code via **AWS Bedrock** (`CLAUDE_CODE_USE_BEDROCK=1`) fall through to the "subscription" path > - This causes a misleading "ANTHROPIC_API_KEY is not set; subscription-based auth can be used" message in the environment check > - Additionally, the hello probe passes `--model claude-opus-4-6` which is **not a valid Bedrock model identifier**, causing `400 The provided model identifier is invalid` and a probe failure > - This pull request adds Bedrock auth detection, skips the Anthropic-style `--model` flag for Bedrock, and returns the correct billing type > - The benefit is that Bedrock users get a working environment check and correct cost tracking out of the box --- ## Pain Point Many enterprise teams use **Claude Code through AWS Bedrock** rather than Anthropic's direct API — for compliance, billing consolidation, or VPC requirements. Currently, these users hit a **hard wall during onboarding**: | Problem | Impact | |---|---| | ❌ Adapter environment check **always fails** | Users cannot create their first agent — blocked at step 1 | | ❌ `--model claude-opus-4-6` is **invalid on Bedrock** (requires `us.anthropic.*` format) | Hello probe exits with code 1: `400 The provided model identifier is invalid` | | ❌ Auth shown as _"subscription-based"_ | Misleading — Bedrock is neither subscription nor API-key auth | | ❌ Quota polling hits Anthropic OAuth endpoint | Fails silently for Bedrock users who have no Anthropic subscription | > **Bottom line**: Paperclip is completely unusable for Bedrock users out of the box. ## Why Bedrock Matters AWS Bedrock is a major deployment path for Claude in enterprise environments: - **Enterprise compliance** — data stays within the customer's AWS account and VPC - **Unified billing** — Claude usage appears on the existing AWS invoice, no separate Anthropic billing - **IAM integration** — access controlled through AWS IAM roles and policies - **Regional deployment** — models run in the customer's preferred AWS region Supporting Bedrock unlocks Paperclip for organizations that **cannot** use Anthropic's direct API due to procurement, security, or regulatory constraints. --- ## What Changed - **`execute.ts`**: Added `isBedrockAuth()` helper that checks `CLAUDE_CODE_USE_BEDROCK` and `ANTHROPIC_BEDROCK_BASE_URL` env vars. `resolveClaudeBillingType()` now returns `"metered_api"` for Bedrock. Biller set to `"aws_bedrock"`. Skips `--model` flag when Bedrock is active (Anthropic-style model IDs are invalid on Bedrock; the CLI uses its own configured model). - **`test.ts`**: Environment check now detects Bedrock env vars (from adapter config or server env) and shows `"AWS Bedrock auth detected. Claude will use Bedrock for inference."` instead of the misleading subscription message. Also skips `--model` in the hello probe for Bedrock. - **`quota.ts`**: Early return with `{ ok: true, windows: [] }` when Bedrock is active — Bedrock usage is billed through AWS, not Anthropic's subscription quota system. - **`ui/src/lib/utils.ts`**: Added `"aws_bedrock"` → `"AWS Bedrock"` to `providerDisplayName()` and `quotaSourceDisplayName()`. ## Verification 1. `pnpm -r typecheck` — all packages pass 2. Unit tests added and passing (6/6) 3. Environment check with Bedrock env vars: | | Before | After | |---|---|---| | **Status** | 🔴 Failed | ✅ Passed | | **Auth message** | `ANTHROPIC_API_KEY is not set; subscription-based auth can be used if Claude is logged in.` | `AWS Bedrock auth detected. Claude will use Bedrock for inference.` | | **Hello probe** | `ERROR · Claude hello probe failed.` (exit code 1 — `--model claude-opus-4-6` is invalid on Bedrock) | `INFO · Claude hello probe succeeded.` | | **Screenshot** | <img height="500" alt="Screenshot 2026-04-05 at 8 25 27 AM" src="https://github.com/user-attachments/assets/476431f6-6139-425a-8abc-97875d653657" /> | <img height="500" alt="Screenshot 2026-04-05 at 8 31 58 AM" src="https://github.com/user-attachments/assets/d388ce87-c5e6-4574-b8d2-fd8b86135299" /> | 4. Existing API key / subscription paths are completely untouched unless Bedrock env vars are present ## Risks - **Low risk.** All changes are additive — existing "api" and "subscription" code paths are only entered when Bedrock env vars are absent. - When Bedrock is active, the `--model` flag is skipped, so the Paperclip model dropdown selection is ignored in favor of the Claude CLI's own model config. This is intentional since Bedrock requires different model identifiers. ## Model Used - Claude Opus 4.6 (`claude-opus-4-6`, 1M context window) via Claude Code CLI ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| agent-icons.ts | ||
| agent-order.ts | ||
| agent-skills-state.test.ts | ||
| agent-skills-state.ts | ||
| assignees.test.ts | ||
| assignees.ts | ||
| color-contrast.ts | ||
| comment-submit-draft.test.ts | ||
| comment-submit-draft.ts | ||
| company-export-selection.test.ts | ||
| company-export-selection.ts | ||
| company-page-memory.ts | ||
| company-portability-sidebar.test.ts | ||
| company-portability-sidebar.ts | ||
| company-routes.test.ts | ||
| company-routes.ts | ||
| company-selection.test.ts | ||
| company-selection.ts | ||
| groupBy.ts | ||
| inbox.test.ts | ||
| inbox.ts | ||
| instance-settings.test.ts | ||
| instance-settings.ts | ||
| issue-timeline-events.test.ts | ||
| issue-timeline-events.ts | ||
| issue-tree.test.ts | ||
| issue-tree.ts | ||
| issueDetailBreadcrumb.test.ts | ||
| issueDetailBreadcrumb.ts | ||
| keyboardShortcuts.test.ts | ||
| keyboardShortcuts.ts | ||
| legacy-agent-config.test.ts | ||
| legacy-agent-config.ts | ||
| markdownPaste.test.ts | ||
| markdownPaste.ts | ||
| mention-aware-link-node.test.ts | ||
| mention-aware-link-node.ts | ||
| mention-chips.ts | ||
| mention-deletion.test.ts | ||
| mention-deletion.ts | ||
| model-utils.ts | ||
| normalize-markdown.test.ts | ||
| normalize-markdown.ts | ||
| onboarding-goal.test.ts | ||
| onboarding-goal.ts | ||
| onboarding-launch.test.ts | ||
| onboarding-launch.ts | ||
| onboarding-route.test.ts | ||
| onboarding-route.ts | ||
| optimistic-issue-comments.test.ts | ||
| optimistic-issue-comments.ts | ||
| paste-normalization.ts | ||
| portable-files.ts | ||
| project-order.ts | ||
| project-workspaces-tab.test.ts | ||
| project-workspaces-tab.ts | ||
| queryKeys.ts | ||
| recent-assignees.ts | ||
| router.tsx | ||
| routine-trigger-patch.test.ts | ||
| routine-trigger-patch.ts | ||
| status-colors.ts | ||
| timeAgo.ts | ||
| utils.ts | ||
| worktree-branding.ts | ||
| zip.test.ts | ||
| zip.ts | ||