mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 01:50:39 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The control plane depends on authenticated routes enforcing company boundaries and role permissions correctly > - This branch also touches the issue detail and markdown editing flows operators use while handling advisory and triage work > - Partial issue cache seeds and fragile rich-editor parsing could leave important issue content missing or blank at the moment an operator needed it > - Blocked issues becoming actionable again should wake their assignee automatically instead of silently staying idle > - This pull request rebases the advisory follow-up branch onto current `master`, hardens authenticated route authorization, and carries the issue-detail/editor reliability fixes forward with regression tests > - The benefit is tighter authz on sensitive routes plus more reliable issue/advisory editing and wakeup behavior on top of the latest base ## What Changed - Hardened authenticated route authorization across agent, activity, approval, access, project, plugin, health, execution-workspace, portability, and related server paths, with new cross-tenant and runtime-authz regression coverage. - Switched issue detail queries from `initialData` to placeholder-based hydration so list/quicklook seeds still refetch full issue bodies. - Normalized advisory-style HTML images before mounting the markdown editor and strengthened fallback behavior when the rich editor silently fails or rejects the content. - Woke assigned agents when blocked issues move back to `todo`, with route coverage for reopen and unblock transitions. - Rebasing note: this branch now sits cleanly on top of the latest `master` tip used for the PR base. ## Verification - `pnpm exec vitest run ui/src/lib/issueDetailQuery.test.tsx ui/src/components/MarkdownEditor.test.tsx server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/activity-routes.test.ts server/src/__tests__/agent-cross-tenant-authz-routes.test.ts` - Confirmed `pnpm-lock.yaml` is not part of the PR diff. - Rebased the branch onto current `public-gh/master` before publishing. ## Risks - Broad authz tightening may expose existing flows that were relying on permissive board or agent access and now need explicit grants. - Markdown editor fallback changes could affect focus or rendering in edge-case content that mixes HTML-like advisory markup with normal markdown. - This verification was intentionally scoped to touched regressions and did not run the full repository suite. ## Model Used - OpenAI Codex, GPT-5-based coding agent in the Codex CLI environment with tool use for terminal, git, and GitHub operations. The exact runtime model identifier is not exposed inside this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, it is behavior-only and does not need before/after screenshots - [x] I have updated relevant documentation to reflect my changes, or no documentation changes were needed for these internal fixes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
138 lines
4 KiB
TypeScript
138 lines
4 KiB
TypeScript
import { and, eq, inArray, isNull, ne, or } from "drizzle-orm";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { agents, issues } from "@paperclipai/db";
|
|
import type { Request } from "express";
|
|
import { forbidden } from "../errors.js";
|
|
import { assertCompanyAccess } from "./authz.js";
|
|
|
|
const WORKSPACE_RUNTIME_ELIGIBLE_ISSUE_STATUSES: string[] = [
|
|
"backlog",
|
|
"todo",
|
|
"in_progress",
|
|
"in_review",
|
|
"blocked",
|
|
];
|
|
|
|
async function listReportingSubtreeAgentIds(db: Db, companyId: string, actorAgentId: string) {
|
|
const companyAgents = await db
|
|
.select({
|
|
id: agents.id,
|
|
reportsTo: agents.reportsTo,
|
|
})
|
|
.from(agents)
|
|
.where(and(eq(agents.companyId, companyId), ne(agents.status, "terminated")));
|
|
|
|
const reportsByManager = new Map<string, string[]>();
|
|
for (const agent of companyAgents) {
|
|
if (!agent.reportsTo) continue;
|
|
const reports = reportsByManager.get(agent.reportsTo) ?? [];
|
|
reports.push(agent.id);
|
|
reportsByManager.set(agent.reportsTo, reports);
|
|
}
|
|
|
|
const visited = new Set<string>([actorAgentId]);
|
|
const queue = [actorAgentId];
|
|
while (queue.length > 0) {
|
|
const current = queue.shift();
|
|
if (!current) continue;
|
|
const reports = reportsByManager.get(current) ?? [];
|
|
for (const reportId of reports) {
|
|
if (visited.has(reportId)) continue;
|
|
visited.add(reportId);
|
|
queue.push(reportId);
|
|
}
|
|
}
|
|
|
|
return [...visited];
|
|
}
|
|
|
|
async function assertAgentCanManageRuntimeServicesForWorkspace(
|
|
db: Db,
|
|
req: Request,
|
|
input: {
|
|
companyId: string;
|
|
projectWorkspaceId?: string | null;
|
|
executionWorkspaceId?: string | null;
|
|
sourceIssueId?: string | null;
|
|
},
|
|
) {
|
|
if (req.actor.type !== "agent" || !req.actor.agentId) {
|
|
throw forbidden("Agent authentication required");
|
|
}
|
|
|
|
const actorAgent = await db
|
|
.select({
|
|
id: agents.id,
|
|
companyId: agents.companyId,
|
|
role: agents.role,
|
|
})
|
|
.from(agents)
|
|
.where(eq(agents.id, req.actor.agentId))
|
|
.then((rows) => rows[0] ?? null);
|
|
|
|
if (!actorAgent || actorAgent.companyId !== input.companyId) {
|
|
throw forbidden("Agent key cannot access another company");
|
|
}
|
|
|
|
if (actorAgent.role === "ceo") {
|
|
return;
|
|
}
|
|
|
|
const eligibleAgentIds = await listReportingSubtreeAgentIds(db, input.companyId, actorAgent.id);
|
|
const workspaceScopeConditions = [
|
|
input.projectWorkspaceId ? eq(issues.projectWorkspaceId, input.projectWorkspaceId) : null,
|
|
input.executionWorkspaceId ? eq(issues.executionWorkspaceId, input.executionWorkspaceId) : null,
|
|
input.sourceIssueId ? eq(issues.id, input.sourceIssueId) : null,
|
|
].filter((condition): condition is NonNullable<typeof condition> => condition !== null);
|
|
|
|
if (workspaceScopeConditions.length === 0) {
|
|
throw forbidden("Missing permission to manage workspace runtime services");
|
|
}
|
|
|
|
const linkedIssue = await db
|
|
.select({ id: issues.id })
|
|
.from(issues)
|
|
.where(and(
|
|
eq(issues.companyId, input.companyId),
|
|
isNull(issues.hiddenAt),
|
|
inArray(issues.status, WORKSPACE_RUNTIME_ELIGIBLE_ISSUE_STATUSES),
|
|
inArray(issues.assigneeAgentId, eligibleAgentIds),
|
|
workspaceScopeConditions.length === 1
|
|
? workspaceScopeConditions[0]!
|
|
: or(...workspaceScopeConditions),
|
|
))
|
|
.then((rows) => rows[0] ?? null);
|
|
|
|
if (linkedIssue) {
|
|
return;
|
|
}
|
|
|
|
throw forbidden("Missing permission to manage workspace runtime services");
|
|
}
|
|
|
|
export async function assertCanManageProjectWorkspaceRuntimeServices(
|
|
db: Db,
|
|
req: Request,
|
|
input: {
|
|
companyId: string;
|
|
projectWorkspaceId: string;
|
|
},
|
|
) {
|
|
assertCompanyAccess(req, input.companyId);
|
|
if (req.actor.type === "board") return;
|
|
await assertAgentCanManageRuntimeServicesForWorkspace(db, req, input);
|
|
}
|
|
|
|
export async function assertCanManageExecutionWorkspaceRuntimeServices(
|
|
db: Db,
|
|
req: Request,
|
|
input: {
|
|
companyId: string;
|
|
executionWorkspaceId: string;
|
|
sourceIssueId?: string | null;
|
|
},
|
|
) {
|
|
assertCompanyAccess(req, input.companyId);
|
|
if (req.actor.type === "board") return;
|
|
await assertAgentCanManageRuntimeServicesForWorkspace(db, req, input);
|
|
}
|