mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 18:30:39 +09:00
d6d7a7cea6
## Thinking Path > - Paperclip is the control plane for autonomous AI companies. > - Routines are the scheduled/recurring work surface that keeps a company operating without manual kicks. > - Operators need routine edits to be auditable and recoverable, especially when routines control assignments, prompts, triggers, and webhook secrets. > - Documents already have revision-style safety, but routines did not have equivalent history or restore semantics. > - This pull request adds append-only routine revisions across the database, shared contracts, server routes, and board UI. > - The benefit is safer routine iteration: users can inspect history, compare changes, restore older definitions, and avoid overwriting newer edits. ## What Changed - Added `routine_revisions` storage, latest revision pointers on routines, shared types, validators, and API docs for routine revision history. - Added server service/route support for listing routine revisions, conflict-aware routine saves, and append-only restore operations. - Added a History tab on routine detail with revision preview, structured change summaries, description line diffs, dirty-edit blocking, restore confirmation, and restored webhook secret surfacing. - Extracted the line diff helper from `DocumentDiffModal` into `ui/src/lib/line-diff.ts` for reuse. - Rebased the branch onto current `public-gh/master` and renumbered the routine revision migration to `0077_unusual_karnak` after upstream `0076_useful_elektra`. - Made the `0077` routine revision migration idempotent so installs that already applied the branch-local `0076_unusual_karnak` can safely advance. - Updated the plugin SDK test harness routine fixture with the new revision fields required by the shared `Routine` contract. ## Verification - `pnpm --filter @paperclipai/db run check:migrations` passed. - `pnpm exec vitest run --project @paperclipai/shared packages/shared/src/validators/routine.test.ts` passed. - `pnpm exec vitest run --project @paperclipai/ui ui/src/lib/line-diff.test.ts ui/src/components/RoutineHistoryTab.test.tsx ui/src/lib/workspace-routines.test.ts ui/src/pages/Routines.test.tsx` passed. - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/routines-service.test.ts --pool=forks --poolOptions.forks.isolate=true` passed. - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/routines-routes.test.ts --pool=forks --poolOptions.forks.isolate=true` passed. - `pnpm --filter @paperclipai/plugin-sdk typecheck` passed after updating the SDK test harness fixture. - `pnpm --filter @paperclipai/plugin-sdk build` passed; this refreshed local generated SDK output needed by plugin example typechecks. - `pnpm -r typecheck` passed. ## Risks - Medium migration risk: this adds routine revision storage and backfills existing routines. The migration is ordered after upstream `0076` and uses `IF NOT EXISTS` / duplicate-object guards to tolerate earlier branch-local migration application. - Restore behavior intentionally appends a new revision instead of mutating history; callers expecting an in-place rollback need to follow the new latest revision pointer. - Restoring webhook triggers recreates webhook secret material, so users must copy newly surfaced secrets after restore. - Conflict-aware saves now reject stale routine edits when the client sends an older `baseRevisionId`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, with shell/tool use in a local git worktree. Exact context-window size is not exposed in this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Screenshots: not attached in this draft PR; the new UI flow is covered by component tests listed above. --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| activity-format.test.ts | ||
| activity-format.ts | ||
| agent-config-patch.test.ts | ||
| agent-config-patch.ts | ||
| agent-icons.ts | ||
| agent-order.ts | ||
| agent-skills-state.test.ts | ||
| agent-skills-state.ts | ||
| assignees.test.ts | ||
| assignees.ts | ||
| color-contrast.ts | ||
| comment-submit-draft.test.ts | ||
| comment-submit-draft.ts | ||
| company-export-selection.test.ts | ||
| company-export-selection.ts | ||
| company-members.test.ts | ||
| company-members.ts | ||
| company-page-memory.ts | ||
| company-portability-sidebar.test.ts | ||
| company-portability-sidebar.ts | ||
| company-routes.test.ts | ||
| company-routes.ts | ||
| company-selection.test.ts | ||
| company-selection.ts | ||
| document-revisions.test.ts | ||
| document-revisions.ts | ||
| groupBy.ts | ||
| inbox.test.ts | ||
| inbox.ts | ||
| instance-settings.test.ts | ||
| instance-settings.ts | ||
| invite-memory.ts | ||
| issue-assignee-overrides.test.ts | ||
| issue-assignee-overrides.ts | ||
| issue-chat-messages.test.ts | ||
| issue-chat-messages.ts | ||
| issue-chat-scroll.test.ts | ||
| issue-chat-scroll.ts | ||
| issue-detail-subissues.test.ts | ||
| issue-detail-subissues.ts | ||
| issue-execution-policy.ts | ||
| issue-filters.test.ts | ||
| issue-filters.ts | ||
| issue-monitor.ts | ||
| issue-properties-panel-key.test.ts | ||
| issue-properties-panel-key.ts | ||
| issue-reference.test.ts | ||
| issue-reference.ts | ||
| issue-thread-interactions.test.ts | ||
| issue-thread-interactions.ts | ||
| issue-timeline-events.test.ts | ||
| issue-timeline-events.ts | ||
| issue-tree.test.ts | ||
| issue-tree.ts | ||
| issueActiveRun.test.ts | ||
| issueActiveRun.ts | ||
| issueChatTranscriptRuns.test.ts | ||
| issueChatTranscriptRuns.ts | ||
| issueDetailBreadcrumb.test.ts | ||
| issueDetailBreadcrumb.ts | ||
| issueDetailCache.test.ts | ||
| issueDetailCache.ts | ||
| issueDetailQuery.test.tsx | ||
| keyboardShortcuts.test.ts | ||
| keyboardShortcuts.ts | ||
| legacy-agent-config.test.ts | ||
| legacy-agent-config.ts | ||
| line-diff.test.ts | ||
| line-diff.ts | ||
| liveIssueIds.test.ts | ||
| liveIssueIds.ts | ||
| main-content-focus.test.ts | ||
| main-content-focus.ts | ||
| markdownPaste.test.ts | ||
| markdownPaste.ts | ||
| mention-aware-link-node.test.ts | ||
| mention-aware-link-node.ts | ||
| mention-chips.ts | ||
| mention-deletion.test.ts | ||
| mention-deletion.ts | ||
| model-utils.ts | ||
| navigation-scroll.test.ts | ||
| navigation-scroll.ts | ||
| new-agent-hire-payload.test.ts | ||
| new-agent-hire-payload.ts | ||
| new-agent-runtime-config.test.ts | ||
| new-agent-runtime-config.ts | ||
| normalize-markdown.test.ts | ||
| normalize-markdown.ts | ||
| onboarding-goal.test.ts | ||
| onboarding-goal.ts | ||
| onboarding-launch.test.ts | ||
| onboarding-launch.ts | ||
| onboarding-route.test.ts | ||
| onboarding-route.ts | ||
| optimistic-issue-comments.test.ts | ||
| optimistic-issue-comments.ts | ||
| optimistic-issue-runs.test.ts | ||
| optimistic-issue-runs.ts | ||
| paste-normalization.ts | ||
| portable-files.ts | ||
| project-order.ts | ||
| project-workspaces-tab.test.ts | ||
| project-workspaces-tab.ts | ||
| query-placeholder-data.test.tsx | ||
| query-placeholder-data.ts | ||
| queryKeys.ts | ||
| recent-assignees.ts | ||
| recent-projects.ts | ||
| recent-selections.test.ts | ||
| recent-selections.ts | ||
| remark-soft-breaks.ts | ||
| reusable-execution-workspaces.test.ts | ||
| reusable-execution-workspaces.ts | ||
| router.tsx | ||
| routine-trigger-patch.test.ts | ||
| routine-trigger-patch.ts | ||
| runRetryState.test.ts | ||
| runRetryState.ts | ||
| status-colors.ts | ||
| subIssueDefaults.test.ts | ||
| subIssueDefaults.ts | ||
| timeAgo.ts | ||
| transcriptPresentation.test.ts | ||
| transcriptPresentation.ts | ||
| utils.ts | ||
| vite-watch.test.ts | ||
| vite-watch.ts | ||
| workflow-sort.test.ts | ||
| workflow-sort.ts | ||
| workspace-routines.test.ts | ||
| workspace-routines.ts | ||
| worktree-branding.ts | ||
| zip.test.ts | ||
| zip.ts | ||