mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-20 12:30:38 +09:00
d9f91576a0
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies, so planning approvals and child-issue fan-out are part of the core control-plane loop. > - Accepted plans are supposed to be a safe bridge from planning into execution, especially when agents wake from review decisions and reuse isolated workspaces. > - The duplicate-subtask incident showed that an accepted plan revision could be interpreted more than once across overlapping runs, which broke the single-source-of-truth model for issue decomposition. > - Fixing that required tightening the backend contract first: accepted-plan decomposition needs an exact-once fingerprint, durable claim state, and retry-safe child creation. > - Once that backend behavior existed, the board still needed visibility into what happened, so the issue detail view needed a dedicated decomposition section instead of forcing operators to reconstruct child creation from raw activity. > - This pull request adds the exact-once decomposition primitive, hardens wake routing and regressions around the incident, and surfaces decomposition state in the UI so future incidents are both prevented and easier to inspect. ## What Changed - Added accepted-plan decomposition semantics to `doc/execution-semantics.md`, including the exact-once fingerprint, durable claim/result expectations, and retry/resume behavior. - Added persistent accepted-plan decomposition claims in the backend, including schema, shared types/validators, service logic, and issue routes for creating and listing decomposition state. - Hardened heartbeat routing so an accepted-plan continuation stays scoped to the relevant planning issue instead of opportunistically re-decomposing another accepted issue on the same assignee. - Added regression coverage for the original failure modes: concurrent same-parent retries, cross-issue accepted-plan isolation, and partial child recreation under the same fingerprint. - Added the `Plan decomposition` issue-detail section plus supporting API/query-key/activity formatting updates so operators can see revision status, owner, child counts, and the linked child issues directly in the UI. - Included the small follow-up UI fix so the decomposition section still renders when the issue work mode is no longer `planning`. ## Verification - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` - `pnpm --filter @paperclipai/db typecheck` - `pnpm exec vitest run server/src/__tests__/issues-service.test.ts` - `pnpm exec vitest run server/src/__tests__/issues-service.test.ts -t "lists persisted decompositions with child issue summaries"` - `pnpm exec vitest run server/src/__tests__/issues-service.test.ts -t "accepted plan decomposition" server/src/__tests__/heartbeat-accepted-plan-workspace-refresh.test.ts server/src/__tests__/heartbeat-context-summary.test.ts` - Manual UI path: create a planning issue without an isolated execution workspace, add a `plan` document, accept the `request_confirmation`, let Paperclip create child issues, then reopen the parent issue detail page and confirm the `Plan decomposition` section shows the accepted revision, status, idempotent-claim badge, and child links. - Separate follow-up bug noted during manual UI validation: accepting a plan on an issue whose run never records `workspace_finalize` is tracked in `PAPA-445` and is not part of this PR’s fix scope. ## Risks - This adds a new migration and a large Drizzle snapshot update; reviewers should confirm the schema shape and generated metadata match the intended decomposition table. - The exact-once claim changes sit on the accepted-plan fan-out path, so regressions there could block legitimate child creation or mis-handle retries if the claim state machine is wrong. - The new UI only appears when decomposition records exist; reviewers should use the manual verification path above rather than expecting existing issues on a stale local instance to show the section automatically. - `PAPA-445` remains an open follow-up for the `workspace_finalize` accept gate when a planning handoff never records finalize; that bug can interfere with reproducing the UI flow on isolated workspaces but does not change the correctness of the exact-once decomposition feature itself. > Checked `ROADMAP.md`: this PR is a bug fix / control-plane hardening change for accepted-plan decomposition, not a new uncoordinated roadmap feature. ## Model Used - OpenAI Codex via Paperclip `codex_local` (GPT-5-based coding agent; exact backend model ID/context window not exposed in the run context), with repository tool use, shell execution, and code-editing capabilities. <img width="806" height="1069" alt="Screenshot 2026-05-27 at 11 05 48 PM" src="https://github.com/user-attachments/assets/5b00b670-96cd-4470-b0a3-581743bcae28" /> ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| acpx-model-filter.test.ts | ||
| acpx-model-filter.ts | ||
| activity-format.test.ts | ||
| activity-format.ts | ||
| agent-config-patch.test.ts | ||
| agent-config-patch.ts | ||
| agent-icons.ts | ||
| agent-onboarding-prompt.ts | ||
| agent-order.ts | ||
| agent-skills-state.test.ts | ||
| agent-skills-state.ts | ||
| assignees.test.ts | ||
| assignees.ts | ||
| blockedInbox.test.ts | ||
| blockedInbox.ts | ||
| color-contrast.ts | ||
| comment-submit-draft.test.ts | ||
| comment-submit-draft.ts | ||
| company-export-selection.test.ts | ||
| company-export-selection.ts | ||
| company-members.test.ts | ||
| company-members.ts | ||
| company-page-memory.ts | ||
| company-portability-sidebar.test.ts | ||
| company-portability-sidebar.ts | ||
| company-routes.test.ts | ||
| company-routes.ts | ||
| company-selection.test.ts | ||
| company-selection.ts | ||
| document-annotation-hash.test.ts | ||
| document-annotation-hash.ts | ||
| document-annotation-selection.test.ts | ||
| document-annotation-selection.ts | ||
| document-revisions.test.ts | ||
| document-revisions.ts | ||
| duplicate-agent-payload.test.ts | ||
| duplicate-agent-payload.ts | ||
| groupBy.ts | ||
| inbox.test.ts | ||
| inbox.ts | ||
| instance-settings.test.ts | ||
| instance-settings.ts | ||
| invite-memory.ts | ||
| issue-assignee-overrides.test.ts | ||
| issue-assignee-overrides.ts | ||
| issue-blockers.ts | ||
| issue-chat-messages.test.ts | ||
| issue-chat-messages.ts | ||
| issue-chat-scroll.test.ts | ||
| issue-chat-scroll.ts | ||
| issue-detail-subissues.test.ts | ||
| issue-detail-subissues.ts | ||
| issue-execution-policy.ts | ||
| issue-filters.test.ts | ||
| issue-filters.ts | ||
| issue-monitor.ts | ||
| issue-properties-panel-key.test.ts | ||
| issue-properties-panel-key.ts | ||
| issue-reference.test.ts | ||
| issue-reference.ts | ||
| issue-thread-interactions.test.ts | ||
| issue-thread-interactions.ts | ||
| issue-timeline-events.test.ts | ||
| issue-timeline-events.ts | ||
| issue-tree.test.ts | ||
| issue-tree.ts | ||
| issueActiveRun.test.ts | ||
| issueActiveRun.ts | ||
| issueChatTranscriptRuns.test.ts | ||
| issueChatTranscriptRuns.ts | ||
| issueDetailBreadcrumb.test.ts | ||
| issueDetailBreadcrumb.ts | ||
| issueDetailCache.test.ts | ||
| issueDetailCache.ts | ||
| issueDetailQuery.test.tsx | ||
| keyboardShortcuts.test.ts | ||
| keyboardShortcuts.ts | ||
| legacy-agent-config.test.ts | ||
| legacy-agent-config.ts | ||
| line-diff.test.ts | ||
| line-diff.ts | ||
| liveIssueIds.test.ts | ||
| liveIssueIds.ts | ||
| main-content-focus.test.ts | ||
| main-content-focus.ts | ||
| markdownPaste.test.ts | ||
| markdownPaste.ts | ||
| mention-aware-link-node.test.ts | ||
| mention-aware-link-node.ts | ||
| mention-chips.ts | ||
| mention-deletion.test.ts | ||
| mention-deletion.ts | ||
| model-utils.ts | ||
| navigation-scroll.test.ts | ||
| navigation-scroll.ts | ||
| new-agent-hire-payload.test.ts | ||
| new-agent-hire-payload.ts | ||
| new-agent-runtime-config.test.ts | ||
| new-agent-runtime-config.ts | ||
| normalize-markdown.test.ts | ||
| normalize-markdown.ts | ||
| onboarding-goal.test.ts | ||
| onboarding-goal.ts | ||
| onboarding-launch.test.ts | ||
| onboarding-launch.ts | ||
| onboarding-route.test.ts | ||
| onboarding-route.ts | ||
| optimistic-issue-comments.test.ts | ||
| optimistic-issue-comments.ts | ||
| optimistic-issue-runs.test.ts | ||
| optimistic-issue-runs.ts | ||
| paste-normalization.ts | ||
| portable-files.ts | ||
| project-order.ts | ||
| project-workspaces-tab.test.ts | ||
| project-workspaces-tab.ts | ||
| pwa-install-mode.test.ts | ||
| query-placeholder-data.test.tsx | ||
| query-placeholder-data.ts | ||
| queryKeys.ts | ||
| recent-assignees.ts | ||
| recent-projects.ts | ||
| recent-searches.ts | ||
| recent-selections.test.ts | ||
| recent-selections.ts | ||
| recovery-display.ts | ||
| remark-soft-breaks.ts | ||
| reusable-execution-workspaces.test.ts | ||
| reusable-execution-workspaces.ts | ||
| router.tsx | ||
| routine-trigger-patch.test.ts | ||
| routine-trigger-patch.ts | ||
| runRetryState.test.ts | ||
| runRetryState.ts | ||
| source-resolved-watchdog-fold.ts | ||
| status-colors.ts | ||
| subIssueDefaults.test.ts | ||
| subIssueDefaults.ts | ||
| successful-run-handoff.test.ts | ||
| successful-run-handoff.ts | ||
| system-notice-comment.test.ts | ||
| system-notice-comment.ts | ||
| timeAgo.ts | ||
| transcriptPresentation.test.ts | ||
| transcriptPresentation.ts | ||
| utils.ts | ||
| vite-watch.test.ts | ||
| vite-watch.ts | ||
| websocket-url.test.ts | ||
| websocket-url.ts | ||
| workflow-sort.test.ts | ||
| workflow-sort.ts | ||
| workspace-routines.test.ts | ||
| workspace-routines.ts | ||
| worktree-branding.ts | ||
| zip.test.ts | ||
| zip.ts | ||