paperclip/packages/mcp-server/src/tools.test.ts
Dotta e400315cbf
Guard assigned backlog liveness (#5428)
## Thinking Path

> - Paperclip orchestrates AI agents for zero-human companies
> - The issue graph and liveness recovery system decide whether assigned
work is executable or parked
> - Assigned issues created without an explicit status could silently
land in backlog, making parents look blocked with no productive wake
path
> - The server, shared validators, recovery analysis, and UI all need to
agree on that execution semantic
> - This pull request makes assigned issue creation default to `todo`,
flags assigned backlog blockers, and surfaces the state in the board
> - The benefit is that parked assigned work becomes intentional and
visible instead of creating silent liveness stalls

## What Changed

- Adds contract tests for assigned issue creation defaults.
- Defaults assigned issue creation to `todo` when status is omitted
while preserving explicit `backlog` parking.
- Exposes `resolveCreateIssueStatusDefault` through shared validators.
- Teaches liveness/blocker attention paths to distinguish assigned
backlog blockers.
- Adds UI notices, row/header badges, and issue detail safeguards for
assigned backlog blockers.
- Adds Storybook fixtures and execution-semantics documentation for the
assigned-backlog behavior.

## Verification

- `pnpm run preflight:workspace-links && pnpm exec vitest run
packages/shared/src/validators/issue.test.ts
server/src/__tests__/issue-assigned-backlog-contract-routes.test.ts
server/src/__tests__/issue-blocker-attention.test.ts
server/src/__tests__/issue-liveness.test.ts
server/src/__tests__/heartbeat-issue-liveness-escalation.test.ts
ui/src/components/IssueAssignedBacklogNotice.test.tsx
ui/src/components/IssueRow.test.tsx` — 50 passed, 23 skipped.
- Skipped tests were embedded Postgres suites on this host with the repo
skip message: `Postgres init script exited with code null. Please check
the logs for extra info. The data directory might already exist.`
- Pairwise merge check against the issue-controls PR branch completed
without conflicts via `git merge --no-commit --no-ff` in a temporary
worktree.
- Screenshots for assigned-backlog UI states:
[light](docs/pr-screenshots/pr-5428/assigned-backlog-light.png),
[dark](docs/pr-screenshots/pr-5428/assigned-backlog-dark.png).
- Follow-up checks: `pnpm --filter /ui typecheck`; `pnpm --filter
/mcp-server build`; `pnpm --filter /mcp-server test`; `pnpm exec vitest
run packages/shared/src/validators/issue.test.ts`; focused UI component
tests.
- Remote PR checks on head `6300b3c`: policy, verify, serialized server
shards 1/4-4/4, Canary Dry Run, e2e, Greptile Review, and Snyk all
passed.

## Risks

- Medium: changes status defaulting for assigned issue creation when the
caller omits status. Explicit `backlog` remains supported, and
server/shared tests cover both paths.
- Medium: liveness classification changes can affect blocker attention
labels; focused service and UI tests cover the new assigned-backlog
state.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool-enabled
Paperclip heartbeat environment. Context window and internal reasoning
mode are not exposed by the runtime.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-05-07 12:25:26 -05:00

344 lines
11 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import { PaperclipApiClient } from "./client.js";
import { createToolDefinitions } from "./tools.js";
function makeClient() {
return new PaperclipApiClient({
apiUrl: "http://localhost:3100/api",
apiKey: "token-123",
companyId: "11111111-1111-1111-1111-111111111111",
agentId: "22222222-2222-2222-2222-222222222222",
runId: "33333333-3333-3333-3333-333333333333",
});
}
function getTool(name: string) {
const tool = createToolDefinitions(makeClient()).find((candidate) => candidate.name === name);
if (!tool) throw new Error(`Missing tool ${name}`);
return tool;
}
function mockJsonResponse(body: unknown, status = 200) {
return new Response(JSON.stringify(body), {
status,
headers: { "Content-Type": "application/json" },
});
}
describe("paperclip MCP tools", () => {
beforeEach(() => {
vi.restoreAllMocks();
});
it("adds auth headers and run id to mutating requests", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ ok: true }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipUpdateIssue");
await tool.execute({
issueId: "PAP-1135",
status: "done",
});
expect(fetchMock).toHaveBeenCalledTimes(1);
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135");
expect(init.method).toBe("PATCH");
expect((init.headers as Record<string, string>)["Authorization"]).toBe("Bearer token-123");
expect((init.headers as Record<string, string>)["X-Paperclip-Run-Id"]).toBe(
"33333333-3333-3333-3333-333333333333",
);
});
it("uses default company id for company-scoped list tools", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse([{ id: "issue-1" }]),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipListIssues");
const response = await tool.execute({});
expect(fetchMock).toHaveBeenCalledTimes(1);
const [url] = fetchMock.mock.calls[0] as [string];
expect(String(url)).toBe(
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/issues",
);
expect(response.content[0]?.text).toContain("issue-1");
});
it("uses default agent id for checkout requests", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "PAP-1135", status: "in_progress" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipCheckoutIssue");
await tool.execute({
issueId: "PAP-1135",
});
const [, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(JSON.parse(String(init.body))).toEqual({
agentId: "22222222-2222-2222-2222-222222222222",
expectedStatuses: ["todo", "backlog", "blocked"],
});
});
it("allows create issue requests to omit status so the API applies assignee defaults", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "issue-1", status: "todo" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipCreateIssue");
await tool.execute({
title: "Assigned follow-up",
assigneeAgentId: "22222222-2222-2222-2222-222222222222",
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe(
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/issues",
);
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
title: "Assigned follow-up",
workMode: "standard",
priority: "medium",
assigneeAgentId: "22222222-2222-2222-2222-222222222222",
requestDepth: 0,
});
});
it("defaults issue document format to markdown", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ key: "plan", latestRevisionNumber: 2 }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipUpsertIssueDocument");
await tool.execute({
issueId: "PAP-1135",
key: "plan",
body: "# Updated",
});
const [, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(JSON.parse(String(init.body))).toEqual({
format: "markdown",
body: "# Updated",
});
});
it("controls issue workspace services through the current execution workspace", async () => {
const fetchMock = vi.fn()
.mockResolvedValueOnce(mockJsonResponse({
currentExecutionWorkspace: {
id: "44444444-4444-4444-8444-444444444444",
runtimeServices: [],
},
}))
.mockResolvedValueOnce(mockJsonResponse({
operation: { id: "operation-1" },
workspace: {
id: "44444444-4444-4444-8444-444444444444",
runtimeServices: [
{
id: "55555555-5555-4555-8555-555555555555",
serviceName: "web",
status: "running",
url: "http://127.0.0.1:5173",
},
],
},
}));
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipControlIssueWorkspaceServices");
await tool.execute({
issueId: "PAP-1135",
action: "restart",
workspaceCommandId: "web",
});
expect(fetchMock).toHaveBeenCalledTimes(2);
const [lookupUrl, lookupInit] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(lookupUrl)).toBe("http://localhost:3100/api/issues/PAP-1135/heartbeat-context");
expect(lookupInit.method).toBe("GET");
const [controlUrl, controlInit] = fetchMock.mock.calls[1] as [string, RequestInit];
expect(String(controlUrl)).toBe(
"http://localhost:3100/api/execution-workspaces/44444444-4444-4444-8444-444444444444/runtime-services/restart",
);
expect(controlInit.method).toBe("POST");
expect(JSON.parse(String(controlInit.body))).toEqual({
workspaceCommandId: "web",
});
});
it("waits for an issue workspace runtime service URL", async () => {
const fetchMock = vi.fn()
.mockResolvedValueOnce(mockJsonResponse({
currentExecutionWorkspace: {
id: "44444444-4444-4444-8444-444444444444",
runtimeServices: [
{
id: "55555555-5555-4555-8555-555555555555",
serviceName: "web",
status: "running",
healthStatus: "healthy",
url: "http://127.0.0.1:5173",
},
],
},
}));
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipWaitForIssueWorkspaceService");
const response = await tool.execute({
issueId: "PAP-1135",
serviceName: "web",
timeoutSeconds: 1,
});
expect(fetchMock).toHaveBeenCalledTimes(1);
expect(response.content[0]?.text).toContain("http://127.0.0.1:5173");
});
it("creates suggest_tasks interactions with the expected issue-scoped payload", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "interaction-1", kind: "suggest_tasks" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipSuggestTasks");
await tool.execute({
issueId: "PAP-1135",
idempotencyKey: "run-1:suggest",
payload: {
version: 1,
tasks: [{ clientKey: "task-1", title: "One" }],
},
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135/interactions");
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
kind: "suggest_tasks",
continuationPolicy: "wake_assignee",
idempotencyKey: "run-1:suggest",
payload: {
version: 1,
tasks: [{ clientKey: "task-1", title: "One" }],
},
});
});
it("creates request_confirmation interactions with plan target payloads", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "interaction-1", kind: "request_confirmation" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipRequestConfirmation");
await tool.execute({
issueId: "PAP-1135",
idempotencyKey: "confirmation:PAP-1135:plan:33333333-3333-4333-8333-333333333333",
title: "Plan approval",
payload: {
version: 1,
prompt: "Accept this plan?",
acceptLabel: "Accept plan",
allowDeclineReason: true,
rejectLabel: "Request changes",
rejectRequiresReason: true,
supersedeOnUserComment: true,
target: {
type: "issue_document",
key: "plan",
revisionId: "33333333-3333-4333-8333-333333333333",
revisionNumber: 3,
},
},
});
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe("http://localhost:3100/api/issues/PAP-1135/interactions");
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
kind: "request_confirmation",
continuationPolicy: "none",
idempotencyKey: "confirmation:PAP-1135:plan:33333333-3333-4333-8333-333333333333",
title: "Plan approval",
payload: {
version: 1,
prompt: "Accept this plan?",
acceptLabel: "Accept plan",
allowDeclineReason: true,
rejectLabel: "Request changes",
rejectRequiresReason: true,
supersedeOnUserComment: true,
target: {
type: "issue_document",
key: "plan",
revisionId: "33333333-3333-4333-8333-333333333333",
revisionNumber: 3,
},
},
});
});
it("creates approvals with the expected company-scoped payload", async () => {
const fetchMock = vi.fn().mockResolvedValue(
mockJsonResponse({ id: "approval-1" }),
);
vi.stubGlobal("fetch", fetchMock);
const tool = getTool("paperclipCreateApproval");
await tool.execute({
type: "hire_agent",
payload: { branch: "pap-1167" },
issueIds: ["44444444-4444-4444-4444-444444444444"],
});
expect(fetchMock).toHaveBeenCalledTimes(1);
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
expect(String(url)).toBe(
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/approvals",
);
expect(init.method).toBe("POST");
expect(JSON.parse(String(init.body))).toEqual({
type: "hire_agent",
payload: { branch: "pap-1167" },
issueIds: ["44444444-4444-4444-4444-444444444444"],
});
});
it("rejects invalid generic request paths", async () => {
vi.stubGlobal("fetch", vi.fn());
const tool = getTool("paperclipApiRequest");
const response = await tool.execute({
method: "GET",
path: "issues",
});
expect(response.content[0]?.text).toContain("path must start with /");
});
it("rejects generic request paths that escape /api", async () => {
vi.stubGlobal("fetch", vi.fn());
const tool = getTool("paperclipApiRequest");
const response = await tool.execute({
method: "GET",
path: "/../../secret",
});
expect(response.content[0]?.text).toContain("must not contain '..'");
});
});