mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 10:30:37 +09:00
32a9165ddf
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The control plane depends on authenticated routes enforcing company boundaries and role permissions correctly > - This branch also touches the issue detail and markdown editing flows operators use while handling advisory and triage work > - Partial issue cache seeds and fragile rich-editor parsing could leave important issue content missing or blank at the moment an operator needed it > - Blocked issues becoming actionable again should wake their assignee automatically instead of silently staying idle > - This pull request rebases the advisory follow-up branch onto current `master`, hardens authenticated route authorization, and carries the issue-detail/editor reliability fixes forward with regression tests > - The benefit is tighter authz on sensitive routes plus more reliable issue/advisory editing and wakeup behavior on top of the latest base ## What Changed - Hardened authenticated route authorization across agent, activity, approval, access, project, plugin, health, execution-workspace, portability, and related server paths, with new cross-tenant and runtime-authz regression coverage. - Switched issue detail queries from `initialData` to placeholder-based hydration so list/quicklook seeds still refetch full issue bodies. - Normalized advisory-style HTML images before mounting the markdown editor and strengthened fallback behavior when the rich editor silently fails or rejects the content. - Woke assigned agents when blocked issues move back to `todo`, with route coverage for reopen and unblock transitions. - Rebasing note: this branch now sits cleanly on top of the latest `master` tip used for the PR base. ## Verification - `pnpm exec vitest run ui/src/lib/issueDetailQuery.test.tsx ui/src/components/MarkdownEditor.test.tsx server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/activity-routes.test.ts server/src/__tests__/agent-cross-tenant-authz-routes.test.ts` - Confirmed `pnpm-lock.yaml` is not part of the PR diff. - Rebased the branch onto current `public-gh/master` before publishing. ## Risks - Broad authz tightening may expose existing flows that were relying on permissive board or agent access and now need explicit grants. - Markdown editor fallback changes could affect focus or rendering in edge-case content that mixes HTML-like advisory markup with normal markdown. - This verification was intentionally scoped to touched regressions and did not run the full repository suite. ## Model Used - OpenAI Codex, GPT-5-based coding agent in the Codex CLI environment with tool use for terminal, git, and GitHub operations. The exact runtime model identifier is not exposed inside this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, it is behavior-only and does not need before/after screenshots - [x] I have updated relevant documentation to reflect my changes, or no documentation changes were needed for these internal fixes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> |
||
|---|---|---|
| .. | ||
| activity-format.test.ts | ||
| activity-format.ts | ||
| agent-config-patch.test.ts | ||
| agent-config-patch.ts | ||
| agent-icons.ts | ||
| agent-order.ts | ||
| agent-skills-state.test.ts | ||
| agent-skills-state.ts | ||
| assignees.test.ts | ||
| assignees.ts | ||
| color-contrast.ts | ||
| comment-submit-draft.test.ts | ||
| comment-submit-draft.ts | ||
| company-export-selection.test.ts | ||
| company-export-selection.ts | ||
| company-page-memory.ts | ||
| company-portability-sidebar.test.ts | ||
| company-portability-sidebar.ts | ||
| company-routes.test.ts | ||
| company-routes.ts | ||
| company-selection.test.ts | ||
| company-selection.ts | ||
| document-revisions.test.ts | ||
| document-revisions.ts | ||
| groupBy.ts | ||
| inbox.test.ts | ||
| inbox.ts | ||
| instance-settings.test.ts | ||
| instance-settings.ts | ||
| issue-chat-messages.test.ts | ||
| issue-chat-messages.ts | ||
| issue-chat-scroll.test.ts | ||
| issue-chat-scroll.ts | ||
| issue-detail-subissues.test.ts | ||
| issue-detail-subissues.ts | ||
| issue-execution-policy.ts | ||
| issue-filters.ts | ||
| issue-properties-panel-key.test.ts | ||
| issue-properties-panel-key.ts | ||
| issue-reference.test.ts | ||
| issue-reference.ts | ||
| issue-timeline-events.test.ts | ||
| issue-timeline-events.ts | ||
| issue-tree.test.ts | ||
| issue-tree.ts | ||
| issueActiveRun.test.ts | ||
| issueActiveRun.ts | ||
| issueChatTranscriptRuns.test.ts | ||
| issueChatTranscriptRuns.ts | ||
| issueDetailBreadcrumb.test.ts | ||
| issueDetailBreadcrumb.ts | ||
| issueDetailCache.test.ts | ||
| issueDetailCache.ts | ||
| issueDetailQuery.test.tsx | ||
| keyboardShortcuts.test.ts | ||
| keyboardShortcuts.ts | ||
| legacy-agent-config.test.ts | ||
| legacy-agent-config.ts | ||
| main-content-focus.test.ts | ||
| main-content-focus.ts | ||
| markdownPaste.test.ts | ||
| markdownPaste.ts | ||
| mention-aware-link-node.test.ts | ||
| mention-aware-link-node.ts | ||
| mention-chips.ts | ||
| mention-deletion.test.ts | ||
| mention-deletion.ts | ||
| model-utils.ts | ||
| navigation-scroll.test.ts | ||
| navigation-scroll.ts | ||
| new-agent-runtime-config.test.ts | ||
| new-agent-runtime-config.ts | ||
| normalize-markdown.test.ts | ||
| normalize-markdown.ts | ||
| onboarding-goal.test.ts | ||
| onboarding-goal.ts | ||
| onboarding-launch.test.ts | ||
| onboarding-launch.ts | ||
| onboarding-route.test.ts | ||
| onboarding-route.ts | ||
| optimistic-issue-comments.test.ts | ||
| optimistic-issue-comments.ts | ||
| optimistic-issue-runs.test.ts | ||
| optimistic-issue-runs.ts | ||
| paste-normalization.ts | ||
| portable-files.ts | ||
| project-order.ts | ||
| project-workspaces-tab.test.ts | ||
| project-workspaces-tab.ts | ||
| query-placeholder-data.test.tsx | ||
| query-placeholder-data.ts | ||
| queryKeys.ts | ||
| recent-assignees.ts | ||
| remark-soft-breaks.ts | ||
| router.tsx | ||
| routine-trigger-patch.test.ts | ||
| routine-trigger-patch.ts | ||
| status-colors.ts | ||
| subIssueDefaults.test.ts | ||
| subIssueDefaults.ts | ||
| timeAgo.ts | ||
| transcriptPresentation.test.ts | ||
| transcriptPresentation.ts | ||
| utils.ts | ||
| worktree-branding.ts | ||
| zip.test.ts | ||
| zip.ts | ||