mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-18 11:40:39 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - A core part of that is the operator experience around reading issue state, agent chat, and sub-task structure > - The current branch had a long run of issue-detail and issue-list UX fixes that all improve how humans follow and steer active work > - Those changes mostly live in the UI/chat surface and should be reviewed together instead of mixed with workspace/runtime work > - This pull request packages the issue-detail, chat, markdown, and sub-issue list improvements into one standalone change > - The benefit is a cleaner, less jumpy, more reliable issue workflow on desktop and mobile without coupling it to unrelated server/runtime refactors ## What Changed - Stabilized issue chat runtime wiring, optimistic comment handling, queued-comment cancellation, and composer anchoring during live updates - Fixed several issue-detail rendering and navigation regressions including placeholder bleed, local polling scope, mobile inbox-to-issue transitions, and visible refresh resets - Improved markdown and rich-content handling with advisory image normalization, editor fallback behavior, touch mention recovery, and `issue:` quicklook links - Refined sub-issue behavior with parent-derived defaults, current-user inheritance fixes, empty-state cleanup, and a reusable issue-list presentation for sub-issues - Added targeted UI tests for the new issue-detail, chat scroll/message, placeholder-data, markdown, and issue-list behaviors ## Verification - `pnpm vitest run ui/src/components/IssueChatThread.test.tsx ui/src/components/MarkdownEditor.test.tsx ui/src/components/IssuesList.test.tsx ui/src/context/LiveUpdatesProvider.test.tsx ui/src/lib/issue-chat-messages.test.ts ui/src/lib/issue-chat-scroll.test.ts ui/src/lib/issue-detail-subissues.test.ts ui/src/lib/query-placeholder-data.test.tsx ui/src/hooks/usePaperclipIssueRuntime.test.tsx` ## Risks - Medium: this branch touches the highest-traffic issue-detail UI paths, so regressions would show up as chat/thread or sub-issue UX glitches - The changes are UI-heavy and would benefit from reviewer screenshots or a quick manual browser pass before merge ## Model Used - OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact deployed model ID is not exposed in this environment), reasoning enabled, tool use and local code execution enabled ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
121 lines
4.2 KiB
TypeScript
121 lines
4.2 KiB
TypeScript
import { Link } from "@/lib/router";
|
|
import { Menu } from "lucide-react";
|
|
import { useBreadcrumbs } from "../context/BreadcrumbContext";
|
|
import { useSidebar } from "../context/SidebarContext";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
Breadcrumb,
|
|
BreadcrumbItem,
|
|
BreadcrumbLink,
|
|
BreadcrumbList,
|
|
BreadcrumbPage,
|
|
BreadcrumbSeparator,
|
|
} from "@/components/ui/breadcrumb";
|
|
import { Fragment, useMemo } from "react";
|
|
import { PluginSlotOutlet, usePluginSlots } from "@/plugins/slots";
|
|
import { PluginLauncherOutlet, usePluginLaunchers } from "@/plugins/launchers";
|
|
|
|
type GlobalToolbarContext = { companyId: string | null; companyPrefix: string | null };
|
|
|
|
function GlobalToolbarPlugins({ context }: { context: GlobalToolbarContext }) {
|
|
const { slots } = usePluginSlots({ slotTypes: ["globalToolbarButton"], companyId: context.companyId });
|
|
const { launchers } = usePluginLaunchers({ placementZones: ["globalToolbarButton"], companyId: context.companyId, enabled: !!context.companyId });
|
|
if (slots.length === 0 && launchers.length === 0) return null;
|
|
return (
|
|
<div className="flex items-center gap-1 ml-auto shrink-0 pl-2">
|
|
<PluginSlotOutlet slotTypes={["globalToolbarButton"]} context={context} className="flex items-center gap-1" />
|
|
<PluginLauncherOutlet placementZones={["globalToolbarButton"]} context={context} className="flex items-center gap-1" />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function BreadcrumbBar() {
|
|
const { breadcrumbs, mobileToolbar } = useBreadcrumbs();
|
|
const { toggleSidebar, isMobile } = useSidebar();
|
|
const { selectedCompanyId, selectedCompany } = useCompany();
|
|
|
|
const globalToolbarSlotContext = useMemo(
|
|
() => ({
|
|
companyId: selectedCompanyId ?? null,
|
|
companyPrefix: selectedCompany?.issuePrefix ?? null,
|
|
}),
|
|
[selectedCompanyId, selectedCompany?.issuePrefix],
|
|
);
|
|
|
|
const globalToolbarSlots = <GlobalToolbarPlugins context={globalToolbarSlotContext} />;
|
|
|
|
if (isMobile && mobileToolbar) {
|
|
return (
|
|
<div className="border-b border-border px-2 h-12 shrink-0 flex items-center">
|
|
{mobileToolbar}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (breadcrumbs.length === 0) {
|
|
return (
|
|
<div className="border-b border-border px-4 md:px-6 h-12 shrink-0 flex items-center justify-end">
|
|
{globalToolbarSlots}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const menuButton = isMobile && (
|
|
<Button
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
className="mr-2 shrink-0"
|
|
onClick={toggleSidebar}
|
|
aria-label="Open sidebar"
|
|
>
|
|
<Menu className="h-5 w-5" />
|
|
</Button>
|
|
);
|
|
|
|
// Single breadcrumb = page title (uppercase)
|
|
if (breadcrumbs.length === 1) {
|
|
return (
|
|
<div className="border-b border-border px-4 md:px-6 h-12 shrink-0 flex items-center">
|
|
{menuButton}
|
|
<div className="min-w-0 overflow-hidden flex-1">
|
|
<h1 className="text-sm font-semibold uppercase tracking-wider truncate">
|
|
{breadcrumbs[0].label}
|
|
</h1>
|
|
</div>
|
|
{globalToolbarSlots}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// Multiple breadcrumbs = breadcrumb trail
|
|
return (
|
|
<div className="border-b border-border px-4 md:px-6 h-12 shrink-0 flex items-center">
|
|
{menuButton}
|
|
<div className="min-w-0 overflow-hidden flex-1">
|
|
<Breadcrumb className="min-w-0 overflow-hidden">
|
|
<BreadcrumbList className="flex-nowrap">
|
|
{breadcrumbs.map((crumb, i) => {
|
|
const isLast = i === breadcrumbs.length - 1;
|
|
return (
|
|
<Fragment key={i}>
|
|
{i > 0 && <BreadcrumbSeparator />}
|
|
<BreadcrumbItem className={isLast ? "min-w-0" : "shrink-0"}>
|
|
{isLast || !crumb.href ? (
|
|
<BreadcrumbPage className="truncate">{crumb.label}</BreadcrumbPage>
|
|
) : (
|
|
<BreadcrumbLink asChild>
|
|
<Link to={crumb.href}>{crumb.label}</Link>
|
|
</BreadcrumbLink>
|
|
)}
|
|
</BreadcrumbItem>
|
|
</Fragment>
|
|
);
|
|
})}
|
|
</BreadcrumbList>
|
|
</Breadcrumb>
|
|
</div>
|
|
{globalToolbarSlots}
|
|
</div>
|
|
);
|
|
}
|