mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-17 11:20:37 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - A fast-moving control plane needs stable local tests and repeatable local maintenance tools so contributors can safely split and review work > - Several route suites needed stronger isolation, Codex manual model selection needed a faster-mode option, and local browser cleanup missed Playwright's headless shell binary > - Storybook static output also needed to be preserved as a generated review artifact from the working branch > - This pull request groups the test/local-dev maintenance pieces so they can be reviewed separately from product runtime changes > - The benefit is more predictable contributor verification and cleaner local maintenance without mixing these changes into feature PRs ## What Changed - Added stable Vitest runner support and serialized route/authz test isolation. - Fixed workspace runtime authz route mocks and stabilized Claude/company-import related assertions. - Allowed Codex fast mode for manually selected models. - Broadened the agent browser cleanup script to detect `chrome-headless-shell` as well as Chrome for Testing. - Preserved generated Storybook static output from the source branch. ## Verification - `pnpm exec vitest run src/__tests__/workspace-runtime-routes-authz.test.ts src/__tests__/claude-local-execute.test.ts --config vitest.config.ts` from `server/` passed: 2 files, 19 tests. - `pnpm exec vitest run src/server/codex-args.test.ts --config vitest.config.ts` from `packages/adapters/codex-local/` passed: 1 file, 3 tests. - `bash -n scripts/kill-agent-browsers.sh && scripts/kill-agent-browsers.sh --dry` passed; dry-run detected `chrome-headless-shell` processes without killing them. - `test -f ui/storybook-static/index.html && test -f ui/storybook-static/assets/forms-editors.stories-Dry7qwx2.js` passed. - `git diff --check public-gh/master..pap-2228-test-local-maintenance -- . ':(exclude)ui/storybook-static'` passed. - `pnpm exec vitest run cli/src/__tests__/company-import-export-e2e.test.ts --config cli/vitest.config.ts` did not complete in the isolated split worktree because `paperclipai run` exited during build prep with `TS2688: Cannot find type definition file for 'react'`; this appears to be caused by the worktree dependency symlink setup, not the code under test. - Confirmed this PR does not include `pnpm-lock.yaml`. ## Risks - Medium risk: the stable Vitest runner changes how route/authz tests are scheduled. - Generated `ui/storybook-static` files are large and contain minified third-party output; `git diff --check` reports whitespace inside those generated assets, so reviewers may choose to drop or regenerate that artifact before merge. - No database migrations. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with shell, git, Paperclip API, and GitHub CLI tool use in the local Paperclip workspace. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Note: screenshot checklist item is not applicable to source UI behavior; the included Storybook static output is generated artifact preservation from the source branch. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
429 lines
15 KiB
TypeScript
429 lines
15 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const mockCompanyService = vi.hoisted(() => ({
|
|
list: vi.fn(),
|
|
stats: vi.fn(),
|
|
getById: vi.fn(),
|
|
create: vi.fn(),
|
|
update: vi.fn(),
|
|
archive: vi.fn(),
|
|
remove: vi.fn(),
|
|
}));
|
|
|
|
const mockAgentService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
}));
|
|
|
|
const mockAccessService = vi.hoisted(() => ({
|
|
ensureMembership: vi.fn(),
|
|
}));
|
|
|
|
const mockBudgetService = vi.hoisted(() => ({
|
|
upsertPolicy: vi.fn(),
|
|
}));
|
|
|
|
const mockCompanyPortabilityService = vi.hoisted(() => ({
|
|
exportBundle: vi.fn(),
|
|
previewExport: vi.fn(),
|
|
previewImport: vi.fn(),
|
|
importBundle: vi.fn(),
|
|
}));
|
|
|
|
const mockLogActivity = vi.hoisted(() => vi.fn());
|
|
const mockFeedbackService = vi.hoisted(() => ({
|
|
listIssueVotesForUser: vi.fn(),
|
|
listFeedbackTraces: vi.fn(),
|
|
getFeedbackTraceById: vi.fn(),
|
|
saveIssueVote: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("../services/access.js", () => ({
|
|
accessService: () => mockAccessService,
|
|
}));
|
|
|
|
vi.mock("../services/activity-log.js", () => ({
|
|
logActivity: mockLogActivity,
|
|
}));
|
|
|
|
vi.mock("../services/agents.js", () => ({
|
|
agentService: () => mockAgentService,
|
|
}));
|
|
|
|
vi.mock("../services/budgets.js", () => ({
|
|
budgetService: () => mockBudgetService,
|
|
}));
|
|
|
|
vi.mock("../services/companies.js", () => ({
|
|
companyService: () => mockCompanyService,
|
|
}));
|
|
|
|
vi.mock("../services/company-portability.js", () => ({
|
|
companyPortabilityService: () => mockCompanyPortabilityService,
|
|
}));
|
|
|
|
vi.mock("../services/feedback.js", () => ({
|
|
feedbackService: () => mockFeedbackService,
|
|
}));
|
|
|
|
vi.mock("../services/index.js", () => ({
|
|
accessService: () => mockAccessService,
|
|
agentService: () => mockAgentService,
|
|
budgetService: () => mockBudgetService,
|
|
companyPortabilityService: () => mockCompanyPortabilityService,
|
|
companyService: () => mockCompanyService,
|
|
feedbackService: () => mockFeedbackService,
|
|
logActivity: mockLogActivity,
|
|
}));
|
|
|
|
function registerCompanyRouteMocks() {
|
|
vi.doMock("../services/index.js", () => ({
|
|
accessService: () => mockAccessService,
|
|
agentService: () => mockAgentService,
|
|
budgetService: () => mockBudgetService,
|
|
companyPortabilityService: () => mockCompanyPortabilityService,
|
|
companyService: () => mockCompanyService,
|
|
feedbackService: () => mockFeedbackService,
|
|
logActivity: mockLogActivity,
|
|
}));
|
|
}
|
|
|
|
let appImportCounter = 0;
|
|
|
|
async function createApp(actor: Record<string, unknown>) {
|
|
registerCompanyRouteMocks();
|
|
appImportCounter += 1;
|
|
const routeModulePath = `../routes/companies.js?company-portability-routes-${appImportCounter}`;
|
|
const middlewareModulePath = `../middleware/index.js?company-portability-routes-${appImportCounter}`;
|
|
const [{ companyRoutes }, { errorHandler }] = await Promise.all([
|
|
import(routeModulePath) as Promise<typeof import("../routes/companies.js")>,
|
|
import(middlewareModulePath) as Promise<typeof import("../middleware/index.js")>,
|
|
]);
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = actor;
|
|
next();
|
|
});
|
|
app.use("/api/companies", companyRoutes({} as any));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
const companyId = "11111111-1111-4111-8111-111111111111";
|
|
const ceoAgentId = "ceo-agent";
|
|
const engineerAgentId = "engineer-agent";
|
|
|
|
const exportRequest = {
|
|
include: { company: true, agents: true, projects: true },
|
|
};
|
|
|
|
function createExportResult() {
|
|
return {
|
|
rootPath: "paperclip",
|
|
manifest: {
|
|
agents: [],
|
|
skills: [],
|
|
projects: [],
|
|
issues: [],
|
|
envInputs: [],
|
|
includes: { company: true, agents: true, projects: true, issues: false, skills: false },
|
|
company: null,
|
|
schemaVersion: 1,
|
|
generatedAt: "2026-01-01T00:00:00.000Z",
|
|
source: null,
|
|
},
|
|
files: {},
|
|
warnings: [],
|
|
};
|
|
}
|
|
|
|
describe.sequential("company portability routes", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockAgentService.getById.mockImplementation(async (id: string) => ({
|
|
id,
|
|
companyId,
|
|
role: id === ceoAgentId ? "ceo" : "engineer",
|
|
}));
|
|
mockCompanyPortabilityService.exportBundle.mockResolvedValue(createExportResult());
|
|
mockCompanyPortabilityService.previewExport.mockResolvedValue({
|
|
rootPath: "paperclip",
|
|
manifest: { agents: [], skills: [], projects: [], issues: [], envInputs: [], includes: { company: true, agents: true, projects: true, issues: false, skills: false }, company: null, schemaVersion: 1, generatedAt: new Date().toISOString(), source: null },
|
|
files: {},
|
|
fileInventory: [],
|
|
counts: { files: 0, agents: 0, skills: 0, projects: 0, issues: 0 },
|
|
warnings: [],
|
|
paperclipExtensionPath: ".paperclip.yaml",
|
|
});
|
|
mockCompanyPortabilityService.previewImport.mockResolvedValue({ ok: true });
|
|
mockCompanyPortabilityService.importBundle.mockResolvedValue({
|
|
company: { id: companyId, action: "created" },
|
|
agents: [],
|
|
warnings: [],
|
|
});
|
|
});
|
|
|
|
it.sequential("rejects non-CEO agents from CEO-safe export preview routes", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: engineerAgentId,
|
|
companyId,
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post(`/api/companies/${companyId}/exports/preview`)
|
|
.send(exportRequest);
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Only CEO agents");
|
|
expect(mockCompanyPortabilityService.previewExport).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("rejects non-CEO agents from legacy and CEO-safe export bundle routes", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: engineerAgentId,
|
|
companyId,
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
for (const path of [`/api/companies/${companyId}/export`, `/api/companies/${companyId}/exports`]) {
|
|
const res = await request(app).post(path).send(exportRequest);
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Only CEO agents");
|
|
}
|
|
expect(mockCompanyPortabilityService.exportBundle).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("allows CEO agents to use company-scoped export preview routes", async () => {
|
|
mockCompanyPortabilityService.previewExport.mockResolvedValue({
|
|
rootPath: "paperclip",
|
|
manifest: { agents: [], skills: [], projects: [], issues: [], envInputs: [], includes: { company: true, agents: true, projects: true, issues: false, skills: false }, company: null, schemaVersion: 1, generatedAt: new Date().toISOString(), source: null },
|
|
files: {},
|
|
fileInventory: [],
|
|
counts: { files: 0, agents: 0, skills: 0, projects: 0, issues: 0 },
|
|
warnings: [],
|
|
paperclipExtensionPath: ".paperclip.yaml",
|
|
});
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: ceoAgentId,
|
|
companyId,
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post(`/api/companies/${companyId}/exports/preview`)
|
|
.send(exportRequest);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.rootPath).toBe("paperclip");
|
|
});
|
|
|
|
it.sequential("allows CEO agents to export through legacy and CEO-safe bundle routes", async () => {
|
|
mockCompanyPortabilityService.exportBundle.mockResolvedValue(createExportResult());
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: ceoAgentId,
|
|
companyId,
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
for (const path of [`/api/companies/${companyId}/export`, `/api/companies/${companyId}/exports`]) {
|
|
const res = await request(app).post(path).send(exportRequest);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.rootPath).toBe("paperclip");
|
|
}
|
|
expect(mockCompanyPortabilityService.exportBundle).toHaveBeenCalledTimes(2);
|
|
expect(mockCompanyPortabilityService.exportBundle).toHaveBeenNthCalledWith(1, companyId, exportRequest);
|
|
expect(mockCompanyPortabilityService.exportBundle).toHaveBeenNthCalledWith(2, companyId, exportRequest);
|
|
});
|
|
|
|
it.sequential("allows board users to export through legacy and CEO-safe bundle routes", async () => {
|
|
mockCompanyPortabilityService.exportBundle.mockResolvedValue(createExportResult());
|
|
const app = await createApp({
|
|
type: "board",
|
|
userId: "user-1",
|
|
companyIds: [companyId],
|
|
source: "session",
|
|
isInstanceAdmin: false,
|
|
});
|
|
|
|
for (const path of [`/api/companies/${companyId}/export`, `/api/companies/${companyId}/exports`]) {
|
|
const res = await request(app).post(path).send(exportRequest);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.rootPath).toBe("paperclip");
|
|
}
|
|
expect(mockCompanyPortabilityService.exportBundle).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it.sequential("rejects replace collision strategy on CEO-safe import routes", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: ceoAgentId,
|
|
companyId: "11111111-1111-4111-8111-111111111111",
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/11111111-1111-4111-8111-111111111111/imports/preview")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "existing_company", companyId: "11111111-1111-4111-8111-111111111111" },
|
|
collisionStrategy: "replace",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("does not allow replace");
|
|
expect(mockCompanyPortabilityService.previewImport).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("keeps global import preview routes board-only", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: engineerAgentId,
|
|
companyId: "11111111-1111-4111-8111-111111111111",
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/import/preview")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "existing_company", companyId: "11111111-1111-4111-8111-111111111111" },
|
|
collisionStrategy: "rename",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Board access required");
|
|
});
|
|
|
|
it.sequential("requires instance admin for new-company import preview", async () => {
|
|
const app = await createApp({
|
|
type: "board",
|
|
userId: "user-1",
|
|
companyIds: ["11111111-1111-4111-8111-111111111111"],
|
|
source: "session",
|
|
isInstanceAdmin: false,
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/import/preview")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "new_company", newCompanyName: "Imported Test" },
|
|
collisionStrategy: "rename",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Instance admin");
|
|
expect(mockCompanyPortabilityService.previewImport).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("rejects replace collision strategy on CEO-safe import apply routes", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: ceoAgentId,
|
|
companyId: "11111111-1111-4111-8111-111111111111",
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/11111111-1111-4111-8111-111111111111/imports/apply")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "existing_company", companyId: "11111111-1111-4111-8111-111111111111" },
|
|
collisionStrategy: "replace",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("does not allow replace");
|
|
expect(mockCompanyPortabilityService.importBundle).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("rejects non-CEO agents from CEO-safe import preview routes", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: engineerAgentId,
|
|
companyId: "11111111-1111-4111-8111-111111111111",
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/11111111-1111-4111-8111-111111111111/imports/preview")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "existing_company", companyId: "11111111-1111-4111-8111-111111111111" },
|
|
collisionStrategy: "rename",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Only CEO agents");
|
|
expect(mockCompanyPortabilityService.previewImport).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("rejects non-CEO agents from CEO-safe import apply routes", async () => {
|
|
const app = await createApp({
|
|
type: "agent",
|
|
agentId: engineerAgentId,
|
|
companyId: "11111111-1111-4111-8111-111111111111",
|
|
source: "agent_key",
|
|
runId: "run-1",
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/11111111-1111-4111-8111-111111111111/imports/apply")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "existing_company", companyId: "11111111-1111-4111-8111-111111111111" },
|
|
collisionStrategy: "rename",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Only CEO agents");
|
|
expect(mockCompanyPortabilityService.importBundle).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.sequential("requires instance admin for new-company import apply", async () => {
|
|
const app = await createApp({
|
|
type: "board",
|
|
userId: "user-1",
|
|
companyIds: ["11111111-1111-4111-8111-111111111111"],
|
|
source: "session",
|
|
isInstanceAdmin: false,
|
|
});
|
|
|
|
const res = await request(app)
|
|
.post("/api/companies/import")
|
|
.send({
|
|
source: { type: "inline", files: { "COMPANY.md": "---\nname: Test\n---\n" } },
|
|
include: { company: true, agents: true, projects: false, issues: false },
|
|
target: { mode: "new_company", newCompanyName: "Imported Test" },
|
|
collisionStrategy: "rename",
|
|
});
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(res.body.error).toContain("Instance admin");
|
|
expect(mockCompanyPortabilityService.importBundle).not.toHaveBeenCalled();
|
|
});
|
|
});
|