mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-14 01:50:39 +09:00
## Thinking Path > - Paperclip's board UI and bundled skills are the operator layer for configuring agents, routines, issue workflows, and local troubleshooting loops. > - The prior rollup mixed this operator polish with database backups, backend reliability, thread scale, and cost/workflow primitives. > - This pull request isolates the remaining board QoL, settings, issue-detail integration, adapter config cleanup, and skills smoke tooling. > - It includes some integration-level overlap with the thread and workflow slices so this branch can run from `origin/master` while still preserving the full original work. > - Preferred merge order is the narrower primitives first, then this integration PR last. > - The benefit is that reviewers can inspect the user-facing board/settings/skills layer separately from backend infrastructure changes. ## What Changed - Added board/settings polish for agents, routines, company settings, project workspace detail, and issue detail controls. - Added agent/routine UI regression tests and New Issue dialog coverage. - Integrated issue-detail activity/cost/interaction surfaces and leaf work pause/resume controls. - Cleaned bundled adapter UI config defaults and onboarding copy. - Added terminal-bench loop and work-stoppage diagnosis skills plus a smoke test script. - Updated attachment type handling and Paperclip skill/API guidance. ## Verification - `pnpm install --frozen-lockfile` - `pnpm exec vitest run ui/src/pages/Agents.test.tsx ui/src/pages/Routines.test.tsx ui/src/components/NewIssueDialog.test.tsx ui/src/pages/IssueDetail.test.tsx server/src/__tests__/costs-service.test.ts server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts` - Result: 7 test files passed, 54 tests passed. - `pnpm run smoke:terminal-bench-loop-skill` - Result: JSON output included `"ok": true` and `"cleanup": true`. - UI screenshots not included because verification is focused component/page coverage for the changed board surfaces. ## Risks - This is the integration-heavy PR in the split and intentionally overlaps some component/API primitives with the issue-thread and workflow PRs so it can run from `origin/master`. - Preferred merge order: #4859, #4860, #4861, #4862, then this PR last. If earlier branches merge first, this PR may need a straightforward conflict refresh in shared UI files. - The terminal-bench smoke script creates temporary mock issues and relies on cleanup; the verified run returned `cleanup: true`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5.5, code execution and GitHub CLI tool use, medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
105 lines
3.5 KiB
TypeScript
105 lines
3.5 KiB
TypeScript
/**
|
|
* Shared attachment content-type configuration.
|
|
*
|
|
* By default a curated set of image/document/text types are allowed. Set the
|
|
* `PAPERCLIP_ALLOWED_ATTACHMENT_TYPES` environment variable to a
|
|
* comma-separated list of MIME types or wildcard patterns to expand the
|
|
* allowed set for routes that use this allowlist.
|
|
*
|
|
* Examples:
|
|
* PAPERCLIP_ALLOWED_ATTACHMENT_TYPES=image/*,application/pdf
|
|
* PAPERCLIP_ALLOWED_ATTACHMENT_TYPES=image/*,application/pdf,text/*
|
|
*
|
|
* Supported pattern syntax:
|
|
* - Exact types: "application/pdf"
|
|
* - Wildcards: "image/*" or "application/vnd.openxmlformats-officedocument.*"
|
|
*/
|
|
import {
|
|
DEFAULT_COMPANY_ATTACHMENT_MAX_BYTES,
|
|
MAX_COMPANY_ATTACHMENT_MAX_BYTES,
|
|
} from "@paperclipai/shared";
|
|
|
|
export const DEFAULT_ALLOWED_TYPES: readonly string[] = [
|
|
"image/png",
|
|
"image/jpeg",
|
|
"image/jpg",
|
|
"image/webp",
|
|
"image/gif",
|
|
"application/pdf",
|
|
"text/markdown",
|
|
"text/plain",
|
|
"application/json",
|
|
"text/csv",
|
|
"text/html",
|
|
];
|
|
|
|
export const DEFAULT_ATTACHMENT_CONTENT_TYPE = "application/octet-stream";
|
|
export const SVG_CONTENT_TYPE = "image/svg+xml";
|
|
export const INLINE_ATTACHMENT_TYPES: readonly string[] = [
|
|
"image/*",
|
|
"application/pdf",
|
|
"text/plain",
|
|
"text/markdown",
|
|
"application/json",
|
|
"text/csv",
|
|
];
|
|
|
|
/**
|
|
* Parse a comma-separated list of MIME type patterns into a normalised array.
|
|
* Returns the default image-only list when the input is empty or undefined.
|
|
*/
|
|
export function parseAllowedTypes(raw: string | undefined): string[] {
|
|
if (!raw) return [...DEFAULT_ALLOWED_TYPES];
|
|
const parsed = raw
|
|
.split(",")
|
|
.map((s) => s.trim().toLowerCase())
|
|
.filter((s) => s.length > 0);
|
|
return parsed.length > 0 ? parsed : [...DEFAULT_ALLOWED_TYPES];
|
|
}
|
|
|
|
/**
|
|
* Check whether `contentType` matches any entry in `allowedPatterns`.
|
|
*
|
|
* Supports exact matches ("application/pdf") and wildcard / prefix
|
|
* patterns ("image/*", "application/vnd.openxmlformats-officedocument.*").
|
|
*/
|
|
export function matchesContentType(contentType: string, allowedPatterns: string[]): boolean {
|
|
const ct = contentType.toLowerCase();
|
|
return allowedPatterns.some((pattern) => {
|
|
if (pattern === "*") return true;
|
|
if (pattern.endsWith("/*") || pattern.endsWith(".*")) {
|
|
return ct.startsWith(pattern.slice(0, -1));
|
|
}
|
|
return ct === pattern;
|
|
});
|
|
}
|
|
|
|
export function normalizeContentType(contentType: string | null | undefined): string {
|
|
const normalized = (contentType ?? "").trim().toLowerCase();
|
|
return normalized || DEFAULT_ATTACHMENT_CONTENT_TYPE;
|
|
}
|
|
|
|
export function isInlineAttachmentContentType(contentType: string): boolean {
|
|
return matchesContentType(contentType, [...INLINE_ATTACHMENT_TYPES]);
|
|
}
|
|
|
|
// ---------- Module-level singletons read once at startup ----------
|
|
|
|
const allowedPatterns: string[] = parseAllowedTypes(
|
|
process.env.PAPERCLIP_ALLOWED_ATTACHMENT_TYPES,
|
|
);
|
|
|
|
/** Convenience wrapper using the process-level allowed list. */
|
|
export function isAllowedContentType(contentType: string): boolean {
|
|
return matchesContentType(contentType, allowedPatterns);
|
|
}
|
|
|
|
export const MAX_ATTACHMENT_BYTES =
|
|
Number(process.env.PAPERCLIP_ATTACHMENT_MAX_BYTES) || 10 * 1024 * 1024;
|
|
|
|
export function normalizeIssueAttachmentMaxBytes(value: number | null | undefined): number {
|
|
if (typeof value !== "number" || !Number.isFinite(value) || value <= 0) {
|
|
return Math.min(DEFAULT_COMPANY_ATTACHMENT_MAX_BYTES, MAX_ATTACHMENT_BYTES);
|
|
}
|
|
return Math.min(Math.floor(value), MAX_COMPANY_ATTACHMENT_MAX_BYTES, MAX_ATTACHMENT_BYTES);
|
|
}
|