mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 18:30:39 +09:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Issue and comment rendering is part of the board UI where humans supervise and inspect agent work. > - External Paperclip issue URLs can appear in comments as references to other runs, review threads, or remote test environments. > - Those links must preserve their full destination, including origin, port, and `#comment-...` fragments, or the operator is taken to the wrong place. > - The bug here was that absolute `http(s)` issue URLs were being normalized into internal `/issues/...` routes in the markdown path. > - This pull request stops rewriting absolute URLs while keeping internal issue-reference behavior for relative paths and identifiers. > - The benefit is that authored external links now navigate exactly where the operator expects, especially for remote test and comment-deep-link workflows. ## What Changed - Stopped `ui/src/lib/issue-reference.ts` from treating absolute `http(s)` URLs as internal issue paths. - Added defense-in-depth in `ui/src/lib/mention-chips.ts` so absolute `http(s)` URLs are never reclassified as issue mention chips. - Updated `ui/src/lib/issue-reference.test.ts` to cover absolute Paperclip URLs with preserved origin, port, and comment hash. - Updated `ui/src/components/MarkdownBody.test.tsx` to assert the reported URL renders as an external link, not an internal `/issues/...` href. ## Verification - `pnpm exec vitest run ui/src/lib/issue-reference.test.ts ui/src/components/MarkdownBody.test.tsx` - Expected result: `2` files passed, `37` tests passed. - Manual spot-check from the issue report path: a URL like `http://remote.example.test:3103/PAPA/issues/PAPA-115#comment-...` should remain an external link with its full destination preserved. ## Risks - Low risk. The change narrows when Paperclip rewrites URLs, so the main risk is if some existing workflow depended on absolute `http(s)` Paperclip URLs being converted into internal issue links. The added regression coverage is aimed at preventing that from regressing silently. ## Model Used - OpenAI Codex local agent via Paperclip `codex_local` - Backing model family: GPT-5-based Codex runtime - Exact backend model ID/version: not exposed by this adapter/runtime surface - Context window: not exposed by this adapter/runtime surface - Capabilities used: tool use, shell command execution, code editing, git operations, and local test execution ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [ ] I will address all Greptile and reviewer comments before requesting merge
218 lines
6 KiB
TypeScript
218 lines
6 KiB
TypeScript
import type { CSSProperties } from "react";
|
|
import {
|
|
parseAgentMentionHref,
|
|
parseIssueReferenceHref,
|
|
parseProjectMentionHref,
|
|
parseSkillMentionHref,
|
|
parseUserMentionHref,
|
|
} from "@paperclipai/shared";
|
|
import { getAgentIcon } from "./agent-icons";
|
|
import { hexToRgb, pickTextColorForPillBg } from "./color-contrast";
|
|
|
|
export type ParsedMentionChip =
|
|
| {
|
|
kind: "agent";
|
|
agentId: string;
|
|
icon: string | null;
|
|
}
|
|
| {
|
|
kind: "issue";
|
|
identifier: string;
|
|
}
|
|
| {
|
|
kind: "project";
|
|
projectId: string;
|
|
color: string | null;
|
|
}
|
|
| {
|
|
kind: "user";
|
|
userId: string;
|
|
}
|
|
| {
|
|
kind: "skill";
|
|
skillId: string;
|
|
slug: string | null;
|
|
};
|
|
|
|
const iconMaskCache = new Map<string, string>();
|
|
|
|
export function parseMentionChipHref(href: string): ParsedMentionChip | null {
|
|
if (/^https?:\/\//i.test(href.trim())) {
|
|
return null;
|
|
}
|
|
|
|
const issue = parseIssueReferenceHref(href);
|
|
if (issue) {
|
|
return {
|
|
kind: "issue",
|
|
identifier: issue.identifier,
|
|
};
|
|
}
|
|
|
|
const agent = parseAgentMentionHref(href);
|
|
if (agent) {
|
|
return {
|
|
kind: "agent",
|
|
agentId: agent.agentId,
|
|
icon: agent.icon,
|
|
};
|
|
}
|
|
|
|
const project = parseProjectMentionHref(href);
|
|
if (project) {
|
|
return {
|
|
kind: "project",
|
|
projectId: project.projectId,
|
|
color: project.color,
|
|
};
|
|
}
|
|
|
|
const user = parseUserMentionHref(href);
|
|
if (user) {
|
|
return {
|
|
kind: "user",
|
|
userId: user.userId,
|
|
};
|
|
}
|
|
|
|
const skill = parseSkillMentionHref(href);
|
|
if (skill) {
|
|
return {
|
|
kind: "skill",
|
|
skillId: skill.skillId,
|
|
slug: skill.slug,
|
|
};
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
export function mentionChipInlineStyle(mention: ParsedMentionChip): CSSProperties | undefined {
|
|
const style: CSSProperties & Record<string, string> = {};
|
|
|
|
if (mention.kind === "project" && mention.color) {
|
|
const projectStyle = projectMentionColors(mention.color);
|
|
Object.assign(style, projectStyle);
|
|
style["--paperclip-mention-project-color"] = mention.color;
|
|
}
|
|
|
|
if (mention.kind === "agent") {
|
|
const iconMask = buildAgentIconMask(mention.icon);
|
|
if (iconMask) {
|
|
style["--paperclip-mention-icon-mask"] = iconMask;
|
|
}
|
|
}
|
|
|
|
return Object.keys(style).length > 0 ? (style as CSSProperties) : undefined;
|
|
}
|
|
|
|
export function applyMentionChipDecoration(element: HTMLElement, mention: ParsedMentionChip) {
|
|
clearMentionChipDecoration(element);
|
|
element.dataset.mentionKind = mention.kind;
|
|
element.setAttribute("contenteditable", "false");
|
|
element.classList.add("paperclip-mention-chip", `paperclip-mention-chip--${mention.kind}`);
|
|
if (mention.kind === "project") {
|
|
element.classList.add("paperclip-project-mention-chip");
|
|
}
|
|
|
|
const style = mentionChipInlineStyle(mention);
|
|
if (!style) return;
|
|
for (const [key, value] of Object.entries(style)) {
|
|
if (typeof value === "string") {
|
|
if (key.startsWith("--")) {
|
|
element.style.setProperty(key, value);
|
|
} else {
|
|
(element.style as CSSStyleDeclaration & Record<string, string>)[key] = value;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
export function clearMentionChipDecoration(element: HTMLElement) {
|
|
delete element.dataset.mentionKind;
|
|
element.classList.remove(
|
|
"paperclip-mention-chip",
|
|
"paperclip-mention-chip--agent",
|
|
"paperclip-mention-chip--issue",
|
|
"paperclip-mention-chip--project",
|
|
"paperclip-mention-chip--user",
|
|
"paperclip-mention-chip--skill",
|
|
"paperclip-project-mention-chip",
|
|
);
|
|
element.removeAttribute("contenteditable");
|
|
element.style.removeProperty("border-color");
|
|
element.style.removeProperty("background-color");
|
|
element.style.removeProperty("color");
|
|
element.style.removeProperty("--paperclip-mention-project-color");
|
|
element.style.removeProperty("--paperclip-mention-icon-mask");
|
|
}
|
|
|
|
function projectMentionColors(color: string): Pick<CSSProperties, "borderColor" | "backgroundColor" | "color"> {
|
|
const rgb = hexToRgb(color);
|
|
if (!rgb) return {};
|
|
return {
|
|
borderColor: color,
|
|
backgroundColor: `rgba(${rgb.r}, ${rgb.g}, ${rgb.b}, 0.22)`,
|
|
color: pickTextColorForPillBg(color),
|
|
};
|
|
}
|
|
|
|
function buildAgentIconMask(iconName: string | null): string | null {
|
|
const cacheKey = iconName ?? "__default__";
|
|
const cached = iconMaskCache.get(cacheKey);
|
|
if (cached) return cached;
|
|
|
|
const Icon = getAgentIcon(iconName);
|
|
const iconNode = resolveLucideIconNode(Icon);
|
|
if (!Array.isArray(iconNode) || iconNode.length === 0) return null;
|
|
|
|
const body = iconNode.map(([tag, attrs]) => {
|
|
const attrString = Object.entries(attrs)
|
|
.filter(([key]) => key !== "key")
|
|
.map(([key, value]) => `${key}="${escapeAttribute(String(value))}"`)
|
|
.join(" ");
|
|
return `<${tag}${attrString ? ` ${attrString}` : ""}></${tag}>`;
|
|
}).join("");
|
|
|
|
const svg =
|
|
`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" ` +
|
|
`fill="none" stroke="#000" stroke-width="2" stroke-linecap="round" ` +
|
|
`stroke-linejoin="round">${body}</svg>`;
|
|
const url = `url("data:image/svg+xml,${encodeURIComponent(svg)}")`;
|
|
iconMaskCache.set(cacheKey, url);
|
|
return url;
|
|
}
|
|
|
|
function resolveLucideIconNode(
|
|
icon: unknown,
|
|
): Array<[string, Record<string, string>]> | null {
|
|
const staticIconNode = (
|
|
icon as {
|
|
iconNode?: Array<[string, Record<string, string>]>;
|
|
}
|
|
).iconNode;
|
|
if (Array.isArray(staticIconNode) && staticIconNode.length > 0) {
|
|
return staticIconNode;
|
|
}
|
|
|
|
const render = (
|
|
icon as {
|
|
render?: (props: Record<string, unknown>, ref: unknown) => {
|
|
props?: { iconNode?: Array<[string, Record<string, string>]> };
|
|
} | null;
|
|
}
|
|
).render;
|
|
const rendered = typeof render === "function" ? render({}, null) : null;
|
|
const renderedIconNode = rendered?.props?.iconNode;
|
|
return Array.isArray(renderedIconNode) && renderedIconNode.length > 0
|
|
? renderedIconNode
|
|
: null;
|
|
}
|
|
|
|
function escapeAttribute(value: string): string {
|
|
return value
|
|
.replaceAll("&", "&")
|
|
.replaceAll('"', """)
|
|
.replaceAll("<", "<")
|
|
.replaceAll(">", ">");
|
|
}
|