mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 10:30:37 +09:00
1266954a4e
## Thinking Path > - Paperclip orchestrates AI agents through issue-driven heartbeats, checkouts, and wake scheduling. > - This change sits in the server heartbeat and issue services that decide which queued runs are allowed to start. > - Before this branch, queued heartbeats could be selected even when their issue still had unresolved blocker relationships. > - That let blocked descendant work compete with actually-ready work and risked auto-checking out issues that were not dependency-ready. > - This pull request teaches the scheduler and checkout path to consult issue dependency readiness before claiming queued runs. > - It also exposes dependency readiness in the agent inbox so agents can see which assigned issues are still blocked. > - The result is that heartbeat execution follows the DAG of blocked dependencies instead of waking work out of order. ## What Changed - Added `IssueDependencyReadiness` helpers to `issueService`, including unresolved blocker lookup for single issues and bulk issue lists. - Prevented issue checkout and `in_progress` transitions when unresolved blockers still exist. - Made heartbeat queued-run claiming and prioritization dependency-aware so ready work starts before blocked descendants. - Included dependency readiness fields in `/api/agents/me/inbox-lite` for agent heartbeat selection. - Added regression coverage for dependency-aware heartbeat promotion and issue-service participation filtering. ## Verification - `pnpm run preflight:workspace-links` - `pnpm exec vitest run server/src/__tests__/heartbeat-dependency-scheduling.test.ts server/src/__tests__/issues-service.test.ts` - On this host, the Vitest command passed, but the embedded-Postgres portions of those files were skipped because `@embedded-postgres/darwin-x64` is not installed. ## Risks - Scheduler ordering now prefers dependency-ready runs, so any hidden assumptions about strict FIFO ordering could surface in edge cases. - The new guardrails reject checkout or `in_progress` transitions for blocked issues; callers depending on the old permissive behavior would now get `422` errors. - Local verification did not execute the embedded-Postgres integration paths on this macOS host because the platform binary package was missing. > I checked `ROADMAP.md`; this is a targeted execution/scheduling fix and does not duplicate planned roadmap feature work. ## Model Used - OpenAI Codex via the Paperclip `codex_local` adapter in this workspace. Exact backend model ID is not surfaced in the runtime here; tool-enabled coding agent with terminal execution and repository editing capabilities. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge |
||
|---|---|---|
| .. | ||
| access.ts | ||
| activity-log.ts | ||
| activity.ts | ||
| adapter-plugin-store.ts | ||
| agent-instructions.ts | ||
| agent-permissions.ts | ||
| agents.ts | ||
| approvals.ts | ||
| assets.ts | ||
| board-auth.ts | ||
| budgets.ts | ||
| companies.ts | ||
| company-export-readme.ts | ||
| company-member-roles.ts | ||
| company-portability.ts | ||
| company-skills.ts | ||
| costs.ts | ||
| cron.ts | ||
| dashboard.ts | ||
| default-agent-instructions.ts | ||
| documents.ts | ||
| execution-workspace-policy.ts | ||
| execution-workspaces.ts | ||
| feedback-redaction.ts | ||
| feedback-share-client.ts | ||
| feedback.ts | ||
| finance.ts | ||
| github-fetch.ts | ||
| goals.ts | ||
| heartbeat-run-summary.ts | ||
| heartbeat-stop-metadata.test.ts | ||
| heartbeat-stop-metadata.ts | ||
| heartbeat.ts | ||
| hire-hook.ts | ||
| inbox-dismissals.ts | ||
| index.ts | ||
| instance-settings.ts | ||
| invite-grants.ts | ||
| issue-approvals.ts | ||
| issue-assignment-wakeup.ts | ||
| issue-continuation-summary.ts | ||
| issue-execution-policy.ts | ||
| issue-goal-fallback.ts | ||
| issues.ts | ||
| live-events.ts | ||
| local-service-supervisor.ts | ||
| plugin-capability-validator.ts | ||
| plugin-config-validator.ts | ||
| plugin-database.ts | ||
| plugin-dev-watcher.ts | ||
| plugin-event-bus.ts | ||
| plugin-host-service-cleanup.ts | ||
| plugin-host-services.ts | ||
| plugin-job-coordinator.ts | ||
| plugin-job-scheduler.ts | ||
| plugin-job-store.ts | ||
| plugin-lifecycle.ts | ||
| plugin-loader.ts | ||
| plugin-log-retention.ts | ||
| plugin-manifest-validator.ts | ||
| plugin-registry.ts | ||
| plugin-runtime-sandbox.ts | ||
| plugin-secrets-handler.ts | ||
| plugin-state-store.ts | ||
| plugin-stream-bus.ts | ||
| plugin-tool-dispatcher.ts | ||
| plugin-tool-registry.ts | ||
| plugin-worker-manager.ts | ||
| project-workspace-runtime-config.ts | ||
| projects.ts | ||
| quota-windows.ts | ||
| routines.ts | ||
| run-continuations.ts | ||
| run-liveness.ts | ||
| run-log-store.ts | ||
| secrets.ts | ||
| sidebar-badges.ts | ||
| sidebar-preferences.ts | ||
| work-products.ts | ||
| workspace-operation-log-store.ts | ||
| workspace-operations.ts | ||
| workspace-runtime-read-model.ts | ||
| workspace-runtime.ts | ||