paperclip/ui/src/lib/issue-timeline-events.ts
Dotta d0e9cc76f2
Show workspace changes and stale notices in issue threads (#5356)
## Thinking Path

> - Paperclip orchestrates AI agents for zero-human companies
> - The issue thread is the operator's durable audit trail for what
changed and why
> - Workspace changes and stale disposition notices need to be visible
in that same timeline without noisy or misleading rendering
> - The local branch already contained backend activity details,
timeline conversion, and UI rendering work for those events
> - This pull request isolates the issue-thread activity work into a
standalone branch against `origin/master`
> - The benefit is a focused audit-trail PR that can merge independently
of the sidebar/operator UI polish branch

## What Changed

- Adds readable workspace-change activity details to issue update
activity events.
- Surfaces workspace-change events in issue chat/timeline rendering.
- Makes the existing issue comment migration idempotent.
- Folds and renders stale disposition notices inline so they match
activity-log styling and spacing.
- Adds focused route, timeline, and issue-thread system notice coverage.

## Verification

- `pnpm install --frozen-lockfile`
- `pnpm exec vitest run
server/src/__tests__/issue-activity-events-routes.test.ts
ui/src/lib/issue-timeline-events.test.ts
ui/src/components/IssueChatThreadSystemNotice.test.tsx` — 3 files
passed, 22 tests passed.
- Confirmed the PR changes 9 files and does not include `pnpm-lock.yaml`
or `.github/workflows/*`.
- `pnpm exec vitest run
server/src/__tests__/issue-closed-workspace-routes.test.ts` — 1 file
passed, 4 tests passed.
- `pnpm exec vitest run
server/src/__tests__/issue-activity-events-routes.test.ts
ui/src/lib/issue-timeline-events.test.ts
ui/src/components/IssueChatThreadSystemNotice.test.tsx
server/src/services/recovery/successful-run-handoff.test.ts
packages/shared/src/validators/issue.test.ts` — 5 files passed, 54 tests
passed.
- `pnpm --filter @paperclipai/shared typecheck && pnpm --filter
@paperclipai/server typecheck && pnpm --filter @paperclipai/ui
typecheck`.
- `pnpm --filter @paperclipai/ui typecheck` after adding the Storybook
screenshot fixture.
- Captured Storybook screenshots for the new UI rendering paths:
- Collapsed stale notice + workspace-change row:
`docs/pr-screenshots/pr-5356/issue-thread-notices-collapsed.png`
- Expanded stale notice details:
`docs/pr-screenshots/pr-5356/issue-thread-notices-expanded.png`


### Screenshots

Collapsed stale notice with workspace-change row:

![Collapsed stale notice with workspace-change
row](docs/pr-screenshots/pr-5356/issue-thread-notices-collapsed.png)

Expanded stale notice details:

![Expanded stale notice
details](docs/pr-screenshots/pr-5356/issue-thread-notices-expanded.png)

## Risks

- Moderate risk: this touches issue activity serialization and
issue-thread rendering, both of which are central operator surfaces.
- Migration risk is low: the only migration change makes an existing
migration idempotent.
- No new migrations are introduced, so there is no cross-PR migration
ordering requirement.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, GPT-5 coding agent, shell/tool-use enabled, used to
split the existing branch, verify the isolated PR branch, and create
this PR.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-05-06 09:00:54 -05:00

182 lines
5.7 KiB
TypeScript

import type { ActivityEvent } from "@paperclipai/shared";
export interface IssueTimelineAssignee {
agentId: string | null;
userId: string | null;
}
export interface IssueTimelineEvent {
id: string;
createdAt: Date | string;
actorType: ActivityEvent["actorType"];
actorId: string;
runId?: string | null;
statusChange?: {
from: string | null;
to: string | null;
};
assigneeChange?: {
from: IssueTimelineAssignee;
to: IssueTimelineAssignee;
};
workspaceChange?: {
from: IssueTimelineWorkspace;
to: IssueTimelineWorkspace;
};
commentId?: string | null;
followUpRequested?: boolean;
}
export interface IssueTimelineWorkspace {
label: string | null;
projectWorkspaceId: string | null;
executionWorkspaceId: string | null;
mode: string | null;
}
export function formatTimelineWorkspaceLabel(workspace: IssueTimelineWorkspace) {
const fallbackId = workspace.executionWorkspaceId ?? workspace.projectWorkspaceId;
return workspace.label ?? (fallbackId ? fallbackId.slice(0, 8) : "None");
}
function asRecord(value: unknown): Record<string, unknown> | null {
if (typeof value !== "object" || value === null || Array.isArray(value)) return null;
return value as Record<string, unknown>;
}
function hasOwn(record: Record<string, unknown>, key: string) {
return Object.prototype.hasOwnProperty.call(record, key);
}
function nullableString(value: unknown): string | null {
return typeof value === "string" && value.length > 0 ? value : null;
}
function toTimestamp(value: Date | string) {
return new Date(value).getTime();
}
function sameAssignee(left: IssueTimelineAssignee, right: IssueTimelineAssignee) {
return left.agentId === right.agentId && left.userId === right.userId;
}
function sameWorkspace(left: IssueTimelineWorkspace, right: IssueTimelineWorkspace) {
return left.projectWorkspaceId === right.projectWorkspaceId
&& left.executionWorkspaceId === right.executionWorkspaceId
&& left.mode === right.mode
&& left.label === right.label;
}
function workspaceFromRecord(value: unknown): IssueTimelineWorkspace | null {
const record = asRecord(value);
if (!record) return null;
return {
label: nullableString(record.label),
projectWorkspaceId: nullableString(record.projectWorkspaceId),
executionWorkspaceId: nullableString(record.executionWorkspaceId),
mode: nullableString(record.mode),
};
}
function workspaceChangeFromDetails(details: Record<string, unknown>) {
const change = asRecord(details.workspaceChange);
if (!change) return null;
const from = workspaceFromRecord(change.from);
const to = workspaceFromRecord(change.to);
if (!from || !to || sameWorkspace(from, to)) return null;
return { from, to };
}
function sortTimelineEvents<T extends { createdAt: Date | string; id: string }>(events: T[]) {
return [...events].sort((a, b) => {
const createdAtDiff = toTimestamp(a.createdAt) - toTimestamp(b.createdAt);
if (createdAtDiff !== 0) return createdAtDiff;
return a.id.localeCompare(b.id);
});
}
export function extractIssueTimelineEvents(activity: ActivityEvent[] | null | undefined): IssueTimelineEvent[] {
const events: IssueTimelineEvent[] = [];
for (const event of activity ?? []) {
const details = asRecord(event.details);
if (!details) continue;
if (event.action === "issue.comment_added") {
if (details.followUpRequested !== true && details.resumeIntent !== true) continue;
if (details.reopened === true) continue;
const commentId = nullableString(details.commentId);
events.push({
id: event.id,
createdAt: event.createdAt,
actorType: event.actorType,
actorId: event.actorId,
runId: event.runId ?? null,
commentId,
followUpRequested: true,
});
continue;
}
if (event.action !== "issue.updated") continue;
const previous = asRecord(details._previous);
const timelineEvent: IssueTimelineEvent = {
id: event.id,
createdAt: event.createdAt,
actorType: event.actorType,
actorId: event.actorId,
runId: event.runId ?? null,
};
if (details.followUpRequested === true || details.resumeIntent === true) {
timelineEvent.followUpRequested = true;
timelineEvent.commentId = nullableString(details.commentId);
}
if (hasOwn(details, "status")) {
const from = nullableString(previous?.status) ?? nullableString(details.reopenedFrom);
const to = nullableString(details.status);
if (from !== to) {
timelineEvent.statusChange = { from, to };
}
}
if (hasOwn(details, "assigneeAgentId") || hasOwn(details, "assigneeUserId")) {
const previousAssignee: IssueTimelineAssignee = {
agentId: nullableString(previous?.assigneeAgentId),
userId: nullableString(previous?.assigneeUserId),
};
const nextAssignee: IssueTimelineAssignee = {
agentId: hasOwn(details, "assigneeAgentId")
? nullableString(details.assigneeAgentId)
: previousAssignee.agentId,
userId: hasOwn(details, "assigneeUserId")
? nullableString(details.assigneeUserId)
: previousAssignee.userId,
};
if (!sameAssignee(previousAssignee, nextAssignee)) {
timelineEvent.assigneeChange = {
from: previousAssignee,
to: nextAssignee,
};
}
}
const workspaceChange = workspaceChangeFromDetails(details);
if (workspaceChange) {
timelineEvent.workspaceChange = workspaceChange;
}
if (
timelineEvent.statusChange
|| timelineEvent.assigneeChange
|| timelineEvent.workspaceChange
|| timelineEvent.followUpRequested
) {
events.push(timelineEvent);
}
}
return sortTimelineEvents(events);
}