mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-15 10:30:37 +09:00
## Thinking Path > - Paperclip is a control plane for autonomous AI companies, where work must end with a clear disposition rather than ambiguous agent liveness. > - Recovery currently detects stalled or missing-next-step issues, but source issue recovery can become split across child recovery issues, blockers, and comments. > - That makes it harder for operators and agents to see who owns recovery and what exact action is needed on the original issue. > - Source-scoped recovery actions give the original issue a first-class active recovery state with owner, evidence, wake policy, and resolution outcome. > - This pull request adds the recovery-action data model, backend reconciliation and resolution APIs, and board UI indicators/actions. > - The benefit is clearer stalled-work recovery without losing source issue context or relying on comments as the liveness path. ## What Changed - Added the `issue_recovery_actions` schema, shared types/constants/validators, and an idempotent `0084_issue_recovery_actions` migration ordered after current `master` migrations. - Updated stranded/missing-disposition recovery to create source-scoped recovery actions, wake the recovery owner on the source issue, and avoid locking the source issue for recovery-action wakes. - Added API support for reading active recovery actions on issue detail/list surfaces and resolving them with restored, blocked, cancelled, or false-positive outcomes. - Require blocked recovery resolutions to have an unresolved first-class blocker, and removed the UI shortcut that could mark recovery blocked without a blocker selection path. - Surfaced recovery indicators/actions in the issue UI, blocker notices, active run panels, issue rows, and Storybook coverage. - Updated docs and focused tests for recovery semantics, ownership, races, stale comments, and UI behavior. ## Verification - `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/IssueBlockedNotice.test.tsx ui/src/api/issues.test.ts` — 5 files, 72 tests passed. - `pnpm --filter @paperclipai/shared typecheck` — passed. - `pnpm --filter @paperclipai/db typecheck` — passed, including migration numbering check. - `pnpm --filter @paperclipai/server typecheck` — passed. - `pnpm --filter @paperclipai/ui typecheck` — passed. - Follow-up verification after blocker-resolution guard: `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/api/issues.test.ts` — 3 files, 27 tests passed. - Follow-up `pnpm --filter @paperclipai/server typecheck` — passed. - Follow-up `pnpm --filter @paperclipai/ui typecheck` — passed. - UI states are available in `ui/storybook/stories/source-issue-recovery.stories.tsx`; screenshot capture helper is `scripts/screenshot-recovery-card.cjs`. ## Risks - Medium: recovery behavior changes from child recovery issue ownership toward source-scoped actions, so operators may see stalled-work state in new places. - Migration risk is mitigated by using the next migration slot after `master` and making the table/constraints/index creation idempotent for anyone who previously applied the old branch-local `0082_dizzy_master_mold` migration. - Existing child recovery issue paths are still guarded for already-created recovery issues, but new source-scoped flows should be watched in CI and Greptile review. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool use enabled for shell, Git, GitHub, and local test execution. Context window not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
57 lines
1.8 KiB
TypeScript
57 lines
1.8 KiB
TypeScript
import type { IssueRecoveryAction } from "@paperclipai/shared";
|
|
import { Eye, OctagonAlert, RefreshCw, TriangleAlert } from "lucide-react";
|
|
|
|
export type RecoveryDisplayState =
|
|
| "needed"
|
|
| "in_progress"
|
|
| "observe_only"
|
|
| "escalated"
|
|
| "resolved";
|
|
|
|
export type ActiveRecoveryDisplayState = Exclude<RecoveryDisplayState, "resolved">;
|
|
|
|
export const RECOVERY_CHIP_DEFAULT_TONE: Record<
|
|
ActiveRecoveryDisplayState,
|
|
{ className: string; icon: typeof TriangleAlert; label: string }
|
|
> = {
|
|
needed: {
|
|
className:
|
|
"border-amber-500/60 bg-amber-500/15 text-amber-700 dark:text-amber-300",
|
|
icon: TriangleAlert,
|
|
label: "Recovery needed",
|
|
},
|
|
in_progress: {
|
|
className:
|
|
"border-sky-500/60 bg-sky-500/15 text-sky-700 dark:text-sky-300",
|
|
icon: RefreshCw,
|
|
label: "Recovery in progress",
|
|
},
|
|
observe_only: {
|
|
className: "border-border bg-muted text-muted-foreground",
|
|
icon: Eye,
|
|
label: "Observing active run",
|
|
},
|
|
escalated: {
|
|
className: "border-red-500/60 bg-red-500/15 text-red-700 dark:text-red-300",
|
|
icon: OctagonAlert,
|
|
label: "Recovery escalated",
|
|
},
|
|
};
|
|
|
|
export function deriveRecoveryDisplayState(
|
|
action: Pick<IssueRecoveryAction, "status" | "kind" | "outcome">,
|
|
): RecoveryDisplayState {
|
|
if (action.status === "resolved") return "resolved";
|
|
if (action.status === "escalated") return "escalated";
|
|
if (action.status === "cancelled") return "resolved";
|
|
if (action.kind === "active_run_watchdog") return "observe_only";
|
|
if (action.outcome === "delegated") return "in_progress";
|
|
return "needed";
|
|
}
|
|
|
|
export function deriveActiveRecoveryDisplayState(
|
|
action: Pick<IssueRecoveryAction, "status" | "kind" | "outcome">,
|
|
): ActiveRecoveryDisplayState | null {
|
|
const state = deriveRecoveryDisplayState(action);
|
|
return state === "resolved" ? null : state;
|
|
}
|