paperclip/server/src/__tests__/sandbox-provider-runtime.test.ts
Devin Foley 5bd0f578fd
Generalize sandbox provider core for plugin-only providers (#4449)
## Thinking Path

> - Paperclip is a control plane, so optional execution providers should
sit at the plugin edge instead of hardcoding provider-specific behavior
into core shared/server/ui layers.
> - Sandbox environments are already first-class, and the fake provider
proves the built-in path; the remaining gap was that real providers
still leaked provider-specific config and runtime assumptions into core.
> - That coupling showed up in config normalization, secret persistence,
capabilities reporting, lease reconstruction, and the board UI form
fields.
> - As long as core knew about those provider-shaped details, shipping a
provider as a pure third-party plugin meant every new provider would
still require host changes.
> - This pull request generalizes the sandbox provider seam around
schema-driven plugin metadata and generic secret-ref handling.
> - The runtime and UI now consume provider metadata generically, so
core only special-cases the built-in fake provider while third-party
providers can live entirely in plugins.

## What Changed

- Added generic sandbox-provider capability metadata so plugin-backed
providers can expose `configSchema` through shared environment support
and the environments capabilities API.
- Reworked sandbox config normalization/persistence/runtime resolution
to handle schema-declared secret-ref fields generically, storing them as
Paperclip secrets and resolving them for probe/execute/release flows.
- Generalized plugin sandbox runtime handling so provider validation,
reusable-lease matching, lease reconstruction, and plugin worker calls
all operate on provider-agnostic config instead of provider-shaped
branches.
- Replaced hardcoded sandbox provider form fields in Company Settings
with schema-driven rendering and blocked agent environment selection
from the built-in fake provider.
- Added regression coverage for the generic seam across shared support
helpers plus environment config, probe, routes, runtime, and
sandbox-provider runtime tests.

## Verification

- `pnpm vitest --run packages/shared/src/environment-support.test.ts
server/src/__tests__/environment-config.test.ts
server/src/__tests__/environment-probe.test.ts
server/src/__tests__/environment-routes.test.ts
server/src/__tests__/environment-runtime.test.ts
server/src/__tests__/sandbox-provider-runtime.test.ts`
- `pnpm -r typecheck`

## Risks

- Plugin sandbox providers now depend more heavily on accurate
`configSchema` declarations; incorrect schemas can misclassify
secret-bearing fields or omit required config.
- Reusable lease matching is now metadata-driven for plugin-backed
providers, so providers that fail to persist stable metadata may
reprovision instead of resuming an existing lease.
- The UI form is now fully schema-driven for plugin-backed sandbox
providers; provider manifests without good defaults or descriptions may
produce a rougher operator experience.

## Model Used

- OpenAI Codex via `codex_local`
- Model ID: `gpt-5.4`
- Reasoning effort: `high`
- Context window observed in runtime session metadata: `258400` tokens
- Capabilities used: terminal tool execution, git, and local code/test
inspection

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [ ] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge
2026-04-24 18:03:41 -07:00

220 lines
6.2 KiB
TypeScript

import { describe, expect, it } from "vitest";
import {
acquireSandboxProviderLease,
findReusableSandboxProviderLeaseId,
getSandboxProvider,
listSandboxProviders,
probeSandboxProvider,
releaseSandboxProviderLease,
sandboxConfigFromLeaseMetadata,
sandboxConfigFromLeaseMetadataLoose,
validateSandboxProviderConfig,
} from "../services/sandbox-provider-runtime.ts";
describe("sandbox provider runtime", () => {
it("exposes fake as the built-in sandbox provider implementation", async () => {
expect(listSandboxProviders().map((provider) => provider.provider).sort()).toEqual(["fake"]);
expect(getSandboxProvider("fake")?.provider).toBe("fake");
expect(getSandboxProvider("fake-plugin")).toBeNull();
await expect(
validateSandboxProviderConfig({
provider: "fake",
image: "ubuntu:24.04",
reuseLease: true,
}),
).resolves.toEqual(
expect.objectContaining({
ok: true,
details: expect.objectContaining({
provider: "fake",
image: "ubuntu:24.04",
}),
}),
);
});
it("does not route plugin-backed providers through the built-in provider helper", async () => {
await expect(probeSandboxProvider({
provider: "fake-plugin",
image: "fake:test",
timeoutMs: 300000,
reuseLease: false,
})).rejects.toThrow('Sandbox provider "fake-plugin" is not registered as a built-in provider.');
});
it("acquires and resumes fake leases deterministically", async () => {
const lease = await acquireSandboxProviderLease({
config: {
provider: "fake",
image: "ubuntu:24.04",
reuseLease: true,
},
environmentId: "env-1",
heartbeatRunId: "run-1",
issueId: "issue-1",
});
expect(lease.providerLeaseId).toBe("sandbox://fake/env-1");
expect(lease.metadata).toEqual(expect.objectContaining({
provider: "fake",
image: "ubuntu:24.04",
reuseLease: true,
}));
const resumed = await acquireSandboxProviderLease({
config: {
provider: "fake",
image: "ubuntu:24.04",
reuseLease: true,
},
environmentId: "env-1",
heartbeatRunId: "run-2",
issueId: "issue-1",
reusableProviderLeaseId: lease.providerLeaseId,
});
expect(resumed.providerLeaseId).toBe(lease.providerLeaseId);
expect(resumed.metadata).toEqual(expect.objectContaining({ resumedLease: true }));
});
it("matches reusable fake leases through the selected provider implementation", () => {
expect(
findReusableSandboxProviderLeaseId({
config: {
provider: "fake",
image: "image-b",
reuseLease: true,
},
leases: [
{
providerLeaseId: "sandbox-image-a",
metadata: {
provider: "fake",
image: "image-a",
reuseLease: true,
},
},
{
providerLeaseId: "sandbox-image-b",
metadata: {
provider: "fake",
image: "image-b",
reuseLease: true,
},
},
],
}),
).toBe("sandbox-image-b");
});
it("matches reusable plugin leases by persisted config fields", () => {
expect(
findReusableSandboxProviderLeaseId({
config: {
provider: "secure-plugin",
template: "template-b",
apiKey: "22222222-2222-2222-2222-222222222222",
timeoutMs: 300000,
reuseLease: true,
},
leases: [
{
providerLeaseId: "sandbox-template-a",
metadata: {
provider: "secure-plugin",
template: "template-a",
apiKey: "11111111-1111-1111-1111-111111111111",
reuseLease: true,
},
},
{
providerLeaseId: "sandbox-template-b",
metadata: {
provider: "secure-plugin",
template: "template-b",
apiKey: "22222222-2222-2222-2222-222222222222",
timeoutMs: 300000,
reuseLease: true,
},
},
],
}),
).toBe("sandbox-template-b");
});
it("reconstructs fake sandbox config from lease metadata for later release", () => {
const metadata = {
provider: "fake",
image: "paperclip-test",
reuseLease: true,
};
expect(sandboxConfigFromLeaseMetadata({ metadata })).toEqual({
provider: "fake",
image: "paperclip-test",
reuseLease: true,
});
expect(sandboxConfigFromLeaseMetadataLoose({ metadata })).toEqual({
provider: "fake",
image: "paperclip-test",
reuseLease: true,
});
});
it("reconstructs plugin-backed sandbox config from lease metadata for runtime recovery", () => {
const metadata = {
provider: "fake-plugin",
reuseLease: true,
timeoutMs: 45_000,
remoteCwd: "/workspace/project",
fakeRootDir: "/tmp/fake-root",
};
expect(sandboxConfigFromLeaseMetadataLoose({ metadata })).toEqual({
provider: "fake-plugin",
reuseLease: true,
timeoutMs: 45_000,
remoteCwd: "/workspace/project",
fakeRootDir: "/tmp/fake-root",
});
});
it("reconstructs plugin-backed secret-ref config from lease metadata for later release", () => {
expect(sandboxConfigFromLeaseMetadata({
metadata: {
provider: "secure-plugin",
template: "paperclip-template",
},
})).toBeNull();
expect(sandboxConfigFromLeaseMetadataLoose({
metadata: {
provider: "secure-plugin",
template: "paperclip-template",
timeoutMs: 120000,
reuseLease: true,
apiKey: "11111111-1111-1111-1111-111111111111",
},
})).toEqual({
provider: "secure-plugin",
template: "paperclip-template",
apiKey: "11111111-1111-1111-1111-111111111111",
timeoutMs: 120000,
reuseLease: true,
});
});
it("releases fake leases without external side effects", async () => {
await expect(releaseSandboxProviderLease({
config: {
provider: "fake",
image: "ubuntu:24.04",
reuseLease: true,
},
providerLeaseId: "sandbox://fake/env-1",
status: "released",
})).resolves.toBeUndefined();
});
});