mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-19 20:10:39 +09:00
bfe6369ef5
## Thinking Path > - Paperclip is the control plane that coordinates AI-agent work through issues, heartbeats, comments, approvals, and auditable recovery paths. > - The affected subsystem is heartbeat/recovery orchestration, especially the optional cheap model profile used for operational recovery overhead. > - Cheap recovery should repair status and liveness, but it must not become the worker lane that writes deliverables, continues source work, or propagates cheap execution hints into downstream retries. > - The gap was that cheap-profile hints could follow recovery wake contexts and assignment overrides farther than intended, making real work eligible to run on the cheap model. > - This pull request separates status-only cheap recovery from normal source-work continuations, adds route guards for deliverable mutations during cheap status-only runs, and documents the invariant. > - The benefit is safer retry/recovery behavior: cheap runs can clean up control-plane state, while any remaining source work resumes through a normal/original model path. ## What Changed - Added recovery model-profile work classes so status-only recovery carries explicit guard context and normal-model continuations scrub cheap hints. - Updated heartbeat, productivity review, liveness continuation, and recovery service wakeups to request cheap only for bounded status-only recovery work. - Blocked cheap status-only recovery runs from writing issue documents, plans, attachments, work products, or assigning downstream work back to `modelProfile: "cheap"`. - Added/updated server tests for cheap profile propagation, artifact/document guards, route authorization, retry scheduling, and successful-run handoff behavior. - Documented the recovery model-profile lane in `doc/SPEC-implementation.md` and `doc/execution-semantics.md`. - After rebasing onto current `public-gh/master`, stabilized the new `InstanceSidebar` plugin-filter tests so the PR check lane stays green. ## Verification - Local: `pnpm exec vitest run --config vitest.config.ts src/services/recovery/model-profile-hint.test.ts src/__tests__/issue-agent-mutation-ownership-routes.test.ts src/__tests__/issue-document-restore-routes.test.ts` from `server/` - 3 files, 37 tests passed after final edits. - Local: `pnpm exec vitest run --config vitest.config.ts src/__tests__/heartbeat-process-recovery.test.ts` from `server/` - 44 tests passed after rerunning the cleanup-sensitive file alone. - Local: `pnpm --filter @paperclipai/ui exec vitest run src/components/InstanceSidebar.test.tsx` - 4 tests passed. - Local: `pnpm --filter @paperclipai/server typecheck` - passed. - Local: `pnpm --filter @paperclipai/ui typecheck` - passed. - PR checks on latest head `6f8c3b1380f5bd872c6f49f6f7188ecf3bb6d263` - all green, including `verify`, build, typecheck, server/general/serialized tests, e2e, Snyk, and policy. - Greptile: pass 3 returned Confidence Score 5/5 with zero unresolved Greptile review threads. ## Risks - Medium risk: recovery behavior is intentionally stricter, so any path that incorrectly relies on cheap recovery to keep doing source work will now need to hand back to a normal-model run. - Low migration risk: no schema changes. - No product UI changes; the UI file touched is a test-only stabilization after rebasing onto current `master`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool use and local code execution enabled; context window not exposed in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots (N/A: no product UI changes) - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge |
||
|---|---|---|
| .. | ||
| recovery | ||
| access.ts | ||
| activity-log.ts | ||
| activity.ts | ||
| adapter-plugin-store.ts | ||
| agent-instructions.ts | ||
| agent-permissions.ts | ||
| agent-start-lock.ts | ||
| agents.ts | ||
| approvals.ts | ||
| assets.ts | ||
| board-auth.ts | ||
| budgets.ts | ||
| companies.ts | ||
| company-export-readme.ts | ||
| company-member-roles.ts | ||
| company-portability.ts | ||
| company-search-rate-limit.ts | ||
| company-search.ts | ||
| company-skills.ts | ||
| costs.ts | ||
| cron.ts | ||
| dashboard.ts | ||
| default-agent-instructions.ts | ||
| documents.ts | ||
| environment-config.ts | ||
| environment-execution-target.ts | ||
| environment-probe.ts | ||
| environment-run-orchestrator.ts | ||
| environment-runtime.ts | ||
| environments.ts | ||
| execution-workspace-policy.ts | ||
| execution-workspaces.ts | ||
| feedback-redaction.ts | ||
| feedback-share-client.ts | ||
| feedback.ts | ||
| finance.ts | ||
| github-fetch.ts | ||
| goals.ts | ||
| heartbeat-run-summary.ts | ||
| heartbeat-stop-metadata.test.ts | ||
| heartbeat-stop-metadata.ts | ||
| heartbeat.ts | ||
| hire-hook.ts | ||
| inbox-dismissals.ts | ||
| index.ts | ||
| instance-settings.ts | ||
| invite-grants.ts | ||
| issue-approvals.ts | ||
| issue-assignment-wakeup.ts | ||
| issue-continuation-summary.ts | ||
| issue-execution-policy.ts | ||
| issue-goal-fallback.ts | ||
| issue-liveness.ts | ||
| issue-recovery-actions.ts | ||
| issue-references.ts | ||
| issue-thread-interactions.test.ts | ||
| issue-thread-interactions.ts | ||
| issue-tree-control.ts | ||
| issues.ts | ||
| json-schema-secret-refs.ts | ||
| live-events.ts | ||
| local-service-supervisor.ts | ||
| plugin-capability-validator.ts | ||
| plugin-config-validator.ts | ||
| plugin-database.ts | ||
| plugin-dev-watcher.ts | ||
| plugin-environment-driver.ts | ||
| plugin-event-bus.ts | ||
| plugin-host-service-cleanup.ts | ||
| plugin-host-services.ts | ||
| plugin-job-coordinator.ts | ||
| plugin-job-scheduler.ts | ||
| plugin-job-store.ts | ||
| plugin-lifecycle.ts | ||
| plugin-loader.ts | ||
| plugin-local-folders.ts | ||
| plugin-log-retention.ts | ||
| plugin-managed-agents.ts | ||
| plugin-managed-routines.ts | ||
| plugin-managed-skills.ts | ||
| plugin-manifest-validator.ts | ||
| plugin-registry.ts | ||
| plugin-runtime-sandbox.ts | ||
| plugin-secrets-handler.ts | ||
| plugin-state-store.ts | ||
| plugin-stream-bus.ts | ||
| plugin-tool-dispatcher.ts | ||
| plugin-tool-registry.ts | ||
| plugin-worker-manager.ts | ||
| productivity-review.ts | ||
| project-workspace-runtime-config.ts | ||
| projects.ts | ||
| quota-windows.ts | ||
| routines.ts | ||
| run-continuations.ts | ||
| run-liveness.ts | ||
| run-log-store.ts | ||
| sandbox-provider-runtime.ts | ||
| secrets.ts | ||
| session-workspace-cwd.test.ts | ||
| session-workspace-cwd.ts | ||
| sidebar-badges.ts | ||
| sidebar-preferences.ts | ||
| work-products.ts | ||
| workspace-operation-log-store.ts | ||
| workspace-operations.ts | ||
| workspace-realization.ts | ||
| workspace-runtime-read-model.ts | ||
| workspace-runtime.ts | ||