mirror of
https://github.com/alkimake/paperclip.git
synced 2026-06-16 19:00:38 +09:00
## Thinking Path > - Paperclip orchestrates AI-agent companies through a control plane that can start, supervise, and recover agent runs. > - Local adapters are the bridge between Paperclip issues and concrete agent runtimes such as Claude, Codex, and other ACP-compatible tools. > - The roadmap calls out broader “bring your own agent” and claw-style agent support, and ACPX gives Paperclip one path to normalize multiple ACP agents behind a single adapter. > - The branch needed to become one reviewable PR against current `paperclipai/paperclip:master`, without carrying stale base conflicts or generated lockfile churn. > - This pull request adds an experimental built-in `acpx_local` adapter, integrates it through the server/CLI/UI adapter surfaces, and adds regression coverage for runtime execution, skill sync, stream parsing, diagnostics, and log redaction. > - The benefit is that Paperclip can run Claude/Codex/custom ACP agents through ACPX while keeping operator configuration, skills, logging, and transcript rendering inside the existing adapter model. ## What Changed - Added `@paperclipai/adapter-acpx-local` with server execution, config schema, ACPX session handling, CLI formatting, UI config helpers, and stdout parsing. - Registered `acpx_local` across CLI, server, shared constants, UI adapter metadata, adapter capabilities, and agent creation/editing surfaces. - Added ACPX runtime execution support with persistent sessions, local-agent JWT environment handling, skill snapshots, runtime skill materialization, and isolation/security regressions. - Added ACPX adapter diagnostics and marked the adapter experimental in the UI. - Added command/env secret redaction for resolved command metadata in adapter-utils, server event storage, and the Agent Detail invocation UI. - Added Storybook coverage for ACPX config, transcript rendering, and skill states, plus PR screenshots under `docs/pr-screenshots/pap-2944/`. - Rebased the branch onto current `public-gh/master`; `pnpm-lock.yaml` is intentionally not included and there are no migration/schema changes. ## Verification - `pnpm exec vitest run packages/adapters/acpx-local/src/server/execute.test.ts packages/adapters/acpx-local/src/server/test.test.ts packages/adapters/acpx-local/src/cli/format-event.test.ts packages/adapters/acpx-local/src/ui/parse-stdout.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/redaction.test.ts server/src/__tests__/acpx-local-execute.test.ts server/src/__tests__/acpx-local-skill-sync.test.ts server/src/__tests__/acpx-local-adapter-environment.test.ts server/src/__tests__/adapter-routes.test.ts server/src/__tests__/agent-skills-routes.test.ts ui/src/adapters/metadata.test.ts` — 12 files, 87 tests passed. - `pnpm --filter @paperclipai/adapter-acpx-local typecheck` — passed. - `pnpm --filter @paperclipai/server typecheck` — passed. - `pnpm --filter @paperclipai/ui typecheck` — passed. - Confirmed PR diff does not include `pnpm-lock.yaml`, database schema files, or migrations. Screenshots:    ## Risks - Medium risk: this introduces a new built-in adapter package and touches runtime execution, adapter registration, agent config, skills, and transcript rendering. - ACPX and ACP agent behavior can vary by installed tool versions; the adapter is marked experimental to set operator expectations. - `pnpm-lock.yaml` is excluded per repository PR policy, so dependency lock refresh must be handled by the repo’s automation or maintainers. - No database migration risk: no schema or migration files changed. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with repository tool use, shell execution, git operations, and local verification. Exact hosted context window was not exposed in this environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
295 lines
10 KiB
TypeScript
295 lines
10 KiB
TypeScript
import { createRequire } from "node:module";
|
|
import fs from "node:fs/promises";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import type {
|
|
AdapterEnvironmentCheck,
|
|
AdapterEnvironmentTestContext,
|
|
AdapterEnvironmentTestResult,
|
|
} from "@paperclipai/adapter-utils";
|
|
import {
|
|
asString,
|
|
parseObject,
|
|
} from "@paperclipai/adapter-utils/server-utils";
|
|
|
|
const require = createRequire(import.meta.url);
|
|
const MIN_NODE_MAJOR = 22;
|
|
const MIN_NODE_MINOR = 12;
|
|
const MIN_NODE_PATCH = 0;
|
|
|
|
function summarizeStatus(checks: AdapterEnvironmentCheck[]): AdapterEnvironmentTestResult["status"] {
|
|
if (checks.some((check) => check.level === "error")) return "fail";
|
|
if (checks.some((check) => check.level === "warn")) return "warn";
|
|
return "pass";
|
|
}
|
|
|
|
function nodeVersionMeetsMinimum(version: string): boolean {
|
|
const [major = 0, minor = 0, patch = 0] = version
|
|
.replace(/^v/, "")
|
|
.split(".")
|
|
.map((part) => Number.parseInt(part, 10));
|
|
if (major > MIN_NODE_MAJOR) return true;
|
|
if (major < MIN_NODE_MAJOR) return false;
|
|
if (minor > MIN_NODE_MINOR) return true;
|
|
if (minor < MIN_NODE_MINOR) return false;
|
|
return patch >= MIN_NODE_PATCH;
|
|
}
|
|
|
|
function isNonEmpty(value: unknown): value is string {
|
|
return typeof value === "string" && value.trim().length > 0;
|
|
}
|
|
|
|
function getStringEnv(configEnv: Record<string, string>, key: string): string | undefined {
|
|
const configured = configEnv[key];
|
|
if (typeof configured === "string") return configured;
|
|
return process.env[key];
|
|
}
|
|
|
|
function credentialSource(configEnv: Record<string, string>, key: string): string {
|
|
return typeof configEnv[key] === "string" ? "adapter config env" : "server environment";
|
|
}
|
|
|
|
async function readJsonObject(filePath: string): Promise<Record<string, unknown> | null> {
|
|
try {
|
|
const parsed = JSON.parse(await fs.readFile(filePath, "utf8")) as unknown;
|
|
return typeof parsed === "object" && parsed !== null && !Array.isArray(parsed)
|
|
? parsed as Record<string, unknown>
|
|
: null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function readNestedString(record: Record<string, unknown>, pathSegments: string[]): string | null {
|
|
let current: unknown = record;
|
|
for (const segment of pathSegments) {
|
|
if (typeof current !== "object" || current === null || Array.isArray(current)) return null;
|
|
current = (current as Record<string, unknown>)[segment];
|
|
}
|
|
return isNonEmpty(current) ? current.trim() : null;
|
|
}
|
|
|
|
async function hasClaudeSubscriptionCredentials(configDir: string): Promise<boolean> {
|
|
for (const filename of [".credentials.json", "credentials.json"]) {
|
|
const credentials = await readJsonObject(path.join(configDir, filename));
|
|
if (!credentials) continue;
|
|
if (readNestedString(credentials, ["claudeAiOauth", "accessToken"])) return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
async function hasCodexNativeCredentials(codexHome: string): Promise<boolean> {
|
|
const auth = await readJsonObject(path.join(codexHome, "auth.json"));
|
|
if (!auth) return false;
|
|
return Boolean(
|
|
readNestedString(auth, ["accessToken"]) ||
|
|
readNestedString(auth, ["tokens", "access_token"]) ||
|
|
readNestedString(auth, ["OPENAI_API_KEY"]),
|
|
);
|
|
}
|
|
|
|
async function buildCredentialHintChecks(
|
|
agent: string,
|
|
configEnv: Record<string, string>,
|
|
): Promise<AdapterEnvironmentCheck[]> {
|
|
if (agent === "claude") {
|
|
const bedrockFlag = getStringEnv(configEnv, "CLAUDE_CODE_USE_BEDROCK");
|
|
const bedrockBaseUrl = getStringEnv(configEnv, "ANTHROPIC_BEDROCK_BASE_URL");
|
|
const hasBedrock =
|
|
bedrockFlag === "1" ||
|
|
/^true$/i.test(bedrockFlag ?? "") ||
|
|
isNonEmpty(bedrockBaseUrl);
|
|
const bedrockSourceKey = isNonEmpty(bedrockFlag)
|
|
? "CLAUDE_CODE_USE_BEDROCK"
|
|
: "ANTHROPIC_BEDROCK_BASE_URL";
|
|
const anthropicApiKey = getStringEnv(configEnv, "ANTHROPIC_API_KEY");
|
|
const claudeConfigDir = isNonEmpty(getStringEnv(configEnv, "CLAUDE_CONFIG_DIR"))
|
|
? path.resolve(getStringEnv(configEnv, "CLAUDE_CONFIG_DIR") as string)
|
|
: path.join(os.homedir(), ".claude");
|
|
|
|
if (hasBedrock) {
|
|
return [{
|
|
code: "acpx_claude_bedrock_auth_detected",
|
|
level: "info",
|
|
message: "Claude credential hint: Bedrock auth indicators are configured.",
|
|
detail: `Detected in ${credentialSource(configEnv, bedrockSourceKey)}.`,
|
|
hint: "Ensure AWS credentials and AWS_REGION are available to the ACPX-launched Claude agent.",
|
|
}];
|
|
}
|
|
|
|
if (isNonEmpty(anthropicApiKey)) {
|
|
return [{
|
|
code: "acpx_claude_anthropic_api_key_detected",
|
|
level: "info",
|
|
message: "Claude credential hint: ANTHROPIC_API_KEY is set.",
|
|
detail: `Detected in ${credentialSource(configEnv, "ANTHROPIC_API_KEY")}.`,
|
|
}];
|
|
}
|
|
|
|
if (await hasClaudeSubscriptionCredentials(claudeConfigDir)) {
|
|
return [{
|
|
code: "acpx_claude_subscription_auth_detected",
|
|
level: "info",
|
|
message: "Claude credential hint: local Claude subscription credentials were found.",
|
|
detail: `Credentials found in ${claudeConfigDir}.`,
|
|
}];
|
|
}
|
|
|
|
return [{
|
|
code: "acpx_claude_credentials_missing",
|
|
level: "info",
|
|
message: "Claude credential hint: no Claude API, Bedrock, or local subscription credentials were detected.",
|
|
hint: "Set ANTHROPIC_API_KEY, configure Bedrock, or run `claude login` before starting an ACPX Claude agent.",
|
|
}];
|
|
}
|
|
|
|
if (agent === "codex") {
|
|
const openAiApiKey = getStringEnv(configEnv, "OPENAI_API_KEY");
|
|
const codexHome = isNonEmpty(getStringEnv(configEnv, "CODEX_HOME"))
|
|
? path.resolve(getStringEnv(configEnv, "CODEX_HOME") as string)
|
|
: path.join(os.homedir(), ".codex");
|
|
|
|
if (isNonEmpty(openAiApiKey)) {
|
|
return [{
|
|
code: "acpx_codex_openai_api_key_detected",
|
|
level: "info",
|
|
message: "Codex credential hint: OPENAI_API_KEY is set.",
|
|
detail: `Detected in ${credentialSource(configEnv, "OPENAI_API_KEY")}.`,
|
|
}];
|
|
}
|
|
|
|
if (await hasCodexNativeCredentials(codexHome)) {
|
|
return [{
|
|
code: "acpx_codex_native_auth_detected",
|
|
level: "info",
|
|
message: "Codex credential hint: local Codex auth configuration was found.",
|
|
detail: `Credentials found in ${path.join(codexHome, "auth.json")}.`,
|
|
}];
|
|
}
|
|
|
|
return [{
|
|
code: "acpx_codex_credentials_missing",
|
|
level: "info",
|
|
message: "Codex credential hint: no OpenAI API key or local Codex auth configuration was detected.",
|
|
hint: "Set OPENAI_API_KEY or run `codex login` before starting an ACPX Codex agent.",
|
|
}];
|
|
}
|
|
|
|
return [];
|
|
}
|
|
|
|
function resolvePackage(name: string): AdapterEnvironmentCheck {
|
|
try {
|
|
const resolved = require.resolve(`${name}/package.json`);
|
|
return {
|
|
code: `acpx_package_${name.replace(/[^a-z0-9]+/gi, "_").toLowerCase()}_present`,
|
|
level: "info",
|
|
message: `${name} is resolvable.`,
|
|
detail: resolved,
|
|
};
|
|
} catch {
|
|
return {
|
|
code: `acpx_package_${name.replace(/[^a-z0-9]+/gi, "_").toLowerCase()}_missing`,
|
|
level: "error",
|
|
message: `${name} is not resolvable from the acpx_local adapter package.`,
|
|
hint: "Run pnpm install so the ACPX adapter dependencies are installed.",
|
|
};
|
|
}
|
|
}
|
|
|
|
async function checkDirectory(pathValue: string, code: string, label: string): Promise<AdapterEnvironmentCheck | null> {
|
|
const dir = pathValue.trim();
|
|
if (!dir) return null;
|
|
try {
|
|
await fs.mkdir(dir, { recursive: true });
|
|
await fs.access(dir);
|
|
return {
|
|
code,
|
|
level: "info",
|
|
message: `${label} is writable: ${dir}`,
|
|
};
|
|
} catch (err) {
|
|
return {
|
|
code: `${code}_invalid`,
|
|
level: "error",
|
|
message: err instanceof Error ? err.message : `${label} is not writable.`,
|
|
detail: dir,
|
|
};
|
|
}
|
|
}
|
|
|
|
export async function testEnvironment(
|
|
ctx: AdapterEnvironmentTestContext,
|
|
): Promise<AdapterEnvironmentTestResult> {
|
|
const config = parseObject(ctx.config);
|
|
const envConfig = parseObject(config.env);
|
|
const configEnv: Record<string, string> = {};
|
|
for (const [key, value] of Object.entries(envConfig)) {
|
|
if (typeof value === "string") configEnv[key] = value;
|
|
}
|
|
const checks: AdapterEnvironmentCheck[] = [];
|
|
const nodeVersion = process.version;
|
|
|
|
checks.push({
|
|
code: nodeVersionMeetsMinimum(nodeVersion) ? "acpx_node_supported" : "acpx_node_unsupported",
|
|
level: nodeVersionMeetsMinimum(nodeVersion) ? "info" : "error",
|
|
message: nodeVersionMeetsMinimum(nodeVersion)
|
|
? `Node ${nodeVersion} satisfies ACPX's >=22.12.0 requirement.`
|
|
: `Node ${nodeVersion} does not satisfy ACPX's >=22.12.0 requirement.`,
|
|
hint: nodeVersionMeetsMinimum(nodeVersion)
|
|
? undefined
|
|
: "Run acpx_local agents with Node >=22.12.0 or use claude_local/codex_local on Node 20.",
|
|
});
|
|
|
|
checks.push(resolvePackage("acpx"));
|
|
checks.push(resolvePackage("@agentclientprotocol/claude-agent-acp"));
|
|
checks.push(resolvePackage("@zed-industries/codex-acp"));
|
|
|
|
const agent = asString(config.agent, "claude");
|
|
if (!["claude", "codex", "custom"].includes(agent)) {
|
|
checks.push({
|
|
code: "acpx_agent_invalid",
|
|
level: "error",
|
|
message: `Unsupported ACP agent: ${agent}`,
|
|
hint: "Use agent=claude, agent=codex, or agent=custom.",
|
|
});
|
|
} else {
|
|
checks.push({
|
|
code: "acpx_agent_selected",
|
|
level: "info",
|
|
message: `ACP agent selected: ${agent}`,
|
|
});
|
|
checks.push(...await buildCredentialHintChecks(agent, configEnv));
|
|
}
|
|
|
|
if (agent === "custom" && !asString(config.agentCommand, "")) {
|
|
checks.push({
|
|
code: "acpx_custom_command_missing",
|
|
level: "error",
|
|
message: "agentCommand is required when agent=custom.",
|
|
});
|
|
}
|
|
|
|
const stateDirCheck = await checkDirectory(asString(config.stateDir, ""), "acpx_state_dir_writable", "ACPX state directory");
|
|
if (stateDirCheck) checks.push(stateDirCheck);
|
|
|
|
const permissionMode = asString(config.permissionMode, "approve-all");
|
|
checks.push({
|
|
code: "acpx_permission_mode",
|
|
level: "info",
|
|
message: `Effective permission mode: ${permissionMode || "approve-all"}`,
|
|
});
|
|
|
|
checks.push({
|
|
code: "acpx_runtime_scaffold",
|
|
level: "info",
|
|
message: "acpx_local runtime execution is available through the bundled ACPX runtime.",
|
|
});
|
|
|
|
return {
|
|
adapterType: ctx.adapterType,
|
|
status: summarizeStatus(checks),
|
|
checks,
|
|
testedAt: new Date().toISOString(),
|
|
};
|
|
}
|